From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 2/2] UML: use obj-y to descend into arch/um/*/
Date: Tue, 8 Aug 2023 11:21:47 -0700 [thread overview]
Message-ID: <ZNKHu4+MlO3L6wUl@google.com> (raw)
In-Reply-To: <20230721171857.3612639-2-masahiroy@kernel.org>
On Sat, Jul 22, 2023 at 02:18:57AM +0900, Masahiro Yamada wrote:
> The single build rule does not work with the core-y syntax. [1]
>
> Use the standard obj-y syntax.
>
> [1]: https://lore.kernel.org/linux-kbuild/d57ba55f-20a3-b836-783d-b49c8a161b6e@kernel.org/T/#m7bc402e1e038f00ebcf2e92ed7fcb8a52fc1ea44
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This resolves an issue I reported (but doesn't seem to be on lore
for linux-kbuild...)
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>
> Changes in v2:
> - Rephase the commit log
>
> arch/um/Kbuild | 2 ++
> arch/um/Makefile | 4 ----
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/um/Kbuild b/arch/um/Kbuild
> index a4e40e534e6a..6cf0c1e5927b 100644
> --- a/arch/um/Kbuild
> +++ b/arch/um/Kbuild
> @@ -1 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +
> +obj-y += kernel/ drivers/ os-Linux/
> diff --git a/arch/um/Makefile b/arch/um/Makefile
> index 1735a562453d..82f05f250634 100644
> --- a/arch/um/Makefile
> +++ b/arch/um/Makefile
> @@ -22,10 +22,6 @@ ARCH_DIR := arch/um
> # features.
> SHELL := /bin/bash
>
> -core-y += $(ARCH_DIR)/kernel/ \
> - $(ARCH_DIR)/drivers/ \
> - $(ARCH_DIR)/os-Linux/
> -
> MODE_INCLUDE += -I$(srctree)/$(ARCH_DIR)/include/shared/skas
>
> HEADER_ARCH := $(SUBARCH)
> --
> 2.39.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v2 2/2] UML: use obj-y to descend into arch/um/*/
Date: Tue, 8 Aug 2023 11:21:47 -0700 [thread overview]
Message-ID: <ZNKHu4+MlO3L6wUl@google.com> (raw)
In-Reply-To: <20230721171857.3612639-2-masahiroy@kernel.org>
On Sat, Jul 22, 2023 at 02:18:57AM +0900, Masahiro Yamada wrote:
> The single build rule does not work with the core-y syntax. [1]
>
> Use the standard obj-y syntax.
>
> [1]: https://lore.kernel.org/linux-kbuild/d57ba55f-20a3-b836-783d-b49c8a161b6e@kernel.org/T/#m7bc402e1e038f00ebcf2e92ed7fcb8a52fc1ea44
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This resolves an issue I reported (but doesn't seem to be on lore
for linux-kbuild...)
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>
> Changes in v2:
> - Rephase the commit log
>
> arch/um/Kbuild | 2 ++
> arch/um/Makefile | 4 ----
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/um/Kbuild b/arch/um/Kbuild
> index a4e40e534e6a..6cf0c1e5927b 100644
> --- a/arch/um/Kbuild
> +++ b/arch/um/Kbuild
> @@ -1 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +
> +obj-y += kernel/ drivers/ os-Linux/
> diff --git a/arch/um/Makefile b/arch/um/Makefile
> index 1735a562453d..82f05f250634 100644
> --- a/arch/um/Makefile
> +++ b/arch/um/Makefile
> @@ -22,10 +22,6 @@ ARCH_DIR := arch/um
> # features.
> SHELL := /bin/bash
>
> -core-y += $(ARCH_DIR)/kernel/ \
> - $(ARCH_DIR)/drivers/ \
> - $(ARCH_DIR)/os-Linux/
> -
> MODE_INCLUDE += -I$(srctree)/$(ARCH_DIR)/include/shared/skas
>
> HEADER_ARCH := $(SUBARCH)
> --
> 2.39.2
>
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-08-08 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 17:18 [PATCH v2 1/2] UML: hard-code the result of 'uname -s' Masahiro Yamada
2023-07-21 17:18 ` Masahiro Yamada
2023-07-21 17:18 ` [PATCH v2 2/2] UML: use obj-y to descend into arch/um/*/ Masahiro Yamada
2023-07-21 17:18 ` Masahiro Yamada
2023-07-24 6:53 ` Jiri Slaby
2023-07-24 6:53 ` Jiri Slaby
2023-08-08 18:21 ` Nick Desaulniers [this message]
2023-08-08 18:21 ` Nick Desaulniers
2023-08-19 21:08 ` [PATCH v2 1/2] UML: hard-code the result of 'uname -s' Richard Weinberger
2023-08-19 21:08 ` Richard Weinberger
2023-08-19 23:03 ` Masahiro Yamada
2023-08-19 23:03 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNKHu4+MlO3L6wUl@google.com \
--to=ndesaulniers@google.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=jirislaby@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.