From: Liang Li <liliang6@email.cn>
To: Yicong Yang <yangyicong@huawei.com>
Cc: will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jonathan.cameron@huawei.com,
linuxarm@huawei.com, yangyicong@hisilicon.com
Subject: Re: [PATCH] perf/smmuv3: Add platform id table for module auto loading
Date: Wed, 9 Aug 2023 10:45:07 +0800 [thread overview]
Message-ID: <ZNL9s92HjLy+MZTw@localhost> (raw)
In-Reply-To: <20230807122233.28563-1-yangyicong@huawei.com>
On 2023-08-07 20:22, Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> On ACPI based system the device is probed by the name directly. If the
> driver is configured as module it can only be loaded manually. Add the
> platform id table as well as the module alias then the driver will be
> loaded automatically by the udev or others once the device added.
>
Please consider revise the long log to clearly express the purpose of the
changes in this patch:
- What's the exact issue the patch is addressing
- Why the changes in this patch can fix the issue or make something working
- Consider impact of the changes introduced by this patch
These info may help reviewers and maintainers .. and yourself on code merge.
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Liang Li <liliang6@email.cn>
To: Yicong Yang <yangyicong@huawei.com>
Cc: will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jonathan.cameron@huawei.com,
linuxarm@huawei.com, yangyicong@hisilicon.com
Subject: Re: [PATCH] perf/smmuv3: Add platform id table for module auto loading
Date: Wed, 9 Aug 2023 10:45:07 +0800 [thread overview]
Message-ID: <ZNL9s92HjLy+MZTw@localhost> (raw)
In-Reply-To: <20230807122233.28563-1-yangyicong@huawei.com>
On 2023-08-07 20:22, Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> On ACPI based system the device is probed by the name directly. If the
> driver is configured as module it can only be loaded manually. Add the
> platform id table as well as the module alias then the driver will be
> loaded automatically by the udev or others once the device added.
>
Please consider revise the long log to clearly express the purpose of the
changes in this patch:
- What's the exact issue the patch is addressing
- Why the changes in this patch can fix the issue or make something working
- Consider impact of the changes introduced by this patch
These info may help reviewers and maintainers .. and yourself on code merge.
Regards.
next prev parent reply other threads:[~2023-08-09 2:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 12:22 [PATCH] perf/smmuv3: Add platform id table for module auto loading Yicong Yang
2023-08-07 12:22 ` Yicong Yang
2023-08-09 2:45 ` Liang Li [this message]
2023-08-09 2:45 ` Liang Li
2023-08-09 5:47 ` Barry Song
2023-08-09 5:47 ` Barry Song
2023-08-09 6:31 ` Yicong Yang
2023-08-09 6:31 ` Yicong Yang
2023-08-09 12:11 ` Liang Li
2023-08-09 12:11 ` Liang Li
2023-08-11 10:14 ` Yicong Yang
2023-08-11 10:14 ` Yicong Yang
2023-08-12 5:24 ` Barry Song
2023-08-12 5:24 ` Barry Song
2023-08-12 5:31 ` Barry Song
2023-08-12 5:31 ` Barry Song
2023-08-14 8:51 ` Yicong Yang
2023-08-14 8:51 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNL9s92HjLy+MZTw@localhost \
--to=liliang6@email.cn \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.