From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat
Date: Thu, 10 Aug 2023 12:26:04 +0200 [thread overview]
Message-ID: <ZNS7PJ0oyOQLeaZ7@ugly> (raw)
In-Reply-To: <xmqq350sm21v.fsf@gitster.g>
On Wed, Aug 09, 2023 at 12:46:36PM -0700, Junio C Hamano wrote:
>Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
>> - grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
>> + grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
>
>... I do not think we want this. A long pipeline should be written
>without extra indentation like
>
> A |
> B |
> C
>
... which is not how i would do it.
>but more like
>
> A |
> B |
> C
>
i'd argue that this should be written as
A |
B |
C
like other continued lines (no trailing backslashes are needed here, but
it would be ok to add them, and there is in fact a commit that does just
that in other places, and one might do the same here in a followup).
regards
next prev parent reply other threads:[~2023-08-10 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:15 [PATCH] t9001: fix/unify indentation regarding pipes somewhat Oswald Buddenhagen
2023-08-09 19:46 ` Junio C Hamano
2023-08-10 10:26 ` Oswald Buddenhagen [this message]
2023-08-10 19:09 ` Junio C Hamano
2023-08-13 10:45 ` Oswald Buddenhagen
2023-08-13 10:46 ` [PATCH v2] t9001: fix indentation in test_no_confirm() Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNS7PJ0oyOQLeaZ7@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.