From: Junio C Hamano <gitster@pobox.com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9001: fix/unify indentation regarding pipes somewhat
Date: Wed, 09 Aug 2023 12:46:36 -0700 [thread overview]
Message-ID: <xmqq350sm21v.fsf@gitster.g> (raw)
In-Reply-To: <20230809171531.2564769-1-oswald.buddenhagen@gmx.de> (Oswald Buddenhagen's message of "Wed, 9 Aug 2023 19:15:31 +0200")
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> @@ -61,8 +61,8 @@ test_no_confirm () {
> --smtp-server="$(pwd)/fake.sendmail" \
> $@ \
> $patches >stdout &&
> - ! grep "Send this email" stdout &&
> - >no_confirm_okay
> + ! grep "Send this email" stdout &&
> + >no_confirm_okay
> }
It is hard to see what is going on here, but ...
> @@ -1197,7 +1197,7 @@ test_expect_success $PREREQ 'utf8 Cc is rfc2047 encoded' '
> --smtp-server="$(pwd)/fake.sendmail" \
> outdir/*.patch &&
> grep "^ " msgtxt1 |
> - grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
> + grep "=?UTF-8?q?=C3=A0=C3=A9=C3=AC=C3=B6=C3=BA?= <utf8@example.com>"
... I do not think we want this. A long pipeline should be written
without extra indentation like
A |
B |
C
but more like
A |
B |
C
If we do not have it in the coding guidelines document, perhaps we
should add an entry for it.
Thanks.
next prev parent reply other threads:[~2023-08-09 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:15 [PATCH] t9001: fix/unify indentation regarding pipes somewhat Oswald Buddenhagen
2023-08-09 19:46 ` Junio C Hamano [this message]
2023-08-10 10:26 ` Oswald Buddenhagen
2023-08-10 19:09 ` Junio C Hamano
2023-08-13 10:45 ` Oswald Buddenhagen
2023-08-13 10:46 ` [PATCH v2] t9001: fix indentation in test_no_confirm() Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq350sm21v.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.