* [NDCTL PATCH] daxctl: Remove unused mem_zone variable
@ 2023-08-09 15:46 Xiao Yang
2023-08-10 17:02 ` Fan Ni
0 siblings, 1 reply; 3+ messages in thread
From: Xiao Yang @ 2023-08-09 15:46 UTC (permalink / raw)
To: vishal.l.verma, nvdimm; +Cc: linux-cxl, Xiao Yang
mem_zone variable has never been used so remove it.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
daxctl/device.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/daxctl/device.c b/daxctl/device.c
index d2d206b..360ae8b 100644
--- a/daxctl/device.c
+++ b/daxctl/device.c
@@ -59,7 +59,6 @@ enum memory_zone {
MEM_ZONE_MOVABLE,
MEM_ZONE_NORMAL,
};
-static enum memory_zone mem_zone = MEM_ZONE_MOVABLE;
enum device_action {
ACTION_RECONFIG,
@@ -469,8 +468,6 @@ static const char *parse_device_options(int argc, const char **argv,
align = __parse_size64(param.align, &units);
} else if (strcmp(param.mode, "system-ram") == 0) {
reconfig_mode = DAXCTL_DEV_MODE_RAM;
- if (param.no_movable)
- mem_zone = MEM_ZONE_NORMAL;
} else if (strcmp(param.mode, "devdax") == 0) {
reconfig_mode = DAXCTL_DEV_MODE_DEVDAX;
if (param.no_online) {
@@ -494,9 +491,6 @@ static const char *parse_device_options(int argc, const char **argv,
align = __parse_size64(param.align, &units);
/* fall through */
case ACTION_ONLINE:
- if (param.no_movable)
- mem_zone = MEM_ZONE_NORMAL;
- /* fall through */
case ACTION_DESTROY:
case ACTION_OFFLINE:
case ACTION_DISABLE:
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [NDCTL PATCH] daxctl: Remove unused mem_zone variable
2023-08-09 15:46 [NDCTL PATCH] daxctl: Remove unused mem_zone variable Xiao Yang
@ 2023-08-10 17:02 ` Fan Ni
2023-08-11 1:15 ` Xiao Yang
0 siblings, 1 reply; 3+ messages in thread
From: Fan Ni @ 2023-08-10 17:02 UTC (permalink / raw)
To: Xiao Yang; +Cc: vishal.l.verma, nvdimm, linux-cxl
On Wed, Aug 09, 2023 at 11:46:36PM +0800, Xiao Yang wrote:
> mem_zone variable has never been used so remove it.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> daxctl/device.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/daxctl/device.c b/daxctl/device.c
> index d2d206b..360ae8b 100644
> --- a/daxctl/device.c
> +++ b/daxctl/device.c
> @@ -59,7 +59,6 @@ enum memory_zone {
> MEM_ZONE_MOVABLE,
> MEM_ZONE_NORMAL,
> };
The enum definition is not used also.
Fan
> -static enum memory_zone mem_zone = MEM_ZONE_MOVABLE;
>
> enum device_action {
> ACTION_RECONFIG,
> @@ -469,8 +468,6 @@ static const char *parse_device_options(int argc, const char **argv,
> align = __parse_size64(param.align, &units);
> } else if (strcmp(param.mode, "system-ram") == 0) {
> reconfig_mode = DAXCTL_DEV_MODE_RAM;
> - if (param.no_movable)
> - mem_zone = MEM_ZONE_NORMAL;
> } else if (strcmp(param.mode, "devdax") == 0) {
> reconfig_mode = DAXCTL_DEV_MODE_DEVDAX;
> if (param.no_online) {
> @@ -494,9 +491,6 @@ static const char *parse_device_options(int argc, const char **argv,
> align = __parse_size64(param.align, &units);
> /* fall through */
> case ACTION_ONLINE:
> - if (param.no_movable)
> - mem_zone = MEM_ZONE_NORMAL;
> - /* fall through */
> case ACTION_DESTROY:
> case ACTION_OFFLINE:
> case ACTION_DISABLE:
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [NDCTL PATCH] daxctl: Remove unused mem_zone variable
2023-08-10 17:02 ` Fan Ni
@ 2023-08-11 1:15 ` Xiao Yang
0 siblings, 0 replies; 3+ messages in thread
From: Xiao Yang @ 2023-08-11 1:15 UTC (permalink / raw)
To: Fan Ni; +Cc: vishal.l.verma, nvdimm, linux-cxl
On 2023/8/11 1:02, Fan Ni wrote:
> The enum definition is not used also.
Hi Fan,
Good catch, I will send v2 patch to remove it.
Best Regards,
Xiao Yang
>
> Fan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-11 1:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-09 15:46 [NDCTL PATCH] daxctl: Remove unused mem_zone variable Xiao Yang
2023-08-10 17:02 ` Fan Ni
2023-08-11 1:15 ` Xiao Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.