All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed
Date: Fri, 11 Aug 2023 09:20:52 +0100	[thread overview]
Message-ID: <ZNXvZOv3q9eViDeW@matsya> (raw)
In-Reply-To: <20230801084807.87160-1-alexander.stein@ew.tq-group.com>

On 01-08-23, 10:48, Alexander Stein wrote:
> This adds an error message if getting vbus failed for some reason,
> -EPROBE_DEFER is handled appropriately as well and adds a nice
> information to debugfs.

Fails to apply on phy/next

> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> index c1a57541fbb3..3af007b8e77f 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> @@ -399,7 +399,7 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
>  	if (PTR_ERR(imx_phy->vbus) == -ENODEV)
>  		imx_phy->vbus = NULL;
>  	else if (IS_ERR(imx_phy->vbus))
> -		return PTR_ERR(imx_phy->vbus);
> +		return dev_err_probe(dev, PTR_ERR(imx_phy->vbus), "failed to get vbus\n");
>  
>  	phy_set_drvdata(imx_phy->phy, imx_phy);
>  
> -- 
> 2.34.1

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed
Date: Fri, 11 Aug 2023 09:20:52 +0100	[thread overview]
Message-ID: <ZNXvZOv3q9eViDeW@matsya> (raw)
In-Reply-To: <20230801084807.87160-1-alexander.stein@ew.tq-group.com>

On 01-08-23, 10:48, Alexander Stein wrote:
> This adds an error message if getting vbus failed for some reason,
> -EPROBE_DEFER is handled appropriately as well and adds a nice
> information to debugfs.

Fails to apply on phy/next

> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> index c1a57541fbb3..3af007b8e77f 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> @@ -399,7 +399,7 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
>  	if (PTR_ERR(imx_phy->vbus) == -ENODEV)
>  		imx_phy->vbus = NULL;
>  	else if (IS_ERR(imx_phy->vbus))
> -		return PTR_ERR(imx_phy->vbus);
> +		return dev_err_probe(dev, PTR_ERR(imx_phy->vbus), "failed to get vbus\n");
>  
>  	phy_set_drvdata(imx_phy->phy, imx_phy);
>  
> -- 
> 2.34.1

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-11  8:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  8:48 [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed Alexander Stein
2023-08-01  8:48 ` Alexander Stein
2023-08-11  8:20 ` Vinod Koul [this message]
2023-08-11  8:20   ` Vinod Koul
2023-08-17  9:55 ` Vinod Koul
2023-08-17  9:55   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNXvZOv3q9eViDeW@matsya \
    --to=vkoul@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kishon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-phy@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.