Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support

From: Cristian Marussi <cristian.marussi@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, lukasz.luba@arm.com,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, quic_rjendra@quicinc.com,
	srinivas.kandagatla@linaro.org,
	Chandra Sekhar Lingutla <quic_lingutla@quicinc.com>
Subject: Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support
Date: Mon, 14 Aug 2023 08:54:23 +0100	[thread overview]
Message-ID: <ZNndrw3fHbuYw9x0@pluto> (raw)
In-Reply-To: <20230811204818.30928-1-quic_sibis@quicinc.com>

On Sat, Aug 12, 2023 at 02:18:18AM +0530, Sibi Sankar wrote:
> The perf power scale value would currently be reported as bogowatts if the
> platform firmware supports microwatt power scale and meets the perf major
> version requirements. Fix this by populating version information in the
> driver private data before the call to protocol attributes is made.
> 
> CC: Chandra Sekhar Lingutla <quic_lingutla@quicinc.com>
> Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts")
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>  drivers/firmware/arm_scmi/perf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Hi,

LGTM.

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index c0cd556fbaae..30dedd6ebfde 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -1080,6 +1080,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
>  	if (!pinfo)
>  		return -ENOMEM;
>  
> +	pinfo->version = version;
> +
>  	ret = scmi_perf_attributes_get(ph, pinfo);
>  	if (ret)
>  		return ret;
> @@ -1104,8 +1106,6 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
>  	if (ret)
>  		return ret;
>  
> -	pinfo->version = version;
> -
>  	return ph->set_priv(ph, pinfo);
>  }
>  
> -- 
> 2.17.1
> 