* [PATCH] gpio: mxc: set the port->irq high to 0 for imx2
@ 2023-08-21 3:14 haibo.chen
2023-08-21 11:00 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: haibo.chen @ 2023-08-21 3:14 UTC (permalink / raw)
To: linus.walleij, brgl; +Cc: andy, haibo.chen, shenwei.wang, linux-gpio, linux-imx
From: Haibo Chen <haibo.chen@nxp.com>
MX2 has one interrupt for all gpio ports, so do not need the value
port->irq_high, need to set to 0. Current setting is -1, which will
meet issue in gpio_set_wake_irq().
Fixes: 5f6d1998adeb ("gpio: mxc: release the parent IRQ in runtime suspend")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/gpio/gpio-mxc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 004c6ad7ce52..c96602da7e3a 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -479,7 +479,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
* the handler is needed only once, but doing it for every port
* is more robust and easier.
*/
- port->irq_high = -1;
+ port->irq_high = 0;
port->mx_irq_handler = mx2_gpio_irq_handler;
} else
port->mx_irq_handler = mx3_gpio_irq_handler;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: mxc: set the port->irq high to 0 for imx2
2023-08-21 3:14 [PATCH] gpio: mxc: set the port->irq high to 0 for imx2 haibo.chen
@ 2023-08-21 11:00 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2023-08-21 11:00 UTC (permalink / raw)
To: haibo.chen; +Cc: linus.walleij, brgl, shenwei.wang, linux-gpio, linux-imx
On Mon, Aug 21, 2023 at 11:14:43AM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> MX2 has one interrupt for all gpio ports, so do not need the value
> port->irq_high, need to set to 0. Current setting is -1, which will
> meet issue in gpio_set_wake_irq().
Can you describe a bit more the nature of the issue?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-21 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-21 3:14 [PATCH] gpio: mxc: set the port->irq high to 0 for imx2 haibo.chen
2023-08-21 11:00 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.