From: Vikram Garhwal <vikram.garhwal@amd.com>
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com,
sstabellini@kernel.org, jbeulich@suse.com
Subject: Re: [XEN][PATCH v9 04/19] common/device_tree: Export __unflatten_device_tree()
Date: Thu, 24 Aug 2023 17:54:40 -0700 [thread overview]
Message-ID: <ZOf70KJ5lYg93aiH@amd.com> (raw)
In-Reply-To: <90fcd05a-3b89-401d-8321-7f792b3fa52c@xen.org>
Hi Julien,
On Tue, Aug 22, 2023 at 08:05:18PM +0100, Julien Grall wrote:
> Hi Vikram,
>
> On 19/08/2023 01:28, Vikram Garhwal wrote:
> > Following changes are done to __unflatten_device_tree():
> > 1. __unflatten_device_tree() is renamed to unflatten_device_tree().
> > 2. Remove __init and static function type.
> >
> > The changes are done to make this function useable for dynamic node programming
> > where new device tree overlay nodes are added to fdt and further unflattend to
> > update xen device tree during runtime.
> >
> > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
>
> It is not clear to me whether you saw my reply about using ERR_PTR() as I
> can't find an answer.
>
I saw the comment but was not able to work on implementing ERR_PRT(). Given that
I see your Acked-by, i will try to address this as separate patch after this
series.
> Anyway, I am not against this interface:
>
> Acked-by: Julien Grall <jgrall@amazon.com>
>
> Cheers,
>
> --
> Julien Grall
next prev parent reply other threads:[~2023-08-25 0:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 0:28 [XEN][PATCH v9 00/19] dynamic node programming using overlay dtbo Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 01/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree() Vikram Garhwal
2023-08-22 19:06 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 02/19] common/device_tree.c: unflatten_device_tree() propagate errors Vikram Garhwal
2023-08-22 18:11 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 03/19] xen/arm/device: Remove __init from function type Vikram Garhwal
2023-08-22 18:59 ` Julien Grall
2023-08-25 0:52 ` Vikram Garhwal
2023-08-25 8:02 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 04/19] common/device_tree: Export __unflatten_device_tree() Vikram Garhwal
2023-08-22 19:05 ` Julien Grall
2023-08-25 0:54 ` Vikram Garhwal [this message]
2023-08-19 0:28 ` [XEN][PATCH v9 05/19] xen/arm: Add CONFIG_OVERLAY_DTB Vikram Garhwal
2023-08-22 19:10 ` Julien Grall
2023-08-25 3:17 ` Vikram Garhwal
2023-08-25 8:05 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 06/19] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 07/19] libfdt: overlay: change overlay_get_target() Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree Vikram Garhwal
2023-08-22 19:21 ` Julien Grall
2023-08-25 4:08 ` Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller Vikram Garhwal
2023-08-21 6:53 ` Jan Beulich
2023-08-21 19:41 ` Vikram Garhwal
2023-08-22 19:43 ` Julien Grall
2023-08-25 5:09 ` Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock Vikram Garhwal
2023-08-22 19:47 ` Julien Grall
2023-08-25 4:44 ` Vikram Garhwal
2023-08-25 8:09 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 11/19] xen/iommu: Introduce iommu_remove_dt_device() Vikram Garhwal
2023-08-22 20:01 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 12/19] xen/smmu: Add remove_device callback for smmu_iommu ops Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 13/19] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h Vikram Garhwal
2023-08-23 21:41 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 14/19] common/device_tree: Add rwlock for dt_host Vikram Garhwal
2023-08-23 22:06 ` Julien Grall
2023-08-25 6:22 ` Vikram Garhwal
2023-08-25 7:52 ` Vikram Garhwal
2023-08-25 8:15 ` Julien Grall
2023-08-19 0:28 ` [XEN][PATCH v9 15/19] xen/arm: Implement device tree node removal functionalities Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 16/19] xen/arm: Implement device tree node addition functionalities Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 17/19] tools/libs/ctrl: Implement new xc interfaces for dt overlay Vikram Garhwal
2023-08-21 16:18 ` Anthony PERARD
2023-08-21 18:53 ` Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 18/19] tools/libs/light: Implement new libxl functions for device tree overlay ops Vikram Garhwal
2023-08-19 0:28 ` [XEN][PATCH v9 19/19] tools/xl: Add new xl command overlay for device tree overlay support Vikram Garhwal
2023-08-23 22:18 ` [XEN][PATCH v9 00/19] dynamic node programming using overlay dtbo Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOf70KJ5lYg93aiH@amd.com \
--to=vikram.garhwal@amd.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.