All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Babu Moger <babu.moger@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	David.Kaplan@amd.com, Andrew Cooper <andrew.cooper3@citrix.com>,
	Nikolay Borisov <nik.borisov@suse.com>,
	gregkh@linuxfoundation.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 00/23] SRSO fixes/cleanups
Date: Sat, 26 Aug 2023 19:00:49 +0200	[thread overview]
Message-ID: <ZOovwXOjnwcgQX0R@gmail.com> (raw)
In-Reply-To: <20230826155742.2hqirzpouzh5pduf@treble>


* Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> On Fri, Aug 25, 2023 at 12:38:53PM +0200, Ingo Molnar wrote:
> > Thank you, this all looks very nice. I've applied your fixes to
> > tip:x86/bugs, with the exception of the two KVM enablement patches.
> > 
> > I've also cherry-picked the apply_returns() fix separately to x86/urgent,
> > AFAICS that's the only super-urgent fix we want to push to the final v6.5
> > release before the weekend, right? The other fixes look like
> > reporting bugs, Kconfig oddities and inefficiencies at worst. Backporters
> > may still pick the rest from x86/bugs too - but we are too close to the
> > release right now.
> 
> As far as I can tell, the apply_returns() fix isn't necessarily urgent,
> since after commit 095b8303f383 it went from being an actual bug to just
> dead code: the optimization will never take effect now that none of the
> rethunk cases use __x86_return_thunk.
>
> On the other hand, if I'm too late sending this, it should be harmless to 
> merge it into the final v6.5 release.

Not too late at all - I've removed it from x86/urgent.

Thanks,

	Ingo

  reply	other threads:[~2023-08-26 17:01 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  7:01 [PATCH v2 00/23] SRSO fixes/cleanups Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 01/23] x86/srso: Fix srso_show_state() side effect Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 02/23] x86/srso: Set CPUID feature bits independently of bug or mitigation status Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 03/23] x86/srso: Don't probe microcode in a guest Josh Poimboeuf
2023-08-25  7:52   ` Andrew Cooper
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 04/23] KVM: x86: Add IBPB_BRTYPE support Josh Poimboeuf
2023-08-25 18:15   ` Sean Christopherson
2023-08-26 15:49     ` Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 05/23] KVM: x86: Add SBPB support Josh Poimboeuf
2023-08-25 18:20   ` Sean Christopherson
2023-08-25  7:01 ` [PATCH 06/23] x86/srso: Fix SBPB enablement for spec_rstack_overflow=off Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 07/23] x86/srso: Fix SBPB enablement for (possible) future fixed HW Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 08/23] x86/srso: Print actual mitigation if requested mitigation isn't possible Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 09/23] x86/srso: Print mitigation for retbleed IBPB case Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 10/23] x86/srso: Fix vulnerability reporting for missing microcode Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-09-01  9:40     ` Borislav Petkov
2023-09-02 10:46       ` Ingo Molnar
2023-09-02 17:04         ` Borislav Petkov
2023-09-03 14:37           ` Borislav Petkov
2023-09-05  4:57         ` Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 11/23] x86/srso: Fix unret validation dependencies Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 12/23] x86/alternatives: Remove faulty optimization Josh Poimboeuf
2023-08-25  9:20   ` Ingo Molnar
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25 10:27   ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 13/23] x86/srso: Improve i-cache locality for alias mitigation Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 14/23] x86/srso: Unexport untraining functions Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 15/23] x86/srso: Remove 'pred_cmd' label Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25 19:51   ` [PATCH 15/23] " Nikolay Borisov
2023-08-26 15:45     ` Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 16/23] x86/bugs: Remove default case for fully switched enums Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-09-02  9:02   ` [PATCH 16/23] " Borislav Petkov
2023-09-05  5:08     ` Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 17/23] x86/srso: Move retbleed IBPB check into existing 'has_microcode' code block Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 18/23] x86/srso: Remove redundant X86_FEATURE_ENTRY_IBPB check Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-09-02  9:10   ` [PATCH 18/23] " Borislav Petkov
2023-08-25  7:01 ` [PATCH 19/23] x86/srso: Disentangle rethunk-dependent options Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 20/23] x86/rethunk: Use SYM_CODE_START[_LOCAL]_NOALIGN macros Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 21/23] x86/retpoline: Remove .text..__x86.return_thunk section Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 22/23] x86/nospec: Refactor UNTRAIN_RET[_*] Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25 18:22   ` [PATCH 22/23] " Nikolay Borisov
2023-08-26 15:42     ` Josh Poimboeuf
2023-08-25  7:01 ` [PATCH 23/23] x86/calldepth: Rename __x86_return_skl() to call_depth_return_thunk() Josh Poimboeuf
2023-08-25 10:19   ` [tip: x86/bugs] " tip-bot2 for Josh Poimboeuf
2023-08-25 10:38 ` [PATCH v2 00/23] SRSO fixes/cleanups Ingo Molnar
2023-08-26 15:57   ` Josh Poimboeuf
2023-08-26 17:00     ` Ingo Molnar [this message]
2023-10-05  1:29 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOovwXOjnwcgQX0R@gmail.com \
    --to=mingo@kernel.org \
    --cc=David.Kaplan@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.