All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: berlin: Drop superfluous ampersands
Date: Sun, 27 Aug 2023 18:21:25 +0800	[thread overview]
Message-ID: <ZOsjpRJYE0nGpmSx@xhacker> (raw)
In-Reply-To: <0ff17be9b31c9fcf03481c0665293b98ced741f7.1692871243.git.geert+renesas@glider.be>

On Thu, Aug 24, 2023 at 12:05:50PM +0200, Geert Uytterhoeven wrote:
> There is no need to use an ampersand to take the address of a function.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Jisheng Zhang <jszhang@kernel.org>

Hi Linus Walleij,

If it's not too late, could you please merge it?

Thanks in advance

> ---
>  drivers/pinctrl/berlin/berlin.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
> index 1e427ea4d31bcbfc..9550cc8095c28720 100644
> --- a/drivers/pinctrl/berlin/berlin.c
> +++ b/drivers/pinctrl/berlin/berlin.c
> @@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev,
>  }
>  
>  static const struct pinctrl_ops berlin_pinctrl_ops = {
> -	.get_groups_count	= &berlin_pinctrl_get_group_count,
> -	.get_group_name		= &berlin_pinctrl_get_group_name,
> -	.dt_node_to_map		= &berlin_pinctrl_dt_node_to_map,
> -	.dt_free_map		= &pinctrl_utils_free_map,
> +	.get_groups_count	= berlin_pinctrl_get_group_count,
> +	.get_group_name		= berlin_pinctrl_get_group_name,
> +	.dt_node_to_map		= berlin_pinctrl_dt_node_to_map,
> +	.dt_free_map		= pinctrl_utils_free_map,
>  };
>  
>  static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev)
> -- 
> 2.34.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: berlin: Drop superfluous ampersands
Date: Sun, 27 Aug 2023 18:21:25 +0800	[thread overview]
Message-ID: <ZOsjpRJYE0nGpmSx@xhacker> (raw)
In-Reply-To: <0ff17be9b31c9fcf03481c0665293b98ced741f7.1692871243.git.geert+renesas@glider.be>

On Thu, Aug 24, 2023 at 12:05:50PM +0200, Geert Uytterhoeven wrote:
> There is no need to use an ampersand to take the address of a function.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Jisheng Zhang <jszhang@kernel.org>

Hi Linus Walleij,

If it's not too late, could you please merge it?

Thanks in advance

> ---
>  drivers/pinctrl/berlin/berlin.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
> index 1e427ea4d31bcbfc..9550cc8095c28720 100644
> --- a/drivers/pinctrl/berlin/berlin.c
> +++ b/drivers/pinctrl/berlin/berlin.c
> @@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev,
>  }
>  
>  static const struct pinctrl_ops berlin_pinctrl_ops = {
> -	.get_groups_count	= &berlin_pinctrl_get_group_count,
> -	.get_group_name		= &berlin_pinctrl_get_group_name,
> -	.dt_node_to_map		= &berlin_pinctrl_dt_node_to_map,
> -	.dt_free_map		= &pinctrl_utils_free_map,
> +	.get_groups_count	= berlin_pinctrl_get_group_count,
> +	.get_group_name		= berlin_pinctrl_get_group_name,
> +	.dt_node_to_map		= berlin_pinctrl_dt_node_to_map,
> +	.dt_free_map		= pinctrl_utils_free_map,
>  };
>  
>  static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev)
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-27 10:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 10:05 [PATCH] pinctrl: berlin: Drop superfluous ampersands Geert Uytterhoeven
2023-08-24 10:05 ` Geert Uytterhoeven
2023-08-27 10:21 ` Jisheng Zhang [this message]
2023-08-27 10:21   ` Jisheng Zhang
2023-09-11 13:45 ` Linus Walleij
2023-09-11 13:45   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOsjpRJYE0nGpmSx@xhacker \
    --to=jszhang@kernel.org \
    --cc=antoine.tenart@bootlin.com \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.