* Re: [PATCH] drm: fix doc warnings related to drm connector
@ 2023-09-10 3:59 ` Randy Dunlap
0 siblings, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2023-09-10 3:59 UTC (permalink / raw)
To: Bagas Sanjaya, Bragatheswaran Manickavel, maarten.lankhorst,
mripard, tzimmermann, airlied, daniel
Cc: dri-devel, linux-kernel
On 9/9/23 20:54, Bagas Sanjaya wrote:
> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote:
>> Addressing drm dp/hdmi connector related kernel documentation
>> warning and add more information about these values.
>
> What are these?
>
There are already patches for these issues.
Please check latest linux-next and make patches to it instead of using mainline.
Thanks.
>>
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>> ---
>> drivers/gpu/drm/drm_connector.c | 2 ++
>> include/drm/drm_connector.h | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
>> index bf8371dc2a61..084c95785dda 100644
>> --- a/drivers/gpu/drm/drm_connector.c
>> +++ b/drivers/gpu/drm/drm_connector.c
>> @@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector,
>> /**
>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property
>> * @connector: connector to create the Colorspace property on.
>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>> *
>> * Called by a driver the first time it's needed, must be attached to desired
>> * HDMI connectors.
>> @@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>> /**
>> * drm_mode_create_dp_colorspace_property - create dp colorspace property
>> * @connector: connector to create the Colorspace property on.
>> + * @supported_colorspaces: to get dp supported colorspaces.
>> *
>> * Called by a driver the first time it's needed, must be attached to desired
>> * DP connectors.
>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>> index d300fde6c1a4..556d66dd122c 100644
>> --- a/include/drm/drm_connector.h
>> +++ b/include/drm/drm_connector.h
>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>> * ITU-R BT.601 colorimetry format
>> * The DP spec does not say whether this is the 525 or the 625
>> * line version.
>> + * @DRM_MODE_COLORIMETRY_COUNT:
>> + * Represents the count of colorspaces.
>> */
>> enum drm_colorspace {
>> /* For Default case, driver will set the colorspace */
>
> Oh, you mean to add description for colorspace-related fields.
>
> Thanks.
>
>
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drm: fix doc warnings related to drm connector
2023-09-10 3:59 ` Randy Dunlap
(?)
@ 2023-09-10 6:37 ` Bragatheswaran Manickavel
2023-09-10 19:11 ` Randy Dunlap
-1 siblings, 1 reply; 11+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-10 6:37 UTC (permalink / raw)
To: Randy Dunlap; +Cc: tzimmermann, linux-kernel, mripard, dri-devel, Bagas Sanjaya
[-- Attachment #1: Type: text/plain, Size: 2570 bytes --]
>On Sun, 10 Sept 2023 at 09:29, Randy Dunlap <rdunlap@infradead.org> wrote:
>On 9/9/23 20:54, Bagas Sanjaya wrote:
>> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel
wrote:
>>> Addressing drm dp/hdmi connector related kernel documentation
>>> warning and add more information about these values.
>>
>> What are these?
>>
>
>There are already patches for these issues.
>
>Please check latest linux-next and make patches to it instead of using
mainline.
>
>Thanks.
Just had a look at the latest next-20230908. Changes of
include/drm/drm_connector.h are
not present.
Thanks,
>
>
>
>>>
>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>>> ---
>>> drivers/gpu/drm/drm_connector.c | 2 ++
>>> include/drm/drm_connector.h | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_connector.c
b/drivers/gpu/drm/drm_connector.c
>>> index bf8371dc2a61..084c95785dda 100644
>>> --- a/drivers/gpu/drm/drm_connector.c
>>> +++ b/drivers/gpu/drm/drm_connector.c
>>> @@ -2203,6 +2203,7 @@ static int
drm_mode_create_colorspace_property(struct drm_connector *connector,
>>> /**
>>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace
property
>>> * @connector: connector to create the Colorspace property on.
>>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>>> *
>>> * Called by a driver the first time it's needed, must be attached to
desired
>>> * HDMI connectors.
>>> @@ -2227,6 +2228,7 @@
EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>>> /**
>>> * drm_mode_create_dp_colorspace_property - create dp colorspace
property
>>> * @connector: connector to create the Colorspace property on.
>>> + * @supported_colorspaces: to get dp supported colorspaces.
>>> *
>>> * Called by a driver the first time it's needed, must be attached to
desired
>>> * DP connectors.
>>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>>> index d300fde6c1a4..556d66dd122c 100644
>>> --- a/include/drm/drm_connector.h
>>> +++ b/include/drm/drm_connector.h
>>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>>> * ITU-R BT.601 colorimetry format
>>> * The DP spec does not say whether this is the 525 or the 625
>>> * line version.
>>> + * @DRM_MODE_COLORIMETRY_COUNT:
>>> + * Represents the count of colorspaces.
>>> */
>>> enum drm_colorspace {
>>> /* For Default case, driver will set the colorspace */
>>
>> Oh, you mean to add description for colorspace-related fields.
>>
>> Thanks.
>>
>>
>
>--
~Randy
[-- Attachment #2: Type: text/html, Size: 3423 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drm: fix doc warnings related to drm connector
2023-09-10 6:37 ` Bragatheswaran Manickavel
@ 2023-09-10 19:11 ` Randy Dunlap
0 siblings, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2023-09-10 19:11 UTC (permalink / raw)
To: Bragatheswaran Manickavel
Cc: tzimmermann, linux-kernel, mripard, dri-devel, Bagas Sanjaya
On 9/9/23 23:37, Bragatheswaran Manickavel wrote:
>>On Sun, 10 Sept 2023 at 09:29, Randy Dunlap <rdunlap@infradead.org <mailto:rdunlap@infradead.org>> wrote:
>>On 9/9/23 20:54, Bagas Sanjaya wrote:
>>> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote:
>>>> Addressing drm dp/hdmi connector related kernel documentation
>>>> warning and add more information about these values.
>>>
>>> What are these?
>>>
>>
>>There are already patches for these issues.
>>
>>Please check latest linux-next and make patches to it instead of using mainline.
>>
>>Thanks.
>
> Just had a look at the latest next-20230908. Changes of include/drm/drm_connector.h are
> not present.
That's correct. The patch for that was sent on Sept. 6 and applied to a drm git tree
on Sept. 7.
It's here: https://lore.kernel.org/all/20230906-topic-drm_connector_doc-v2-1-1f2dcaa43269@gmail.com/
>>>>
>>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com <mailto:bragathemanick0908@gmail.com>>
>>>> ---
>>>> drivers/gpu/drm/drm_connector.c | 2 ++
>>>> include/drm/drm_connector.h | 2 ++
>>>> 2 files changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
>>>> index bf8371dc2a61..084c95785dda 100644
>>>> --- a/drivers/gpu/drm/drm_connector.c
>>>> +++ b/drivers/gpu/drm/drm_connector.c
>>>> @@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector,
>>>> /**
>>>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property
>>>> * @connector: connector to create the Colorspace property on.
>>>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>>>> *
>>>> * Called by a driver the first time it's needed, must be attached to desired
>>>> * HDMI connectors.
>>>> @@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>>>> /**
>>>> * drm_mode_create_dp_colorspace_property - create dp colorspace property
>>>> * @connector: connector to create the Colorspace property on.
>>>> + * @supported_colorspaces: to get dp supported colorspaces.
>>>> *
>>>> * Called by a driver the first time it's needed, must be attached to desired
>>>> * DP connectors.
>>>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>>>> index d300fde6c1a4..556d66dd122c 100644
>>>> --- a/include/drm/drm_connector.h
>>>> +++ b/include/drm/drm_connector.h
>>>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>>>> * ITU-R BT.601 colorimetry format
>>>> * The DP spec does not say whether this is the 525 or the 625
>>>> * line version.
>>>> + * @DRM_MODE_COLORIMETRY_COUNT:
>>>> + * Represents the count of colorspaces.
>>>> */
>>>> enum drm_colorspace {
>>>> /* For Default case, driver will set the colorspace */
>>>
>>> Oh, you mean to add description for colorspace-related fields.
>>>
>>> Thanks.
>>>
>>>
>>
>>--
> ~Randy
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drm: fix doc warnings related to drm connector
@ 2023-09-10 19:11 ` Randy Dunlap
0 siblings, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2023-09-10 19:11 UTC (permalink / raw)
To: Bragatheswaran Manickavel
Cc: Bagas Sanjaya, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, dri-devel, linux-kernel
On 9/9/23 23:37, Bragatheswaran Manickavel wrote:
>>On Sun, 10 Sept 2023 at 09:29, Randy Dunlap <rdunlap@infradead.org <mailto:rdunlap@infradead.org>> wrote:
>>On 9/9/23 20:54, Bagas Sanjaya wrote:
>>> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote:
>>>> Addressing drm dp/hdmi connector related kernel documentation
>>>> warning and add more information about these values.
>>>
>>> What are these?
>>>
>>
>>There are already patches for these issues.
>>
>>Please check latest linux-next and make patches to it instead of using mainline.
>>
>>Thanks.
>
> Just had a look at the latest next-20230908. Changes of include/drm/drm_connector.h are
> not present.
That's correct. The patch for that was sent on Sept. 6 and applied to a drm git tree
on Sept. 7.
It's here: https://lore.kernel.org/all/20230906-topic-drm_connector_doc-v2-1-1f2dcaa43269@gmail.com/
>>>>
>>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com <mailto:bragathemanick0908@gmail.com>>
>>>> ---
>>>> drivers/gpu/drm/drm_connector.c | 2 ++
>>>> include/drm/drm_connector.h | 2 ++
>>>> 2 files changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
>>>> index bf8371dc2a61..084c95785dda 100644
>>>> --- a/drivers/gpu/drm/drm_connector.c
>>>> +++ b/drivers/gpu/drm/drm_connector.c
>>>> @@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector,
>>>> /**
>>>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property
>>>> * @connector: connector to create the Colorspace property on.
>>>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>>>> *
>>>> * Called by a driver the first time it's needed, must be attached to desired
>>>> * HDMI connectors.
>>>> @@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>>>> /**
>>>> * drm_mode_create_dp_colorspace_property - create dp colorspace property
>>>> * @connector: connector to create the Colorspace property on.
>>>> + * @supported_colorspaces: to get dp supported colorspaces.
>>>> *
>>>> * Called by a driver the first time it's needed, must be attached to desired
>>>> * DP connectors.
>>>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>>>> index d300fde6c1a4..556d66dd122c 100644
>>>> --- a/include/drm/drm_connector.h
>>>> +++ b/include/drm/drm_connector.h
>>>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>>>> * ITU-R BT.601 colorimetry format
>>>> * The DP spec does not say whether this is the 525 or the 625
>>>> * line version.
>>>> + * @DRM_MODE_COLORIMETRY_COUNT:
>>>> + * Represents the count of colorspaces.
>>>> */
>>>> enum drm_colorspace {
>>>> /* For Default case, driver will set the colorspace */
>>>
>>> Oh, you mean to add description for colorspace-related fields.
>>>
>>> Thanks.
>>>
>>>
>>
>>--
> ~Randy
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm: fix doc warnings related to drm connector
2023-09-10 3:59 ` Randy Dunlap
(?)
(?)
@ 2023-09-10 6:45 ` Bragatheswaran Manickavel
-1 siblings, 0 replies; 11+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-10 6:45 UTC (permalink / raw)
To: Randy Dunlap, airlied, maarten.lankhorst, daniel, Bagas Sanjaya,
mripard, tzimmermann
Cc: linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 2558 bytes --]
>On Sun, 10 Sept 2023 at 09:29, Randy Dunlap <rdunlap@infradead.org> wrote:
>On 9/9/23 20:54, Bagas Sanjaya wrote:
>> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel
wrote:
>>> Addressing drm dp/hdmi connector related kernel documentation
>>> warning and add more information about these values.
>>
>> What are these?
>>
>
>There are already patches for these issues.
>
>Please check latest linux-next and make patches to it instead of using
mainline.
>
>Thanks.
Just had a look at the latest next-20230908. Changes of
include/drm/drm_connector.h are
not present.
Thanks,
>
>>>
>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>>> ---
>>> drivers/gpu/drm/drm_connector.c | 2 ++
>>> include/drm/drm_connector.h | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_connector.c
b/drivers/gpu/drm/drm_connector.c
>>> index bf8371dc2a61..084c95785dda 100644
>>> --- a/drivers/gpu/drm/drm_connector.c
>>> +++ b/drivers/gpu/drm/drm_connector.c
>>> @@ -2203,6 +2203,7 @@ static int
drm_mode_create_colorspace_property(struct drm_connector *connector,
>>> /**
>>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace
property
>>> * @connector: connector to create the Colorspace property on.
>>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>>> *
>>> * Called by a driver the first time it's needed, must be attached to
desired
>>> * HDMI connectors.
>>> @@ -2227,6 +2228,7 @@
EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>>> /**
>>> * drm_mode_create_dp_colorspace_property - create dp colorspace
property
>>> * @connector: connector to create the Colorspace property on.
>>> + * @supported_colorspaces: to get dp supported colorspaces.
>>> *
>>> * Called by a driver the first time it's needed, must be attached to
desired
>>> * DP connectors.
>>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>>> index d300fde6c1a4..556d66dd122c 100644
>>> --- a/include/drm/drm_connector.h
>>> +++ b/include/drm/drm_connector.h
>>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>>> * ITU-R BT.601 colorimetry format
>>> * The DP spec does not say whether this is the 525 or the 625
>>> * line version.
>>> + * @DRM_MODE_COLORIMETRY_COUNT:
>>> + * Represents the count of colorspaces.
>>> */
>>> enum drm_colorspace {
>>> /* For Default case, driver will set the colorspace */
>>
>> Oh, you mean to add description for colorspace-related fields.
>>
>> Thanks.
>>
>>
>
--
[-- Attachment #2: Type: text/html, Size: 3431 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drm: fix doc warnings related to drm connector
2023-09-10 3:59 ` Randy Dunlap
` (2 preceding siblings ...)
(?)
@ 2023-09-10 9:39 ` Bragatheswaran Manickavel
-1 siblings, 0 replies; 11+ messages in thread
From: Bragatheswaran Manickavel @ 2023-09-10 9:39 UTC (permalink / raw)
To: Randy Dunlap; +Cc: tzimmermann, linux-kernel, mripard, dri-devel, Bagas Sanjaya
[-- Attachment #1: Type: text/plain, Size: 2550 bytes --]
On Sun, 10 Sept 2023 at 09:29, Randy Dunlap <rdunlap@infradead.org> wrote:
>On 9/9/23 20:54, Bagas Sanjaya wrote:
>> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel
wrote:
>>> Addressing drm dp/hdmi connector related kernel documentation
>>> warning and add more information about these values.
>>
>> What are these?
>>
>
>There are already patches for these issues.
>
>Please check latest linux-next and make patches to it instead of using
mainline.
>
>Thanks.
Just had a look at the latest next-20230908. Changes of
include/drm/drm_connector.h are
not present.
thanks,
>
>>>
>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>>> ---
>>> drivers/gpu/drm/drm_connector.c | 2 ++
>>> include/drm/drm_connector.h | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_connector.c
b/drivers/gpu/drm/drm_connector.c
>>> index bf8371dc2a61..084c95785dda 100644
>>> --- a/drivers/gpu/drm/drm_connector.c
>>> +++ b/drivers/gpu/drm/drm_connector.c
>>> @@ -2203,6 +2203,7 @@ static int
drm_mode_create_colorspace_property(struct drm_connector *connector,
>>> /**
>>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace
property
>>> * @connector: connector to create the Colorspace property on.
>>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>>> *
>>> * Called by a driver the first time it's needed, must be attached to
desired
>>> * HDMI connectors.
>>> @@ -2227,6 +2228,7 @@
EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>>> /**
>>> * drm_mode_create_dp_colorspace_property - create dp colorspace
property
>>> * @connector: connector to create the Colorspace property on.
>>> + * @supported_colorspaces: to get dp supported colorspaces.
>>> *
>>> * Called by a driver the first time it's needed, must be attached to
desired
>>> * DP connectors.
>>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>>> index d300fde6c1a4..556d66dd122c 100644
>>> --- a/include/drm/drm_connector.h
>>> +++ b/include/drm/drm_connector.h
>>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>>> * ITU-R BT.601 colorimetry format
>>> * The DP spec does not say whether this is the 525 or the 625
>>> * line version.
>>> + * @DRM_MODE_COLORIMETRY_COUNT:
>>> + * Represents the count of colorspaces.
>>> */
>>> enum drm_colorspace {
>>> /* For Default case, driver will set the colorspace */
>>
>> Oh, you mean to add description for colorspace-related fields.
>>
>> Thanks.
--
[-- Attachment #2: Type: text/html, Size: 3361 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread