[PATCH] ASoC: dwc: fix typo in comment

[PATCH] ASoC: dwc: fix typo in comment

[Myunguk Kim]

This fixes typo in comment

Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
---
 sound/soc/dwc/dwc-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 71ff894035a4..45e55e550924 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
 			irq_valid = true;
 		}
 
-		/* Error Handling: TX */
+		/* Error Handling: RX */
 		if (isr[i] & ISR_RXFO) 
{ 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
 			irq_valid = true;
-- 
2.34.1

Re: [PATCH] ASoC: dwc: fix typo in comment

[Maxim Kochetkov]

On 11.09.2023 09:46, Myunguk Kim wrote:
> This fixes typo in comment
> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>

Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>

Re: [PATCH] ASoC: dwc: fix typo in comment

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Mon, Sep 11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:
> This fixes typo in comment

On what? Can you describe the typofix in more detail?

> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
> ---
>  sound/soc/dwc/dwc-i2s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 71ff894035a4..45e55e550924 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
>  			irq_valid = true;
>  		}
>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
>  			irq_valid = true;

Oh, you mean the code following the comment checks for RXFO overrun.

Confused...

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] ASoC: dwc: fix typo in comment

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

On Mon, Sep 11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:
> This fixes typo in comment
> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>

This doesn't apply against current code, please check and resend:

Applying: ASoC: dwc: fix typo in comment
error: sha1 information is lacking or useless (sound/soc/dwc/dwc-i2s.c).
error: could not build fake ancestor
Patch failed at 0001 ASoC: dwc: fix typo in comment

(after fixing what looked like corruption in the mail)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: dwc: fix typo in comment

[Myunguk Kim]

> This doesn't apply against current code, please check and resend:

Sorry, I will send a clean v2 in a moment.

(no subject)

[Myunguk Kim]

RE: Re: [PATCH] ASoC: dwc: fix typo in comment

[김명욱]

ISR_RXFO means \"Status of Data Overrun interrupt for the RX channel\"
according to the datasheetSo, the comment should be RX, not
TXThanksMyunguk------------Original Message------------Subject : Re: [PATCH]
ASoC: dwc: fix typo in commentDate : 2023-09-11 21:46:05From : Bagas Sanjaya
<bagasdotme@gmailcom>To : Myunguk Kim <mwkim@gaonchipscom>,
alsa-devel@alsa-projectorgCc : Liam Girdwood <lgirdwood@gmailcom>,
Mark Brown <broonie@kernelorg>, Jaroslav Kysela <perex@perexcz>,
Takashi Iwai <tiwai@susecom>, Maxim Kochetkov
<fido_max@inboxru>, Kuninori Morimoto
<kuninorimorimotogx@renesascom>, Xingyu Wu
<xingyuwu@starfivetechcom>, Uwe Kleine-König
<ukleine-koenig@pengutronixde>, linux-kernel@vgerkernelorgOn Mon, Sep
11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:> This fixes typo in
commentOn what? Can you describe the typofix in more detail?>>
Signed-off-by: Myunguk Kim <mwkim@gaonchipscom>> --->
sound/soc/dwc/dwc-i2sc | 2 +-> 1 file changed, 1 insertion(+), 1
deletion(-)>> diff --git a/sound/soc/dwc/dwc-i2sc
b/sound/soc/dwc/dwc-i2sc> index 71ff894035a445e55e550924 100644> ---
a/sound/soc/dwc/dwc-i2sc> +++ b/sound/soc/dwc/dwc-i2sc> @@ -138,7
+138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)>
irq_valid = true;> }>> - /* Error Handling: TX */> + /* Error
Handling: RX */> if (isr[i] & ISR_RXFO)> {
dev_err_ratelimited(dev->dev, \"RX overrun (ch_id=%d)\\n\", i);>
irq_valid = true;Oh, you mean the code following the comment checks for RXFO
overrunConfused--An old man doll just what I always wanted! - Clara

Re: [PATCH] ASoC: dwc: fix typo in comment

[Bagas Sanjaya]

On 12/09/2023 08:23, 김명욱 wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel" according to the datasheet.
> 
> So, the comment should be RX, not TX
> 
=

OK, but next time don't reply like:

> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top

because I can't see the context you're replying to.

And don't send HTML emails as mailing lists hate and
block them.

Regardless, send v2 with reviews (especially on patch description like this)
addressed.

Thanks!

-- 
An old man doll... just what I always wanted! - Clara