* [Intel-gfx] [PATCH 0/6] drm, cec and edid updates @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Avoid accessing the raw edid directly. Pre-parse the source physical address during normal EDID parsing and use that for CEC. Jani Nikula (6): drm/edid: add drm_edid_is_digital() drm/i915/display: use drm_edid_is_digital() drm/edid: parse source physical address drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid drm/i915/cec: switch to setting physical address directly media: cec: core: add note about *_from_edid() function usage in drm drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- drivers/media/cec/core/cec-adap.c | 4 ++++ drivers/media/cec/core/cec-notifier.c | 4 ++++ include/drm/display/drm_dp_helper.h | 6 ++++++ include/drm/drm_connector.h | 8 ++++++++ include/drm/drm_edid.h | 1 + 11 files changed, 73 insertions(+), 27 deletions(-) -- 2.39.2 ^ permalink raw reply [flat|nested] 77+ messages in thread
* [PATCH 0/6] drm, cec and edid updates @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula Avoid accessing the raw edid directly. Pre-parse the source physical address during normal EDID parsing and use that for CEC. Jani Nikula (6): drm/edid: add drm_edid_is_digital() drm/i915/display: use drm_edid_is_digital() drm/edid: parse source physical address drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid drm/i915/cec: switch to setting physical address directly media: cec: core: add note about *_from_edid() function usage in drm drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- drivers/media/cec/core/cec-adap.c | 4 ++++ drivers/media/cec/core/cec-notifier.c | 4 ++++ include/drm/display/drm_dp_helper.h | 6 ++++++ include/drm/drm_connector.h | 8 ++++++++ include/drm/drm_edid.h | 1 + 11 files changed, 73 insertions(+), 27 deletions(-) -- 2.39.2 ^ permalink raw reply [flat|nested] 77+ messages in thread
* [PATCH 0/6] drm, cec and edid updates @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Avoid accessing the raw edid directly. Pre-parse the source physical address during normal EDID parsing and use that for CEC. Jani Nikula (6): drm/edid: add drm_edid_is_digital() drm/i915/display: use drm_edid_is_digital() drm/edid: parse source physical address drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid drm/i915/cec: switch to setting physical address directly media: cec: core: add note about *_from_edid() function usage in drm drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- drivers/media/cec/core/cec-adap.c | 4 ++++ drivers/media/cec/core/cec-notifier.c | 4 ++++ include/drm/display/drm_dp_helper.h | 6 ++++++ include/drm/drm_connector.h | 8 ++++++++ include/drm/drm_edid.h | 1 + 11 files changed, 73 insertions(+), 27 deletions(-) -- 2.39.2 ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH 1/6] drm/edid: add drm_edid_is_digital() 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-24 13:46 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to deserve a helper that also lets us abstract the raw EDID a bit better. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- include/drm/drm_edid.h | 1 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 340da8257b51..1dbb15439468 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) return ret; } - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); + return drm_edid_is_digital(drm_edid); } static void @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, if (edid->revision < 3) goto out; - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) + if (!drm_edid_is_digital(drm_edid)) goto out; info->color_formats |= DRM_COLOR_FORMAT_RGB444; @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, connector->tile_group = NULL; } } + +/** + * drm_edid_is_digital - is digital? + * @drm_edid: The EDID + * + * Return true if input is digital. + */ +bool drm_edid_is_digital(const struct drm_edid *drm_edid) +{ + return drm_edid && drm_edid->edid && + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; +} +EXPORT_SYMBOL(drm_edid_is_digital); diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 48e93f909ef6..882d2638708e 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, int drm_edid_connector_update(struct drm_connector *connector, const struct drm_edid *edid); int drm_edid_connector_add_modes(struct drm_connector *connector); +bool drm_edid_is_digital(const struct drm_edid *drm_edid); const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, int ext_id, int *ext_index); -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to deserve a helper that also lets us abstract the raw EDID a bit better. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- include/drm/drm_edid.h | 1 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 340da8257b51..1dbb15439468 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) return ret; } - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); + return drm_edid_is_digital(drm_edid); } static void @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, if (edid->revision < 3) goto out; - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) + if (!drm_edid_is_digital(drm_edid)) goto out; info->color_formats |= DRM_COLOR_FORMAT_RGB444; @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, connector->tile_group = NULL; } } + +/** + * drm_edid_is_digital - is digital? + * @drm_edid: The EDID + * + * Return true if input is digital. + */ +bool drm_edid_is_digital(const struct drm_edid *drm_edid) +{ + return drm_edid && drm_edid->edid && + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; +} +EXPORT_SYMBOL(drm_edid_is_digital); diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 48e93f909ef6..882d2638708e 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, int drm_edid_connector_update(struct drm_connector *connector, const struct drm_edid *edid); int drm_edid_connector_add_modes(struct drm_connector *connector); +bool drm_edid_is_digital(const struct drm_edid *drm_edid); const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, int ext_id, int *ext_index); -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to deserve a helper that also lets us abstract the raw EDID a bit better. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- include/drm/drm_edid.h | 1 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 340da8257b51..1dbb15439468 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) return ret; } - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); + return drm_edid_is_digital(drm_edid); } static void @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, if (edid->revision < 3) goto out; - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) + if (!drm_edid_is_digital(drm_edid)) goto out; info->color_formats |= DRM_COLOR_FORMAT_RGB444; @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, connector->tile_group = NULL; } } + +/** + * drm_edid_is_digital - is digital? + * @drm_edid: The EDID + * + * Return true if input is digital. + */ +bool drm_edid_is_digital(const struct drm_edid *drm_edid) +{ + return drm_edid && drm_edid->edid && + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; +} +EXPORT_SYMBOL(drm_edid_is_digital); diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 48e93f909ef6..882d2638708e 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, int drm_edid_connector_update(struct drm_connector *connector, const struct drm_edid *edid); int drm_edid_connector_add_modes(struct drm_connector *connector); +bool drm_edid_is_digital(const struct drm_edid *drm_edid); const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, int ext_id, int *ext_index); -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 1/6] drm/edid: add drm_edid_is_digital() 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-31 17:23 ` Ville Syrjälä -1 siblings, 0 replies; 77+ messages in thread From: Ville Syrjälä @ 2023-08-31 17:23 UTC (permalink / raw) To: Jani Nikula; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Thu, Aug 24, 2023 at 04:46:02PM +0300, Jani Nikula wrote: > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- > include/drm/drm_edid.h | 1 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 340da8257b51..1dbb15439468 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) > return ret; > } > > - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > + return drm_edid_is_digital(drm_edid); > } > > static void > @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, > if (edid->revision < 3) > goto out; > > - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) > + if (!drm_edid_is_digital(drm_edid)) > goto out; > > info->color_formats |= DRM_COLOR_FORMAT_RGB444; > @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, > connector->tile_group = NULL; > } > } > + > +/** > + * drm_edid_is_digital - is digital? > + * @drm_edid: The EDID > + * > + * Return true if input is digital. > + */ > +bool drm_edid_is_digital(const struct drm_edid *drm_edid) > +{ > + return drm_edid && drm_edid->edid && > + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; > +} > +EXPORT_SYMBOL(drm_edid_is_digital); > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 48e93f909ef6..882d2638708e 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, > int drm_edid_connector_update(struct drm_connector *connector, > const struct drm_edid *edid); > int drm_edid_connector_add_modes(struct drm_connector *connector); > +bool drm_edid_is_digital(const struct drm_edid *drm_edid); > > const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, > int ext_id, int *ext_index); > -- > 2.39.2 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-08-31 17:23 ` Ville Syrjälä 0 siblings, 0 replies; 77+ messages in thread From: Ville Syrjälä @ 2023-08-31 17:23 UTC (permalink / raw) To: Jani Nikula; +Cc: dri-devel, Hans Verkuil, intel-gfx, linux-media On Thu, Aug 24, 2023 at 04:46:02PM +0300, Jani Nikula wrote: > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- > include/drm/drm_edid.h | 1 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 340da8257b51..1dbb15439468 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) > return ret; > } > > - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > + return drm_edid_is_digital(drm_edid); > } > > static void > @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, > if (edid->revision < 3) > goto out; > > - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) > + if (!drm_edid_is_digital(drm_edid)) > goto out; > > info->color_formats |= DRM_COLOR_FORMAT_RGB444; > @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, > connector->tile_group = NULL; > } > } > + > +/** > + * drm_edid_is_digital - is digital? > + * @drm_edid: The EDID > + * > + * Return true if input is digital. > + */ > +bool drm_edid_is_digital(const struct drm_edid *drm_edid) > +{ > + return drm_edid && drm_edid->edid && > + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; > +} > +EXPORT_SYMBOL(drm_edid_is_digital); > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 48e93f909ef6..882d2638708e 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, > int drm_edid_connector_update(struct drm_connector *connector, > const struct drm_edid *edid); > int drm_edid_connector_add_modes(struct drm_connector *connector); > +bool drm_edid_is_digital(const struct drm_edid *drm_edid); > > const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, > int ext_id, int *ext_index); > -- > 2.39.2 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-08-31 17:23 ` Ville Syrjälä 0 siblings, 0 replies; 77+ messages in thread From: Ville Syrjälä @ 2023-08-31 17:23 UTC (permalink / raw) To: Jani Nikula; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Thu, Aug 24, 2023 at 04:46:02PM +0300, Jani Nikula wrote: > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- > include/drm/drm_edid.h | 1 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 340da8257b51..1dbb15439468 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) > return ret; > } > > - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > + return drm_edid_is_digital(drm_edid); > } > > static void > @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, > if (edid->revision < 3) > goto out; > > - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) > + if (!drm_edid_is_digital(drm_edid)) > goto out; > > info->color_formats |= DRM_COLOR_FORMAT_RGB444; > @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, > connector->tile_group = NULL; > } > } > + > +/** > + * drm_edid_is_digital - is digital? > + * @drm_edid: The EDID > + * > + * Return true if input is digital. > + */ > +bool drm_edid_is_digital(const struct drm_edid *drm_edid) > +{ > + return drm_edid && drm_edid->edid && > + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; > +} > +EXPORT_SYMBOL(drm_edid_is_digital); > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 48e93f909ef6..882d2638708e 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, > int drm_edid_connector_update(struct drm_connector *connector, > const struct drm_edid *edid); > int drm_edid_connector_add_modes(struct drm_connector *connector); > +bool drm_edid_is_digital(const struct drm_edid *drm_edid); > > const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, > int ext_id, int *ext_index); > -- > 2.39.2 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 1/6] drm/edid: add drm_edid_is_digital() 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-09-01 19:26 ` Alex Deucher -1 siblings, 0 replies; 77+ messages in thread From: Alex Deucher @ 2023-09-01 19:26 UTC (permalink / raw) To: Jani Nikula; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula <jani.nikula@intel.com> wrote: > > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Seems to be a few additional users of this that could be converted: drivers/gpu/drm/i915/display/intel_sdvo.c: if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/i915/display/intel_sdvo.c: bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/i915/display/intel_crt.c: bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; drivers/gpu/drm/i915/display/intel_hdmi.c: if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/gma500/psb_intel_sdvo.c: bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/gma500/cdv_intel_hdmi.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/display/drm_dp_helper.c: edid->input & DRM_EDID_INPUT_DIGITAL && drivers/gpu/drm/nouveau/nouveau_connector.c: if (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/radeon/radeon_connectors.c: !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/radeon/radeon_connectors.c: !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > --- > drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- > include/drm/drm_edid.h | 1 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 340da8257b51..1dbb15439468 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) > return ret; > } > > - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > + return drm_edid_is_digital(drm_edid); > } > > static void > @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, > if (edid->revision < 3) > goto out; > > - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) > + if (!drm_edid_is_digital(drm_edid)) > goto out; > > info->color_formats |= DRM_COLOR_FORMAT_RGB444; > @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, > connector->tile_group = NULL; > } > } > + > +/** > + * drm_edid_is_digital - is digital? > + * @drm_edid: The EDID > + * > + * Return true if input is digital. > + */ > +bool drm_edid_is_digital(const struct drm_edid *drm_edid) > +{ > + return drm_edid && drm_edid->edid && > + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; > +} > +EXPORT_SYMBOL(drm_edid_is_digital); > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 48e93f909ef6..882d2638708e 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, > int drm_edid_connector_update(struct drm_connector *connector, > const struct drm_edid *edid); > int drm_edid_connector_add_modes(struct drm_connector *connector); > +bool drm_edid_is_digital(const struct drm_edid *drm_edid); > > const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, > int ext_id, int *ext_index); > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-09-01 19:26 ` Alex Deucher 0 siblings, 0 replies; 77+ messages in thread From: Alex Deucher @ 2023-09-01 19:26 UTC (permalink / raw) To: Jani Nikula; +Cc: dri-devel, Hans Verkuil, intel-gfx, linux-media On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula <jani.nikula@intel.com> wrote: > > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Seems to be a few additional users of this that could be converted: drivers/gpu/drm/i915/display/intel_sdvo.c: if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/i915/display/intel_sdvo.c: bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/i915/display/intel_crt.c: bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; drivers/gpu/drm/i915/display/intel_hdmi.c: if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/gma500/psb_intel_sdvo.c: bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/gma500/cdv_intel_hdmi.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/display/drm_dp_helper.c: edid->input & DRM_EDID_INPUT_DIGITAL && drivers/gpu/drm/nouveau/nouveau_connector.c: if (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/radeon/radeon_connectors.c: !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/radeon/radeon_connectors.c: !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > --- > drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- > include/drm/drm_edid.h | 1 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 340da8257b51..1dbb15439468 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) > return ret; > } > > - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > + return drm_edid_is_digital(drm_edid); > } > > static void > @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, > if (edid->revision < 3) > goto out; > > - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) > + if (!drm_edid_is_digital(drm_edid)) > goto out; > > info->color_formats |= DRM_COLOR_FORMAT_RGB444; > @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, > connector->tile_group = NULL; > } > } > + > +/** > + * drm_edid_is_digital - is digital? > + * @drm_edid: The EDID > + * > + * Return true if input is digital. > + */ > +bool drm_edid_is_digital(const struct drm_edid *drm_edid) > +{ > + return drm_edid && drm_edid->edid && > + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; > +} > +EXPORT_SYMBOL(drm_edid_is_digital); > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 48e93f909ef6..882d2638708e 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, > int drm_edid_connector_update(struct drm_connector *connector, > const struct drm_edid *edid); > int drm_edid_connector_add_modes(struct drm_connector *connector); > +bool drm_edid_is_digital(const struct drm_edid *drm_edid); > > const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, > int ext_id, int *ext_index); > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-09-01 19:26 ` Alex Deucher 0 siblings, 0 replies; 77+ messages in thread From: Alex Deucher @ 2023-09-01 19:26 UTC (permalink / raw) To: Jani Nikula; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula <jani.nikula@intel.com> wrote: > > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Seems to be a few additional users of this that could be converted: drivers/gpu/drm/i915/display/intel_sdvo.c: if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/i915/display/intel_sdvo.c: bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/i915/display/intel_crt.c: bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; drivers/gpu/drm/i915/display/intel_hdmi.c: if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/gma500/psb_intel_sdvo.c: bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/gma500/cdv_intel_hdmi.c: if (edid->input & DRM_EDID_INPUT_DIGITAL) { drivers/gpu/drm/display/drm_dp_helper.c: edid->input & DRM_EDID_INPUT_DIGITAL && drivers/gpu/drm/nouveau/nouveau_connector.c: if (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL) drivers/gpu/drm/radeon/radeon_connectors.c: !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/radeon/radeon_connectors.c: !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > --- > drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- > include/drm/drm_edid.h | 1 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 340da8257b51..1dbb15439468 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) > return ret; > } > > - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > + return drm_edid_is_digital(drm_edid); > } > > static void > @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, > if (edid->revision < 3) > goto out; > > - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) > + if (!drm_edid_is_digital(drm_edid)) > goto out; > > info->color_formats |= DRM_COLOR_FORMAT_RGB444; > @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, > connector->tile_group = NULL; > } > } > + > +/** > + * drm_edid_is_digital - is digital? > + * @drm_edid: The EDID > + * > + * Return true if input is digital. > + */ > +bool drm_edid_is_digital(const struct drm_edid *drm_edid) > +{ > + return drm_edid && drm_edid->edid && > + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; > +} > +EXPORT_SYMBOL(drm_edid_is_digital); > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index 48e93f909ef6..882d2638708e 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, > int drm_edid_connector_update(struct drm_connector *connector, > const struct drm_edid *edid); > int drm_edid_connector_add_modes(struct drm_connector *connector); > +bool drm_edid_is_digital(const struct drm_edid *drm_edid); > > const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, > int ext_id, int *ext_index); > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 1/6] drm/edid: add drm_edid_is_digital() 2023-09-01 19:26 ` Alex Deucher (?) @ 2023-09-04 10:43 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-09-04 10:43 UTC (permalink / raw) To: Alex Deucher; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Fri, 01 Sep 2023, Alex Deucher <alexdeucher@gmail.com> wrote: > On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula <jani.nikula@intel.com> wrote: >> >> Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to >> deserve a helper that also lets us abstract the raw EDID a bit better. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Thanks; I'm afraid this got merged already. > Seems to be a few additional users of this that could be converted: > > drivers/gpu/drm/i915/display/intel_sdvo.c: if (edid && > edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/i915/display/intel_sdvo.c: bool monitor_is_digital > = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/i915/display/intel_crt.c: bool is_digital = > edid->input & DRM_EDID_INPUT_DIGITAL; > drivers/gpu/drm/i915/display/intel_hdmi.c: if (edid && edid->input > & DRM_EDID_INPUT_DIGITAL) { The next patch takes care of these. > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) { > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/gma500/psb_intel_sdvo.c: bool > monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid != NULL && > edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/gma500/cdv_intel_hdmi.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) { > drivers/gpu/drm/display/drm_dp_helper.c: edid->input & > DRM_EDID_INPUT_DIGITAL && > drivers/gpu/drm/nouveau/nouveau_connector.c: if > (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/radeon/radeon_connectors.c: > !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/radeon/radeon_connectors.c: > !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: > !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: > !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drm_edid_is_digital() operates on struct drm_edid. The drivers would first need to be converted to use struct drm_edid instead of struct edid, and I'm not really taking that on. IMO adding helpers to operate on struct edid would be counter-productive. BR, Jani. > > > > >> --- >> drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- >> include/drm/drm_edid.h | 1 + >> 2 files changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 340da8257b51..1dbb15439468 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) >> return ret; >> } >> >> - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); >> + return drm_edid_is_digital(drm_edid); >> } >> >> static void >> @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, >> if (edid->revision < 3) >> goto out; >> >> - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) >> + if (!drm_edid_is_digital(drm_edid)) >> goto out; >> >> info->color_formats |= DRM_COLOR_FORMAT_RGB444; >> @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, >> connector->tile_group = NULL; >> } >> } >> + >> +/** >> + * drm_edid_is_digital - is digital? >> + * @drm_edid: The EDID >> + * >> + * Return true if input is digital. >> + */ >> +bool drm_edid_is_digital(const struct drm_edid *drm_edid) >> +{ >> + return drm_edid && drm_edid->edid && >> + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; >> +} >> +EXPORT_SYMBOL(drm_edid_is_digital); >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 48e93f909ef6..882d2638708e 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, >> int drm_edid_connector_update(struct drm_connector *connector, >> const struct drm_edid *edid); >> int drm_edid_connector_add_modes(struct drm_connector *connector); >> +bool drm_edid_is_digital(const struct drm_edid *drm_edid); >> >> const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, >> int ext_id, int *ext_index); >> -- >> 2.39.2 >> -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-09-04 10:43 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-09-04 10:43 UTC (permalink / raw) To: Alex Deucher; +Cc: dri-devel, Hans Verkuil, intel-gfx, linux-media On Fri, 01 Sep 2023, Alex Deucher <alexdeucher@gmail.com> wrote: > On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula <jani.nikula@intel.com> wrote: >> >> Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to >> deserve a helper that also lets us abstract the raw EDID a bit better. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Thanks; I'm afraid this got merged already. > Seems to be a few additional users of this that could be converted: > > drivers/gpu/drm/i915/display/intel_sdvo.c: if (edid && > edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/i915/display/intel_sdvo.c: bool monitor_is_digital > = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/i915/display/intel_crt.c: bool is_digital = > edid->input & DRM_EDID_INPUT_DIGITAL; > drivers/gpu/drm/i915/display/intel_hdmi.c: if (edid && edid->input > & DRM_EDID_INPUT_DIGITAL) { The next patch takes care of these. > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) { > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/gma500/psb_intel_sdvo.c: bool > monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid != NULL && > edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/gma500/cdv_intel_hdmi.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) { > drivers/gpu/drm/display/drm_dp_helper.c: edid->input & > DRM_EDID_INPUT_DIGITAL && > drivers/gpu/drm/nouveau/nouveau_connector.c: if > (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/radeon/radeon_connectors.c: > !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/radeon/radeon_connectors.c: > !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: > !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: > !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drm_edid_is_digital() operates on struct drm_edid. The drivers would first need to be converted to use struct drm_edid instead of struct edid, and I'm not really taking that on. IMO adding helpers to operate on struct edid would be counter-productive. BR, Jani. > > > > >> --- >> drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- >> include/drm/drm_edid.h | 1 + >> 2 files changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 340da8257b51..1dbb15439468 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) >> return ret; >> } >> >> - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); >> + return drm_edid_is_digital(drm_edid); >> } >> >> static void >> @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, >> if (edid->revision < 3) >> goto out; >> >> - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) >> + if (!drm_edid_is_digital(drm_edid)) >> goto out; >> >> info->color_formats |= DRM_COLOR_FORMAT_RGB444; >> @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, >> connector->tile_group = NULL; >> } >> } >> + >> +/** >> + * drm_edid_is_digital - is digital? >> + * @drm_edid: The EDID >> + * >> + * Return true if input is digital. >> + */ >> +bool drm_edid_is_digital(const struct drm_edid *drm_edid) >> +{ >> + return drm_edid && drm_edid->edid && >> + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; >> +} >> +EXPORT_SYMBOL(drm_edid_is_digital); >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 48e93f909ef6..882d2638708e 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, >> int drm_edid_connector_update(struct drm_connector *connector, >> const struct drm_edid *edid); >> int drm_edid_connector_add_modes(struct drm_connector *connector); >> +bool drm_edid_is_digital(const struct drm_edid *drm_edid); >> >> const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, >> int ext_id, int *ext_index); >> -- >> 2.39.2 >> -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital() @ 2023-09-04 10:43 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-09-04 10:43 UTC (permalink / raw) To: Alex Deucher; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Fri, 01 Sep 2023, Alex Deucher <alexdeucher@gmail.com> wrote: > On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula <jani.nikula@intel.com> wrote: >> >> Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to >> deserve a helper that also lets us abstract the raw EDID a bit better. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Thanks; I'm afraid this got merged already. > Seems to be a few additional users of this that could be converted: > > drivers/gpu/drm/i915/display/intel_sdvo.c: if (edid && > edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/i915/display/intel_sdvo.c: bool monitor_is_digital > = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/i915/display/intel_crt.c: bool is_digital = > edid->input & DRM_EDID_INPUT_DIGITAL; > drivers/gpu/drm/i915/display/intel_hdmi.c: if (edid && edid->input > & DRM_EDID_INPUT_DIGITAL) { The next patch takes care of these. > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) { > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/gma500/psb_intel_sdvo.c: bool > monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/gma500/psb_intel_sdvo.c: if (edid != NULL && > edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/gma500/cdv_intel_hdmi.c: if (edid->input & > DRM_EDID_INPUT_DIGITAL) { > drivers/gpu/drm/display/drm_dp_helper.c: edid->input & > DRM_EDID_INPUT_DIGITAL && > drivers/gpu/drm/nouveau/nouveau_connector.c: if > (nv_connector->edid->input & DRM_EDID_INPUT_DIGITAL) > drivers/gpu/drm/radeon/radeon_connectors.c: > !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/radeon/radeon_connectors.c: > !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: > !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c: > !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); drm_edid_is_digital() operates on struct drm_edid. The drivers would first need to be converted to use struct drm_edid instead of struct edid, and I'm not really taking that on. IMO adding helpers to operate on struct edid would be counter-productive. BR, Jani. > > > > >> --- >> drivers/gpu/drm/drm_edid.c | 17 +++++++++++++++-- >> include/drm/drm_edid.h | 1 + >> 2 files changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 340da8257b51..1dbb15439468 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -3110,7 +3110,7 @@ drm_monitor_supports_rb(const struct drm_edid *drm_edid) >> return ret; >> } >> >> - return ((drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL) != 0); >> + return drm_edid_is_digital(drm_edid); >> } >> >> static void >> @@ -6519,7 +6519,7 @@ static void update_display_info(struct drm_connector *connector, >> if (edid->revision < 3) >> goto out; >> >> - if (!(edid->input & DRM_EDID_INPUT_DIGITAL)) >> + if (!drm_edid_is_digital(drm_edid)) >> goto out; >> >> info->color_formats |= DRM_COLOR_FORMAT_RGB444; >> @@ -7335,3 +7335,16 @@ static void _drm_update_tile_info(struct drm_connector *connector, >> connector->tile_group = NULL; >> } >> } >> + >> +/** >> + * drm_edid_is_digital - is digital? >> + * @drm_edid: The EDID >> + * >> + * Return true if input is digital. >> + */ >> +bool drm_edid_is_digital(const struct drm_edid *drm_edid) >> +{ >> + return drm_edid && drm_edid->edid && >> + drm_edid->edid->input & DRM_EDID_INPUT_DIGITAL; >> +} >> +EXPORT_SYMBOL(drm_edid_is_digital); >> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> index 48e93f909ef6..882d2638708e 100644 >> --- a/include/drm/drm_edid.h >> +++ b/include/drm/drm_edid.h >> @@ -612,6 +612,7 @@ const struct drm_edid *drm_edid_read_switcheroo(struct drm_connector *connector, >> int drm_edid_connector_update(struct drm_connector *connector, >> const struct drm_edid *edid); >> int drm_edid_connector_add_modes(struct drm_connector *connector); >> +bool drm_edid_is_digital(const struct drm_edid *drm_edid); >> >> const u8 *drm_find_edid_extension(const struct drm_edid *drm_edid, >> int ext_id, int *ext_index); >> -- >> 2.39.2 >> -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH 2/6] drm/i915/display: use drm_edid_is_digital() 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-24 13:46 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Reduce the use of struct edid and drm_edid_raw(). Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- drivers/gpu/drm/i915/display/intel_hdmi.c | 9 ++++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c index f66340b4caf0..310670bb6c25 100644 --- a/drivers/gpu/drm/i915/display/intel_crt.c +++ b/drivers/gpu/drm/i915/display/intel_crt.c @@ -657,21 +657,18 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) drm_edid = intel_crt_get_edid(connector, i2c); if (drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; - /* * This may be a DVI-I connector with a shared DDC * link between analog and digital outputs, so we * have to check the EDID input spec of the attached device. */ - if (!is_digital) { + if (drm_edid_is_digital(drm_edid)) { drm_dbg_kms(&dev_priv->drm, - "CRT detected via DDC:0x50 [EDID]\n"); - ret = true; + "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); } else { drm_dbg_kms(&dev_priv->drm, - "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); + "CRT detected via DDC:0x50 [EDID]\n"); + ret = true; } } else { drm_dbg_kms(&dev_priv->drm, diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 9442bf43550e..aa9915098dda 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2452,7 +2452,6 @@ intel_hdmi_set_edid(struct drm_connector *connector) struct intel_hdmi *intel_hdmi = intel_attached_hdmi(to_intel_connector(connector)); intel_wakeref_t wakeref; const struct drm_edid *drm_edid; - const struct edid *edid; bool connected = false; struct i2c_adapter *i2c; @@ -2475,9 +2474,7 @@ intel_hdmi_set_edid(struct drm_connector *connector) to_intel_connector(connector)->detect_edid = drm_edid; - /* FIXME: Get rid of drm_edid_raw() */ - edid = drm_edid_raw(drm_edid); - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { + if (drm_edid_is_digital(drm_edid)) { intel_hdmi_dp_dual_mode_detect(connector); connected = true; @@ -2485,7 +2482,9 @@ intel_hdmi_set_edid(struct drm_connector *connector) intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, edid); + /* FIXME: Get rid of drm_edid_raw() */ + cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, + drm_edid_raw(drm_edid)); return connected; } diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index 7d25a64698e2..917771e19e38 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -2094,10 +2094,8 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) status = connector_status_unknown; if (drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - /* DDC bus is shared, match EDID to connector type */ - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) + if (drm_edid_is_digital(drm_edid)) status = connector_status_connected; else status = connector_status_disconnected; @@ -2111,8 +2109,7 @@ static bool intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo, const struct drm_edid *drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); + bool monitor_is_digital = drm_edid_is_digital(drm_edid); bool connector_is_digital = !!IS_DIGITAL(sdvo); DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n", -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 2/6] drm/i915/display: use drm_edid_is_digital() @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula Reduce the use of struct edid and drm_edid_raw(). Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- drivers/gpu/drm/i915/display/intel_hdmi.c | 9 ++++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c index f66340b4caf0..310670bb6c25 100644 --- a/drivers/gpu/drm/i915/display/intel_crt.c +++ b/drivers/gpu/drm/i915/display/intel_crt.c @@ -657,21 +657,18 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) drm_edid = intel_crt_get_edid(connector, i2c); if (drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; - /* * This may be a DVI-I connector with a shared DDC * link between analog and digital outputs, so we * have to check the EDID input spec of the attached device. */ - if (!is_digital) { + if (drm_edid_is_digital(drm_edid)) { drm_dbg_kms(&dev_priv->drm, - "CRT detected via DDC:0x50 [EDID]\n"); - ret = true; + "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); } else { drm_dbg_kms(&dev_priv->drm, - "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); + "CRT detected via DDC:0x50 [EDID]\n"); + ret = true; } } else { drm_dbg_kms(&dev_priv->drm, diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 9442bf43550e..aa9915098dda 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2452,7 +2452,6 @@ intel_hdmi_set_edid(struct drm_connector *connector) struct intel_hdmi *intel_hdmi = intel_attached_hdmi(to_intel_connector(connector)); intel_wakeref_t wakeref; const struct drm_edid *drm_edid; - const struct edid *edid; bool connected = false; struct i2c_adapter *i2c; @@ -2475,9 +2474,7 @@ intel_hdmi_set_edid(struct drm_connector *connector) to_intel_connector(connector)->detect_edid = drm_edid; - /* FIXME: Get rid of drm_edid_raw() */ - edid = drm_edid_raw(drm_edid); - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { + if (drm_edid_is_digital(drm_edid)) { intel_hdmi_dp_dual_mode_detect(connector); connected = true; @@ -2485,7 +2482,9 @@ intel_hdmi_set_edid(struct drm_connector *connector) intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, edid); + /* FIXME: Get rid of drm_edid_raw() */ + cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, + drm_edid_raw(drm_edid)); return connected; } diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index 7d25a64698e2..917771e19e38 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -2094,10 +2094,8 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) status = connector_status_unknown; if (drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - /* DDC bus is shared, match EDID to connector type */ - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) + if (drm_edid_is_digital(drm_edid)) status = connector_status_connected; else status = connector_status_disconnected; @@ -2111,8 +2109,7 @@ static bool intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo, const struct drm_edid *drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); + bool monitor_is_digital = drm_edid_is_digital(drm_edid); bool connector_is_digital = !!IS_DIGITAL(sdvo); DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n", -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 2/6] drm/i915/display: use drm_edid_is_digital() @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Reduce the use of struct edid and drm_edid_raw(). Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- drivers/gpu/drm/i915/display/intel_hdmi.c | 9 ++++----- drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c index f66340b4caf0..310670bb6c25 100644 --- a/drivers/gpu/drm/i915/display/intel_crt.c +++ b/drivers/gpu/drm/i915/display/intel_crt.c @@ -657,21 +657,18 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) drm_edid = intel_crt_get_edid(connector, i2c); if (drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; - /* * This may be a DVI-I connector with a shared DDC * link between analog and digital outputs, so we * have to check the EDID input spec of the attached device. */ - if (!is_digital) { + if (drm_edid_is_digital(drm_edid)) { drm_dbg_kms(&dev_priv->drm, - "CRT detected via DDC:0x50 [EDID]\n"); - ret = true; + "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); } else { drm_dbg_kms(&dev_priv->drm, - "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); + "CRT detected via DDC:0x50 [EDID]\n"); + ret = true; } } else { drm_dbg_kms(&dev_priv->drm, diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 9442bf43550e..aa9915098dda 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2452,7 +2452,6 @@ intel_hdmi_set_edid(struct drm_connector *connector) struct intel_hdmi *intel_hdmi = intel_attached_hdmi(to_intel_connector(connector)); intel_wakeref_t wakeref; const struct drm_edid *drm_edid; - const struct edid *edid; bool connected = false; struct i2c_adapter *i2c; @@ -2475,9 +2474,7 @@ intel_hdmi_set_edid(struct drm_connector *connector) to_intel_connector(connector)->detect_edid = drm_edid; - /* FIXME: Get rid of drm_edid_raw() */ - edid = drm_edid_raw(drm_edid); - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { + if (drm_edid_is_digital(drm_edid)) { intel_hdmi_dp_dual_mode_detect(connector); connected = true; @@ -2485,7 +2482,9 @@ intel_hdmi_set_edid(struct drm_connector *connector) intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, edid); + /* FIXME: Get rid of drm_edid_raw() */ + cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, + drm_edid_raw(drm_edid)); return connected; } diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index 7d25a64698e2..917771e19e38 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -2094,10 +2094,8 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) status = connector_status_unknown; if (drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - /* DDC bus is shared, match EDID to connector type */ - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) + if (drm_edid_is_digital(drm_edid)) status = connector_status_connected; else status = connector_status_disconnected; @@ -2111,8 +2109,7 @@ static bool intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo, const struct drm_edid *drm_edid) { - const struct edid *edid = drm_edid_raw(drm_edid); - bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); + bool monitor_is_digital = drm_edid_is_digital(drm_edid); bool connector_is_digital = !!IS_DIGITAL(sdvo); DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n", -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: use drm_edid_is_digital() 2023-08-24 13:46 ` Jani Nikula @ 2023-08-31 17:24 ` Ville Syrjälä -1 siblings, 0 replies; 77+ messages in thread From: Ville Syrjälä @ 2023-08-31 17:24 UTC (permalink / raw) To: Jani Nikula; +Cc: Hans Verkuil, intel-gfx, dri-devel, linux-media On Thu, Aug 24, 2023 at 04:46:03PM +0300, Jani Nikula wrote: > Reduce the use of struct edid and drm_edid_raw(). > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- > drivers/gpu/drm/i915/display/intel_hdmi.c | 9 ++++----- > drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- > 3 files changed, 10 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c > index f66340b4caf0..310670bb6c25 100644 > --- a/drivers/gpu/drm/i915/display/intel_crt.c > +++ b/drivers/gpu/drm/i915/display/intel_crt.c > @@ -657,21 +657,18 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) > drm_edid = intel_crt_get_edid(connector, i2c); > > if (drm_edid) { > - const struct edid *edid = drm_edid_raw(drm_edid); > - bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; > - > /* > * This may be a DVI-I connector with a shared DDC > * link between analog and digital outputs, so we > * have to check the EDID input spec of the attached device. > */ > - if (!is_digital) { > + if (drm_edid_is_digital(drm_edid)) { > drm_dbg_kms(&dev_priv->drm, > - "CRT detected via DDC:0x50 [EDID]\n"); > - ret = true; > + "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); > } else { > drm_dbg_kms(&dev_priv->drm, > - "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); > + "CRT detected via DDC:0x50 [EDID]\n"); > + ret = true; Inverting the check made the diff a bit confusing, but looks correct in the end. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > } > } else { > drm_dbg_kms(&dev_priv->drm, > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 9442bf43550e..aa9915098dda 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -2452,7 +2452,6 @@ intel_hdmi_set_edid(struct drm_connector *connector) > struct intel_hdmi *intel_hdmi = intel_attached_hdmi(to_intel_connector(connector)); > intel_wakeref_t wakeref; > const struct drm_edid *drm_edid; > - const struct edid *edid; > bool connected = false; > struct i2c_adapter *i2c; > > @@ -2475,9 +2474,7 @@ intel_hdmi_set_edid(struct drm_connector *connector) > > to_intel_connector(connector)->detect_edid = drm_edid; > > - /* FIXME: Get rid of drm_edid_raw() */ > - edid = drm_edid_raw(drm_edid); > - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { > + if (drm_edid_is_digital(drm_edid)) { > intel_hdmi_dp_dual_mode_detect(connector); > > connected = true; > @@ -2485,7 +2482,9 @@ intel_hdmi_set_edid(struct drm_connector *connector) > > intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); > > - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, edid); > + /* FIXME: Get rid of drm_edid_raw() */ > + cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, > + drm_edid_raw(drm_edid)); > > return connected; > } > diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c > index 7d25a64698e2..917771e19e38 100644 > --- a/drivers/gpu/drm/i915/display/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c > @@ -2094,10 +2094,8 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) > > status = connector_status_unknown; > if (drm_edid) { > - const struct edid *edid = drm_edid_raw(drm_edid); > - > /* DDC bus is shared, match EDID to connector type */ > - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) > + if (drm_edid_is_digital(drm_edid)) > status = connector_status_connected; > else > status = connector_status_disconnected; > @@ -2111,8 +2109,7 @@ static bool > intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo, > const struct drm_edid *drm_edid) > { > - const struct edid *edid = drm_edid_raw(drm_edid); > - bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > + bool monitor_is_digital = drm_edid_is_digital(drm_edid); > bool connector_is_digital = !!IS_DIGITAL(sdvo); > > DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n", > -- > 2.39.2 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: use drm_edid_is_digital() @ 2023-08-31 17:24 ` Ville Syrjälä 0 siblings, 0 replies; 77+ messages in thread From: Ville Syrjälä @ 2023-08-31 17:24 UTC (permalink / raw) To: Jani Nikula; +Cc: dri-devel, Hans Verkuil, intel-gfx, linux-media On Thu, Aug 24, 2023 at 04:46:03PM +0300, Jani Nikula wrote: > Reduce the use of struct edid and drm_edid_raw(). > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- > drivers/gpu/drm/i915/display/intel_hdmi.c | 9 ++++----- > drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- > 3 files changed, 10 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c > index f66340b4caf0..310670bb6c25 100644 > --- a/drivers/gpu/drm/i915/display/intel_crt.c > +++ b/drivers/gpu/drm/i915/display/intel_crt.c > @@ -657,21 +657,18 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector) > drm_edid = intel_crt_get_edid(connector, i2c); > > if (drm_edid) { > - const struct edid *edid = drm_edid_raw(drm_edid); > - bool is_digital = edid->input & DRM_EDID_INPUT_DIGITAL; > - > /* > * This may be a DVI-I connector with a shared DDC > * link between analog and digital outputs, so we > * have to check the EDID input spec of the attached device. > */ > - if (!is_digital) { > + if (drm_edid_is_digital(drm_edid)) { > drm_dbg_kms(&dev_priv->drm, > - "CRT detected via DDC:0x50 [EDID]\n"); > - ret = true; > + "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); > } else { > drm_dbg_kms(&dev_priv->drm, > - "CRT not detected via DDC:0x50 [EDID reports a digital panel]\n"); > + "CRT detected via DDC:0x50 [EDID]\n"); > + ret = true; Inverting the check made the diff a bit confusing, but looks correct in the end. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > } > } else { > drm_dbg_kms(&dev_priv->drm, > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 9442bf43550e..aa9915098dda 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -2452,7 +2452,6 @@ intel_hdmi_set_edid(struct drm_connector *connector) > struct intel_hdmi *intel_hdmi = intel_attached_hdmi(to_intel_connector(connector)); > intel_wakeref_t wakeref; > const struct drm_edid *drm_edid; > - const struct edid *edid; > bool connected = false; > struct i2c_adapter *i2c; > > @@ -2475,9 +2474,7 @@ intel_hdmi_set_edid(struct drm_connector *connector) > > to_intel_connector(connector)->detect_edid = drm_edid; > > - /* FIXME: Get rid of drm_edid_raw() */ > - edid = drm_edid_raw(drm_edid); > - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) { > + if (drm_edid_is_digital(drm_edid)) { > intel_hdmi_dp_dual_mode_detect(connector); > > connected = true; > @@ -2485,7 +2482,9 @@ intel_hdmi_set_edid(struct drm_connector *connector) > > intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); > > - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, edid); > + /* FIXME: Get rid of drm_edid_raw() */ > + cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, > + drm_edid_raw(drm_edid)); > > return connected; > } > diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c > index 7d25a64698e2..917771e19e38 100644 > --- a/drivers/gpu/drm/i915/display/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c > @@ -2094,10 +2094,8 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) > > status = connector_status_unknown; > if (drm_edid) { > - const struct edid *edid = drm_edid_raw(drm_edid); > - > /* DDC bus is shared, match EDID to connector type */ > - if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) > + if (drm_edid_is_digital(drm_edid)) > status = connector_status_connected; > else > status = connector_status_disconnected; > @@ -2111,8 +2109,7 @@ static bool > intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo, > const struct drm_edid *drm_edid) > { > - const struct edid *edid = drm_edid_raw(drm_edid); > - bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); > + bool monitor_is_digital = drm_edid_is_digital(drm_edid); > bool connector_is_digital = !!IS_DIGITAL(sdvo); > > DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n", > -- > 2.39.2 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH 3/6] drm/edid: parse source physical address 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-24 13:46 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media CEC needs the source physical address. Parsing it is trivial with the existing EDID CEA DB infrastructure. Default to CEC_PHYS_ADDR_INVALID (0xffff) instead of 0 to cater for easier CEC usage. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 5 +++++ include/drm/drm_connector.h | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1dbb15439468..39dd3f694544 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -29,6 +29,7 @@ */ #include <linux/bitfield.h> +#include <linux/cec.h> #include <linux/hdmi.h> #include <linux/i2c.h> #include <linux/kernel.h> @@ -6192,6 +6193,8 @@ drm_parse_hdmi_vsdb_video(struct drm_connector *connector, const u8 *db) info->is_hdmi = true; + info->source_physical_address = (db[4] << 8) | db[5]; + if (len >= 6) info->dvi_dual = db[6] & 1; if (len >= 7) @@ -6470,6 +6473,8 @@ static void drm_reset_display_info(struct drm_connector *connector) info->vics_len = 0; info->quirks = 0; + + info->source_physical_address = CEC_PHYS_ADDR_INVALID; } static void update_displayid_info(struct drm_connector *connector, diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index d300fde6c1a4..40a5e7acf2fa 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -816,6 +816,14 @@ struct drm_display_info { * @quirks: EDID based quirks. Internal to EDID parsing. */ u32 quirks; + + /** + * @source_physical_address: Source Physical Address from HDMI + * Vendor-Specific Data Block, for CEC usage. + * + * Defaults to CEC_PHYS_ADDR_INVALID (0xffff). + */ + u16 source_physical_address; }; int drm_display_info_set_bus_formats(struct drm_display_info *info, -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 3/6] drm/edid: parse source physical address @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula CEC needs the source physical address. Parsing it is trivial with the existing EDID CEA DB infrastructure. Default to CEC_PHYS_ADDR_INVALID (0xffff) instead of 0 to cater for easier CEC usage. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 5 +++++ include/drm/drm_connector.h | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1dbb15439468..39dd3f694544 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -29,6 +29,7 @@ */ #include <linux/bitfield.h> +#include <linux/cec.h> #include <linux/hdmi.h> #include <linux/i2c.h> #include <linux/kernel.h> @@ -6192,6 +6193,8 @@ drm_parse_hdmi_vsdb_video(struct drm_connector *connector, const u8 *db) info->is_hdmi = true; + info->source_physical_address = (db[4] << 8) | db[5]; + if (len >= 6) info->dvi_dual = db[6] & 1; if (len >= 7) @@ -6470,6 +6473,8 @@ static void drm_reset_display_info(struct drm_connector *connector) info->vics_len = 0; info->quirks = 0; + + info->source_physical_address = CEC_PHYS_ADDR_INVALID; } static void update_displayid_info(struct drm_connector *connector, diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index d300fde6c1a4..40a5e7acf2fa 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -816,6 +816,14 @@ struct drm_display_info { * @quirks: EDID based quirks. Internal to EDID parsing. */ u32 quirks; + + /** + * @source_physical_address: Source Physical Address from HDMI + * Vendor-Specific Data Block, for CEC usage. + * + * Defaults to CEC_PHYS_ADDR_INVALID (0xffff). + */ + u16 source_physical_address; }; int drm_display_info_set_bus_formats(struct drm_display_info *info, -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 3/6] drm/edid: parse source physical address @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media CEC needs the source physical address. Parsing it is trivial with the existing EDID CEA DB infrastructure. Default to CEC_PHYS_ADDR_INVALID (0xffff) instead of 0 to cater for easier CEC usage. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/drm_edid.c | 5 +++++ include/drm/drm_connector.h | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1dbb15439468..39dd3f694544 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -29,6 +29,7 @@ */ #include <linux/bitfield.h> +#include <linux/cec.h> #include <linux/hdmi.h> #include <linux/i2c.h> #include <linux/kernel.h> @@ -6192,6 +6193,8 @@ drm_parse_hdmi_vsdb_video(struct drm_connector *connector, const u8 *db) info->is_hdmi = true; + info->source_physical_address = (db[4] << 8) | db[5]; + if (len >= 6) info->dvi_dual = db[6] & 1; if (len >= 7) @@ -6470,6 +6473,8 @@ static void drm_reset_display_info(struct drm_connector *connector) info->vics_len = 0; info->quirks = 0; + + info->source_physical_address = CEC_PHYS_ADDR_INVALID; } static void update_displayid_info(struct drm_connector *connector, diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index d300fde6c1a4..40a5e7acf2fa 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -816,6 +816,14 @@ struct drm_display_info { * @quirks: EDID based quirks. Internal to EDID parsing. */ u32 quirks; + + /** + * @source_physical_address: Source Physical Address from HDMI + * Vendor-Specific Data Block, for CEC usage. + * + * Defaults to CEC_PHYS_ADDR_INVALID (0xffff). + */ + u16 source_physical_address; }; int drm_display_info_set_bus_formats(struct drm_display_info *info, -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 3/6] drm/edid: parse source physical address 2023-08-24 13:46 ` Jani Nikula @ 2023-08-30 9:54 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 9:54 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > CEC needs the source physical address. Parsing it is trivial with the > existing EDID CEA DB infrastructure. > > Default to CEC_PHYS_ADDR_INVALID (0xffff) instead of 0 to cater for > easier CEC usage. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > --- > drivers/gpu/drm/drm_edid.c | 5 +++++ > include/drm/drm_connector.h | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 1dbb15439468..39dd3f694544 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -29,6 +29,7 @@ > */ > > #include <linux/bitfield.h> > +#include <linux/cec.h> > #include <linux/hdmi.h> > #include <linux/i2c.h> > #include <linux/kernel.h> > @@ -6192,6 +6193,8 @@ drm_parse_hdmi_vsdb_video(struct drm_connector *connector, const u8 *db) > > info->is_hdmi = true; > > + info->source_physical_address = (db[4] << 8) | db[5]; > + > if (len >= 6) > info->dvi_dual = db[6] & 1; > if (len >= 7) > @@ -6470,6 +6473,8 @@ static void drm_reset_display_info(struct drm_connector *connector) > info->vics_len = 0; > > info->quirks = 0; > + > + info->source_physical_address = CEC_PHYS_ADDR_INVALID; > } > > static void update_displayid_info(struct drm_connector *connector, > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index d300fde6c1a4..40a5e7acf2fa 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -816,6 +816,14 @@ struct drm_display_info { > * @quirks: EDID based quirks. Internal to EDID parsing. > */ > u32 quirks; > + > + /** > + * @source_physical_address: Source Physical Address from HDMI > + * Vendor-Specific Data Block, for CEC usage. > + * > + * Defaults to CEC_PHYS_ADDR_INVALID (0xffff). > + */ > + u16 source_physical_address; > }; > > int drm_display_info_set_bus_formats(struct drm_display_info *info, ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 3/6] drm/edid: parse source physical address @ 2023-08-30 9:54 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 9:54 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > CEC needs the source physical address. Parsing it is trivial with the > existing EDID CEA DB infrastructure. > > Default to CEC_PHYS_ADDR_INVALID (0xffff) instead of 0 to cater for > easier CEC usage. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > --- > drivers/gpu/drm/drm_edid.c | 5 +++++ > include/drm/drm_connector.h | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 1dbb15439468..39dd3f694544 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -29,6 +29,7 @@ > */ > > #include <linux/bitfield.h> > +#include <linux/cec.h> > #include <linux/hdmi.h> > #include <linux/i2c.h> > #include <linux/kernel.h> > @@ -6192,6 +6193,8 @@ drm_parse_hdmi_vsdb_video(struct drm_connector *connector, const u8 *db) > > info->is_hdmi = true; > > + info->source_physical_address = (db[4] << 8) | db[5]; > + > if (len >= 6) > info->dvi_dual = db[6] & 1; > if (len >= 7) > @@ -6470,6 +6473,8 @@ static void drm_reset_display_info(struct drm_connector *connector) > info->vics_len = 0; > > info->quirks = 0; > + > + info->source_physical_address = CEC_PHYS_ADDR_INVALID; > } > > static void update_displayid_info(struct drm_connector *connector, > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index d300fde6c1a4..40a5e7acf2fa 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -816,6 +816,14 @@ struct drm_display_info { > * @quirks: EDID based quirks. Internal to EDID parsing. > */ > u32 quirks; > + > + /** > + * @source_physical_address: Source Physical Address from HDMI > + * Vendor-Specific Data Block, for CEC usage. > + * > + * Defaults to CEC_PHYS_ADDR_INVALID (0xffff). > + */ > + u16 source_physical_address; > }; > > int drm_display_info_set_bus_formats(struct drm_display_info *info, ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-24 13:46 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forward. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- include/drm/display/drm_dp_helper.h | 6 ++++++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c index ae39dc794190..da7a7d357446 100644 --- a/drivers/gpu/drm/display/drm_dp_cec.c +++ b/drivers/gpu/drm/display/drm_dp_cec.c @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) * were unchanged and just update the CEC physical address. Otherwise * unregister the old CEC adapter and create a new one. */ -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) { struct drm_connector *connector = aux->cec.connector; u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) if (aux->cec.adap->capabilities == cec_caps && aux->cec.adap->available_log_addrs == num_las) { /* Unchanged, so just set the phys addr */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(adap, source_physical_address, false); goto unlock; } /* @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) * from drm_dp_cec_register_connector() edid == NULL, so in * that case the phys addr is just invalidated. */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(adap, source_physical_address, false); } unlock: mutex_unlock(&aux->cec.lock); } +EXPORT_SYMBOL(drm_dp_cec_attach); + +/* + * Note: Prefer calling drm_dp_cec_attach() with + * connector->display_info.source_physical_address if possible. + */ +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +{ + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; + + if (edid && edid->extensions) + pa = cec_get_edid_phys_addr((const u8 *)edid, + EDID_LENGTH * (edid->extensions + 1), NULL); + + drm_dp_cec_attach(aux, source_physical_address); +} EXPORT_SYMBOL(drm_dp_cec_set_edid); /* diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 86f24a759268..3369104e2d25 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); void drm_dp_cec_register_connector(struct drm_dp_aux *aux, struct drm_connector *connector); void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); #else @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) { } +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, + u16 source_physical_address) +{ +} + static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forward. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- include/drm/display/drm_dp_helper.h | 6 ++++++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c index ae39dc794190..da7a7d357446 100644 --- a/drivers/gpu/drm/display/drm_dp_cec.c +++ b/drivers/gpu/drm/display/drm_dp_cec.c @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) * were unchanged and just update the CEC physical address. Otherwise * unregister the old CEC adapter and create a new one. */ -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) { struct drm_connector *connector = aux->cec.connector; u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) if (aux->cec.adap->capabilities == cec_caps && aux->cec.adap->available_log_addrs == num_las) { /* Unchanged, so just set the phys addr */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(adap, source_physical_address, false); goto unlock; } /* @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) * from drm_dp_cec_register_connector() edid == NULL, so in * that case the phys addr is just invalidated. */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(adap, source_physical_address, false); } unlock: mutex_unlock(&aux->cec.lock); } +EXPORT_SYMBOL(drm_dp_cec_attach); + +/* + * Note: Prefer calling drm_dp_cec_attach() with + * connector->display_info.source_physical_address if possible. + */ +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +{ + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; + + if (edid && edid->extensions) + pa = cec_get_edid_phys_addr((const u8 *)edid, + EDID_LENGTH * (edid->extensions + 1), NULL); + + drm_dp_cec_attach(aux, source_physical_address); +} EXPORT_SYMBOL(drm_dp_cec_set_edid); /* diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 86f24a759268..3369104e2d25 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); void drm_dp_cec_register_connector(struct drm_dp_aux *aux, struct drm_connector *connector); void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); #else @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) { } +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, + u16 source_physical_address) +{ +} + static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forward. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- include/drm/display/drm_dp_helper.h | 6 ++++++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c index ae39dc794190..da7a7d357446 100644 --- a/drivers/gpu/drm/display/drm_dp_cec.c +++ b/drivers/gpu/drm/display/drm_dp_cec.c @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) * were unchanged and just update the CEC physical address. Otherwise * unregister the old CEC adapter and create a new one. */ -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) { struct drm_connector *connector = aux->cec.connector; u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) if (aux->cec.adap->capabilities == cec_caps && aux->cec.adap->available_log_addrs == num_las) { /* Unchanged, so just set the phys addr */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(adap, source_physical_address, false); goto unlock; } /* @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) * from drm_dp_cec_register_connector() edid == NULL, so in * that case the phys addr is just invalidated. */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(adap, source_physical_address, false); } unlock: mutex_unlock(&aux->cec.lock); } +EXPORT_SYMBOL(drm_dp_cec_attach); + +/* + * Note: Prefer calling drm_dp_cec_attach() with + * connector->display_info.source_physical_address if possible. + */ +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +{ + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; + + if (edid && edid->extensions) + pa = cec_get_edid_phys_addr((const u8 *)edid, + EDID_LENGTH * (edid->extensions + 1), NULL); + + drm_dp_cec_attach(aux, source_physical_address); +} EXPORT_SYMBOL(drm_dp_cec_set_edid); /* diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 86f24a759268..3369104e2d25 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); void drm_dp_cec_register_connector(struct drm_dp_aux *aux, struct drm_connector *connector); void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); #else @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) { } +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, + u16 source_physical_address) +{ +} + static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-24 13:46 ` Jani Nikula @ 2023-08-25 11:23 ` kernel test robot -1 siblings, 0 replies; 77+ messages in thread From: kernel test robot @ 2023-08-25 11:23 UTC (permalink / raw) To: Jani Nikula, dri-devel Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media, oe-kbuild-all Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm/drm-next next-20230825] [cannot apply to drm-intel/for-linux-next-fixes drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-edid-add-drm_edid_is_digital/20230824-220926 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/f8ed9b38fd2ebcd8344a1889a6c0f288969454ea.1692884619.git.jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid config: nios2-randconfig-r036-20230824 (https://download.01.org/0day-ci/archive/20230825/202308251937.G5ETiCfF-lkp@intel.com/config) compiler: nios2-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251937.G5ETiCfF-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308251937.G5ETiCfF-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_attach': >> drivers/gpu/drm/display/drm_dp_cec.c:342:41: error: 'adap' undeclared (first use in this function) 342 | cec_s_phys_addr(adap, source_physical_address, false); | ^~~~ drivers/gpu/drm/display/drm_dp_cec.c:342:41: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_set_edid': >> drivers/gpu/drm/display/drm_dp_cec.c:388:25: error: invalid use of undefined type 'const struct edid' 388 | if (edid && edid->extensions) | ^~ >> drivers/gpu/drm/display/drm_dp_cec.c:389:17: error: 'pa' undeclared (first use in this function) 389 | pa = cec_get_edid_phys_addr((const u8 *)edid, | ^~ >> drivers/gpu/drm/display/drm_dp_cec.c:390:45: error: 'EDID_LENGTH' undeclared (first use in this function) 390 | EDID_LENGTH * (edid->extensions + 1), NULL); | ^~~~~~~~~~~ drivers/gpu/drm/display/drm_dp_cec.c:390:64: error: invalid use of undefined type 'const struct edid' 390 | EDID_LENGTH * (edid->extensions + 1), NULL); | ^~ vim +/adap +342 drivers/gpu/drm/display/drm_dp_cec.c 293 294 /* 295 * A new EDID is set. If there is no CEC adapter, then create one. If 296 * there was a CEC adapter, then check if the CEC adapter properties 297 * were unchanged and just update the CEC physical address. Otherwise 298 * unregister the old CEC adapter and create a new one. 299 */ 300 void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) 301 { 302 struct drm_connector *connector = aux->cec.connector; 303 u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | 304 CEC_CAP_CONNECTOR_INFO; 305 struct cec_connector_info conn_info; 306 unsigned int num_las = 1; 307 u8 cap; 308 309 /* No transfer function was set, so not a DP connector */ 310 if (!aux->transfer) 311 return; 312 313 #ifndef CONFIG_MEDIA_CEC_RC 314 /* 315 * CEC_CAP_RC is part of CEC_CAP_DEFAULTS, but it is stripped by 316 * cec_allocate_adapter() if CONFIG_MEDIA_CEC_RC is undefined. 317 * 318 * Do this here as well to ensure the tests against cec_caps are 319 * correct. 320 */ 321 cec_caps &= ~CEC_CAP_RC; 322 #endif 323 cancel_delayed_work_sync(&aux->cec.unregister_work); 324 325 mutex_lock(&aux->cec.lock); 326 if (!drm_dp_cec_cap(aux, &cap)) { 327 /* CEC is not supported, unregister any existing adapter */ 328 cec_unregister_adapter(aux->cec.adap); 329 aux->cec.adap = NULL; 330 goto unlock; 331 } 332 333 if (cap & DP_CEC_SNOOPING_CAPABLE) 334 cec_caps |= CEC_CAP_MONITOR_ALL; 335 if (cap & DP_CEC_MULTIPLE_LA_CAPABLE) 336 num_las = CEC_MAX_LOG_ADDRS; 337 338 if (aux->cec.adap) { 339 if (aux->cec.adap->capabilities == cec_caps && 340 aux->cec.adap->available_log_addrs == num_las) { 341 /* Unchanged, so just set the phys addr */ > 342 cec_s_phys_addr(adap, source_physical_address, false); 343 goto unlock; 344 } 345 /* 346 * The capabilities changed, so unregister the old 347 * adapter first. 348 */ 349 cec_unregister_adapter(aux->cec.adap); 350 } 351 352 /* Create a new adapter */ 353 aux->cec.adap = cec_allocate_adapter(&drm_dp_cec_adap_ops, 354 aux, connector->name, cec_caps, 355 num_las); 356 if (IS_ERR(aux->cec.adap)) { 357 aux->cec.adap = NULL; 358 goto unlock; 359 } 360 361 cec_fill_conn_info_from_drm(&conn_info, connector); 362 cec_s_conn_info(aux->cec.adap, &conn_info); 363 364 if (cec_register_adapter(aux->cec.adap, connector->dev->dev)) { 365 cec_delete_adapter(aux->cec.adap); 366 aux->cec.adap = NULL; 367 } else { 368 /* 369 * Update the phys addr for the new CEC adapter. When called 370 * from drm_dp_cec_register_connector() edid == NULL, so in 371 * that case the phys addr is just invalidated. 372 */ 373 cec_s_phys_addr(adap, source_physical_address, false); 374 } 375 unlock: 376 mutex_unlock(&aux->cec.lock); 377 } 378 EXPORT_SYMBOL(drm_dp_cec_attach); 379 380 /* 381 * Note: Prefer calling drm_dp_cec_attach() with 382 * connector->display_info.source_physical_address if possible. 383 */ 384 void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) 385 { 386 u16 source_physical_address = CEC_PHYS_ADDR_INVALID; 387 > 388 if (edid && edid->extensions) > 389 pa = cec_get_edid_phys_addr((const u8 *)edid, > 390 EDID_LENGTH * (edid->extensions + 1), NULL); 391 392 drm_dp_cec_attach(aux, source_physical_address); 393 } 394 EXPORT_SYMBOL(drm_dp_cec_set_edid); 395 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-25 11:23 ` kernel test robot 0 siblings, 0 replies; 77+ messages in thread From: kernel test robot @ 2023-08-25 11:23 UTC (permalink / raw) To: Jani Nikula, dri-devel Cc: oe-kbuild-all, Hans Verkuil, Jani Nikula, intel-gfx, linux-media Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm/drm-next next-20230825] [cannot apply to drm-intel/for-linux-next-fixes drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-edid-add-drm_edid_is_digital/20230824-220926 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/f8ed9b38fd2ebcd8344a1889a6c0f288969454ea.1692884619.git.jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid config: nios2-randconfig-r036-20230824 (https://download.01.org/0day-ci/archive/20230825/202308251937.G5ETiCfF-lkp@intel.com/config) compiler: nios2-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251937.G5ETiCfF-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308251937.G5ETiCfF-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_attach': >> drivers/gpu/drm/display/drm_dp_cec.c:342:41: error: 'adap' undeclared (first use in this function) 342 | cec_s_phys_addr(adap, source_physical_address, false); | ^~~~ drivers/gpu/drm/display/drm_dp_cec.c:342:41: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_set_edid': >> drivers/gpu/drm/display/drm_dp_cec.c:388:25: error: invalid use of undefined type 'const struct edid' 388 | if (edid && edid->extensions) | ^~ >> drivers/gpu/drm/display/drm_dp_cec.c:389:17: error: 'pa' undeclared (first use in this function) 389 | pa = cec_get_edid_phys_addr((const u8 *)edid, | ^~ >> drivers/gpu/drm/display/drm_dp_cec.c:390:45: error: 'EDID_LENGTH' undeclared (first use in this function) 390 | EDID_LENGTH * (edid->extensions + 1), NULL); | ^~~~~~~~~~~ drivers/gpu/drm/display/drm_dp_cec.c:390:64: error: invalid use of undefined type 'const struct edid' 390 | EDID_LENGTH * (edid->extensions + 1), NULL); | ^~ vim +/adap +342 drivers/gpu/drm/display/drm_dp_cec.c 293 294 /* 295 * A new EDID is set. If there is no CEC adapter, then create one. If 296 * there was a CEC adapter, then check if the CEC adapter properties 297 * were unchanged and just update the CEC physical address. Otherwise 298 * unregister the old CEC adapter and create a new one. 299 */ 300 void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) 301 { 302 struct drm_connector *connector = aux->cec.connector; 303 u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | 304 CEC_CAP_CONNECTOR_INFO; 305 struct cec_connector_info conn_info; 306 unsigned int num_las = 1; 307 u8 cap; 308 309 /* No transfer function was set, so not a DP connector */ 310 if (!aux->transfer) 311 return; 312 313 #ifndef CONFIG_MEDIA_CEC_RC 314 /* 315 * CEC_CAP_RC is part of CEC_CAP_DEFAULTS, but it is stripped by 316 * cec_allocate_adapter() if CONFIG_MEDIA_CEC_RC is undefined. 317 * 318 * Do this here as well to ensure the tests against cec_caps are 319 * correct. 320 */ 321 cec_caps &= ~CEC_CAP_RC; 322 #endif 323 cancel_delayed_work_sync(&aux->cec.unregister_work); 324 325 mutex_lock(&aux->cec.lock); 326 if (!drm_dp_cec_cap(aux, &cap)) { 327 /* CEC is not supported, unregister any existing adapter */ 328 cec_unregister_adapter(aux->cec.adap); 329 aux->cec.adap = NULL; 330 goto unlock; 331 } 332 333 if (cap & DP_CEC_SNOOPING_CAPABLE) 334 cec_caps |= CEC_CAP_MONITOR_ALL; 335 if (cap & DP_CEC_MULTIPLE_LA_CAPABLE) 336 num_las = CEC_MAX_LOG_ADDRS; 337 338 if (aux->cec.adap) { 339 if (aux->cec.adap->capabilities == cec_caps && 340 aux->cec.adap->available_log_addrs == num_las) { 341 /* Unchanged, so just set the phys addr */ > 342 cec_s_phys_addr(adap, source_physical_address, false); 343 goto unlock; 344 } 345 /* 346 * The capabilities changed, so unregister the old 347 * adapter first. 348 */ 349 cec_unregister_adapter(aux->cec.adap); 350 } 351 352 /* Create a new adapter */ 353 aux->cec.adap = cec_allocate_adapter(&drm_dp_cec_adap_ops, 354 aux, connector->name, cec_caps, 355 num_las); 356 if (IS_ERR(aux->cec.adap)) { 357 aux->cec.adap = NULL; 358 goto unlock; 359 } 360 361 cec_fill_conn_info_from_drm(&conn_info, connector); 362 cec_s_conn_info(aux->cec.adap, &conn_info); 363 364 if (cec_register_adapter(aux->cec.adap, connector->dev->dev)) { 365 cec_delete_adapter(aux->cec.adap); 366 aux->cec.adap = NULL; 367 } else { 368 /* 369 * Update the phys addr for the new CEC adapter. When called 370 * from drm_dp_cec_register_connector() edid == NULL, so in 371 * that case the phys addr is just invalidated. 372 */ 373 cec_s_phys_addr(adap, source_physical_address, false); 374 } 375 unlock: 376 mutex_unlock(&aux->cec.lock); 377 } 378 EXPORT_SYMBOL(drm_dp_cec_attach); 379 380 /* 381 * Note: Prefer calling drm_dp_cec_attach() with 382 * connector->display_info.source_physical_address if possible. 383 */ 384 void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) 385 { 386 u16 source_physical_address = CEC_PHYS_ADDR_INVALID; 387 > 388 if (edid && edid->extensions) > 389 pa = cec_get_edid_phys_addr((const u8 *)edid, > 390 EDID_LENGTH * (edid->extensions + 1), NULL); 391 392 drm_dp_cec_attach(aux, source_physical_address); 393 } 394 EXPORT_SYMBOL(drm_dp_cec_set_edid); 395 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-24 13:46 ` Jani Nikula @ 2023-08-25 11:23 ` kernel test robot -1 siblings, 0 replies; 77+ messages in thread From: kernel test robot @ 2023-08-25 11:23 UTC (permalink / raw) To: Jani Nikula, dri-devel Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media, oe-kbuild-all Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm/drm-next next-20230825] [cannot apply to drm-intel/for-linux-next-fixes drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-edid-add-drm_edid_is_digital/20230824-220926 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/f8ed9b38fd2ebcd8344a1889a6c0f288969454ea.1692884619.git.jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid config: i386-buildonly-randconfig-001-20230824 (https://download.01.org/0day-ci/archive/20230825/202308251944.9tpk0wma-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251944.9tpk0wma-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308251944.9tpk0wma-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_attach': drivers/gpu/drm/display/drm_dp_cec.c:342:20: error: 'adap' undeclared (first use in this function) 342 | cec_s_phys_addr(adap, source_physical_address, false); | ^~~~ drivers/gpu/drm/display/drm_dp_cec.c:342:20: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_set_edid': >> drivers/gpu/drm/display/drm_dp_cec.c:388:18: error: dereferencing pointer to incomplete type 'const struct edid' 388 | if (edid && edid->extensions) | ^~ drivers/gpu/drm/display/drm_dp_cec.c:389:3: error: 'pa' undeclared (first use in this function) 389 | pa = cec_get_edid_phys_addr((const u8 *)edid, | ^~ drivers/gpu/drm/display/drm_dp_cec.c:390:10: error: 'EDID_LENGTH' undeclared (first use in this function) 390 | EDID_LENGTH * (edid->extensions + 1), NULL); | ^~~~~~~~~~~ vim +388 drivers/gpu/drm/display/drm_dp_cec.c 379 380 /* 381 * Note: Prefer calling drm_dp_cec_attach() with 382 * connector->display_info.source_physical_address if possible. 383 */ 384 void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) 385 { 386 u16 source_physical_address = CEC_PHYS_ADDR_INVALID; 387 > 388 if (edid && edid->extensions) 389 pa = cec_get_edid_phys_addr((const u8 *)edid, 390 EDID_LENGTH * (edid->extensions + 1), NULL); 391 392 drm_dp_cec_attach(aux, source_physical_address); 393 } 394 EXPORT_SYMBOL(drm_dp_cec_set_edid); 395 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-25 11:23 ` kernel test robot 0 siblings, 0 replies; 77+ messages in thread From: kernel test robot @ 2023-08-25 11:23 UTC (permalink / raw) To: Jani Nikula, dri-devel Cc: oe-kbuild-all, Hans Verkuil, Jani Nikula, intel-gfx, linux-media Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm/drm-next next-20230825] [cannot apply to drm-intel/for-linux-next-fixes drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-edid-add-drm_edid_is_digital/20230824-220926 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/f8ed9b38fd2ebcd8344a1889a6c0f288969454ea.1692884619.git.jani.nikula%40intel.com patch subject: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid config: i386-buildonly-randconfig-001-20230824 (https://download.01.org/0day-ci/archive/20230825/202308251944.9tpk0wma-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251944.9tpk0wma-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202308251944.9tpk0wma-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_attach': drivers/gpu/drm/display/drm_dp_cec.c:342:20: error: 'adap' undeclared (first use in this function) 342 | cec_s_phys_addr(adap, source_physical_address, false); | ^~~~ drivers/gpu/drm/display/drm_dp_cec.c:342:20: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/display/drm_dp_cec.c: In function 'drm_dp_cec_set_edid': >> drivers/gpu/drm/display/drm_dp_cec.c:388:18: error: dereferencing pointer to incomplete type 'const struct edid' 388 | if (edid && edid->extensions) | ^~ drivers/gpu/drm/display/drm_dp_cec.c:389:3: error: 'pa' undeclared (first use in this function) 389 | pa = cec_get_edid_phys_addr((const u8 *)edid, | ^~ drivers/gpu/drm/display/drm_dp_cec.c:390:10: error: 'EDID_LENGTH' undeclared (first use in this function) 390 | EDID_LENGTH * (edid->extensions + 1), NULL); | ^~~~~~~~~~~ vim +388 drivers/gpu/drm/display/drm_dp_cec.c 379 380 /* 381 * Note: Prefer calling drm_dp_cec_attach() with 382 * connector->display_info.source_physical_address if possible. 383 */ 384 void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) 385 { 386 u16 source_physical_address = CEC_PHYS_ADDR_INVALID; 387 > 388 if (edid && edid->extensions) 389 pa = cec_get_edid_phys_addr((const u8 *)edid, 390 EDID_LENGTH * (edid->extensions + 1), NULL); 391 392 drm_dp_cec_attach(aux, source_physical_address); 393 } 394 EXPORT_SYMBOL(drm_dp_cec_set_edid); 395 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-25 13:01 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-25 13:01 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: Hans Verkuil, intel-gfx, linux-media Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forward. v2: Fix the embarrashing build failures Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/display/drm_dp_cec.c | 23 ++++++++++++++++++++--- include/drm/display/drm_dp_helper.h | 6 ++++++ 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c index ae39dc794190..007ceb281d00 100644 --- a/drivers/gpu/drm/display/drm_dp_cec.c +++ b/drivers/gpu/drm/display/drm_dp_cec.c @@ -14,6 +14,7 @@ #include <drm/display/drm_dp_helper.h> #include <drm/drm_connector.h> #include <drm/drm_device.h> +#include <drm/drm_edid.h> /* * Unfortunately it turns out that we have a chicken-and-egg situation @@ -297,7 +298,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) * were unchanged and just update the CEC physical address. Otherwise * unregister the old CEC adapter and create a new one. */ -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) { struct drm_connector *connector = aux->cec.connector; u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | @@ -339,7 +340,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) if (aux->cec.adap->capabilities == cec_caps && aux->cec.adap->available_log_addrs == num_las) { /* Unchanged, so just set the phys addr */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); goto unlock; } /* @@ -370,11 +371,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) * from drm_dp_cec_register_connector() edid == NULL, so in * that case the phys addr is just invalidated. */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); } unlock: mutex_unlock(&aux->cec.lock); } +EXPORT_SYMBOL(drm_dp_cec_attach); + +/* + * Note: Prefer calling drm_dp_cec_attach() with + * connector->display_info.source_physical_address if possible. + */ +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +{ + u16 pa = CEC_PHYS_ADDR_INVALID; + + if (edid && edid->extensions) + pa = cec_get_edid_phys_addr((const u8 *)edid, + EDID_LENGTH * (edid->extensions + 1), NULL); + + drm_dp_cec_attach(aux, pa); +} EXPORT_SYMBOL(drm_dp_cec_set_edid); /* diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 86f24a759268..3369104e2d25 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); void drm_dp_cec_register_connector(struct drm_dp_aux *aux, struct drm_connector *connector); void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); #else @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) { } +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, + u16 source_physical_address) +{ +} + static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-25 13:01 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-25 13:01 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forward. v2: Fix the embarrashing build failures Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/display/drm_dp_cec.c | 23 ++++++++++++++++++++--- include/drm/display/drm_dp_helper.h | 6 ++++++ 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c index ae39dc794190..007ceb281d00 100644 --- a/drivers/gpu/drm/display/drm_dp_cec.c +++ b/drivers/gpu/drm/display/drm_dp_cec.c @@ -14,6 +14,7 @@ #include <drm/display/drm_dp_helper.h> #include <drm/drm_connector.h> #include <drm/drm_device.h> +#include <drm/drm_edid.h> /* * Unfortunately it turns out that we have a chicken-and-egg situation @@ -297,7 +298,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) * were unchanged and just update the CEC physical address. Otherwise * unregister the old CEC adapter and create a new one. */ -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) { struct drm_connector *connector = aux->cec.connector; u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | @@ -339,7 +340,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) if (aux->cec.adap->capabilities == cec_caps && aux->cec.adap->available_log_addrs == num_las) { /* Unchanged, so just set the phys addr */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); goto unlock; } /* @@ -370,11 +371,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) * from drm_dp_cec_register_connector() edid == NULL, so in * that case the phys addr is just invalidated. */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); } unlock: mutex_unlock(&aux->cec.lock); } +EXPORT_SYMBOL(drm_dp_cec_attach); + +/* + * Note: Prefer calling drm_dp_cec_attach() with + * connector->display_info.source_physical_address if possible. + */ +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +{ + u16 pa = CEC_PHYS_ADDR_INVALID; + + if (edid && edid->extensions) + pa = cec_get_edid_phys_addr((const u8 *)edid, + EDID_LENGTH * (edid->extensions + 1), NULL); + + drm_dp_cec_attach(aux, pa); +} EXPORT_SYMBOL(drm_dp_cec_set_edid); /* diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 86f24a759268..3369104e2d25 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); void drm_dp_cec_register_connector(struct drm_dp_aux *aux, struct drm_connector *connector); void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); #else @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) { } +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, + u16 source_physical_address) +{ +} + static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-25 13:01 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-25 13:01 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: Hans Verkuil, intel-gfx, linux-media Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forward. v2: Fix the embarrashing build failures Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/display/drm_dp_cec.c | 23 ++++++++++++++++++++--- include/drm/display/drm_dp_helper.h | 6 ++++++ 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c index ae39dc794190..007ceb281d00 100644 --- a/drivers/gpu/drm/display/drm_dp_cec.c +++ b/drivers/gpu/drm/display/drm_dp_cec.c @@ -14,6 +14,7 @@ #include <drm/display/drm_dp_helper.h> #include <drm/drm_connector.h> #include <drm/drm_device.h> +#include <drm/drm_edid.h> /* * Unfortunately it turns out that we have a chicken-and-egg situation @@ -297,7 +298,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) * were unchanged and just update the CEC physical address. Otherwise * unregister the old CEC adapter and create a new one. */ -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) { struct drm_connector *connector = aux->cec.connector; u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | @@ -339,7 +340,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) if (aux->cec.adap->capabilities == cec_caps && aux->cec.adap->available_log_addrs == num_las) { /* Unchanged, so just set the phys addr */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); goto unlock; } /* @@ -370,11 +371,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) * from drm_dp_cec_register_connector() edid == NULL, so in * that case the phys addr is just invalidated. */ - cec_s_phys_addr_from_edid(aux->cec.adap, edid); + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); } unlock: mutex_unlock(&aux->cec.lock); } +EXPORT_SYMBOL(drm_dp_cec_attach); + +/* + * Note: Prefer calling drm_dp_cec_attach() with + * connector->display_info.source_physical_address if possible. + */ +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) +{ + u16 pa = CEC_PHYS_ADDR_INVALID; + + if (edid && edid->extensions) + pa = cec_get_edid_phys_addr((const u8 *)edid, + EDID_LENGTH * (edid->extensions + 1), NULL); + + drm_dp_cec_attach(aux, pa); +} EXPORT_SYMBOL(drm_dp_cec_set_edid); /* diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 86f24a759268..3369104e2d25 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); void drm_dp_cec_register_connector(struct drm_dp_aux *aux, struct drm_connector *connector); void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); #else @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) { } +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, + u16 source_physical_address) +{ +} + static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-25 13:01 ` Jani Nikula @ 2023-08-30 10:26 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 10:26 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media Hi Jani, Sorry, I missed the v2. On 25/08/2023 15:01, Jani Nikula wrote: > Connectors have source physical address available in display > info. There's no need to parse the EDID again for this. Add > drm_dp_cec_attach() to do this. > > Seems like the set_edid/unset_edid naming is a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > v2: Fix the embarrashing build failures > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > --- > drivers/gpu/drm/display/drm_dp_cec.c | 23 ++++++++++++++++++++--- > include/drm/display/drm_dp_helper.h | 6 ++++++ > 2 files changed, 26 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c > index ae39dc794190..007ceb281d00 100644 > --- a/drivers/gpu/drm/display/drm_dp_cec.c > +++ b/drivers/gpu/drm/display/drm_dp_cec.c > @@ -14,6 +14,7 @@ > #include <drm/display/drm_dp_helper.h> > #include <drm/drm_connector.h> > #include <drm/drm_device.h> > +#include <drm/drm_edid.h> > > /* > * Unfortunately it turns out that we have a chicken-and-egg situation > @@ -297,7 +298,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) > * were unchanged and just update the CEC physical address. Otherwise > * unregister the old CEC adapter and create a new one. > */ > -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) > { > struct drm_connector *connector = aux->cec.connector; > u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | > @@ -339,7 +340,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > if (aux->cec.adap->capabilities == cec_caps && > aux->cec.adap->available_log_addrs == num_las) { > /* Unchanged, so just set the phys addr */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); > goto unlock; > } > /* > @@ -370,11 +371,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > * from drm_dp_cec_register_connector() edid == NULL, so in > * that case the phys addr is just invalidated. > */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); > } > unlock: > mutex_unlock(&aux->cec.lock); > } > +EXPORT_SYMBOL(drm_dp_cec_attach); > + > +/* > + * Note: Prefer calling drm_dp_cec_attach() with > + * connector->display_info.source_physical_address if possible. > + */ > +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +{ > + u16 pa = CEC_PHYS_ADDR_INVALID; > + > + if (edid && edid->extensions) > + pa = cec_get_edid_phys_addr((const u8 *)edid, > + EDID_LENGTH * (edid->extensions + 1), NULL); > + > + drm_dp_cec_attach(aux, pa); > +} > EXPORT_SYMBOL(drm_dp_cec_set_edid); > > /* > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h > index 86f24a759268..3369104e2d25 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); > void drm_dp_cec_register_connector(struct drm_dp_aux *aux, > struct drm_connector *connector); > void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); > void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); > void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); > #else > @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) > { > } > > +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, > + u16 source_physical_address) > +{ > +} > + > static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, > const struct edid *edid) > { ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-30 10:26 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 10:26 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media Hi Jani, Sorry, I missed the v2. On 25/08/2023 15:01, Jani Nikula wrote: > Connectors have source physical address available in display > info. There's no need to parse the EDID again for this. Add > drm_dp_cec_attach() to do this. > > Seems like the set_edid/unset_edid naming is a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > v2: Fix the embarrashing build failures > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > --- > drivers/gpu/drm/display/drm_dp_cec.c | 23 ++++++++++++++++++++--- > include/drm/display/drm_dp_helper.h | 6 ++++++ > 2 files changed, 26 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c > index ae39dc794190..007ceb281d00 100644 > --- a/drivers/gpu/drm/display/drm_dp_cec.c > +++ b/drivers/gpu/drm/display/drm_dp_cec.c > @@ -14,6 +14,7 @@ > #include <drm/display/drm_dp_helper.h> > #include <drm/drm_connector.h> > #include <drm/drm_device.h> > +#include <drm/drm_edid.h> > > /* > * Unfortunately it turns out that we have a chicken-and-egg situation > @@ -297,7 +298,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) > * were unchanged and just update the CEC physical address. Otherwise > * unregister the old CEC adapter and create a new one. > */ > -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) > { > struct drm_connector *connector = aux->cec.connector; > u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | > @@ -339,7 +340,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > if (aux->cec.adap->capabilities == cec_caps && > aux->cec.adap->available_log_addrs == num_las) { > /* Unchanged, so just set the phys addr */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); > goto unlock; > } > /* > @@ -370,11 +371,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > * from drm_dp_cec_register_connector() edid == NULL, so in > * that case the phys addr is just invalidated. > */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(aux->cec.adap, source_physical_address, false); > } > unlock: > mutex_unlock(&aux->cec.lock); > } > +EXPORT_SYMBOL(drm_dp_cec_attach); > + > +/* > + * Note: Prefer calling drm_dp_cec_attach() with > + * connector->display_info.source_physical_address if possible. > + */ > +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +{ > + u16 pa = CEC_PHYS_ADDR_INVALID; > + > + if (edid && edid->extensions) > + pa = cec_get_edid_phys_addr((const u8 *)edid, > + EDID_LENGTH * (edid->extensions + 1), NULL); > + > + drm_dp_cec_attach(aux, pa); > +} > EXPORT_SYMBOL(drm_dp_cec_set_edid); > > /* > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h > index 86f24a759268..3369104e2d25 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); > void drm_dp_cec_register_connector(struct drm_dp_aux *aux, > struct drm_connector *connector); > void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); > void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); > void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); > #else > @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) > { > } > > +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, > + u16 source_physical_address) > +{ > +} > + > static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, > const struct edid *edid) > { ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-24 13:46 ` Jani Nikula @ 2023-08-30 9:57 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 9:57 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > Connectors have source physical address available in display > info. There's no need to parse the EDID again for this. Add > drm_dp_cec_attach() to do this. > > Seems like the set_edid/unset_edid naming is a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- > include/drm/display/drm_dp_helper.h | 6 ++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c > index ae39dc794190..da7a7d357446 100644 > --- a/drivers/gpu/drm/display/drm_dp_cec.c > +++ b/drivers/gpu/drm/display/drm_dp_cec.c > @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) > * were unchanged and just update the CEC physical address. Otherwise > * unregister the old CEC adapter and create a new one. > */ > -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) > { > struct drm_connector *connector = aux->cec.connector; > u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | > @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > if (aux->cec.adap->capabilities == cec_caps && > aux->cec.adap->available_log_addrs == num_las) { > /* Unchanged, so just set the phys addr */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(adap, source_physical_address, false); As the kernel test robot indicated, this does not compile, this should be aux->cec.adap. > goto unlock; > } > /* > @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > * from drm_dp_cec_register_connector() edid == NULL, so in > * that case the phys addr is just invalidated. > */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(adap, source_physical_address, false); > } > unlock: > mutex_unlock(&aux->cec.lock); > } > +EXPORT_SYMBOL(drm_dp_cec_attach); > + > +/* > + * Note: Prefer calling drm_dp_cec_attach() with > + * connector->display_info.source_physical_address if possible. > + */ > +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +{ > + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; > + > + if (edid && edid->extensions) And this source needs to include <drm/drm_edid.h>, also as found by the kernel test robot. Regards, Hans > + pa = cec_get_edid_phys_addr((const u8 *)edid, > + EDID_LENGTH * (edid->extensions + 1), NULL); > + > + drm_dp_cec_attach(aux, source_physical_address); > +} > EXPORT_SYMBOL(drm_dp_cec_set_edid); > > /* > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h > index 86f24a759268..3369104e2d25 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); > void drm_dp_cec_register_connector(struct drm_dp_aux *aux, > struct drm_connector *connector); > void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); > void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); > void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); > #else > @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) > { > } > > +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, > + u16 source_physical_address) > +{ > +} > + > static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, > const struct edid *edid) > { ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-30 9:57 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 9:57 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > Connectors have source physical address available in display > info. There's no need to parse the EDID again for this. Add > drm_dp_cec_attach() to do this. > > Seems like the set_edid/unset_edid naming is a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- > include/drm/display/drm_dp_helper.h | 6 ++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c > index ae39dc794190..da7a7d357446 100644 > --- a/drivers/gpu/drm/display/drm_dp_cec.c > +++ b/drivers/gpu/drm/display/drm_dp_cec.c > @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) > * were unchanged and just update the CEC physical address. Otherwise > * unregister the old CEC adapter and create a new one. > */ > -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) > { > struct drm_connector *connector = aux->cec.connector; > u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | > @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > if (aux->cec.adap->capabilities == cec_caps && > aux->cec.adap->available_log_addrs == num_las) { > /* Unchanged, so just set the phys addr */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(adap, source_physical_address, false); As the kernel test robot indicated, this does not compile, this should be aux->cec.adap. > goto unlock; > } > /* > @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > * from drm_dp_cec_register_connector() edid == NULL, so in > * that case the phys addr is just invalidated. > */ > - cec_s_phys_addr_from_edid(aux->cec.adap, edid); > + cec_s_phys_addr(adap, source_physical_address, false); > } > unlock: > mutex_unlock(&aux->cec.lock); > } > +EXPORT_SYMBOL(drm_dp_cec_attach); > + > +/* > + * Note: Prefer calling drm_dp_cec_attach() with > + * connector->display_info.source_physical_address if possible. > + */ > +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) > +{ > + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; > + > + if (edid && edid->extensions) And this source needs to include <drm/drm_edid.h>, also as found by the kernel test robot. Regards, Hans > + pa = cec_get_edid_phys_addr((const u8 *)edid, > + EDID_LENGTH * (edid->extensions + 1), NULL); > + > + drm_dp_cec_attach(aux, source_physical_address); > +} > EXPORT_SYMBOL(drm_dp_cec_set_edid); > > /* > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h > index 86f24a759268..3369104e2d25 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); > void drm_dp_cec_register_connector(struct drm_dp_aux *aux, > struct drm_connector *connector); > void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); > +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); > void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); > void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); > #else > @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) > { > } > > +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, > + u16 source_physical_address) > +{ > +} > + > static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, > const struct edid *edid) > { ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 2023-08-30 9:57 ` Hans Verkuil @ 2023-08-30 10:23 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-30 10:23 UTC (permalink / raw) To: Hans Verkuil, dri-devel; +Cc: intel-gfx, linux-media On Wed, 30 Aug 2023, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > On 24/08/2023 15:46, Jani Nikula wrote: >> Connectors have source physical address available in display >> info. There's no need to parse the EDID again for this. Add >> drm_dp_cec_attach() to do this. >> >> Seems like the set_edid/unset_edid naming is a bit specific now that >> there's no need to pass the EDID at all, so aim for attach/detach going >> forward. >> >> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >> Cc: linux-media@vger.kernel.org >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- >> include/drm/display/drm_dp_helper.h | 6 ++++++ >> 2 files changed, 25 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c >> index ae39dc794190..da7a7d357446 100644 >> --- a/drivers/gpu/drm/display/drm_dp_cec.c >> +++ b/drivers/gpu/drm/display/drm_dp_cec.c >> @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) >> * were unchanged and just update the CEC physical address. Otherwise >> * unregister the old CEC adapter and create a new one. >> */ >> -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) >> { >> struct drm_connector *connector = aux->cec.connector; >> u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | >> @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> if (aux->cec.adap->capabilities == cec_caps && >> aux->cec.adap->available_log_addrs == num_las) { >> /* Unchanged, so just set the phys addr */ >> - cec_s_phys_addr_from_edid(aux->cec.adap, edid); >> + cec_s_phys_addr(adap, source_physical_address, false); > > As the kernel test robot indicated, this does not compile, this should > be aux->cec.adap. > >> goto unlock; >> } >> /* >> @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> * from drm_dp_cec_register_connector() edid == NULL, so in >> * that case the phys addr is just invalidated. >> */ >> - cec_s_phys_addr_from_edid(aux->cec.adap, edid); >> + cec_s_phys_addr(adap, source_physical_address, false); >> } >> unlock: >> mutex_unlock(&aux->cec.lock); >> } >> +EXPORT_SYMBOL(drm_dp_cec_attach); >> + >> +/* >> + * Note: Prefer calling drm_dp_cec_attach() with >> + * connector->display_info.source_physical_address if possible. >> + */ >> +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> +{ >> + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; >> + >> + if (edid && edid->extensions) > > And this source needs to include <drm/drm_edid.h>, also as found by > the kernel test robot. Yes, very embarrassing, I sent the v2 in reply [1]. BR, Jani. [1] https://patchwork.freedesktop.org/patch/msgid/20230825130120.1250089-1-jani.nikula@intel.com > > Regards, > > Hans > >> + pa = cec_get_edid_phys_addr((const u8 *)edid, >> + EDID_LENGTH * (edid->extensions + 1), NULL); >> + >> + drm_dp_cec_attach(aux, source_physical_address); >> +} >> EXPORT_SYMBOL(drm_dp_cec_set_edid); >> >> /* >> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h >> index 86f24a759268..3369104e2d25 100644 >> --- a/include/drm/display/drm_dp_helper.h >> +++ b/include/drm/display/drm_dp_helper.h >> @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); >> void drm_dp_cec_register_connector(struct drm_dp_aux *aux, >> struct drm_connector *connector); >> void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); >> +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); >> void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); >> void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); >> #else >> @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) >> { >> } >> >> +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, >> + u16 source_physical_address) >> +{ >> +} >> + >> static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, >> const struct edid *edid) >> { > -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid @ 2023-08-30 10:23 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-30 10:23 UTC (permalink / raw) To: Hans Verkuil, dri-devel; +Cc: intel-gfx, linux-media On Wed, 30 Aug 2023, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > On 24/08/2023 15:46, Jani Nikula wrote: >> Connectors have source physical address available in display >> info. There's no need to parse the EDID again for this. Add >> drm_dp_cec_attach() to do this. >> >> Seems like the set_edid/unset_edid naming is a bit specific now that >> there's no need to pass the EDID at all, so aim for attach/detach going >> forward. >> >> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >> Cc: linux-media@vger.kernel.org >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- >> include/drm/display/drm_dp_helper.h | 6 ++++++ >> 2 files changed, 25 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/display/drm_dp_cec.c b/drivers/gpu/drm/display/drm_dp_cec.c >> index ae39dc794190..da7a7d357446 100644 >> --- a/drivers/gpu/drm/display/drm_dp_cec.c >> +++ b/drivers/gpu/drm/display/drm_dp_cec.c >> @@ -297,7 +297,7 @@ static void drm_dp_cec_unregister_work(struct work_struct *work) >> * were unchanged and just update the CEC physical address. Otherwise >> * unregister the old CEC adapter and create a new one. >> */ >> -void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address) >> { >> struct drm_connector *connector = aux->cec.connector; >> u32 cec_caps = CEC_CAP_DEFAULTS | CEC_CAP_NEEDS_HPD | >> @@ -339,7 +339,7 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> if (aux->cec.adap->capabilities == cec_caps && >> aux->cec.adap->available_log_addrs == num_las) { >> /* Unchanged, so just set the phys addr */ >> - cec_s_phys_addr_from_edid(aux->cec.adap, edid); >> + cec_s_phys_addr(adap, source_physical_address, false); > > As the kernel test robot indicated, this does not compile, this should > be aux->cec.adap. > >> goto unlock; >> } >> /* >> @@ -370,11 +370,27 @@ void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> * from drm_dp_cec_register_connector() edid == NULL, so in >> * that case the phys addr is just invalidated. >> */ >> - cec_s_phys_addr_from_edid(aux->cec.adap, edid); >> + cec_s_phys_addr(adap, source_physical_address, false); >> } >> unlock: >> mutex_unlock(&aux->cec.lock); >> } >> +EXPORT_SYMBOL(drm_dp_cec_attach); >> + >> +/* >> + * Note: Prefer calling drm_dp_cec_attach() with >> + * connector->display_info.source_physical_address if possible. >> + */ >> +void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid) >> +{ >> + u16 source_physical_address = CEC_PHYS_ADDR_INVALID; >> + >> + if (edid && edid->extensions) > > And this source needs to include <drm/drm_edid.h>, also as found by > the kernel test robot. Yes, very embarrassing, I sent the v2 in reply [1]. BR, Jani. [1] https://patchwork.freedesktop.org/patch/msgid/20230825130120.1250089-1-jani.nikula@intel.com > > Regards, > > Hans > >> + pa = cec_get_edid_phys_addr((const u8 *)edid, >> + EDID_LENGTH * (edid->extensions + 1), NULL); >> + >> + drm_dp_cec_attach(aux, source_physical_address); >> +} >> EXPORT_SYMBOL(drm_dp_cec_set_edid); >> >> /* >> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h >> index 86f24a759268..3369104e2d25 100644 >> --- a/include/drm/display/drm_dp_helper.h >> +++ b/include/drm/display/drm_dp_helper.h >> @@ -699,6 +699,7 @@ void drm_dp_cec_irq(struct drm_dp_aux *aux); >> void drm_dp_cec_register_connector(struct drm_dp_aux *aux, >> struct drm_connector *connector); >> void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux); >> +void drm_dp_cec_attach(struct drm_dp_aux *aux, u16 source_physical_address); >> void drm_dp_cec_set_edid(struct drm_dp_aux *aux, const struct edid *edid); >> void drm_dp_cec_unset_edid(struct drm_dp_aux *aux); >> #else >> @@ -716,6 +717,11 @@ static inline void drm_dp_cec_unregister_connector(struct drm_dp_aux *aux) >> { >> } >> >> +static inline void drm_dp_cec_attach(struct drm_dp_aux *aux, >> + u16 source_physical_address) >> +{ >> +} >> + >> static inline void drm_dp_cec_set_edid(struct drm_dp_aux *aux, >> const struct edid *edid) >> { > -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH 5/6] drm/i915/cec: switch to setting physical address directly 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-24 13:46 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Avoid parsing the EDID again for source physical address. Also gets rids of a few remaining raw EDID usages. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 7067ee3a4bd3..c4b8e0e74c15 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5198,7 +5198,6 @@ intel_dp_set_edid(struct intel_dp *intel_dp) struct drm_i915_private *i915 = dp_to_i915(intel_dp); struct intel_connector *connector = intel_dp->attached_connector; const struct drm_edid *drm_edid; - const struct edid *edid; bool vrr_capable; intel_dp_unset_edid(intel_dp); @@ -5216,10 +5215,8 @@ intel_dp_set_edid(struct intel_dp *intel_dp) intel_dp_update_dfp(intel_dp, drm_edid); intel_dp_update_420(intel_dp); - /* FIXME: Get rid of drm_edid_raw() */ - edid = drm_edid_raw(drm_edid); - - drm_dp_cec_set_edid(&intel_dp->aux, edid); + drm_dp_cec_attach(&intel_dp->aux, + connector->base.display_info.source_physical_address); } static void diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index aa9915098dda..5d6255ee8b54 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2482,9 +2482,8 @@ intel_hdmi_set_edid(struct drm_connector *connector) intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); - /* FIXME: Get rid of drm_edid_raw() */ - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, - drm_edid_raw(drm_edid)); + cec_notifier_set_phys_addr(intel_hdmi->cec_notifier, + connector->display_info.source_physical_address); return connected; } -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 5/6] drm/i915/cec: switch to setting physical address directly @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula Avoid parsing the EDID again for source physical address. Also gets rids of a few remaining raw EDID usages. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 7067ee3a4bd3..c4b8e0e74c15 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5198,7 +5198,6 @@ intel_dp_set_edid(struct intel_dp *intel_dp) struct drm_i915_private *i915 = dp_to_i915(intel_dp); struct intel_connector *connector = intel_dp->attached_connector; const struct drm_edid *drm_edid; - const struct edid *edid; bool vrr_capable; intel_dp_unset_edid(intel_dp); @@ -5216,10 +5215,8 @@ intel_dp_set_edid(struct intel_dp *intel_dp) intel_dp_update_dfp(intel_dp, drm_edid); intel_dp_update_420(intel_dp); - /* FIXME: Get rid of drm_edid_raw() */ - edid = drm_edid_raw(drm_edid); - - drm_dp_cec_set_edid(&intel_dp->aux, edid); + drm_dp_cec_attach(&intel_dp->aux, + connector->base.display_info.source_physical_address); } static void diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index aa9915098dda..5d6255ee8b54 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2482,9 +2482,8 @@ intel_hdmi_set_edid(struct drm_connector *connector) intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); - /* FIXME: Get rid of drm_edid_raw() */ - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, - drm_edid_raw(drm_edid)); + cec_notifier_set_phys_addr(intel_hdmi->cec_notifier, + connector->display_info.source_physical_address); return connected; } -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 5/6] drm/i915/cec: switch to setting physical address directly @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media Avoid parsing the EDID again for source physical address. Also gets rids of a few remaining raw EDID usages. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 7067ee3a4bd3..c4b8e0e74c15 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5198,7 +5198,6 @@ intel_dp_set_edid(struct intel_dp *intel_dp) struct drm_i915_private *i915 = dp_to_i915(intel_dp); struct intel_connector *connector = intel_dp->attached_connector; const struct drm_edid *drm_edid; - const struct edid *edid; bool vrr_capable; intel_dp_unset_edid(intel_dp); @@ -5216,10 +5215,8 @@ intel_dp_set_edid(struct intel_dp *intel_dp) intel_dp_update_dfp(intel_dp, drm_edid); intel_dp_update_420(intel_dp); - /* FIXME: Get rid of drm_edid_raw() */ - edid = drm_edid_raw(drm_edid); - - drm_dp_cec_set_edid(&intel_dp->aux, edid); + drm_dp_cec_attach(&intel_dp->aux, + connector->base.display_info.source_physical_address); } static void diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index aa9915098dda..5d6255ee8b54 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2482,9 +2482,8 @@ intel_hdmi_set_edid(struct drm_connector *connector) intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); - /* FIXME: Get rid of drm_edid_raw() */ - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, - drm_edid_raw(drm_edid)); + cec_notifier_set_phys_addr(intel_hdmi->cec_notifier, + connector->display_info.source_physical_address); return connected; } -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 5/6] drm/i915/cec: switch to setting physical address directly 2023-08-24 13:46 ` Jani Nikula @ 2023-08-30 9:57 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 9:57 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > Avoid parsing the EDID again for source physical address. Also gets rids > of a few remaining raw EDID usages. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > --- > drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- > drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- > 2 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7067ee3a4bd3..c4b8e0e74c15 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5198,7 +5198,6 @@ intel_dp_set_edid(struct intel_dp *intel_dp) > struct drm_i915_private *i915 = dp_to_i915(intel_dp); > struct intel_connector *connector = intel_dp->attached_connector; > const struct drm_edid *drm_edid; > - const struct edid *edid; > bool vrr_capable; > > intel_dp_unset_edid(intel_dp); > @@ -5216,10 +5215,8 @@ intel_dp_set_edid(struct intel_dp *intel_dp) > intel_dp_update_dfp(intel_dp, drm_edid); > intel_dp_update_420(intel_dp); > > - /* FIXME: Get rid of drm_edid_raw() */ > - edid = drm_edid_raw(drm_edid); > - > - drm_dp_cec_set_edid(&intel_dp->aux, edid); > + drm_dp_cec_attach(&intel_dp->aux, > + connector->base.display_info.source_physical_address); > } > > static void > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index aa9915098dda..5d6255ee8b54 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -2482,9 +2482,8 @@ intel_hdmi_set_edid(struct drm_connector *connector) > > intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); > > - /* FIXME: Get rid of drm_edid_raw() */ > - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, > - drm_edid_raw(drm_edid)); > + cec_notifier_set_phys_addr(intel_hdmi->cec_notifier, > + connector->display_info.source_physical_address); > > return connected; > } ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 5/6] drm/i915/cec: switch to setting physical address directly @ 2023-08-30 9:57 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 9:57 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > Avoid parsing the EDID again for source physical address. Also gets rids > of a few remaining raw EDID usages. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > --- > drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- > drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- > 2 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7067ee3a4bd3..c4b8e0e74c15 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5198,7 +5198,6 @@ intel_dp_set_edid(struct intel_dp *intel_dp) > struct drm_i915_private *i915 = dp_to_i915(intel_dp); > struct intel_connector *connector = intel_dp->attached_connector; > const struct drm_edid *drm_edid; > - const struct edid *edid; > bool vrr_capable; > > intel_dp_unset_edid(intel_dp); > @@ -5216,10 +5215,8 @@ intel_dp_set_edid(struct intel_dp *intel_dp) > intel_dp_update_dfp(intel_dp, drm_edid); > intel_dp_update_420(intel_dp); > > - /* FIXME: Get rid of drm_edid_raw() */ > - edid = drm_edid_raw(drm_edid); > - > - drm_dp_cec_set_edid(&intel_dp->aux, edid); > + drm_dp_cec_attach(&intel_dp->aux, > + connector->base.display_info.source_physical_address); > } > > static void > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index aa9915098dda..5d6255ee8b54 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -2482,9 +2482,8 @@ intel_hdmi_set_edid(struct drm_connector *connector) > > intel_display_power_put(dev_priv, POWER_DOMAIN_GMBUS, wakeref); > > - /* FIXME: Get rid of drm_edid_raw() */ > - cec_notifier_set_phys_addr_from_edid(intel_hdmi->cec_notifier, > - drm_edid_raw(drm_edid)); > + cec_notifier_set_phys_addr(intel_hdmi->cec_notifier, > + connector->display_info.source_physical_address); > > return connected; > } ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-24 13:46 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/media/cec/core/cec-adap.c | 4 ++++ drivers/media/cec/core/cec-notifier.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c index 241b1621b197..2c627ed611ed 100644 --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) } EXPORT_SYMBOL_GPL(cec_s_phys_addr); +/* + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with + * connector->display_info.source_physical_address if possible. + */ void cec_s_phys_addr_from_edid(struct cec_adapter *adap, const struct edid *edid) { diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c index 389dc664b211..13f043b3025b 100644 --- a/drivers/media/cec/core/cec-notifier.c +++ b/drivers/media/cec/core/cec-notifier.c @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) } EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); +/* + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with + * connector->display_info.source_physical_address if possible. + */ void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: intel-gfx, linux-media, Hans Verkuil, Jani Nikula In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/media/cec/core/cec-adap.c | 4 ++++ drivers/media/cec/core/cec-notifier.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c index 241b1621b197..2c627ed611ed 100644 --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) } EXPORT_SYMBOL_GPL(cec_s_phys_addr); +/* + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with + * connector->display_info.source_physical_address if possible. + */ void cec_s_phys_addr_from_edid(struct cec_adapter *adap, const struct edid *edid) { diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c index 389dc664b211..13f043b3025b 100644 --- a/drivers/media/cec/core/cec-notifier.c +++ b/drivers/media/cec/core/cec-notifier.c @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) } EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); +/* + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with + * connector->display_info.source_physical_address if possible. + */ void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm @ 2023-08-24 13:46 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-24 13:46 UTC (permalink / raw) To: dri-devel; +Cc: Hans Verkuil, Jani Nikula, intel-gfx, linux-media In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/media/cec/core/cec-adap.c | 4 ++++ drivers/media/cec/core/cec-notifier.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c index 241b1621b197..2c627ed611ed 100644 --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) } EXPORT_SYMBOL_GPL(cec_s_phys_addr); +/* + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with + * connector->display_info.source_physical_address if possible. + */ void cec_s_phys_addr_from_edid(struct cec_adapter *adap, const struct edid *edid) { diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c index 389dc664b211..13f043b3025b 100644 --- a/drivers/media/cec/core/cec-notifier.c +++ b/drivers/media/cec/core/cec-notifier.c @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) } EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); +/* + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with + * connector->display_info.source_physical_address if possible. + */ void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm 2023-08-24 13:46 ` Jani Nikula @ 2023-08-30 10:03 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 10:03 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/media/cec/core/cec-adap.c | 4 ++++ > drivers/media/cec/core/cec-notifier.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c > index 241b1621b197..2c627ed611ed 100644 > --- a/drivers/media/cec/core/cec-adap.c > +++ b/drivers/media/cec/core/cec-adap.c > @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) > } > EXPORT_SYMBOL_GPL(cec_s_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with > + * connector->display_info.source_physical_address if possible. > + */ I would rephrase this: /* * Note: in the drm subsystem, prefer calling (if possible): * * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); */ I think it is important to indicate that the last argument should be 'false'. > void cec_s_phys_addr_from_edid(struct cec_adapter *adap, > const struct edid *edid) > { > diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c > index 389dc664b211..13f043b3025b 100644 > --- a/drivers/media/cec/core/cec-notifier.c > +++ b/drivers/media/cec/core/cec-notifier.c > @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) > } > EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with > + * connector->display_info.source_physical_address if possible. > + */ This comment is fine, there is no similar last argument here. But perhaps it is good to use a similar format as above. Up to you. > void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, > const struct edid *edid) > { Regards, Hans ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm @ 2023-08-30 10:03 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-30 10:03 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 24/08/2023 15:46, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/media/cec/core/cec-adap.c | 4 ++++ > drivers/media/cec/core/cec-notifier.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c > index 241b1621b197..2c627ed611ed 100644 > --- a/drivers/media/cec/core/cec-adap.c > +++ b/drivers/media/cec/core/cec-adap.c > @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) > } > EXPORT_SYMBOL_GPL(cec_s_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with > + * connector->display_info.source_physical_address if possible. > + */ I would rephrase this: /* * Note: in the drm subsystem, prefer calling (if possible): * * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); */ I think it is important to indicate that the last argument should be 'false'. > void cec_s_phys_addr_from_edid(struct cec_adapter *adap, > const struct edid *edid) > { > diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c > index 389dc664b211..13f043b3025b 100644 > --- a/drivers/media/cec/core/cec-notifier.c > +++ b/drivers/media/cec/core/cec-notifier.c > @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) > } > EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with > + * connector->display_info.source_physical_address if possible. > + */ This comment is fine, there is no similar last argument here. But perhaps it is good to use a similar format as above. Up to you. > void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, > const struct edid *edid) > { Regards, Hans ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm 2023-08-30 10:03 ` Hans Verkuil @ 2023-08-31 10:52 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 10:52 UTC (permalink / raw) To: Hans Verkuil, dri-devel; +Cc: intel-gfx, linux-media On Wed, 30 Aug 2023, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > On 24/08/2023 15:46, Jani Nikula wrote: >> In the drm subsystem, the source physical address is, in most cases, >> available without having to parse the EDID again. Add notes about >> preferring to use the pre-parsed address instead. >> >> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >> Cc: linux-media@vger.kernel.org >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/media/cec/core/cec-adap.c | 4 ++++ >> drivers/media/cec/core/cec-notifier.c | 4 ++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c >> index 241b1621b197..2c627ed611ed 100644 >> --- a/drivers/media/cec/core/cec-adap.c >> +++ b/drivers/media/cec/core/cec-adap.c >> @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) >> } >> EXPORT_SYMBOL_GPL(cec_s_phys_addr); >> >> +/* >> + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with >> + * connector->display_info.source_physical_address if possible. >> + */ > > I would rephrase this: > > /* > * Note: in the drm subsystem, prefer calling (if possible): > * > * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); > */ > > I think it is important to indicate that the last argument should be 'false'. Agreed. > >> void cec_s_phys_addr_from_edid(struct cec_adapter *adap, >> const struct edid *edid) >> { >> diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c >> index 389dc664b211..13f043b3025b 100644 >> --- a/drivers/media/cec/core/cec-notifier.c >> +++ b/drivers/media/cec/core/cec-notifier.c >> @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) >> } >> EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); >> >> +/* >> + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with >> + * connector->display_info.source_physical_address if possible. >> + */ > > This comment is fine, there is no similar last argument here. But perhaps > it is good to use a similar format as above. Up to you. Thanks, rephrased both in v2. BR, Jani. > >> void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, >> const struct edid *edid) >> { > > Regards, > > Hans -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm @ 2023-08-31 10:52 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 10:52 UTC (permalink / raw) To: Hans Verkuil, dri-devel; +Cc: intel-gfx, linux-media On Wed, 30 Aug 2023, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > On 24/08/2023 15:46, Jani Nikula wrote: >> In the drm subsystem, the source physical address is, in most cases, >> available without having to parse the EDID again. Add notes about >> preferring to use the pre-parsed address instead. >> >> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >> Cc: linux-media@vger.kernel.org >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/media/cec/core/cec-adap.c | 4 ++++ >> drivers/media/cec/core/cec-notifier.c | 4 ++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c >> index 241b1621b197..2c627ed611ed 100644 >> --- a/drivers/media/cec/core/cec-adap.c >> +++ b/drivers/media/cec/core/cec-adap.c >> @@ -1688,6 +1688,10 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) >> } >> EXPORT_SYMBOL_GPL(cec_s_phys_addr); >> >> +/* >> + * Note: In the drm subsystem, prefer calling cec_s_phys_addr() with >> + * connector->display_info.source_physical_address if possible. >> + */ > > I would rephrase this: > > /* > * Note: in the drm subsystem, prefer calling (if possible): > * > * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); > */ > > I think it is important to indicate that the last argument should be 'false'. Agreed. > >> void cec_s_phys_addr_from_edid(struct cec_adapter *adap, >> const struct edid *edid) >> { >> diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c >> index 389dc664b211..13f043b3025b 100644 >> --- a/drivers/media/cec/core/cec-notifier.c >> +++ b/drivers/media/cec/core/cec-notifier.c >> @@ -195,6 +195,10 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) >> } >> EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); >> >> +/* >> + * Note: In the drm subsystem, prefer calling cec_notifier_set_phys_addr() with >> + * connector->display_info.source_physical_address if possible. >> + */ > > This comment is fine, there is no similar last argument here. But perhaps > it is good to use a similar format as above. Up to you. Thanks, rephrased both in v2. BR, Jani. > >> void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, >> const struct edid *edid) >> { > > Regards, > > Hans -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm 2023-08-24 13:46 ` Jani Nikula @ 2023-08-31 10:51 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 10:51 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: Hans Verkuil, intel-gfx, linux-media In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- v2: rephrase comments, in particular indicate cec_s_phys_addr() should be false (Hans) --- drivers/media/cec/core/cec-adap.c | 5 +++++ drivers/media/cec/core/cec-notifier.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c index 241b1621b197..1109af525c35 100644 --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1688,6 +1688,11 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) } EXPORT_SYMBOL_GPL(cec_s_phys_addr); +/* + * Note: In the drm subsystem, prefer calling (if possible): + * + * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); + */ void cec_s_phys_addr_from_edid(struct cec_adapter *adap, const struct edid *edid) { diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c index 389dc664b211..d600be0f7b67 100644 --- a/drivers/media/cec/core/cec-notifier.c +++ b/drivers/media/cec/core/cec-notifier.c @@ -195,6 +195,11 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) } EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); +/* + * Note: In the drm subsystem, prefer calling (if possible): + * + * cec_notifier_set_phys_addr(n, connector->display_info.source_physical_address); + */ void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm @ 2023-08-31 10:51 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 10:51 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: Hans Verkuil, intel-gfx, linux-media In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- v2: rephrase comments, in particular indicate cec_s_phys_addr() should be false (Hans) --- drivers/media/cec/core/cec-adap.c | 5 +++++ drivers/media/cec/core/cec-notifier.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c index 241b1621b197..1109af525c35 100644 --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1688,6 +1688,11 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) } EXPORT_SYMBOL_GPL(cec_s_phys_addr); +/* + * Note: In the drm subsystem, prefer calling (if possible): + * + * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); + */ void cec_s_phys_addr_from_edid(struct cec_adapter *adap, const struct edid *edid) { diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c index 389dc664b211..d600be0f7b67 100644 --- a/drivers/media/cec/core/cec-notifier.c +++ b/drivers/media/cec/core/cec-notifier.c @@ -195,6 +195,11 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) } EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); +/* + * Note: In the drm subsystem, prefer calling (if possible): + * + * cec_notifier_set_phys_addr(n, connector->display_info.source_physical_address); + */ void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, const struct edid *edid) { -- 2.39.2 ^ permalink raw reply related [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm 2023-08-31 10:51 ` Jani Nikula @ 2023-08-31 11:38 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-31 11:38 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 31/08/2023 12:51, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Thanks! Hans > > --- > > v2: rephrase comments, in particular indicate cec_s_phys_addr() should > be false (Hans) > --- > drivers/media/cec/core/cec-adap.c | 5 +++++ > drivers/media/cec/core/cec-notifier.c | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c > index 241b1621b197..1109af525c35 100644 > --- a/drivers/media/cec/core/cec-adap.c > +++ b/drivers/media/cec/core/cec-adap.c > @@ -1688,6 +1688,11 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) > } > EXPORT_SYMBOL_GPL(cec_s_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling (if possible): > + * > + * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); > + */ > void cec_s_phys_addr_from_edid(struct cec_adapter *adap, > const struct edid *edid) > { > diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c > index 389dc664b211..d600be0f7b67 100644 > --- a/drivers/media/cec/core/cec-notifier.c > +++ b/drivers/media/cec/core/cec-notifier.c > @@ -195,6 +195,11 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) > } > EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling (if possible): > + * > + * cec_notifier_set_phys_addr(n, connector->display_info.source_physical_address); > + */ > void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, > const struct edid *edid) > { ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm @ 2023-08-31 11:38 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-31 11:38 UTC (permalink / raw) To: Jani Nikula, dri-devel; +Cc: intel-gfx, linux-media On 31/08/2023 12:51, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Thanks! Hans > > --- > > v2: rephrase comments, in particular indicate cec_s_phys_addr() should > be false (Hans) > --- > drivers/media/cec/core/cec-adap.c | 5 +++++ > drivers/media/cec/core/cec-notifier.c | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c > index 241b1621b197..1109af525c35 100644 > --- a/drivers/media/cec/core/cec-adap.c > +++ b/drivers/media/cec/core/cec-adap.c > @@ -1688,6 +1688,11 @@ void cec_s_phys_addr(struct cec_adapter *adap, u16 phys_addr, bool block) > } > EXPORT_SYMBOL_GPL(cec_s_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling (if possible): > + * > + * cec_s_phys_addr(adap, connector->display_info.source_physical_address, false); > + */ > void cec_s_phys_addr_from_edid(struct cec_adapter *adap, > const struct edid *edid) > { > diff --git a/drivers/media/cec/core/cec-notifier.c b/drivers/media/cec/core/cec-notifier.c > index 389dc664b211..d600be0f7b67 100644 > --- a/drivers/media/cec/core/cec-notifier.c > +++ b/drivers/media/cec/core/cec-notifier.c > @@ -195,6 +195,11 @@ void cec_notifier_set_phys_addr(struct cec_notifier *n, u16 pa) > } > EXPORT_SYMBOL_GPL(cec_notifier_set_phys_addr); > > +/* > + * Note: In the drm subsystem, prefer calling (if possible): > + * > + * cec_notifier_set_phys_addr(n, connector->display_info.source_physical_address); > + */ > void cec_notifier_set_phys_addr_from_edid(struct cec_notifier *n, > const struct edid *edid) > { ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, cec and edid updates 2023-08-24 13:46 ` Jani Nikula ` (7 preceding siblings ...) (?) @ 2023-08-24 19:59 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-24 19:59 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm, cec and edid updates URL : https://patchwork.freedesktop.org/series/122841/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm, cec and edid updates 2023-08-24 13:46 ` Jani Nikula ` (8 preceding siblings ...) (?) @ 2023-08-24 20:16 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-24 20:16 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 4715 bytes --] == Series Details == Series: drm, cec and edid updates URL : https://patchwork.freedesktop.org/series/122841/ State : success == Summary == CI Bug Log - changes from CI_DRM_13562 -> Patchwork_122841v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/index.html Participating hosts (41 -> 40) ------------------------------ Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_122841v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_suspend@basic-s3-without-i915: - bat-adlm-1: NOTRUN -> [INCOMPLETE][1] ([i915#7443]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-adlm-1/igt@i915_suspend@basic-s3-without-i915.html - bat-mtlp-8: NOTRUN -> [SKIP][2] ([i915#6645]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_cursor_legacy@basic-flip-before-cursor-atomic: - fi-kbl-soraka: [PASS][3] -> [FAIL][4] ([i915#8391]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/fi-kbl-soraka/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/fi-kbl-soraka/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html * igt@kms_psr@primary_mmap_gtt: - bat-rplp-1: NOTRUN -> [ABORT][5] ([i915#8442] / [i915#8469] / [i915#8668]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html * igt@kms_psr@sprite_plane_onoff: - bat-rplp-1: NOTRUN -> [SKIP][6] ([i915#1072]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html #### Possible fixes #### * igt@i915_selftest@live@requests: - bat-mtlp-8: [ABORT][7] ([i915#7982] / [i915#8865]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/bat-mtlp-8/igt@i915_selftest@live@requests.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-mtlp-8/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@workarounds: - bat-adlm-1: [INCOMPLETE][9] ([i915#4983] / [i915#7677]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/bat-adlm-1/igt@i915_selftest@live@workarounds.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-adlm-1/igt@i915_selftest@live@workarounds.html #### Warnings #### * igt@kms_psr@cursor_plane_move: - bat-rplp-1: [ABORT][11] ([i915#8469] / [i915#8668]) -> [SKIP][12] ([i915#1072]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/bat-rplp-1/igt@kms_psr@cursor_plane_move.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/bat-rplp-1/igt@kms_psr@cursor_plane_move.html [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443 [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677 [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982 [i915#8391]: https://gitlab.freedesktop.org/drm/intel/issues/8391 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 [i915#8469]: https://gitlab.freedesktop.org/drm/intel/issues/8469 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8865]: https://gitlab.freedesktop.org/drm/intel/issues/8865 Build changes ------------- * Linux: CI_DRM_13562 -> Patchwork_122841v1 CI-20190529: 20190529 CI_DRM_13562: 6cd46255547ba72bb6cc6aab91c905b1dec95696 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7451: 5d48d1fb231f449fe2f80cda14ea7a1ecfda59fa @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_122841v1: 6cd46255547ba72bb6cc6aab91c905b1dec95696 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits cc68fa312d8a media: cec: core: add note about *_from_edid() function usage in drm 958e2a13a7ea drm/i915/cec: switch to setting physical address directly 6917765822c0 drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 23826a357a1c drm/edid: parse source physical address 6b8a090203fa drm/i915/display: use drm_edid_is_digital() 95c1b6c89253 drm/edid: add drm_edid_is_digital() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/index.html [-- Attachment #2: Type: text/html, Size: 5725 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm, cec and edid updates 2023-08-24 13:46 ` Jani Nikula ` (9 preceding siblings ...) (?) @ 2023-08-25 9:10 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-25 9:10 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 66333 bytes --] == Series Details == Series: drm, cec and edid updates URL : https://patchwork.freedesktop.org/series/122841/ State : success == Summary == CI Bug Log - changes from CI_DRM_13562_full -> Patchwork_122841v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (9 -> 9) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_122841v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@api_intel_bb@crc32: - shard-tglu: NOTRUN -> [SKIP][1] ([i915#6230]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@api_intel_bb@crc32.html * igt@api_intel_bb@render-ccs: - shard-dg2: NOTRUN -> [FAIL][2] ([i915#6122]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@api_intel_bb@render-ccs.html * igt@device_reset@cold-reset-bound: - shard-dg2: NOTRUN -> [SKIP][3] ([i915#7701]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@device_reset@cold-reset-bound.html * igt@device_reset@unbind-cold-reset-rebind: - shard-tglu: NOTRUN -> [SKIP][4] ([i915#7701]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@device_reset@unbind-cold-reset-rebind.html * igt@drm_fdinfo@busy-idle@bcs0: - shard-dg2: NOTRUN -> [SKIP][5] ([i915#8414]) +21 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@drm_fdinfo@busy-idle@bcs0.html * igt@feature_discovery@chamelium: - shard-dg2: NOTRUN -> [SKIP][6] ([i915#4854]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@feature_discovery@chamelium.html * igt@gem_basic@multigpu-create-close: - shard-tglu: NOTRUN -> [SKIP][7] ([i915#7697]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-8/igt@gem_basic@multigpu-create-close.html * igt@gem_busy@semaphore: - shard-dg2: NOTRUN -> [SKIP][8] ([i915#3936]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_busy@semaphore.html * igt@gem_caching@writes: - shard-mtlp: NOTRUN -> [SKIP][9] ([i915#4873]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-5/igt@gem_caching@writes.html * igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0: - shard-dg2: NOTRUN -> [INCOMPLETE][10] ([i915#6311] / [i915#7297]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0.html * igt@gem_close_race@multigpu-basic-process: - shard-dg2: NOTRUN -> [SKIP][11] ([i915#7697]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@gem_close_race@multigpu-basic-process.html * igt@gem_ctx_persistence@hang: - shard-dg2: NOTRUN -> [SKIP][12] ([i915#8555]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gem_ctx_persistence@hang.html * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#1099]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_ctx_persistence@saturated-hostile-nopreempt@vcs1: - shard-mtlp: NOTRUN -> [SKIP][14] ([i915#5882]) +5 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@gem_ctx_persistence@saturated-hostile-nopreempt@vcs1.html * igt@gem_ctx_sseu@invalid-args: - shard-rkl: NOTRUN -> [SKIP][15] ([i915#280]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@gem_ctx_sseu@invalid-args.html * igt@gem_eio@in-flight-contexts-immediate: - shard-mtlp: [PASS][16] -> [ABORT][17] ([i915#8503]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-5/igt@gem_eio@in-flight-contexts-immediate.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-7/igt@gem_eio@in-flight-contexts-immediate.html * igt@gem_eio@reset-stress: - shard-dg1: [PASS][18] -> [FAIL][19] ([i915#5784]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg1-19/igt@gem_eio@reset-stress.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-13/igt@gem_eio@reset-stress.html * igt@gem_exec_balancer@bonded-sync: - shard-dg2: NOTRUN -> [SKIP][20] ([i915#4771]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@gem_exec_balancer@bonded-sync.html * igt@gem_exec_capture@capture-recoverable: - shard-tglu: NOTRUN -> [SKIP][21] ([i915#6344]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@gem_exec_capture@capture-recoverable.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-rkl: [PASS][22] -> [FAIL][23] ([i915#2842]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-4/igt@gem_exec_fair@basic-pace@vcs0.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-6/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-sync: - shard-mtlp: NOTRUN -> [SKIP][24] ([i915#4473] / [i915#4771]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@gem_exec_fair@basic-sync.html * igt@gem_exec_fence@submit67: - shard-dg2: NOTRUN -> [SKIP][25] ([i915#4812]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@gem_exec_fence@submit67.html * igt@gem_exec_flush@basic-wb-rw-default: - shard-dg2: NOTRUN -> [SKIP][26] ([i915#3539] / [i915#4852]) +4 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@gem_exec_flush@basic-wb-rw-default.html * igt@gem_exec_reloc@basic-write-read-active: - shard-dg2: NOTRUN -> [SKIP][27] ([i915#3281]) +6 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@gem_exec_reloc@basic-write-read-active.html * igt@gem_exec_schedule@preempt-queue-contexts-chain: - shard-dg2: NOTRUN -> [SKIP][28] ([i915#4537] / [i915#4812]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gem_exec_schedule@preempt-queue-contexts-chain.html * igt@gem_exec_suspend@basic-s4-devices@smem: - shard-tglu: [PASS][29] -> [ABORT][30] ([i915#7975] / [i915#8213]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-tglu-5/igt@gem_exec_suspend@basic-s4-devices@smem.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html * igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible: - shard-dg2: NOTRUN -> [SKIP][31] ([i915#4860]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible.html * igt@gem_lmem_swapping@heavy-verify-random-ccs: - shard-tglu: NOTRUN -> [SKIP][32] ([i915#4613]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@gem_lmem_swapping@heavy-verify-random-ccs.html * igt@gem_media_fill@media-fill: - shard-dg2: NOTRUN -> [SKIP][33] ([i915#8289]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_media_fill@media-fill.html * igt@gem_mmap_gtt@basic-copy: - shard-mtlp: NOTRUN -> [SKIP][34] ([i915#4077]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@gem_mmap_gtt@basic-copy.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-dg2: NOTRUN -> [SKIP][35] ([i915#4077]) +9 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_mmap_wc@copy: - shard-dg2: NOTRUN -> [SKIP][36] ([i915#4083]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_mmap_wc@copy.html * igt@gem_partial_pwrite_pread@reads-uncached: - shard-dg2: NOTRUN -> [SKIP][37] ([i915#3282]) +6 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_partial_pwrite_pread@reads-uncached.html * igt@gem_partial_pwrite_pread@writes-after-reads-uncached: - shard-rkl: NOTRUN -> [SKIP][38] ([i915#3282]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html * igt@gem_pread@exhaustion: - shard-snb: NOTRUN -> [WARN][39] ([i915#2658]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@gem_pread@exhaustion.html * igt@gem_pxp@protected-encrypted-src-copy-not-readible: - shard-dg2: NOTRUN -> [SKIP][40] ([i915#4270]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gem_pxp@protected-encrypted-src-copy-not-readible.html * igt@gem_pxp@verify-pxp-stale-buf-execution: - shard-rkl: NOTRUN -> [SKIP][41] ([i915#4270]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@gem_pxp@verify-pxp-stale-buf-execution.html * igt@gem_pxp@verify-pxp-stale-ctx-execution: - shard-tglu: NOTRUN -> [SKIP][42] ([i915#4270]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-8/igt@gem_pxp@verify-pxp-stale-ctx-execution.html * igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled: - shard-dg2: NOTRUN -> [SKIP][43] ([i915#5190]) +12 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled.html * igt@gem_softpin@evict-snoop: - shard-dg2: NOTRUN -> [SKIP][44] ([i915#4885]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_softpin@evict-snoop.html * igt@gem_tiled_pread_basic: - shard-dg2: NOTRUN -> [SKIP][45] ([i915#4079]) +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_tiled_pread_basic.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap: - shard-dg2: NOTRUN -> [SKIP][46] ([i915#3297] / [i915#4880]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@gem_userptr_blits@map-fixed-invalidate-overlap.html * igt@gem_userptr_blits@readonly-pwrite-unsync: - shard-dg2: NOTRUN -> [SKIP][47] ([i915#3297]) +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@gem_userptr_blits@readonly-pwrite-unsync.html * igt@gem_userptr_blits@sd-probe: - shard-dg2: NOTRUN -> [SKIP][48] ([i915#3297] / [i915#4958]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@gem_userptr_blits@sd-probe.html * igt@gem_workarounds@suspend-resume-fd: - shard-snb: NOTRUN -> [DMESG-WARN][49] ([i915#8841]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@gem_workarounds@suspend-resume-fd.html * igt@gen3_render_mixed_blits: - shard-mtlp: NOTRUN -> [SKIP][50] ([fdo#109289]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@gen3_render_mixed_blits.html * igt@gen3_render_tiledy_blits: - shard-tglu: NOTRUN -> [SKIP][51] ([fdo#109289]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@gen3_render_tiledy_blits.html * igt@gen7_exec_parse@oacontrol-tracking: - shard-dg2: NOTRUN -> [SKIP][52] ([fdo#109289]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@gen7_exec_parse@oacontrol-tracking.html * igt@gen9_exec_parse@allowed-single: - shard-dg2: NOTRUN -> [SKIP][53] ([i915#2856]) +4 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@bb-start-far: - shard-tglu: NOTRUN -> [SKIP][54] ([i915#2527] / [i915#2856]) +1 similar issue [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@gen9_exec_parse@bb-start-far.html * igt@i915_pm_backlight@bad-brightness: - shard-tglu: NOTRUN -> [SKIP][55] ([i915#7561]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@i915_pm_backlight@bad-brightness.html * igt@i915_pm_backlight@fade-with-dpms: - shard-rkl: NOTRUN -> [SKIP][56] ([i915#7561]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@i915_pm_backlight@fade-with-dpms.html * igt@i915_pm_dc@dc9-dpms: - shard-tglu: NOTRUN -> [SKIP][57] ([i915#4281]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rpm@modeset-lpsp: - shard-dg2: NOTRUN -> [SKIP][58] ([i915#1397]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_pm_rpm@modeset-pc8-residency-stress: - shard-dg2: NOTRUN -> [SKIP][59] ([fdo#109506]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@i915_pm_rpm@modeset-pc8-residency-stress.html * igt@i915_pm_rps@thresholds-park@gt0: - shard-dg2: NOTRUN -> [SKIP][60] ([i915#8925]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@i915_pm_rps@thresholds-park@gt0.html * igt@i915_query@query-topology-known-pci-ids: - shard-tglu: NOTRUN -> [SKIP][61] ([fdo#109303]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@i915_query@query-topology-known-pci-ids.html * igt@i915_suspend@sysfs-reader: - shard-mtlp: [PASS][62] -> [ABORT][63] ([i915#6311] / [i915#8466]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-1/igt@i915_suspend@sysfs-reader.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-1/igt@i915_suspend@sysfs-reader.html * igt@kms_addfb_basic@basic-y-tiled-legacy: - shard-dg2: NOTRUN -> [SKIP][64] ([i915#4215] / [i915#5190]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_addfb_basic@basic-y-tiled-legacy.html * igt@kms_addfb_basic@framebuffer-vs-set-tiling: - shard-dg2: NOTRUN -> [SKIP][65] ([i915#4212]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs: - shard-dg2: NOTRUN -> [SKIP][66] ([i915#8502] / [i915#8709]) +11 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-6/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-mtlp: NOTRUN -> [SKIP][67] ([i915#1769]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels: - shard-snb: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#1769]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-tglu: NOTRUN -> [SKIP][69] ([fdo#111615] / [i915#5286]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-mtlp: [PASS][70] -> [FAIL][71] ([i915#5138]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-6/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip: - shard-rkl: NOTRUN -> [SKIP][72] ([i915#5286]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip.html * igt@kms_big_fb@linear-32bpp-rotate-90: - shard-mtlp: NOTRUN -> [SKIP][73] ([fdo#111614]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_big_fb@linear-32bpp-rotate-90.html * igt@kms_big_fb@x-tiled-16bpp-rotate-270: - shard-dg2: NOTRUN -> [SKIP][74] ([fdo#111614]) +4 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html * igt@kms_big_fb@x-tiled-16bpp-rotate-90: - shard-tglu: NOTRUN -> [SKIP][75] ([fdo#111614]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html * igt@kms_big_fb@x-tiled-32bpp-rotate-270: - shard-rkl: NOTRUN -> [SKIP][76] ([fdo#111614] / [i915#3638]) +1 similar issue [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-180: - shard-dg2: NOTRUN -> [SKIP][77] ([i915#4538] / [i915#5190]) +4 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-270: - shard-tglu: NOTRUN -> [SKIP][78] ([fdo#111615]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip: - shard-mtlp: NOTRUN -> [SKIP][79] ([fdo#111615]) +3 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html * igt@kms_ccs@pipe-a-bad-rotation-90-4_tiled_dg2_rc_ccs: - shard-rkl: NOTRUN -> [SKIP][80] ([i915#5354] / [i915#6095]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_ccs@pipe-a-bad-rotation-90-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs: - shard-dg2: NOTRUN -> [SKIP][81] ([i915#3689] / [i915#5354]) +20 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs.html * igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs: - shard-dg2: NOTRUN -> [SKIP][82] ([i915#3689] / [i915#3886] / [i915#5354]) +8 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs: - shard-mtlp: NOTRUN -> [SKIP][83] ([i915#6095]) +3 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-7/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html * igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs: - shard-tglu: NOTRUN -> [SKIP][84] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs: - shard-tglu: NOTRUN -> [SKIP][85] ([i915#3689] / [i915#5354] / [i915#6095]) +4 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-mtlp: NOTRUN -> [SKIP][86] ([i915#3886] / [i915#6095]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-7/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs: - shard-tglu: NOTRUN -> [SKIP][87] ([i915#5354] / [i915#6095]) +8 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs: - shard-rkl: NOTRUN -> [SKIP][88] ([i915#5354]) +3 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html * igt@kms_cdclk@mode-transition-all-outputs: - shard-tglu: NOTRUN -> [SKIP][89] ([i915#3742]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_cdclk@mode-transition-all-outputs.html * igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2: - shard-dg2: NOTRUN -> [SKIP][90] ([i915#7213]) +3 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2.html * igt@kms_cdclk@plane-scaling@pipe-c-dp-2: - shard-dg2: NOTRUN -> [SKIP][91] ([i915#4087]) +3 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@kms_cdclk@plane-scaling@pipe-c-dp-2.html * igt@kms_chamelium_color@gamma: - shard-dg2: NOTRUN -> [SKIP][92] ([fdo#111827]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_chamelium_color@gamma.html * igt@kms_chamelium_edid@hdmi-edid-stress-resolution-non-4k: - shard-dg2: NOTRUN -> [SKIP][93] ([i915#7828]) +11 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@kms_chamelium_edid@hdmi-edid-stress-resolution-non-4k.html * igt@kms_chamelium_hpd@hdmi-hpd: - shard-mtlp: NOTRUN -> [SKIP][94] ([i915#7828]) +1 similar issue [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_chamelium_hpd@hdmi-hpd.html * igt@kms_chamelium_hpd@hdmi-hpd-for-each-pipe: - shard-tglu: NOTRUN -> [SKIP][95] ([i915#7828]) +1 similar issue [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_chamelium_hpd@hdmi-hpd-for-each-pipe.html * igt@kms_content_protection@atomic: - shard-dg2: NOTRUN -> [SKIP][96] ([i915#7118]) +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_content_protection@atomic.html * igt@kms_content_protection@dp-mst-type-1: - shard-dg2: NOTRUN -> [SKIP][97] ([i915#3299]) +1 similar issue [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_content_protection@dp-mst-type-1.html * igt@kms_content_protection@legacy@pipe-a-dp-2: - shard-dg2: NOTRUN -> [TIMEOUT][98] ([i915#7173]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@kms_content_protection@legacy@pipe-a-dp-2.html * igt@kms_content_protection@mei_interface: - shard-tglu: NOTRUN -> [SKIP][99] ([i915#6944] / [i915#7116] / [i915#7118]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-8/igt@kms_content_protection@mei_interface.html * igt@kms_cursor_crc@cursor-offscreen-512x170: - shard-dg2: NOTRUN -> [SKIP][100] ([i915#3359]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_cursor_crc@cursor-offscreen-512x170.html * igt@kms_cursor_crc@cursor-onscreen-512x512: - shard-tglu: NOTRUN -> [SKIP][101] ([i915#3359]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_cursor_crc@cursor-onscreen-512x512.html * igt@kms_cursor_crc@cursor-onscreen-max-size: - shard-rkl: NOTRUN -> [SKIP][102] ([i915#3555]) +1 similar issue [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_cursor_crc@cursor-onscreen-max-size.html * igt@kms_cursor_crc@cursor-random-512x170: - shard-rkl: NOTRUN -> [SKIP][103] ([i915#3359]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_cursor_crc@cursor-random-512x170.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic: - shard-dg2: NOTRUN -> [SKIP][104] ([fdo#109274] / [fdo#111767] / [i915#5354]) +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic: - shard-dg2: NOTRUN -> [SKIP][105] ([fdo#109274] / [i915#5354]) +7 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions: - shard-rkl: NOTRUN -> [SKIP][106] ([i915#4103]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size: - shard-dg2: NOTRUN -> [SKIP][107] ([i915#4103] / [i915#4213]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html * igt@kms_display_modes@mst-extended-mode-negative: - shard-dg2: NOTRUN -> [SKIP][108] ([i915#8588]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_display_modes@mst-extended-mode-negative.html * igt@kms_dither@fb-8bpc-vs-panel-8bpc: - shard-dg2: NOTRUN -> [SKIP][109] ([i915#3555]) +7 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-6/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html * igt@kms_dsc@dsc-with-output-formats: - shard-dg2: NOTRUN -> [SKIP][110] ([i915#3555] / [i915#3840]) +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_dsc@dsc-with-output-formats.html * igt@kms_fbcon_fbt@psr-suspend: - shard-dg2: NOTRUN -> [SKIP][111] ([i915#3469]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_fence_pin_leak: - shard-dg2: NOTRUN -> [SKIP][112] ([i915#4881]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_fence_pin_leak.html * igt@kms_flip@2x-flip-vs-blocking-wf-vblank: - shard-snb: NOTRUN -> [SKIP][113] ([fdo#109271] / [fdo#111767]) +1 similar issue [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@kms_flip@2x-flip-vs-blocking-wf-vblank.html * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible: - shard-mtlp: NOTRUN -> [SKIP][114] ([i915#3637]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html * igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][115] -> [FAIL][116] ([i915#2122]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html * igt@kms_flip@2x-flip-vs-rmfb-interruptible: - shard-dg2: NOTRUN -> [SKIP][117] ([fdo#109274] / [fdo#111767]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-11/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible: - shard-tglu: NOTRUN -> [SKIP][118] ([fdo#109274] / [i915#3637]) +1 similar issue [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html * igt@kms_flip@2x-modeset-vs-vblank-race: - shard-dg2: NOTRUN -> [SKIP][119] ([fdo#109274]) +7 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_flip@2x-modeset-vs-vblank-race.html * igt@kms_flip@flip-vs-fences: - shard-dg2: NOTRUN -> [SKIP][120] ([i915#8381]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_flip@flip-vs-fences.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode: - shard-tglu: NOTRUN -> [SKIP][121] ([i915#2587] / [i915#2672]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][122] ([i915#2672]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][123] ([i915#8810]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-valid-mode: - shard-dg2: NOTRUN -> [SKIP][124] ([i915#2672]) +4 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-valid-mode.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc: - shard-dg2: NOTRUN -> [SKIP][125] ([i915#8708]) +24 similar issues [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite: - shard-dg2: [PASS][126] -> [FAIL][127] ([i915#6880]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render: - shard-tglu: NOTRUN -> [SKIP][128] ([fdo#109280]) +12 similar issues [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu: - shard-mtlp: NOTRUN -> [SKIP][129] ([i915#1825]) +4 similar issues [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu: - shard-dg2: NOTRUN -> [SKIP][130] ([i915#3458]) +13 similar issues [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render: - shard-dg2: NOTRUN -> [SKIP][131] ([i915#5354]) +46 similar issues [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt: - shard-tglu: NOTRUN -> [SKIP][132] ([fdo#110189]) +9 similar issues [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-tiling-y: - shard-mtlp: NOTRUN -> [SKIP][133] ([i915#5460]) [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-pgflip-blt: - shard-rkl: NOTRUN -> [SKIP][134] ([fdo#111825] / [i915#1825]) +3 similar issues [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary: - shard-rkl: NOTRUN -> [SKIP][135] ([i915#3023]) +1 similar issue [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html * igt@kms_hdr@invalid-metadata-sizes: - shard-dg2: NOTRUN -> [SKIP][136] ([i915#3555] / [i915#8228]) +1 similar issue [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_hdr@invalid-metadata-sizes.html * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1: - shard-apl: [PASS][137] -> [ABORT][138] ([i915#180]) [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1.html * igt@kms_plane_lowres@tiling-yf: - shard-dg2: NOTRUN -> [SKIP][139] ([i915#3555] / [i915#8821]) [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@kms_plane_lowres@tiling-yf.html * igt@kms_plane_scaling@intel-max-src-size: - shard-dg2: NOTRUN -> [SKIP][140] ([i915#6953]) [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-6/igt@kms_plane_scaling@intel-max-src-size.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][141] ([i915#5176]) +5 similar issues [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html - shard-dg1: NOTRUN -> [SKIP][142] ([i915#5176]) +15 similar issues [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-19/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-c-hdmi-a-2: - shard-dg2: NOTRUN -> [SKIP][143] ([i915#5176]) +7 similar issues [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-c-hdmi-a-2.html * igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-c-dp-2: - shard-dg2: NOTRUN -> [SKIP][144] ([i915#5235]) +7 similar issues [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-c-dp-2.html * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][145] ([i915#5235]) +1 similar issue [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1.html * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-1: - shard-dg1: NOTRUN -> [SKIP][146] ([i915#5235]) +11 similar issues [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-19/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_prime@basic-modeset-hybrid: - shard-dg2: NOTRUN -> [SKIP][147] ([i915#6524] / [i915#6805]) [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_prime@basic-modeset-hybrid.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area: - shard-dg2: NOTRUN -> [SKIP][148] ([i915#658]) +3 similar issues [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb: - shard-tglu: NOTRUN -> [SKIP][149] ([i915#658]) [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-dg2: NOTRUN -> [SKIP][150] ([i915#1072]) +5 similar issues [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@kms_psr@sprite_mmap_gtt: - shard-rkl: NOTRUN -> [SKIP][151] ([i915#1072]) [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_psr@sprite_mmap_gtt.html * igt@kms_rotation_crc@primary-y-tiled-reflect-x-0: - shard-mtlp: NOTRUN -> [SKIP][152] ([i915#5289]) [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html * igt@kms_rotation_crc@primary-y-tiled-reflect-x-90: - shard-dg2: NOTRUN -> [SKIP][153] ([i915#4235] / [i915#5190]) [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html * igt@kms_rotation_crc@sprite-rotation-90-pos-100-0: - shard-dg2: NOTRUN -> [SKIP][154] ([i915#4235]) [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html * igt@kms_scaling_modes@scaling-mode-none: - shard-tglu: NOTRUN -> [SKIP][155] ([i915#3555]) +1 similar issue [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_scaling_modes@scaling-mode-none.html * igt@kms_selftest@drm_cmdline: - shard-dg2: NOTRUN -> [SKIP][156] ([i915#8661]) +1 similar issue [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_selftest@drm_cmdline.html * igt@kms_selftest@drm_damage: - shard-snb: NOTRUN -> [SKIP][157] ([fdo#109271] / [i915#8661]) +1 similar issue [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@kms_selftest@drm_damage.html * igt@kms_setmode@basic@pipe-a-hdmi-a-1: - shard-snb: NOTRUN -> [FAIL][158] ([i915#5465]) +1 similar issue [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html * igt@kms_tiled_display@basic-test-pattern: - shard-tglu: NOTRUN -> [SKIP][159] ([i915#8623]) [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@kms_tiled_display@basic-test-pattern.html * igt@kms_vblank@pipe-c-query-busy-hang: - shard-snb: NOTRUN -> [SKIP][160] ([fdo#109271]) +272 similar issues [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-snb4/igt@kms_vblank@pipe-c-query-busy-hang.html * igt@kms_vblank@pipe-c-query-forked: - shard-rkl: NOTRUN -> [SKIP][161] ([i915#4070] / [i915#6768]) [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_vblank@pipe-c-query-forked.html * igt@kms_vrr@flip-dpms: - shard-mtlp: NOTRUN -> [SKIP][162] ([i915#8808]) [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@kms_vrr@flip-dpms.html * igt@kms_writeback@writeback-invalid-parameters: - shard-dg2: NOTRUN -> [SKIP][163] ([i915#2437]) [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@kms_writeback@writeback-invalid-parameters.html * igt@perf@global-sseu-config-invalid: - shard-dg2: NOTRUN -> [SKIP][164] ([i915#7387]) [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-12/igt@perf@global-sseu-config-invalid.html * igt@perf@non-zero-reason@0-rcs0: - shard-dg2: NOTRUN -> [FAIL][165] ([i915#7484]) [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-1/igt@perf@non-zero-reason@0-rcs0.html * igt@perf_pmu@module-unload: - shard-dg2: NOTRUN -> [FAIL][166] ([i915#5793] / [i915#6121]) [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@perf_pmu@module-unload.html * igt@tools_test@sysfs_l3_parity: - shard-tglu: NOTRUN -> [SKIP][167] ([fdo#109307]) [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@tools_test@sysfs_l3_parity.html * igt@v3d/v3d_create_bo@create-bo-invalid-flags: - shard-rkl: NOTRUN -> [SKIP][168] ([fdo#109315]) +2 similar issues [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@v3d/v3d_create_bo@create-bo-invalid-flags.html * igt@v3d/v3d_submit_csd@job-perfmon: - shard-tglu: NOTRUN -> [SKIP][169] ([fdo#109315] / [i915#2575]) +2 similar issues [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@v3d/v3d_submit_csd@job-perfmon.html * igt@v3d/v3d_submit_csd@single-out-sync: - shard-dg2: NOTRUN -> [SKIP][170] ([i915#2575]) +13 similar issues [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@v3d/v3d_submit_csd@single-out-sync.html * igt@v3d/v3d_wait_bo@unused-bo-0ns: - shard-mtlp: NOTRUN -> [SKIP][171] ([i915#2575]) +1 similar issue [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@v3d/v3d_wait_bo@unused-bo-0ns.html * igt@vc4/vc4_perfmon@create-two-perfmon: - shard-mtlp: NOTRUN -> [SKIP][172] ([i915#7711]) [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-7/igt@vc4/vc4_perfmon@create-two-perfmon.html * igt@vc4/vc4_wait_bo@unused-bo-1ns: - shard-dg2: NOTRUN -> [SKIP][173] ([i915#7711]) +7 similar issues [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@vc4/vc4_wait_bo@unused-bo-1ns.html * igt@vc4/vc4_wait_bo@used-bo: - shard-tglu: NOTRUN -> [SKIP][174] ([i915#2575]) +2 similar issues [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@vc4/vc4_wait_bo@used-bo.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-dg2: [FAIL][175] ([fdo#103375]) -> [PASS][176] +1 similar issue [175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg2-5/igt@gem_ctx_isolation@preservation-s3@bcs0.html [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-6/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_eio@hibernate: - shard-tglu: [ABORT][177] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][178] [177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-tglu-10/igt@gem_eio@hibernate.html [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-6/igt@gem_eio@hibernate.html * igt@gem_exec_capture@capture@vcs1-smem: - shard-mtlp: [DMESG-WARN][179] ([i915#5591]) -> [PASS][180] [179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-3/igt@gem_exec_capture@capture@vcs1-smem.html [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-3/igt@gem_exec_capture@capture@vcs1-smem.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][181] ([i915#2846]) -> [PASS][182] [181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-glk6/igt@gem_exec_fair@basic-deadline.html [182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-glk4/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-rkl: [FAIL][183] ([i915#2842]) -> [PASS][184] [183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-7/igt@gem_exec_fair@basic-pace-share@rcs0.html [184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html - shard-tglu: [FAIL][185] ([i915#2842]) -> [PASS][186] [185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html [186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [FAIL][187] ([i915#2842]) -> [PASS][188] [187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html [188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_schedule@noreorder-priority@ccs0: - shard-mtlp: [DMESG-FAIL][189] ([i915#9121]) -> [PASS][190] [189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-4/igt@gem_exec_schedule@noreorder-priority@ccs0.html [190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-5/igt@gem_exec_schedule@noreorder-priority@ccs0.html * igt@i915_module_load@reload-with-fault-injection: - shard-mtlp: [ABORT][191] ([i915#8489] / [i915#8668]) -> [PASS][192] [191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-2/igt@i915_module_load@reload-with-fault-injection.html [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-4/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_rpm@dpms-mode-unset-lpsp: - shard-dg1: [SKIP][193] ([i915#1397]) -> [PASS][194] [193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg1-14/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-19/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp: - shard-dg2: [SKIP][195] ([i915#1397]) -> [PASS][196] +1 similar issue [195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg2-12/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html [196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-2/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html - shard-rkl: [SKIP][197] ([i915#1397]) -> [PASS][198] [197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html [198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1: - shard-mtlp: [FAIL][199] ([i915#2521]) -> [PASS][200] [199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-7/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html [200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-5/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html * igt@kms_big_fb@4-tiled-64bpp-rotate-180: - shard-mtlp: [FAIL][201] ([i915#5138]) -> [PASS][202] [201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-5/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html [202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-3/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size: - shard-mtlp: [FAIL][203] ([i915#8248]) -> [PASS][204] [203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-5/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html [204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-apl: [FAIL][205] ([i915#2346]) -> [PASS][206] [205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-dg1: [FAIL][207] ([fdo#103375]) -> [PASS][208] [207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg1-18/igt@kms_fbcon_fbt@fbc-suspend.html [208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-15/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_getfb@getfb-addfb-different-handles: - shard-mtlp: [DMESG-WARN][209] ([i915#2017] / [i915#9157]) -> [PASS][210] [209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-3/igt@kms_getfb@getfb-addfb-different-handles.html [210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-3/igt@kms_getfb@getfb-addfb-different-handles.html * igt@kms_rotation_crc@sprite-rotation-90: - shard-rkl: [ABORT][211] ([i915#8178]) -> [PASS][212] [211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-4/igt@kms_rotation_crc@sprite-rotation-90.html [212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-4/igt@kms_rotation_crc@sprite-rotation-90.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-idle@bcs0: - shard-tglu: [WARN][213] ([i915#2681]) -> [FAIL][214] ([i915#2681] / [i915#3591]) [213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-tglu-6/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html [214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-9/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html * igt@i915_pm_rc6_residency@rc6-idle@vcs0: - shard-tglu: [FAIL][215] ([i915#2681] / [i915#3591]) -> [WARN][216] ([i915#2681]) [215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-tglu-6/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html [216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-tglu-9/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html * igt@kms_content_protection@type1: - shard-dg2: [SKIP][217] ([i915#7118] / [i915#7162]) -> [SKIP][218] ([i915#7118]) [217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg2-12/igt@kms_content_protection@type1.html [218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg2-3/igt@kms_content_protection@type1.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-mtlp: [FAIL][219] ([i915#2346]) -> [DMESG-FAIL][220] ([i915#1982] / [i915#2017] / [i915#5954]) [219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@psr: - shard-rkl: [SKIP][221] ([fdo#110189] / [i915#3955]) -> [SKIP][222] ([i915#3955]) [221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-1/igt@kms_fbcon_fbt@psr.html [222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-3/igt@kms_fbcon_fbt@psr.html * igt@kms_force_connector_basic@force-load-detect: - shard-rkl: [SKIP][223] ([fdo#109285] / [i915#4098]) -> [SKIP][224] ([fdo#109285]) [223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-4/igt@kms_force_connector_basic@force-load-detect.html [224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-6/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_multipipe_modeset@basic-max-pipe-crc-check: - shard-rkl: [SKIP][225] ([i915#4816]) -> [SKIP][226] ([i915#4070] / [i915#4816]) [225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html [226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html * igt@kms_psr@primary_mmap_gtt: - shard-dg1: [SKIP][227] ([i915#1072] / [i915#4078]) -> [SKIP][228] ([i915#1072]) [227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg1-16/igt@kms_psr@primary_mmap_gtt.html [228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-15/igt@kms_psr@primary_mmap_gtt.html * igt@kms_psr@primary_page_flip: - shard-dg1: [SKIP][229] ([i915#1072]) -> [SKIP][230] ([i915#1072] / [i915#4078]) [229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-dg1-19/igt@kms_psr@primary_page_flip.html [230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-dg1-13/igt@kms_psr@primary_page_flip.html * igt@syncobj_timeline@invalid-wait-illegal-handle: - shard-mtlp: [DMESG-WARN][231] ([i915#2017]) -> [DMESG-WARN][232] ([i915#9157]) [231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13562/shard-mtlp-3/igt@syncobj_timeline@invalid-wait-illegal-handle.html [232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/shard-mtlp-3/igt@syncobj_timeline@invalid-wait-illegal-handle.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473 [i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885 [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5460]: https://gitlab.freedesktop.org/drm/intel/issues/5460 [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465 [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5793]: https://gitlab.freedesktop.org/drm/intel/issues/5793 [i915#5882]: https://gitlab.freedesktop.org/drm/intel/issues/5882 [i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121 [i915#6122]: https://gitlab.freedesktop.org/drm/intel/issues/6122 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311 [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805 [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162 [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173 [i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213 [i915#7297]: https://gitlab.freedesktop.org/drm/intel/issues/7297 [i915#7387]: https://gitlab.freedesktop.org/drm/intel/issues/7387 [i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 [i915#8178]: https://gitlab.freedesktop.org/drm/intel/issues/8178 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248 [i915#8289]: https://gitlab.freedesktop.org/drm/intel/issues/8289 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 [i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8466]: https://gitlab.freedesktop.org/drm/intel/issues/8466 [i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489 [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502 [i915#8503]: https://gitlab.freedesktop.org/drm/intel/issues/8503 [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555 [i915#8588]: https://gitlab.freedesktop.org/drm/intel/issues/8588 [i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623 [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709 [i915#8808]: https://gitlab.freedesktop.org/drm/intel/issues/8808 [i915#8810]: https://gitlab.freedesktop.org/drm/intel/issues/8810 [i915#8821]: https://gitlab.freedesktop.org/drm/intel/issues/8821 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 [i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925 [i915#9121]: https://gitlab.freedesktop.org/drm/intel/issues/9121 [i915#9157]: https://gitlab.freedesktop.org/drm/intel/issues/9157 Build changes ------------- * Linux: CI_DRM_13562 -> Patchwork_122841v1 CI-20190529: 20190529 CI_DRM_13562: 6cd46255547ba72bb6cc6aab91c905b1dec95696 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7451: 5d48d1fb231f449fe2f80cda14ea7a1ecfda59fa @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_122841v1: 6cd46255547ba72bb6cc6aab91c905b1dec95696 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v1/index.html [-- Attachment #2: Type: text/html, Size: 79026 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, cec and edid updates (rev2) 2023-08-24 13:46 ` Jani Nikula ` (10 preceding siblings ...) (?) @ 2023-08-25 16:17 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-25 16:17 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm, cec and edid updates (rev2) URL : https://patchwork.freedesktop.org/series/122841/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm, cec and edid updates (rev2) 2023-08-24 13:46 ` Jani Nikula ` (11 preceding siblings ...) (?) @ 2023-08-25 16:35 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-25 16:35 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 5454 bytes --] == Series Details == Series: drm, cec and edid updates (rev2) URL : https://patchwork.freedesktop.org/series/122841/ State : success == Summary == CI Bug Log - changes from CI_DRM_13568 -> Patchwork_122841v2 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/index.html Participating hosts (40 -> 40) ------------------------------ Additional (1): fi-kbl-soraka Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_122841v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0@smem: - bat-dg2-9: [PASS][1] -> [INCOMPLETE][2] ([i915#6311]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_huc_copy@huc-copy: - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html * igt@i915_selftest@live@gt_heartbeat: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#5334] / [i915#7872]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html - fi-apl-guc: [PASS][6] -> [DMESG-FAIL][7] ([i915#5334]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#7913]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271]) +8 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/fi-kbl-soraka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_psr@primary_page_flip: - bat-rplp-1: NOTRUN -> [SKIP][10] ([i915#1072]) +3 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/bat-rplp-1/igt@kms_psr@primary_page_flip.html * igt@kms_setmode@basic-clone-single-crtc: - bat-rplp-1: NOTRUN -> [ABORT][11] ([i915#8260] / [i915#8668]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html #### Possible fixes #### * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1: - bat-rplp-1: [ABORT][12] ([i915#8442] / [i915#8668]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311 [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8879]: https://gitlab.freedesktop.org/drm/intel/issues/8879 Build changes ------------- * Linux: CI_DRM_13568 -> Patchwork_122841v2 CI-20190529: 20190529 CI_DRM_13568: f8b90de70ee92dbdebc6f2078e2edd12756d7a63 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7453: 7453 Patchwork_122841v2: f8b90de70ee92dbdebc6f2078e2edd12756d7a63 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 6b240a830c68 media: cec: core: add note about *_from_edid() function usage in drm 92f5df8d301e drm/i915/cec: switch to setting physical address directly 28ac4d017c25 drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 88427522b18e drm/edid: parse source physical address 9d0173b6ed71 drm/i915/display: use drm_edid_is_digital() 8e6cc5160f44 drm/edid: add drm_edid_is_digital() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/index.html [-- Attachment #2: Type: text/html, Size: 6456 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm, cec and edid updates (rev2) 2023-08-24 13:46 ` Jani Nikula ` (12 preceding siblings ...) (?) @ 2023-08-26 8:15 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-26 8:15 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 49111 bytes --] == Series Details == Series: drm, cec and edid updates (rev2) URL : https://patchwork.freedesktop.org/series/122841/ State : success == Summary == CI Bug Log - changes from CI_DRM_13568_full -> Patchwork_122841v2_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (9 -> 9) ------------------------------ No changes in participating hosts New tests --------- New tests have been introduced between CI_DRM_13568_full and Patchwork_122841v2_full: ### New IGT tests (7) ### * igt@kms_flip@dpms-off-confusion@a-hdmi-a3: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@dpms-off-confusion@b-hdmi-a3: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@dpms-off-confusion@c-hdmi-a3: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_invalid_mode@zero-hdisplay@hdmi-a-3-pipe-a: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_invalid_mode@zero-hdisplay@hdmi-a-3-pipe-b: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_invalid_mode@zero-hdisplay@hdmi-a-3-pipe-c: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_invalid_mode@zero-hdisplay@hdmi-a-3-pipe-d: - Statuses : 1 pass(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in Patchwork_122841v2_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_fdinfo@virtual-busy-all: - shard-mtlp: NOTRUN -> [SKIP][1] ([i915#8414]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@drm_fdinfo@virtual-busy-all.html * igt@drm_mm@drm_mm_test: - shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#8661]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb5/igt@drm_mm@drm_mm_test.html - shard-dg2: NOTRUN -> [SKIP][3] ([i915#8661]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@drm_mm@drm_mm_test.html * igt@gem_caching@reads: - shard-mtlp: NOTRUN -> [SKIP][4] ([i915#4873]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@gem_caching@reads.html * igt@gem_create@create-ext-set-pat: - shard-dg2: NOTRUN -> [SKIP][5] ([i915#8562]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@gem_create@create-ext-set-pat.html * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb5/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2846]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-glk4/igt@gem_exec_fair@basic-deadline.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-glk6/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-rkl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-rkl-1/igt@gem_exec_fair@basic-none-share@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace: - shard-dg2: NOTRUN -> [SKIP][11] ([i915#3539]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@gem_exec_fair@basic-pace.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-glk9/igt@gem_exec_fair@basic-pace@rcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-glk3/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-sync: - shard-mtlp: NOTRUN -> [SKIP][14] ([i915#4473] / [i915#4771]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-7/igt@gem_exec_fair@basic-sync.html * igt@gem_exec_fence@parallel@vecs0: - shard-mtlp: [PASS][15] -> [FAIL][16] ([i915#8957]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-1/igt@gem_exec_fence@parallel@vecs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@gem_exec_fence@parallel@vecs0.html * igt@gem_exec_flush@basic-batch-kernel-default-wb: - shard-mtlp: [PASS][17] -> [DMESG-FAIL][18] ([i915#9121]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-5/igt@gem_exec_flush@basic-batch-kernel-default-wb.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@gem_exec_flush@basic-batch-kernel-default-wb.html * igt@gem_exec_flush@basic-uc-pro-default: - shard-dg2: NOTRUN -> [SKIP][19] ([i915#3539] / [i915#4852]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@gem_exec_flush@basic-uc-pro-default.html * igt@gem_exec_reloc@basic-write-cpu-noreloc: - shard-mtlp: NOTRUN -> [SKIP][20] ([i915#3281]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@gem_exec_reloc@basic-write-cpu-noreloc.html * igt@gem_exec_reloc@basic-write-wc-noreloc: - shard-dg2: NOTRUN -> [SKIP][21] ([i915#3281]) +4 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@gem_exec_reloc@basic-write-wc-noreloc.html * igt@gem_exec_schedule@preempt-engines@ccs0: - shard-mtlp: [PASS][22] -> [FAIL][23] ([i915#9119]) +4 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-5/igt@gem_exec_schedule@preempt-engines@ccs0.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@gem_exec_schedule@preempt-engines@ccs0.html * igt@gem_exec_schedule@preempt-engines@rcs0: - shard-mtlp: [PASS][24] -> [DMESG-FAIL][25] ([i915#8962] / [i915#9121]) +3 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-5/igt@gem_exec_schedule@preempt-engines@rcs0.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@gem_exec_schedule@preempt-engines@rcs0.html * igt@gem_fenced_exec_thrash@2-spare-fences: - shard-dg2: NOTRUN -> [SKIP][26] ([i915#4860]) +3 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@gem_fenced_exec_thrash@2-spare-fences.html * igt@gem_lmem_swapping@heavy-random: - shard-mtlp: NOTRUN -> [SKIP][27] ([i915#4613]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@gem_lmem_swapping@heavy-random.html * igt@gem_lmem_swapping@smem-oom@lmem0: - shard-dg2: NOTRUN -> [TIMEOUT][28] ([i915#5493]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@gem_mmap_gtt@basic-write-read-distinct: - shard-mtlp: NOTRUN -> [SKIP][29] ([i915#4077]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@gem_mmap_gtt@basic-write-read-distinct.html * igt@gem_mmap_gtt@zero-extend: - shard-dg2: NOTRUN -> [SKIP][30] ([i915#4077]) +7 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@gem_mmap_gtt@zero-extend.html * igt@gem_mmap_wc@copy: - shard-dg2: NOTRUN -> [SKIP][31] ([i915#4083]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@gem_mmap_wc@copy.html * igt@gem_ppgtt@blt-vs-render-ctxn: - shard-snb: [PASS][32] -> [DMESG-FAIL][33] ([i915#8295]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-snb2/igt@gem_ppgtt@blt-vs-render-ctxn.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctxn.html * igt@gem_pread@snoop: - shard-mtlp: NOTRUN -> [SKIP][34] ([i915#3282]) +1 similar issue [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-6/igt@gem_pread@snoop.html * igt@gem_pxp@create-regular-context-2: - shard-dg2: NOTRUN -> [SKIP][35] ([i915#4270]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@gem_pxp@create-regular-context-2.html * igt@gem_readwrite@beyond-eob: - shard-dg2: NOTRUN -> [SKIP][36] ([i915#3282]) +2 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@gem_readwrite@beyond-eob.html * igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs: - shard-mtlp: NOTRUN -> [SKIP][37] ([i915#8428]) +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs.html * igt@gem_set_tiling_vs_blt@tiled-to-untiled: - shard-dg2: NOTRUN -> [SKIP][38] ([i915#4079]) +1 similar issue [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html * igt@gem_softpin@noreloc-s3: - shard-dg1: [PASS][39] -> [FAIL][40] ([fdo#103375]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-18/igt@gem_softpin@noreloc-s3.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-13/igt@gem_softpin@noreloc-s3.html * igt@gen3_render_tiledx_blits: - shard-dg2: NOTRUN -> [SKIP][41] ([fdo#109289]) +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@gen3_render_tiledx_blits.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][42] -> [ABORT][43] ([i915#5566]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-apl3/igt@gen9_exec_parse@allowed-single.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-apl7/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@batch-zero-length: - shard-mtlp: NOTRUN -> [SKIP][44] ([i915#2856]) +1 similar issue [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@gen9_exec_parse@batch-zero-length.html * igt@gen9_exec_parse@bb-start-param: - shard-dg2: NOTRUN -> [SKIP][45] ([i915#2856]) +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@gen9_exec_parse@bb-start-param.html * igt@i915_pm_backlight@fade-with-suspend: - shard-dg2: NOTRUN -> [SKIP][46] ([i915#5354] / [i915#7561]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@i915_pm_backlight@fade-with-suspend.html * igt@i915_pm_dc@dc6-dpms: - shard-dg2: NOTRUN -> [SKIP][47] ([i915#5978]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rc6_residency@media-rc6-accuracy: - shard-mtlp: NOTRUN -> [SKIP][48] ([i915#8403]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@i915_pm_rc6_residency@media-rc6-accuracy.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-dg2: [PASS][49] -> [SKIP][50] ([i915#1397]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-1/igt@i915_pm_rpm@modeset-non-lpsp.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp.html - shard-dg1: [PASS][51] -> [SKIP][52] ([i915#1397]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-13/igt@i915_pm_rpm@modeset-non-lpsp.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@i915_pm_sseu@full-enable: - shard-dg2: NOTRUN -> [SKIP][53] ([i915#4387]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@i915_pm_sseu@full-enable.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-snb: NOTRUN -> [DMESG-WARN][54] ([i915#8841]) +4 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb4/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels: - shard-dg2: NOTRUN -> [SKIP][55] ([i915#1769] / [i915#3555]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html * igt@kms_big_fb@linear-32bpp-rotate-270: - shard-dg2: NOTRUN -> [SKIP][56] ([fdo#111614]) +3 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_big_fb@linear-32bpp-rotate-270.html * igt@kms_big_fb@y-tiled-64bpp-rotate-0: - shard-dg2: NOTRUN -> [SKIP][57] ([i915#5190]) +4 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html * igt@kms_big_fb@y-tiled-addfb-size-offset-overflow: - shard-mtlp: NOTRUN -> [SKIP][58] ([i915#6187]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-6/igt@kms_big_fb@y-tiled-addfb-size-offset-overflow.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip: - shard-mtlp: NOTRUN -> [SKIP][59] ([fdo#111615]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-90: - shard-dg2: NOTRUN -> [SKIP][60] ([i915#4538] / [i915#5190]) +3 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html * igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs: - shard-mtlp: NOTRUN -> [SKIP][61] ([i915#3886] / [i915#6095]) +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-7/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs: - shard-mtlp: NOTRUN -> [SKIP][62] ([i915#6095]) +9 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs: - shard-dg2: NOTRUN -> [SKIP][63] ([i915#3689] / [i915#3886] / [i915#5354]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs: - shard-dg2: NOTRUN -> [SKIP][64] ([i915#3689] / [i915#5354]) +10 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html * igt@kms_chamelium_frames@hdmi-crc-multiple: - shard-dg2: NOTRUN -> [SKIP][65] ([i915#7828]) +6 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_chamelium_frames@hdmi-crc-multiple.html * igt@kms_color@deep-color: - shard-rkl: NOTRUN -> [SKIP][66] ([i915#3555]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-6/igt@kms_color@deep-color.html * igt@kms_content_protection@dp-mst-type-1: - shard-dg2: NOTRUN -> [SKIP][67] ([i915#3299]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_content_protection@dp-mst-type-1.html * igt@kms_content_protection@srm@pipe-a-dp-2: - shard-dg2: NOTRUN -> [TIMEOUT][68] ([i915#7173]) +1 similar issue [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-12/igt@kms_content_protection@srm@pipe-a-dp-2.html * igt@kms_content_protection@type1: - shard-dg2: NOTRUN -> [SKIP][69] ([i915#7118]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_content_protection@type1.html * igt@kms_cursor_crc@cursor-offscreen-512x170: - shard-dg2: NOTRUN -> [SKIP][70] ([i915#3359]) +2 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@kms_cursor_crc@cursor-offscreen-512x170.html * igt@kms_cursor_crc@cursor-onscreen-32x10: - shard-mtlp: NOTRUN -> [SKIP][71] ([i915#8814]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_cursor_crc@cursor-onscreen-32x10.html * igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-3: - shard-dg1: NOTRUN -> [FAIL][72] ([fdo#103375]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-13/igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-3.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic: - shard-mtlp: NOTRUN -> [SKIP][73] ([fdo#111767] / [i915#3546]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-6/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: - shard-dg2: NOTRUN -> [SKIP][74] ([fdo#109274] / [i915#5354]) +2 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html * igt@kms_cursor_legacy@cursor-vs-flip-toggle: - shard-mtlp: [PASS][75] -> [FAIL][76] ([i915#8248]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-3/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html * igt@kms_cursor_legacy@cursora-vs-flipb-atomic: - shard-mtlp: NOTRUN -> [SKIP][77] ([i915#3546]) +2 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [PASS][78] -> [FAIL][79] ([i915#2346]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle: - shard-dg2: NOTRUN -> [SKIP][80] ([i915#4103] / [i915#4213]) +1 similar issue [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html * igt@kms_cursor_legacy@single-move@all-pipes: - shard-mtlp: [PASS][81] -> [DMESG-WARN][82] ([i915#2017]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-1/igt@kms_cursor_legacy@single-move@all-pipes.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@kms_cursor_legacy@single-move@all-pipes.html * igt@kms_flip@2x-flip-vs-panning-vs-hang: - shard-dg2: NOTRUN -> [SKIP][83] ([fdo#109274]) +5 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_flip@2x-flip-vs-panning-vs-hang.html * igt@kms_flip@2x-flip-vs-rmfb-interruptible: - shard-dg2: NOTRUN -> [SKIP][84] ([fdo#109274] / [fdo#111767]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html - shard-snb: NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111767]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb5/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode: - shard-dg2: NOTRUN -> [SKIP][86] ([i915#2672]) +3 similar issues [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][87] ([i915#2672]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][88] ([i915#8708]) +2 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc: - shard-dg2: NOTRUN -> [SKIP][89] ([i915#8708]) +7 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbc-badstride: - shard-dg2: NOTRUN -> [FAIL][90] ([i915#6880]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-badstride.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt: - shard-dg2: NOTRUN -> [SKIP][91] ([i915#3458]) +8 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-pwrite: - shard-mtlp: NOTRUN -> [SKIP][92] ([i915#1825]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt: - shard-dg2: NOTRUN -> [SKIP][93] ([i915#5354]) +33 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt.html * igt@kms_hdr@static-swap: - shard-mtlp: NOTRUN -> [SKIP][94] ([i915#8228]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-7/igt@kms_hdr@static-swap.html * igt@kms_hdr@static-toggle-suspend: - shard-dg2: NOTRUN -> [SKIP][95] ([i915#3555] / [i915#8228]) +1 similar issue [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_hdr@static-toggle-suspend.html * igt@kms_panel_fitting@legacy: - shard-dg2: NOTRUN -> [SKIP][96] ([i915#6301]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_panel_fitting@legacy.html * igt@kms_plane@pixel-format-source-clamping@pipe-b-planes: - shard-mtlp: [PASS][97] -> [FAIL][98] ([i915#1623]) +1 similar issue [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-7/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-8/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html * igt@kms_plane_cursor@viewport@pipe-d-edp-1-size-256: - shard-mtlp: [PASS][99] -> [DMESG-WARN][100] ([i915#1982]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-6/igt@kms_plane_cursor@viewport@pipe-d-edp-1-size-256.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-8/igt@kms_plane_cursor@viewport@pipe-d-edp-1-size-256.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-dp-2: - shard-dg2: NOTRUN -> [SKIP][101] ([i915#5176]) +3 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-12/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-dp-2.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-edp-1: - shard-mtlp: NOTRUN -> [SKIP][102] ([i915#5176]) +5 similar issues [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-edp-1.html * igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][103] ([i915#5176]) +1 similar issue [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-7/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][104] ([i915#5176]) +11 similar issues [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-14/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4.html * igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2: - shard-dg2: NOTRUN -> [SKIP][105] ([i915#5235]) +23 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2.html * igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1: - shard-snb: NOTRUN -> [SKIP][106] ([fdo#109271]) +276 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb6/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2: - shard-rkl: NOTRUN -> [SKIP][107] ([i915#5235]) +1 similar issue [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-4/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1: - shard-mtlp: NOTRUN -> [SKIP][108] ([i915#5235]) +3 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][109] ([i915#5235]) +15 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-16/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area: - shard-dg2: NOTRUN -> [SKIP][110] ([i915#658]) +4 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html * igt@kms_psr2_su@page_flip-xrgb8888: - shard-mtlp: NOTRUN -> [SKIP][111] ([i915#4348]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_psr2_su@page_flip-xrgb8888.html * igt@kms_psr@sprite_blt: - shard-dg2: NOTRUN -> [SKIP][112] ([i915#1072]) +4 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-1/igt@kms_psr@sprite_blt.html * igt@kms_psr_stress_test@invalidate-primary-flip-overlay: - shard-dg2: NOTRUN -> [SKIP][113] ([i915#5461] / [i915#658]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html * igt@kms_rotation_crc@bad-pixel-format: - shard-mtlp: NOTRUN -> [SKIP][114] ([i915#4235]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_rotation_crc@bad-pixel-format.html * igt@kms_tv_load_detect@load-detect: - shard-mtlp: NOTRUN -> [SKIP][115] ([fdo#109309]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@kms_tv_load_detect@load-detect.html * igt@kms_vrr@flipline: - shard-dg2: NOTRUN -> [SKIP][116] ([i915#3555]) +1 similar issue [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_vrr@flipline.html * igt@perf@gen8-unprivileged-single-ctx-counters: - shard-dg2: NOTRUN -> [SKIP][117] ([i915#2436]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@perf@gen8-unprivileged-single-ctx-counters.html * igt@perf_pmu@rc6@other-idle-gt0: - shard-dg2: NOTRUN -> [SKIP][118] ([i915#8516]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@perf_pmu@rc6@other-idle-gt0.html * igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem: - shard-dg2: NOTRUN -> [INCOMPLETE][119] ([i915#5493]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html * igt@prime_udl: - shard-dg2: NOTRUN -> [SKIP][120] ([fdo#109291]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@prime_udl.html * igt@v3d/v3d_get_param@base-params: - shard-mtlp: NOTRUN -> [SKIP][121] ([i915#2575]) +1 similar issue [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@v3d/v3d_get_param@base-params.html * igt@v3d/v3d_submit_cl@valid-multisync-submission: - shard-dg2: NOTRUN -> [SKIP][122] ([i915#2575]) +5 similar issues [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@v3d/v3d_submit_cl@valid-multisync-submission.html * igt@vc4/vc4_purgeable_bo@mark-purgeable-twice: - shard-mtlp: NOTRUN -> [SKIP][123] ([i915#7711]) +2 similar issues [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@vc4/vc4_purgeable_bo@mark-purgeable-twice.html * igt@vc4/vc4_tiling@get-bad-handle: - shard-dg2: NOTRUN -> [SKIP][124] ([i915#7711]) +3 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@vc4/vc4_tiling@get-bad-handle.html #### Possible fixes #### * igt@gem_eio@in-flight-suspend: - shard-mtlp: [FAIL][125] ([i915#6121] / [i915#7052]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-5/igt@gem_eio@in-flight-suspend.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@gem_eio@in-flight-suspend.html * igt@gem_eio@kms: - shard-dg2: [INCOMPLETE][127] ([i915#7892]) -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-2/igt@gem_eio@kms.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-11/igt@gem_eio@kms.html * igt@gem_eio@unwedge-stress: - shard-dg1: [FAIL][129] ([i915#5784]) -> [PASS][130] +1 similar issue [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-15/igt@gem_eio@unwedge-stress.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-18/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglu: [FAIL][131] ([i915#2842]) -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-tglu-2/igt@gem_exec_fair@basic-flow@rcs0.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-tglu-10/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_suspend@basic-s0@smem: - shard-dg2: [INCOMPLETE][133] ([i915#6311]) -> [PASS][134] [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-6/igt@gem_exec_suspend@basic-s0@smem.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@gem_exec_suspend@basic-s0@smem.html * igt@i915_pipe_stress@stress-xrgb8888-untiled: - shard-mtlp: [FAIL][135] ([i915#8691]) -> [PASS][136] [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-2/igt@i915_pipe_stress@stress-xrgb8888-untiled.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-6/igt@i915_pipe_stress@stress-xrgb8888-untiled.html * igt@i915_pm_rc6_residency@rc6-idle@rcs0: - shard-dg1: [FAIL][137] ([i915#3591]) -> [PASS][138] +1 similar issue [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html * igt@i915_pm_rpm@dpms-lpsp: - shard-dg1: [SKIP][139] ([i915#1397]) -> [PASS][140] [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-13/igt@i915_pm_rpm@dpms-lpsp.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-19/igt@i915_pm_rpm@dpms-lpsp.html - shard-dg2: [SKIP][141] ([i915#1397]) -> [PASS][142] [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-1/igt@i915_pm_rpm@dpms-lpsp.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-10/igt@i915_pm_rpm@dpms-lpsp.html * igt@i915_selftest@live@requests: - shard-mtlp: [ABORT][143] ([i915#7920] / [i915#7982]) -> [PASS][144] [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-6/igt@i915_selftest@live@requests.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-5/igt@i915_selftest@live@requests.html * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip: - shard-mtlp: [FAIL][145] ([i915#3743]) -> [PASS][146] +1 similar issue [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-mtlp: [FAIL][147] ([i915#5138]) -> [PASS][148] [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][149] ([i915#2346]) -> [PASS][150] [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-mtlp: [FAIL][151] ([fdo#103375]) -> [PASS][152] +2 similar issues [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-mtlp-5/igt@kms_fbcon_fbt@fbc-suspend.html [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-mtlp-4/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt: - shard-dg2: [FAIL][153] ([i915#6880]) -> [PASS][154] +1 similar issue [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-dg2: [FAIL][155] ([fdo#103375]) -> [PASS][156] [155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-suspend.html [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@perf@non-zero-reason@0-rcs0: - shard-dg2: [FAIL][157] ([i915#7484]) -> [PASS][158] [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-5/igt@perf@non-zero-reason@0-rcs0.html [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-3/igt@perf@non-zero-reason@0-rcs0.html * igt@perf_pmu@busy-double-start@vecs1: - shard-dg2: [FAIL][159] ([i915#4349]) -> [PASS][160] +3 similar issues [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-8/igt@perf_pmu@busy-double-start@vecs1.html [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-6/igt@perf_pmu@busy-double-start@vecs1.html #### Warnings #### * igt@gem_lmem_swapping@smem-oom@lmem0: - shard-dg1: [TIMEOUT][161] ([i915#5493]) -> [DMESG-WARN][162] ([i915#4936] / [i915#5493]) [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@i915_suspend@basic-s3-without-i915: - shard-rkl: [FAIL][163] ([fdo#103375]) -> [INCOMPLETE][164] ([i915#4817]) [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-1/igt@i915_suspend@basic-s3-without-i915.html * igt@i915_suspend@forcewake: - shard-snb: [DMESG-WARN][165] ([i915#8841]) -> [INCOMPLETE][166] ([i915#4817] / [i915#7888]) [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-snb5/igt@i915_suspend@forcewake.html [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-snb7/igt@i915_suspend@forcewake.html * igt@kms_content_protection@content_type_change: - shard-dg2: [SKIP][167] ([i915#7118]) -> [SKIP][168] ([i915#7118] / [i915#7162]) [167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg2-2/igt@kms_content_protection@content_type_change.html [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg2-11/igt@kms_content_protection@content_type_change.html * igt@kms_fbcon_fbt@psr: - shard-rkl: [SKIP][169] ([fdo#110189] / [i915#3955]) -> [SKIP][170] ([i915#3955]) [169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-rkl-2/igt@kms_fbcon_fbt@psr.html [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-7/igt@kms_fbcon_fbt@psr.html * igt@kms_fbcon_fbt@psr-suspend: - shard-rkl: [SKIP][171] ([i915#3955]) -> [SKIP][172] ([fdo#110189] / [i915#3955]) [171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-rkl-4/igt@kms_fbcon_fbt@psr-suspend.html [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-1/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_multipipe_modeset@basic-max-pipe-crc-check: - shard-rkl: [SKIP][173] ([i915#4816]) -> [SKIP][174] ([i915#4070] / [i915#4816]) [173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html * igt@kms_psr@cursor_plane_move: - shard-dg1: [SKIP][175] ([i915#1072]) -> [SKIP][176] ([i915#1072] / [i915#4078]) [175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-19/igt@kms_psr@cursor_plane_move.html [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-16/igt@kms_psr@cursor_plane_move.html * igt@kms_psr@sprite_plane_onoff: - shard-dg1: [SKIP][177] ([i915#1072] / [i915#4078]) -> [SKIP][178] ([i915#1072]) [177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13568/shard-dg1-18/igt@kms_psr@sprite_plane_onoff.html [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/shard-dg1-19/igt@kms_psr@sprite_plane_onoff.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4348]: https://gitlab.freedesktop.org/drm/intel/issues/4348 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5978]: https://gitlab.freedesktop.org/drm/intel/issues/5978 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121 [i915#6187]: https://gitlab.freedesktop.org/drm/intel/issues/6187 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880 [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162 [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173 [i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7888]: https://gitlab.freedesktop.org/drm/intel/issues/7888 [i915#7892]: https://gitlab.freedesktop.org/drm/intel/issues/7892 [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920 [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248 [i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295 [i915#8403]: https://gitlab.freedesktop.org/drm/intel/issues/8403 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428 [i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516 [i915#8562]: https://gitlab.freedesktop.org/drm/intel/issues/8562 [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661 [i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 [i915#8957]: https://gitlab.freedesktop.org/drm/intel/issues/8957 [i915#8962]: https://gitlab.freedesktop.org/drm/intel/issues/8962 [i915#9053]: https://gitlab.freedesktop.org/drm/intel/issues/9053 [i915#9119]: https://gitlab.freedesktop.org/drm/intel/issues/9119 [i915#9121]: https://gitlab.freedesktop.org/drm/intel/issues/9121 Build changes ------------- * Linux: CI_DRM_13568 -> Patchwork_122841v2 CI-20190529: 20190529 CI_DRM_13568: f8b90de70ee92dbdebc6f2078e2edd12756d7a63 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7453: 7453 Patchwork_122841v2: f8b90de70ee92dbdebc6f2078e2edd12756d7a63 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v2/index.html [-- Attachment #2: Type: text/html, Size: 57408 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, cec and edid updates (rev3) 2023-08-24 13:46 ` Jani Nikula ` (13 preceding siblings ...) (?) @ 2023-08-31 14:29 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-31 14:29 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm, cec and edid updates (rev3) URL : https://patchwork.freedesktop.org/series/122841/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm, cec and edid updates (rev3) 2023-08-24 13:46 ` Jani Nikula ` (14 preceding siblings ...) (?) @ 2023-08-31 14:44 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-31 14:44 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 6765 bytes --] == Series Details == Series: drm, cec and edid updates (rev3) URL : https://patchwork.freedesktop.org/series/122841/ State : success == Summary == CI Bug Log - changes from CI_DRM_13579 -> Patchwork_122841v3 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/index.html Participating hosts (39 -> 40) ------------------------------ Additional (2): bat-adlp-11 fi-bsw-n3050 Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_122841v3 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - bat-adlp-11: NOTRUN -> [SKIP][1] ([i915#7456]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-adlp-11/igt@debugfs_test@basic-hwmon.html * igt@gem_lmem_swapping@random-engines: - fi-bsw-n3050: NOTRUN -> [SKIP][2] ([fdo#109271]) +18 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html * igt@gem_tiled_pread_basic: - bat-adlp-11: NOTRUN -> [SKIP][3] ([i915#3282]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-adlp-11/igt@gem_tiled_pread_basic.html * igt@i915_selftest@live@gt_heartbeat: - fi-apl-guc: [PASS][4] -> [DMESG-FAIL][5] ([i915#5334]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_suspend@basic-s3-without-i915: - bat-rpls-1: NOTRUN -> [ABORT][6] ([i915#7978] / [i915#8668]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - bat-adlp-11: NOTRUN -> [SKIP][7] ([i915#4103]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-adlp-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-adlp-11: NOTRUN -> [SKIP][8] ([i915#4093]) +3 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-adlp-11/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5: - bat-adlp-11: NOTRUN -> [ABORT][9] ([i915#8668]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5.html * igt@kms_psr@primary_mmap_gtt: - bat-rplp-1: NOTRUN -> [SKIP][10] ([i915#1072]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html * igt@kms_setmode@basic-clone-single-crtc: - bat-rplp-1: NOTRUN -> [ABORT][11] ([i915#8260] / [i915#8668]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3@smem: - fi-rkl-11600: [FAIL][12] ([fdo#103375]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_selftest@live@hangcheck: - bat-rpls-1: [INCOMPLETE][14] ([i915#7677]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/bat-rpls-1/igt@i915_selftest@live@hangcheck.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-rpls-1/igt@i915_selftest@live@hangcheck.html * igt@vgem_basic@debugfs: - fi-kbl-soraka: [INCOMPLETE][16] -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/fi-kbl-soraka/igt@vgem_basic@debugfs.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/fi-kbl-soraka/igt@vgem_basic@debugfs.html #### Warnings #### * igt@kms_psr@cursor_plane_move: - bat-rplp-1: [ABORT][18] ([i915#8469] / [i915#8668] / [i915#9243]) -> [SKIP][19] ([i915#1072]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/bat-rplp-1/igt@kms_psr@cursor_plane_move.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/bat-rplp-1/igt@kms_psr@cursor_plane_move.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677 [i915#7952]: https://gitlab.freedesktop.org/drm/intel/issues/7952 [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978 [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260 [i915#8469]: https://gitlab.freedesktop.org/drm/intel/issues/8469 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#9243]: https://gitlab.freedesktop.org/drm/intel/issues/9243 Build changes ------------- * Linux: CI_DRM_13579 -> Patchwork_122841v3 CI-20190529: 20190529 CI_DRM_13579: 27896186d81a305aab16bf1a3b964a321d00ed38 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7460: 30b4034ea562952039ba6af58106791d5c39999e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_122841v3: 27896186d81a305aab16bf1a3b964a321d00ed38 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 3953ea1b2d8c media: cec: core: add note about *_from_edid() function usage in drm 452a68eb56ec drm/i915/cec: switch to setting physical address directly 1ad8fdba572f drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid 6bb716e5b517 drm/edid: parse source physical address 4bea6f3a3cb3 drm/i915/display: use drm_edid_is_digital() 937c7ae91980 drm/edid: add drm_edid_is_digital() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/index.html [-- Attachment #2: Type: text/html, Size: 7956 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm, cec and edid updates (rev3) 2023-08-24 13:46 ` Jani Nikula ` (15 preceding siblings ...) (?) @ 2023-08-31 18:48 ` Patchwork -1 siblings, 0 replies; 77+ messages in thread From: Patchwork @ 2023-08-31 18:48 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 46301 bytes --] == Series Details == Series: drm, cec and edid updates (rev3) URL : https://patchwork.freedesktop.org/series/122841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13579_full -> Patchwork_122841v3_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_122841v3_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_122841v3_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (9 -> 9) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_122841v3_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_capture@pi@vcs1: - shard-tglu: [PASS][1] -> [TIMEOUT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-tglu-8/igt@gem_exec_capture@pi@vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-tglu-8/igt@gem_exec_capture@pi@vcs1.html * igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1: - shard-rkl: [PASS][3] -> [ABORT][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-rkl-7/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-7/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-dg2: [PASS][5] -> [INCOMPLETE][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html Known issues ------------ Here are the changes found in Patchwork_122841v3_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@api_intel_bb@object-reloc-keep-cache: - shard-dg2: NOTRUN -> [SKIP][7] ([i915#8411]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@api_intel_bb@object-reloc-keep-cache.html * igt@device_reset@unbind-cold-reset-rebind: - shard-dg2: NOTRUN -> [SKIP][8] ([i915#7701]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@device_reset@unbind-cold-reset-rebind.html * igt@drm_fdinfo@busy-idle@bcs0: - shard-mtlp: NOTRUN -> [SKIP][9] ([i915#8414]) +5 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@drm_fdinfo@busy-idle@bcs0.html * igt@drm_fdinfo@busy@ccs0: - shard-dg2: NOTRUN -> [SKIP][10] ([i915#8414]) +9 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@drm_fdinfo@busy@ccs0.html * igt@feature_discovery@display-3x: - shard-dg2: NOTRUN -> [SKIP][11] ([i915#1839]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@feature_discovery@display-3x.html * igt@gem_ctx_exec@basic-nohangcheck: - shard-tglu: [PASS][12] -> [FAIL][13] ([i915#6268]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-tglu-6/igt@gem_ctx_exec@basic-nohangcheck.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-tglu-6/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_ctx_persistence@hang: - shard-dg2: NOTRUN -> [SKIP][14] ([i915#8555]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_ctx_persistence@hang.html * igt@gem_eio@reset-stress: - shard-dg1: [PASS][15] -> [FAIL][16] ([i915#5784]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-17/igt@gem_eio@reset-stress.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-17/igt@gem_eio@reset-stress.html * igt@gem_exec_balancer@invalid-bonds: - shard-mtlp: NOTRUN -> [SKIP][17] ([i915#4036]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@gem_exec_balancer@invalid-bonds.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-glk: [PASS][18] -> [FAIL][19] ([i915#2842]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-rkl: [PASS][20] -> [FAIL][21] ([i915#2842]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-rkl-2/igt@gem_exec_fair@basic-pace@vcs0.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-2/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fence@submit: - shard-dg2: NOTRUN -> [SKIP][22] ([i915#4812]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_exec_fence@submit.html * igt@gem_exec_flush@basic-uc-pro-default: - shard-dg2: NOTRUN -> [SKIP][23] ([i915#3539] / [i915#4852]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_exec_flush@basic-uc-pro-default.html * igt@gem_exec_reloc@basic-gtt-noreloc: - shard-mtlp: NOTRUN -> [SKIP][24] ([i915#3281]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@gem_exec_reloc@basic-gtt-noreloc.html * igt@gem_exec_reloc@basic-gtt-wc-active: - shard-dg2: NOTRUN -> [SKIP][25] ([i915#3281]) +3 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_exec_reloc@basic-gtt-wc-active.html * igt@gem_exec_suspend@basic-s4-devices@smem: - shard-tglu: [PASS][26] -> [ABORT][27] ([i915#7975] / [i915#8213]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-tglu-2/igt@gem_exec_suspend@basic-s4-devices@smem.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html * igt@gem_madvise@dontneed-before-pwrite: - shard-dg2: NOTRUN -> [SKIP][28] ([i915#3282]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_madvise@dontneed-before-pwrite.html * igt@gem_media_fill@media-fill: - shard-mtlp: NOTRUN -> [SKIP][29] ([i915#8289]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@gem_media_fill@media-fill.html * igt@gem_mmap@basic-small-bo: - shard-dg2: NOTRUN -> [SKIP][30] ([i915#4083]) +2 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_mmap@basic-small-bo.html * igt@gem_mmap_gtt@cpuset-big-copy-xy: - shard-dg2: NOTRUN -> [SKIP][31] ([i915#4077]) +4 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_mmap_gtt@cpuset-big-copy-xy.html * igt@gem_pxp@verify-pxp-stale-ctx-execution: - shard-dg2: NOTRUN -> [SKIP][32] ([i915#4270]) +3 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_pxp@verify-pxp-stale-ctx-execution.html * igt@gem_set_tiling_vs_pwrite: - shard-dg2: NOTRUN -> [SKIP][33] ([i915#4079]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@gem_set_tiling_vs_pwrite.html * igt@gem_unfence_active_buffers: - shard-dg2: NOTRUN -> [SKIP][34] ([i915#4879]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@gem_unfence_active_buffers.html * igt@gem_userptr_blits@unsync-unmap-cycles: - shard-dg2: NOTRUN -> [SKIP][35] ([i915#3297]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@gem_userptr_blits@unsync-unmap-cycles.html * igt@gen3_render_tiledx_blits: - shard-dg2: NOTRUN -> [SKIP][36] ([fdo#109289]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@gen3_render_tiledx_blits.html * igt@gen9_exec_parse@shadow-peek: - shard-dg2: NOTRUN -> [SKIP][37] ([i915#2856]) +2 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@gen9_exec_parse@shadow-peek.html * igt@i915_module_load@reload-with-fault-injection: - shard-dg2: [PASS][38] -> [DMESG-WARN][39] ([i915#7061] / [i915#8617]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-8/igt@i915_module_load@reload-with-fault-injection.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pipe_stress@stress-xrgb8888-ytiled: - shard-dg2: NOTRUN -> [SKIP][40] ([i915#7091]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html * igt@i915_pm_lpsp@screens-disabled: - shard-dg2: NOTRUN -> [SKIP][41] ([i915#1902]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@i915_pm_lpsp@screens-disabled.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-dg2: NOTRUN -> [SKIP][42] ([fdo#109506]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-dg2: [PASS][43] -> [SKIP][44] ([i915#1397]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-2/igt@i915_pm_rpm@modeset-non-lpsp.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp.html - shard-dg1: [PASS][45] -> [SKIP][46] ([i915#1397]) +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-18/igt@i915_pm_rpm@modeset-non-lpsp.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@i915_pm_rps@thresholds-idle-park@gt0: - shard-dg2: NOTRUN -> [SKIP][47] ([i915#8925]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@i915_pm_rps@thresholds-idle-park@gt0.html * igt@i915_suspend@forcewake: - shard-dg2: [PASS][48] -> [TIMEOUT][49] ([fdo#103375]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-8/igt@i915_suspend@forcewake.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-5/igt@i915_suspend@forcewake.html * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs: - shard-dg2: NOTRUN -> [SKIP][50] ([i915#8502] / [i915#8709]) +11 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-1/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs.html * igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-4-y-rc_ccs: - shard-dg1: NOTRUN -> [SKIP][51] ([i915#8502]) +7 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-16/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-4-y-rc_ccs.html * igt@kms_async_flips@invalid-async-flip: - shard-dg2: NOTRUN -> [SKIP][52] ([i915#6228]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_async_flips@invalid-async-flip.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip: - shard-mtlp: [PASS][53] -> [FAIL][54] ([i915#3743]) +3 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-mtlp: [PASS][55] -> [FAIL][56] ([i915#5138]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@x-tiled-32bpp-rotate-270: - shard-dg2: NOTRUN -> [SKIP][57] ([fdo#111614]) +2 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180: - shard-dg2: NOTRUN -> [SKIP][58] ([i915#5190]) +4 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-180: - shard-dg2: NOTRUN -> [SKIP][59] ([i915#4538] / [i915#5190]) +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs: - shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271]) +22 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-apl7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs: - shard-dg2: NOTRUN -> [SKIP][61] ([i915#3689] / [i915#5354]) +12 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs: - shard-mtlp: NOTRUN -> [SKIP][62] ([i915#6095]) +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_ccs.html * igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs: - shard-snb: NOTRUN -> [SKIP][63] ([fdo#109271]) +203 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-snb2/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-dg2: NOTRUN -> [SKIP][64] ([i915#3689] / [i915#3886] / [i915#5354]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-mtlp: NOTRUN -> [SKIP][65] ([i915#3886] / [i915#6095]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-8/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2: - shard-dg2: NOTRUN -> [SKIP][66] ([i915#7213]) +3 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-2/igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2.html * igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][67] ([i915#4087]) +3 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-5/igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3.html * igt@kms_chamelium_color@degamma: - shard-dg2: NOTRUN -> [SKIP][68] ([fdo#111827]) +1 similar issue [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_chamelium_color@degamma.html * igt@kms_chamelium_frames@hdmi-crc-fast: - shard-dg2: NOTRUN -> [SKIP][69] ([i915#7828]) +3 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_chamelium_frames@hdmi-crc-fast.html * igt@kms_chamelium_hpd@vga-hpd: - shard-mtlp: NOTRUN -> [SKIP][70] ([i915#7828]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@kms_chamelium_hpd@vga-hpd.html * igt@kms_content_protection@dp-mst-lic-type-0: - shard-dg2: NOTRUN -> [SKIP][71] ([i915#3299]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_content_protection@dp-mst-lic-type-0.html * igt@kms_content_protection@srm: - shard-dg2: NOTRUN -> [SKIP][72] ([i915#7118]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-1/igt@kms_content_protection@srm.html * igt@kms_cursor_crc@cursor-offscreen-512x512: - shard-dg2: NOTRUN -> [SKIP][73] ([i915#3359]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_cursor_crc@cursor-offscreen-512x512.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-3: - shard-dg2: NOTRUN -> [FAIL][74] ([fdo#103375]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-5/igt@kms_cursor_crc@cursor-suspend@pipe-a-hdmi-a-3.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic: - shard-dg2: NOTRUN -> [SKIP][75] ([fdo#109274] / [i915#5354]) +2 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size: - shard-dg2: NOTRUN -> [SKIP][76] ([i915#4103] / [i915#4213]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html * igt@kms_dirtyfb@dirtyfb-ioctl@fbc-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][77] ([i915#9227]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-17/igt@kms_dirtyfb@dirtyfb-ioctl@fbc-hdmi-a-4.html * igt@kms_dirtyfb@dirtyfb-ioctl@psr-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][78] ([i915#9226]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-17/igt@kms_dirtyfb@dirtyfb-ioctl@psr-hdmi-a-4.html * igt@kms_draw_crc@draw-method-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][79] ([i915#8812]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@kms_draw_crc@draw-method-mmap-gtt.html * igt@kms_dsc@dsc-with-output-formats: - shard-dg2: NOTRUN -> [SKIP][80] ([i915#3555] / [i915#3840]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_dsc@dsc-with-output-formats.html * igt@kms_flip@2x-absolute-wf_vblank: - shard-dg2: NOTRUN -> [SKIP][81] ([fdo#109274]) +4 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_flip@2x-absolute-wf_vblank.html * igt@kms_flip@2x-flip-vs-blocking-wf-vblank: - shard-dg2: NOTRUN -> [SKIP][82] ([fdo#109274] / [fdo#111767]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_flip@2x-flip-vs-blocking-wf-vblank.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-snb: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111767]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-snb2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@2x-flip-vs-fences-interruptible: - shard-dg2: NOTRUN -> [SKIP][84] ([i915#8381]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_flip@2x-flip-vs-fences-interruptible.html * igt@kms_flip@flip-vs-suspend@b-hdmi-a1: - shard-snb: NOTRUN -> [DMESG-WARN][85] ([i915#8841]) +7 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-snb1/igt@kms_flip@flip-vs-suspend@b-hdmi-a1.html * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode: - shard-dg2: NOTRUN -> [SKIP][86] ([i915#2672]) +1 similar issue [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-dg2: [PASS][87] -> [FAIL][88] ([i915#6880]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite: - shard-mtlp: NOTRUN -> [SKIP][89] ([i915#1825]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-tiling-y: - shard-dg2: NOTRUN -> [SKIP][90] ([i915#5460]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-tiling-y.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move: - shard-dg2: NOTRUN -> [SKIP][91] ([i915#3458]) +9 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt: - shard-dg2: NOTRUN -> [SKIP][92] ([i915#5354]) +23 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt: - shard-dg2: NOTRUN -> [SKIP][93] ([i915#8708]) +4 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4: - shard-dg1: NOTRUN -> [FAIL][94] ([i915#8292]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-18/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html * igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][95] ([i915#5176]) +3 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-6/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3.html * igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][96] ([i915#5176]) +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][97] ([i915#5176]) +19 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-14/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4.html * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][98] ([i915#5235]) +11 similar issues [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-hdmi-a-3.html * igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-hdmi-a-2: - shard-rkl: NOTRUN -> [SKIP][99] ([i915#5235]) +1 similar issue [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-hdmi-a-2.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][100] ([i915#5235]) +19 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-17/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4.html * igt@kms_psr@psr2_dpms: - shard-dg2: NOTRUN -> [SKIP][101] ([i915#1072]) +4 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_psr@psr2_dpms.html * igt@kms_selftest@drm_format_helper: - shard-snb: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#8661]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-snb5/igt@kms_selftest@drm_format_helper.html * igt@kms_setmode@basic@pipe-a-vga-1: - shard-snb: NOTRUN -> [FAIL][103] ([i915#5465]) +1 similar issue [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-snb2/igt@kms_setmode@basic@pipe-a-vga-1.html * igt@kms_vrr@flip-dpms: - shard-dg2: NOTRUN -> [SKIP][104] ([i915#3555]) +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@kms_vrr@flip-dpms.html * igt@kms_writeback@writeback-check-output: - shard-mtlp: NOTRUN -> [SKIP][105] ([i915#2437]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@kms_writeback@writeback-check-output.html * igt@kms_writeback@writeback-invalid-parameters: - shard-dg2: NOTRUN -> [SKIP][106] ([i915#2437]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@kms_writeback@writeback-invalid-parameters.html * igt@perf@mi-rpc: - shard-dg2: NOTRUN -> [SKIP][107] ([i915#2434]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@perf@mi-rpc.html * igt@prime_vgem@basic-fence-mmap: - shard-dg2: NOTRUN -> [SKIP][108] ([i915#3708] / [i915#4077]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@prime_vgem@basic-fence-mmap.html * igt@v3d/v3d_submit_cl@bad-bo: - shard-dg2: NOTRUN -> [SKIP][109] ([i915#2575]) +6 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-8/igt@v3d/v3d_submit_cl@bad-bo.html * igt@vc4/vc4_perfmon@create-single-perfmon: - shard-mtlp: NOTRUN -> [SKIP][110] ([i915#7711]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-8/igt@vc4/vc4_perfmon@create-single-perfmon.html * igt@vc4/vc4_perfmon@destroy-invalid-perfmon: - shard-dg2: NOTRUN -> [SKIP][111] ([i915#7711]) +3 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-3/igt@vc4/vc4_perfmon@destroy-invalid-perfmon.html #### Possible fixes #### * igt@drm_fdinfo@most-busy-idle-check-all@rcs0: - shard-rkl: [FAIL][112] ([i915#7742]) -> [PASS][113] [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html * igt@fbdev@eof: - shard-mtlp: [DMESG-WARN][114] ([i915#1982]) -> [PASS][115] [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-8/igt@fbdev@eof.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-5/igt@fbdev@eof.html * igt@gem_ctx_isolation@preservation-s3@vcs1: - shard-dg1: [DMESG-WARN][116] ([i915#4391] / [i915#4423]) -> [PASS][117] +1 similar issue [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-15/igt@gem_ctx_isolation@preservation-s3@vcs1.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-14/igt@gem_ctx_isolation@preservation-s3@vcs1.html * igt@gem_exec_capture@pi@rcs0: - shard-mtlp: [FAIL][118] ([i915#4475]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-1/igt@gem_exec_capture@pi@rcs0.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@gem_exec_capture@pi@rcs0.html * igt@gem_exec_capture@pi@vcs0: - shard-mtlp: [ABORT][120] -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-1/igt@gem_exec_capture@pi@vcs0.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@gem_exec_capture@pi@vcs0.html * igt@gem_exec_capture@pi@vecs0: - shard-mtlp: [INCOMPLETE][122] -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-1/igt@gem_exec_capture@pi@vecs0.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-2/igt@gem_exec_capture@pi@vecs0.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglu: [FAIL][124] ([i915#2842]) -> [PASS][125] +1 similar issue [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-tglu-9/igt@gem_exec_fair@basic-flow@rcs0.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-tglu-7/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-rkl: [FAIL][126] ([i915#2842]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-rkl-4/igt@gem_exec_fair@basic-none-share@rcs0.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-4/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-apl: [FAIL][128] ([i915#2842]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][130] ([i915#2842]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_schedule@noreorder@vecs0: - shard-mtlp: [DMESG-FAIL][132] ([i915#9121]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-4/igt@gem_exec_schedule@noreorder@vecs0.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-4/igt@gem_exec_schedule@noreorder@vecs0.html * igt@i915_pm_rc6_residency@rc6-idle@bcs0: - shard-dg1: [FAIL][134] ([i915#3591]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html * igt@i915_pm_rpm@modeset-non-lpsp-stress: - shard-dg2: [SKIP][136] ([i915#1397]) -> [PASS][137] [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-12/igt@i915_pm_rpm@modeset-non-lpsp-stress.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-1/igt@i915_pm_rpm@modeset-non-lpsp-stress.html - shard-dg1: [SKIP][138] ([i915#1397]) -> [PASS][139] [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-16/igt@i915_pm_rpm@modeset-non-lpsp-stress.html * igt@i915_selftest@live@gt_pm: - shard-rkl: [DMESG-FAIL][140] ([i915#4258]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-rkl-6/igt@i915_selftest@live@gt_pm.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-4/igt@i915_selftest@live@gt_pm.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip: - shard-tglu: [FAIL][142] ([i915#3743]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-tglu-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-tglu-3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2: - shard-glk: [FAIL][144] ([i915#79]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html * igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-valid-mode: - shard-dg1: [FAIL][146] ([i915#7479]) -> [PASS][147] [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-19/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-valid-mode.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-18/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-valid-mode.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-dg2: [FAIL][148] ([fdo#103375]) -> [PASS][149] [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-suspend.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1: - shard-apl: [ABORT][150] ([i915#180]) -> [PASS][151] [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1.html * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1: - shard-apl: [DMESG-WARN][152] ([i915#180]) -> [PASS][153] [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html #### Warnings #### * igt@gem_spin_batch@spin-each: - shard-mtlp: [DMESG-FAIL][154] ([i915#9121]) -> [DMESG-FAIL][155] ([i915#8962] / [i915#9121]) [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-4/igt@gem_spin_batch@spin-each.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-4/igt@gem_spin_batch@spin-each.html * igt@kms_content_protection@mei_interface: - shard-dg2: [SKIP][156] ([i915#7118] / [i915#7162]) -> [SKIP][157] ([i915#7118]) [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg2-12/igt@kms_content_protection@mei_interface.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg2-6/igt@kms_content_protection@mei_interface.html - shard-dg1: [SKIP][158] ([i915#7116]) -> [SKIP][159] ([fdo#109300]) [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-14/igt@kms_content_protection@mei_interface.html [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-13/igt@kms_content_protection@mei_interface.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-mtlp: [FAIL][160] ([i915#2346]) -> [DMESG-FAIL][161] ([i915#2017] / [i915#5954]) [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@psr-suspend: - shard-rkl: [SKIP][162] ([fdo#110189] / [i915#3955]) -> [SKIP][163] ([i915#3955]) +1 similar issue [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_psr@cursor_plane_move: - shard-dg1: [SKIP][164] ([i915#1072]) -> [SKIP][165] ([i915#1072] / [i915#4078]) +2 similar issues [164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-14/igt@kms_psr@cursor_plane_move.html [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-13/igt@kms_psr@cursor_plane_move.html * igt@kms_psr@primary_page_flip: - shard-dg1: [SKIP][166] ([i915#1072] / [i915#4078]) -> [SKIP][167] ([i915#1072]) [166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-dg1-13/igt@kms_psr@primary_page_flip.html [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-dg1-17/igt@kms_psr@primary_page_flip.html * igt@sysfs_heartbeat_interval@mixed@ccs0: - shard-mtlp: [DMESG-WARN][168] ([i915#8552]) -> [ABORT][169] ([i915#8552]) [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-2/igt@sysfs_heartbeat_interval@mixed@ccs0.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-4/igt@sysfs_heartbeat_interval@mixed@ccs0.html * igt@sysfs_heartbeat_interval@mixed@vecs0: - shard-mtlp: [ABORT][170] ([i915#8552]) -> [FAIL][171] ([i915#1731]) [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13579/shard-mtlp-2/igt@sysfs_heartbeat_interval@mixed@vecs0.html [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/shard-mtlp-4/igt@sysfs_heartbeat_interval@mixed@vecs0.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 [i915#4475]: https://gitlab.freedesktop.org/drm/intel/issues/4475 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5460]: https://gitlab.freedesktop.org/drm/intel/issues/5460 [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6228]: https://gitlab.freedesktop.org/drm/intel/issues/6228 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880 [i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061 [i915#7091]: https://gitlab.freedesktop.org/drm/intel/issues/7091 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162 [i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213 [i915#7479]: https://gitlab.freedesktop.org/drm/intel/issues/7479 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8289]: https://gitlab.freedesktop.org/drm/intel/issues/8289 [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502 [i915#8552]: https://gitlab.freedesktop.org/drm/intel/issues/8552 [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555 [i915#8617]: https://gitlab.freedesktop.org/drm/intel/issues/8617 [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709 [i915#8812]: https://gitlab.freedesktop.org/drm/intel/issues/8812 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 [i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925 [i915#8962]: https://gitlab.freedesktop.org/drm/intel/issues/8962 [i915#9121]: https://gitlab.freedesktop.org/drm/intel/issues/9121 [i915#9226]: https://gitlab.freedesktop.org/drm/intel/issues/9226 [i915#9227]: https://gitlab.freedesktop.org/drm/intel/issues/9227 Build changes ------------- * Linux: CI_DRM_13579 -> Patchwork_122841v3 CI-20190529: 20190529 CI_DRM_13579: 27896186d81a305aab16bf1a3b964a321d00ed38 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7460: 30b4034ea562952039ba6af58106791d5c39999e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_122841v3: 27896186d81a305aab16bf1a3b964a321d00ed38 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_122841v3/index.html [-- Attachment #2: Type: text/html, Size: 53217 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 0/6] drm, cec and edid updates 2023-08-24 13:46 ` Jani Nikula (?) @ 2023-08-31 18:51 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 18:51 UTC (permalink / raw) To: dri-devel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann Cc: Hans Verkuil, intel-gfx, linux-media On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: > Avoid accessing the raw edid directly. Pre-parse the source physical > address during normal EDID parsing and use that for CEC. > > Jani Nikula (6): > drm/edid: add drm_edid_is_digital() > drm/i915/display: use drm_edid_is_digital() > drm/edid: parse source physical address > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid > drm/i915/cec: switch to setting physical address directly Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via drm-intel? > media: cec: core: add note about *_from_edid() function usage in drm Hans, while there's no build dependency here, I think it would make sense to merge this together with patches 3 and 4. Ack for merging via drm-intel? Thanks, Jani. > > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- > drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- > drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- > drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- > drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- > drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- > drivers/media/cec/core/cec-adap.c | 4 ++++ > drivers/media/cec/core/cec-notifier.c | 4 ++++ > include/drm/display/drm_dp_helper.h | 6 ++++++ > include/drm/drm_connector.h | 8 ++++++++ > include/drm/drm_edid.h | 1 + > 11 files changed, 73 insertions(+), 27 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-08-31 18:51 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 18:51 UTC (permalink / raw) To: dri-devel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann Cc: intel-gfx, linux-media, Hans Verkuil On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: > Avoid accessing the raw edid directly. Pre-parse the source physical > address during normal EDID parsing and use that for CEC. > > Jani Nikula (6): > drm/edid: add drm_edid_is_digital() > drm/i915/display: use drm_edid_is_digital() > drm/edid: parse source physical address > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid > drm/i915/cec: switch to setting physical address directly Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via drm-intel? > media: cec: core: add note about *_from_edid() function usage in drm Hans, while there's no build dependency here, I think it would make sense to merge this together with patches 3 and 4. Ack for merging via drm-intel? Thanks, Jani. > > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- > drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- > drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- > drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- > drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- > drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- > drivers/media/cec/core/cec-adap.c | 4 ++++ > drivers/media/cec/core/cec-notifier.c | 4 ++++ > include/drm/display/drm_dp_helper.h | 6 ++++++ > include/drm/drm_connector.h | 8 ++++++++ > include/drm/drm_edid.h | 1 + > 11 files changed, 73 insertions(+), 27 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-08-31 18:51 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-08-31 18:51 UTC (permalink / raw) To: dri-devel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann Cc: Hans Verkuil, intel-gfx, linux-media On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: > Avoid accessing the raw edid directly. Pre-parse the source physical > address during normal EDID parsing and use that for CEC. > > Jani Nikula (6): > drm/edid: add drm_edid_is_digital() > drm/i915/display: use drm_edid_is_digital() > drm/edid: parse source physical address > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid > drm/i915/cec: switch to setting physical address directly Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via drm-intel? > media: cec: core: add note about *_from_edid() function usage in drm Hans, while there's no build dependency here, I think it would make sense to merge this together with patches 3 and 4. Ack for merging via drm-intel? Thanks, Jani. > > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- > drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- > drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- > drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- > drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- > drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- > drivers/media/cec/core/cec-adap.c | 4 ++++ > drivers/media/cec/core/cec-notifier.c | 4 ++++ > include/drm/display/drm_dp_helper.h | 6 ++++++ > include/drm/drm_connector.h | 8 ++++++++ > include/drm/drm_edid.h | 1 + > 11 files changed, 73 insertions(+), 27 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 0/6] drm, cec and edid updates 2023-08-31 18:51 ` Jani Nikula @ 2023-08-31 21:32 ` Hans Verkuil -1 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-31 21:32 UTC (permalink / raw) To: Jani Nikula, dri-devel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann Cc: intel-gfx, linux-media On 31/08/2023 20:51, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: >> Avoid accessing the raw edid directly. Pre-parse the source physical >> address during normal EDID parsing and use that for CEC. >> >> Jani Nikula (6): >> drm/edid: add drm_edid_is_digital() >> drm/i915/display: use drm_edid_is_digital() >> drm/edid: parse source physical address >> drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid >> drm/i915/cec: switch to setting physical address directly > > Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via > drm-intel? > >> media: cec: core: add note about *_from_edid() function usage in drm > > Hans, while there's no build dependency here, I think it would make > sense to merge this together with patches 3 and 4. Ack for merging via > drm-intel? That's fine, it makes sense to do that. If you need it, for this series: Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > > Thanks, > Jani. > > >> >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- >> drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- >> drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- >> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- >> drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- >> drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- >> drivers/media/cec/core/cec-adap.c | 4 ++++ >> drivers/media/cec/core/cec-notifier.c | 4 ++++ >> include/drm/display/drm_dp_helper.h | 6 ++++++ >> include/drm/drm_connector.h | 8 ++++++++ >> include/drm/drm_edid.h | 1 + >> 11 files changed, 73 insertions(+), 27 deletions(-) > ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-08-31 21:32 ` Hans Verkuil 0 siblings, 0 replies; 77+ messages in thread From: Hans Verkuil @ 2023-08-31 21:32 UTC (permalink / raw) To: Jani Nikula, dri-devel, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann Cc: intel-gfx, linux-media On 31/08/2023 20:51, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: >> Avoid accessing the raw edid directly. Pre-parse the source physical >> address during normal EDID parsing and use that for CEC. >> >> Jani Nikula (6): >> drm/edid: add drm_edid_is_digital() >> drm/i915/display: use drm_edid_is_digital() >> drm/edid: parse source physical address >> drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid >> drm/i915/cec: switch to setting physical address directly > > Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via > drm-intel? > >> media: cec: core: add note about *_from_edid() function usage in drm > > Hans, while there's no build dependency here, I think it would make > sense to merge this together with patches 3 and 4. Ack for merging via > drm-intel? That's fine, it makes sense to do that. If you need it, for this series: Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Regards, Hans > > Thanks, > Jani. > > >> >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++++++++++++++++++--- >> drivers/gpu/drm/drm_edid.c | 22 ++++++++++++++++++++-- >> drivers/gpu/drm/i915/display/intel_crt.c | 11 ++++------- >> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++----- >> drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++----- >> drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++----- >> drivers/media/cec/core/cec-adap.c | 4 ++++ >> drivers/media/cec/core/cec-notifier.c | 4 ++++ >> include/drm/display/drm_dp_helper.h | 6 ++++++ >> include/drm/drm_connector.h | 8 ++++++++ >> include/drm/drm_edid.h | 1 + >> 11 files changed, 73 insertions(+), 27 deletions(-) > ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 0/6] drm, cec and edid updates 2023-08-31 18:51 ` Jani Nikula (?) @ 2023-09-01 7:24 ` Maxime Ripard -1 siblings, 0 replies; 77+ messages in thread From: Maxime Ripard @ 2023-09-01 7:24 UTC (permalink / raw) To: Jani Nikula Cc: intel-gfx, dri-devel, Thomas Zimmermann, Hans Verkuil, linux-media [-- Attachment #1: Type: text/plain, Size: 721 bytes --] On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: > > Avoid accessing the raw edid directly. Pre-parse the source physical > > address during normal EDID parsing and use that for CEC. > > > > Jani Nikula (6): > > drm/edid: add drm_edid_is_digital() > > drm/i915/display: use drm_edid_is_digital() > > drm/edid: parse source physical address > > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid > > drm/i915/cec: switch to setting physical address directly > > Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via > drm-intel? Acked-by: Maxime Ripard <mripard@kernel.org> Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-09-01 7:24 ` Maxime Ripard 0 siblings, 0 replies; 77+ messages in thread From: Maxime Ripard @ 2023-09-01 7:24 UTC (permalink / raw) To: Jani Nikula Cc: dri-devel, Maarten Lankhorst, Thomas Zimmermann, intel-gfx, linux-media, Hans Verkuil [-- Attachment #1: Type: text/plain, Size: 721 bytes --] On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: > > Avoid accessing the raw edid directly. Pre-parse the source physical > > address during normal EDID parsing and use that for CEC. > > > > Jani Nikula (6): > > drm/edid: add drm_edid_is_digital() > > drm/i915/display: use drm_edid_is_digital() > > drm/edid: parse source physical address > > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid > > drm/i915/cec: switch to setting physical address directly > > Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via > drm-intel? Acked-by: Maxime Ripard <mripard@kernel.org> Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-09-01 7:24 ` Maxime Ripard 0 siblings, 0 replies; 77+ messages in thread From: Maxime Ripard @ 2023-09-01 7:24 UTC (permalink / raw) To: Jani Nikula Cc: intel-gfx, dri-devel, Thomas Zimmermann, Hans Verkuil, linux-media [-- Attachment #1: Type: text/plain, Size: 721 bytes --] On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: > > Avoid accessing the raw edid directly. Pre-parse the source physical > > address during normal EDID parsing and use that for CEC. > > > > Jani Nikula (6): > > drm/edid: add drm_edid_is_digital() > > drm/i915/display: use drm_edid_is_digital() > > drm/edid: parse source physical address > > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid > > drm/i915/cec: switch to setting physical address directly > > Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via > drm-intel? Acked-by: Maxime Ripard <mripard@kernel.org> Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [Intel-gfx] [PATCH 0/6] drm, cec and edid updates 2023-09-01 7:24 ` Maxime Ripard (?) @ 2023-09-01 8:57 ` Jani Nikula -1 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-09-01 8:57 UTC (permalink / raw) To: Maxime Ripard Cc: intel-gfx, dri-devel, Thomas Zimmermann, Hans Verkuil, linux-media On Fri, 01 Sep 2023, Maxime Ripard <mripard@kernel.org> wrote: > On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: >> On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: >> > Avoid accessing the raw edid directly. Pre-parse the source physical >> > address during normal EDID parsing and use that for CEC. >> > >> > Jani Nikula (6): >> > drm/edid: add drm_edid_is_digital() >> > drm/i915/display: use drm_edid_is_digital() >> > drm/edid: parse source physical address >> > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid >> > drm/i915/cec: switch to setting physical address directly >> >> Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via >> drm-intel? > > Acked-by: Maxime Ripard <mripard@kernel.org> Thanks for all the reviews and acks, pushed the series to drm-intel-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-09-01 8:57 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-09-01 8:57 UTC (permalink / raw) To: Maxime Ripard Cc: intel-gfx, dri-devel, Thomas Zimmermann, Hans Verkuil, linux-media, Ville Syrjälä On Fri, 01 Sep 2023, Maxime Ripard <mripard@kernel.org> wrote: > On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: >> On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: >> > Avoid accessing the raw edid directly. Pre-parse the source physical >> > address during normal EDID parsing and use that for CEC. >> > >> > Jani Nikula (6): >> > drm/edid: add drm_edid_is_digital() >> > drm/i915/display: use drm_edid_is_digital() >> > drm/edid: parse source physical address >> > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid >> > drm/i915/cec: switch to setting physical address directly >> >> Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via >> drm-intel? > > Acked-by: Maxime Ripard <mripard@kernel.org> Thanks for all the reviews and acks, pushed the series to drm-intel-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
* Re: [PATCH 0/6] drm, cec and edid updates @ 2023-09-01 8:57 ` Jani Nikula 0 siblings, 0 replies; 77+ messages in thread From: Jani Nikula @ 2023-09-01 8:57 UTC (permalink / raw) To: Maxime Ripard Cc: intel-gfx, dri-devel, Thomas Zimmermann, Hans Verkuil, linux-media On Fri, 01 Sep 2023, Maxime Ripard <mripard@kernel.org> wrote: > On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: >> On Thu, 24 Aug 2023, Jani Nikula <jani.nikula@intel.com> wrote: >> > Avoid accessing the raw edid directly. Pre-parse the source physical >> > address during normal EDID parsing and use that for CEC. >> > >> > Jani Nikula (6): >> > drm/edid: add drm_edid_is_digital() >> > drm/i915/display: use drm_edid_is_digital() >> > drm/edid: parse source physical address >> > drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid >> > drm/i915/cec: switch to setting physical address directly >> >> Maarten, Maxime, Thomas, ack for merging patches 1, 3 and 4 via via >> drm-intel? > > Acked-by: Maxime Ripard <mripard@kernel.org> Thanks for all the reviews and acks, pushed the series to drm-intel-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 77+ messages in thread
end of thread, other threads:[~2023-09-04 10:46 UTC | newest] Thread overview: 77+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-24 13:46 [Intel-gfx] [PATCH 0/6] drm, cec and edid updates Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` [Intel-gfx] [PATCH 1/6] drm/edid: add drm_edid_is_digital() Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-31 17:23 ` [Intel-gfx] " Ville Syrjälä 2023-08-31 17:23 ` Ville Syrjälä 2023-08-31 17:23 ` Ville Syrjälä 2023-09-01 19:26 ` [Intel-gfx] " Alex Deucher 2023-09-01 19:26 ` Alex Deucher 2023-09-01 19:26 ` Alex Deucher 2023-09-04 10:43 ` [Intel-gfx] " Jani Nikula 2023-09-04 10:43 ` Jani Nikula 2023-09-04 10:43 ` Jani Nikula 2023-08-24 13:46 ` [Intel-gfx] [PATCH 2/6] drm/i915/display: use drm_edid_is_digital() Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-31 17:24 ` [Intel-gfx] " Ville Syrjälä 2023-08-31 17:24 ` Ville Syrjälä 2023-08-24 13:46 ` [Intel-gfx] [PATCH 3/6] drm/edid: parse source physical address Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-30 9:54 ` [Intel-gfx] " Hans Verkuil 2023-08-30 9:54 ` Hans Verkuil 2023-08-24 13:46 ` [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-25 11:23 ` [Intel-gfx] " kernel test robot 2023-08-25 11:23 ` kernel test robot 2023-08-25 11:23 ` kernel test robot 2023-08-25 11:23 ` kernel test robot 2023-08-25 13:01 ` [Intel-gfx] [PATCH v2] " Jani Nikula 2023-08-25 13:01 ` Jani Nikula 2023-08-25 13:01 ` Jani Nikula 2023-08-30 10:26 ` [Intel-gfx] " Hans Verkuil 2023-08-30 10:26 ` Hans Verkuil 2023-08-30 9:57 ` [Intel-gfx] [PATCH 4/6] " Hans Verkuil 2023-08-30 9:57 ` Hans Verkuil 2023-08-30 10:23 ` [Intel-gfx] " Jani Nikula 2023-08-30 10:23 ` Jani Nikula 2023-08-24 13:46 ` [Intel-gfx] [PATCH 5/6] drm/i915/cec: switch to setting physical address directly Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-30 9:57 ` [Intel-gfx] " Hans Verkuil 2023-08-30 9:57 ` Hans Verkuil 2023-08-24 13:46 ` [Intel-gfx] [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-24 13:46 ` Jani Nikula 2023-08-30 10:03 ` [Intel-gfx] " Hans Verkuil 2023-08-30 10:03 ` Hans Verkuil 2023-08-31 10:52 ` [Intel-gfx] " Jani Nikula 2023-08-31 10:52 ` Jani Nikula 2023-08-31 10:51 ` [Intel-gfx] [PATCH v2] " Jani Nikula 2023-08-31 10:51 ` Jani Nikula 2023-08-31 11:38 ` [Intel-gfx] " Hans Verkuil 2023-08-31 11:38 ` Hans Verkuil 2023-08-24 19:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, cec and edid updates Patchwork 2023-08-24 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-08-25 9:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-08-25 16:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, cec and edid updates (rev2) Patchwork 2023-08-25 16:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-08-26 8:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-08-31 14:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm, cec and edid updates (rev3) Patchwork 2023-08-31 14:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-08-31 18:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2023-08-31 18:51 ` [Intel-gfx] [PATCH 0/6] drm, cec and edid updates Jani Nikula 2023-08-31 18:51 ` Jani Nikula 2023-08-31 18:51 ` Jani Nikula 2023-08-31 21:32 ` [Intel-gfx] " Hans Verkuil 2023-08-31 21:32 ` Hans Verkuil 2023-09-01 7:24 ` [Intel-gfx] " Maxime Ripard 2023-09-01 7:24 ` Maxime Ripard 2023-09-01 7:24 ` Maxime Ripard 2023-09-01 8:57 ` [Intel-gfx] " Jani Nikula 2023-09-01 8:57 ` Jani Nikula 2023-09-01 8:57 ` Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.