All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huaweicloud.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	catalin.marinas@arm.com, thunder.leizhen@huawei.com,
	dyoung@redhat.com, prudo@redhat.com, samuel.holland@sifive.com,
	kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
	x86@kernel.org
Subject: Re: [PATCH v2 4/8] crash_core: add generic function to do reservation
Date: Fri, 1 Sep 2023 18:08:55 +0800	[thread overview]
Message-ID: <ZPG4Nzd/4JdU1Ft4@MiWiFi-R3L-srv> (raw)
In-Reply-To: <df395f20-55e9-169b-846b-f55d21d00861@huaweicloud.com>

On 08/31/23 at 11:23am, Leizhen (ThunderTown) wrote:
......
> > +void __init reserve_crashkernel_generic(char *cmdline,
> > +			     unsigned long long crash_size,
> > +			     unsigned long long crash_base,
> > +			     unsigned long long crash_low_size,
> > +			     bool high)
> > +{
> > +	unsigned long long search_end = CRASH_ADDR_LOW_MAX, search_base = 0;
> > +	bool fixed_base = false;
> > +
> > +	/* User specifies base address explicitly. */
> > +	if (crash_base) {
> > +		fixed_base = true;
> > +		search_base = crash_base;
> > +		search_end = crash_base + crash_size;
> > +	}
> > +
> > +	if (high) {
> 
> It might be a little clearer to use "else if (high) {"

Makes sense, will update.

> 
> > +		search_base = CRASH_ADDR_LOW_MAX;
> > +		search_end = CRASH_ADDR_HIGH_MAX;
> > +	}
> > +
> > +retry:
> > +	crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN,
> > +					       search_base, search_end);
......


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huaweicloud.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	catalin.marinas@arm.com, thunder.leizhen@huawei.com,
	dyoung@redhat.com, prudo@redhat.com, samuel.holland@sifive.com,
	kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
	x86@kernel.org
Subject: Re: [PATCH v2 4/8] crash_core: add generic function to do reservation
Date: Fri, 1 Sep 2023 18:08:55 +0800	[thread overview]
Message-ID: <ZPG4Nzd/4JdU1Ft4@MiWiFi-R3L-srv> (raw)
In-Reply-To: <df395f20-55e9-169b-846b-f55d21d00861@huaweicloud.com>

On 08/31/23 at 11:23am, Leizhen (ThunderTown) wrote:
......
> > +void __init reserve_crashkernel_generic(char *cmdline,
> > +			     unsigned long long crash_size,
> > +			     unsigned long long crash_base,
> > +			     unsigned long long crash_low_size,
> > +			     bool high)
> > +{
> > +	unsigned long long search_end = CRASH_ADDR_LOW_MAX, search_base = 0;
> > +	bool fixed_base = false;
> > +
> > +	/* User specifies base address explicitly. */
> > +	if (crash_base) {
> > +		fixed_base = true;
> > +		search_base = crash_base;
> > +		search_end = crash_base + crash_size;
> > +	}
> > +
> > +	if (high) {
> 
> It might be a little clearer to use "else if (high) {"

Makes sense, will update.

> 
> > +		search_base = CRASH_ADDR_LOW_MAX;
> > +		search_end = CRASH_ADDR_HIGH_MAX;
> > +	}
> > +
> > +retry:
> > +	crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN,
> > +					       search_base, search_end);
......


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-01 10:09 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 12:16 [PATCH v2 0/8] kdump: use generic functions to simplify crashkernel reservation in arch Baoquan He
2023-08-29 12:16 ` Baoquan He
2023-08-29 12:16 ` [PATCH v2 1/8] crash_core.c: remove unnecessary parameter of function Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-31  1:25   ` Leizhen (ThunderTown)
2023-08-31  1:25     ` Leizhen (ThunderTown)
2023-08-29 12:16 ` [PATCH v2 2/8] crash_core: change the prototype of function parse_crashkernel() Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-31  2:30   ` Leizhen (ThunderTown)
2023-08-31  2:30     ` Leizhen (ThunderTown)
2023-08-29 12:16 ` [PATCH v2 3/8] crash_core: change parse_crashkernel() to support crashkernel=,high|low parsing Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-31  2:56   ` Leizhen (ThunderTown)
2023-08-31  2:56     ` Leizhen (ThunderTown)
2023-09-01  9:49     ` Baoquan He
2023-09-01  9:49       ` Baoquan He
2023-09-04  2:47       ` Leizhen (ThunderTown)
2023-09-04  2:47         ` Leizhen (ThunderTown)
2023-09-05  8:29         ` Baoquan He
2023-09-05  8:29           ` Baoquan He
2023-09-06  9:07           ` Leizhen (ThunderTown)
2023-09-06  9:07             ` Leizhen (ThunderTown)
2023-09-11  2:11             ` Baoquan He
2023-09-11  2:11               ` Baoquan He
2023-08-29 12:16 ` [PATCH v2 4/8] crash_core: add generic function to do reservation Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-31  3:23   ` Leizhen (ThunderTown)
2023-08-31  3:23     ` Leizhen (ThunderTown)
2023-09-01 10:08     ` Baoquan He [this message]
2023-09-01 10:08       ` Baoquan He
2023-08-29 12:16 ` [PATCH v2 5/8] crash_core.h: include <asm/crash_core.h> if generic reservation is needed Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-29 12:16 ` [PATCH v2 6/8] x86: kdump: use generic interface to simplify crashkernel reservation code Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-29 21:37   ` kernel test robot
2023-08-29 21:37     ` kernel test robot
2023-08-29 21:37     ` kernel test robot
2023-08-30  1:49   ` kernel test robot
2023-08-30  1:49     ` kernel test robot
2023-08-30  1:49     ` kernel test robot
2023-08-30 11:39     ` Baoquan He
2023-08-30 11:39       ` Baoquan He
2023-08-30 11:39       ` Baoquan He
2023-08-31  3:43   ` Leizhen (ThunderTown)
2023-08-31  3:43     ` Leizhen (ThunderTown)
2023-09-01 10:10     ` Baoquan He
2023-09-01 10:10       ` Baoquan He
2023-08-29 12:16 ` [PATCH v2 7/8] arm64: kdump: use generic interface to simplify crashkernel reservation Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-31  3:51   ` Leizhen (ThunderTown)
2023-08-31  3:51     ` Leizhen (ThunderTown)
2023-08-29 12:16 ` [PATCH v2 8/8] crash_core.c: remove unneeded functions Baoquan He
2023-08-29 12:16   ` Baoquan He
2023-08-31  3:51   ` Leizhen (ThunderTown)
2023-08-31  3:51     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPG4Nzd/4JdU1Ft4@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prudo@redhat.com \
    --cc=samuel.holland@sifive.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=thunder.leizhen@huaweicloud.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.