* [PATCH] configfs: fix a race in configfs_lookup() in stable-5.10.y
@ 2023-09-02 0:50 Kyle Zeng
2023-09-02 6:45 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Kyle Zeng @ 2023-09-02 0:50 UTC (permalink / raw)
To: gregkh, jlbec, hch, linux-kernel
Basically porting c42dd069be8dfc9b2239a5c89e73bbd08ab35de0 to
stable-v5.10.y to avoid race condition between configfs_dir_lseek and
configfs_lookup since they both operate ->s_childre and configfs_lookup
forgets to obtain the lock.
Signed-off-by: Kyle Zeng <zengyhkyle@gmail.com>
---
fs/configfs/dir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 12388ed4faa5..0b7e9ab517d5 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -479,6 +479,7 @@ static struct dentry * configfs_lookup(struct inode *dir,
if (!configfs_dirent_is_ready(parent_sd))
goto out;
+ spin_lock(&configfs_dirent_lock);
list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
if (sd->s_type & CONFIGFS_NOT_PINNED) {
const unsigned char * name = configfs_get_name(sd);
@@ -491,6 +492,7 @@ static struct dentry * configfs_lookup(struct inode *dir,
break;
}
}
+ spin_unlock(&configfs_dirent_lock);
if (!found) {
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] configfs: fix a race in configfs_lookup() in stable-5.10.y
2023-09-02 0:50 [PATCH] configfs: fix a race in configfs_lookup() in stable-5.10.y Kyle Zeng
@ 2023-09-02 6:45 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-09-02 6:45 UTC (permalink / raw)
To: Kyle Zeng; +Cc: jlbec, hch, linux-kernel
On Fri, Sep 01, 2023 at 05:50:37PM -0700, Kyle Zeng wrote:
> Basically porting c42dd069be8dfc9b2239a5c89e73bbd08ab35de0 to
> stable-v5.10.y to avoid race condition between configfs_dir_lseek and
> configfs_lookup since they both operate ->s_childre and configfs_lookup
> forgets to obtain the lock.
>
> Signed-off-by: Kyle Zeng <zengyhkyle@gmail.com>
> ---
> fs/configfs/dir.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
> index 12388ed4faa5..0b7e9ab517d5 100644
> --- a/fs/configfs/dir.c
> +++ b/fs/configfs/dir.c
> @@ -479,6 +479,7 @@ static struct dentry * configfs_lookup(struct inode *dir,
> if (!configfs_dirent_is_ready(parent_sd))
> goto out;
>
> + spin_lock(&configfs_dirent_lock);
> list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
> if (sd->s_type & CONFIGFS_NOT_PINNED) {
> const unsigned char * name = configfs_get_name(sd);
> @@ -491,6 +492,7 @@ static struct dentry * configfs_lookup(struct inode *dir,
> break;
> }
> }
> + spin_unlock(&configfs_dirent_lock);
>
> if (!found) {
> /*
> --
> 2.34.1
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-02 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-02 0:50 [PATCH] configfs: fix a race in configfs_lookup() in stable-5.10.y Kyle Zeng
2023-09-02 6:45 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.