From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Fei Yang" <fei.yang@intel.com>,
daniel.vetter@ffwll.ch, "Imre Deak" <imre.deak@intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"David Airlie" <airlied@gmail.com>,
ville.syrjala@linux.intel.com,
"Rob Clark" <robdclark@chromium.org>,
amd-gfx@lists.freedesktop.org,
"Matthew Auld" <matthew.auld@intel.com>,
"Mika Kahola" <mika.kahola@intel.com>,
"Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
seanpaul@chromium.org,
"José Roberto de Souza" <jose.souza@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
daniel@ffwll.ch
Subject: Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs
Date: Mon, 4 Sep 2023 08:32:40 +0200 [thread overview]
Message-ID: <ZPV6CMBlDWriMyva@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230903184607.272198-4-jim.cromie@gmail.com>
Hi Jim,
On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
>
> No functional changes.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Andrzej Hajda <andrzej.hajda@intel.com>,
David Airlie <airlied@gmail.com>,
Rob Clark <robdclark@chromium.org>,
amd-gfx@lists.freedesktop.org,
Matthew Auld <matthew.auld@intel.com>,
jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
seanpaul@chromium.org, Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
linux-kernel@vger.kernel.org, daniel@ffwll.ch
Subject: Re: [Intel-gfx] [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs
Date: Mon, 4 Sep 2023 08:32:40 +0200 [thread overview]
Message-ID: <ZPV6CMBlDWriMyva@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230903184607.272198-4-jim.cromie@gmail.com>
Hi Jim,
On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
>
> No functional changes.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Fei Yang" <fei.yang@intel.com>,
daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Rob Clark" <robdclark@chromium.org>,
amd-gfx@lists.freedesktop.org,
"Matthew Auld" <matthew.auld@intel.com>,
"Mika Kahola" <mika.kahola@intel.com>,
"Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
seanpaul@chromium.org,
"José Roberto de Souza" <jose.souza@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Radhakrishna Sripada" <radhakrishna.sripada@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs
Date: Mon, 4 Sep 2023 08:32:40 +0200 [thread overview]
Message-ID: <ZPV6CMBlDWriMyva@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230903184607.272198-4-jim.cromie@gmail.com>
Hi Jim,
On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
>
> No functional changes.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
next prev parent reply other threads:[~2023-09-04 6:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 18:45 [PATCH v2 0/6] drm_dbg: add trailing newlines where missing Jim Cromie
2023-09-03 18:45 ` Jim Cromie
2023-09-03 18:45 ` [Intel-gfx] " Jim Cromie
2023-09-03 18:45 ` [PATCH v2 1/6] drm_dbg: add trailing newlines to msgs Jim Cromie
2023-09-03 18:45 ` Jim Cromie
2023-09-03 18:45 ` [Intel-gfx] " Jim Cromie
2023-09-03 18:45 ` [PATCH v2 2/6] " Jim Cromie
2023-09-03 18:45 ` Jim Cromie
2023-09-03 18:45 ` [Intel-gfx] " Jim Cromie
2023-09-03 18:46 ` [PATCH v2 3/6] " Jim Cromie
2023-09-03 18:46 ` Jim Cromie
2023-09-03 18:46 ` [Intel-gfx] " Jim Cromie
2023-09-04 6:32 ` Andi Shyti [this message]
2023-09-04 6:32 ` Andi Shyti
2023-09-04 6:32 ` [Intel-gfx] " Andi Shyti
2023-09-06 16:42 ` Rodrigo Vivi
2023-09-06 16:42 ` Rodrigo Vivi
2023-09-06 16:42 ` [Intel-gfx] " Rodrigo Vivi
2023-09-06 18:06 ` jim.cromie
2023-09-06 18:06 ` jim.cromie
2023-09-06 18:06 ` [Intel-gfx] " jim.cromie
2023-09-03 18:46 ` [PATCH v2 4/6] " Jim Cromie
2023-09-03 18:46 ` Jim Cromie
2023-09-03 18:46 ` Jim Cromie
2023-09-03 18:46 ` [Intel-gfx] " Jim Cromie
2023-09-03 18:46 ` [PATCH v2 5/6] " Jim Cromie
2023-09-03 18:46 ` Jim Cromie
2023-09-03 18:46 ` [Intel-gfx] " Jim Cromie
2023-09-03 18:46 ` [PATCH v2 6/6] drm: use correct ccflags-y syntax Jim Cromie
2023-09-03 18:46 ` Jim Cromie
2023-09-03 18:46 ` [Intel-gfx] " Jim Cromie
2023-09-03 19:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_dbg: add trailing newlines where missing (rev2) Patchwork
2023-09-03 19:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-03 19:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-03 20:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPV6CMBlDWriMyva@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=Jason@zx2c4.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.yang@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=jim.cromie@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.souza@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=mika.kahola@intel.com \
--cc=radhakrishna.sripada@intel.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@chromium.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.