All of lore.kernel.org
 help / color / mirror / Atom feed
* [master-next][PATCH] virtiofsd: add seccomp to REQUIRED_DISTRO_FEATURES
@ 2023-09-01 19:01 Martin Jansa
  2023-09-04  3:06 ` [meta-virtualization] " Bruce Ashfield
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Jansa @ 2023-09-01 19:01 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

* otherwise causes world build failures for DISTROs without seccomp:

  ERROR: Nothing PROVIDES 'libseccomp' (but meta-virtualization/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb DEPENDS on or otherwise requires it)
  libseccomp was skipped: missing required distro feature 'seccomp' (not in DISTRO_FEATURES)

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-extended/virtiofsd/virtiofsd_1.7.0.bb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb b/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb
index 7224888..b8a9382 100644
--- a/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb
+++ b/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb
@@ -6,8 +6,11 @@ LIC_FILES_CHKSUM = " \
     file://LICENSE-APACHE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
     file://LICENSE-BSD-3-Clause;md5=b1ed361f9fc790c1054d81a7ef041a34 \
 "
-DEPENDS += "libseccomp"
-DEPENDS += "libcap-ng"
+
+DEPENDS = "libseccomp libcap-ng"
+
+inherit features_check
+REQUIRED_DISTRO_FEATURES = "seccomp"
 
 SRC_URI += "crate://crates.io/virtiofsd/1.7.0"
 SRC_URI[virtiofsd-1.7.0.sha256sum] = "6f043afa23aedbb18f36084b9df831796a9e4c62e73a16fe557de0cf30d7708d"
-- 
2.42.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-virtualization] [master-next][PATCH] virtiofsd: add seccomp to REQUIRED_DISTRO_FEATURES
  2023-09-01 19:01 [master-next][PATCH] virtiofsd: add seccomp to REQUIRED_DISTRO_FEATURES Martin Jansa
@ 2023-09-04  3:06 ` Bruce Ashfield
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2023-09-04  3:06 UTC (permalink / raw)
  To: Martin Jansa; +Cc: meta-virtualization

Thanks Martin,

This is on master-next (soon to become master)

Bruce

In message: [meta-virtualization] [master-next][PATCH] virtiofsd: add seccomp to REQUIRED_DISTRO_FEATURES
on 01/09/2023 Martin Jansa wrote:

> * otherwise causes world build failures for DISTROs without seccomp:
> 
>   ERROR: Nothing PROVIDES 'libseccomp' (but meta-virtualization/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb DEPENDS on or otherwise requires it)
>   libseccomp was skipped: missing required distro feature 'seccomp' (not in DISTRO_FEATURES)
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  recipes-extended/virtiofsd/virtiofsd_1.7.0.bb | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb b/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb
> index 7224888..b8a9382 100644
> --- a/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb
> +++ b/recipes-extended/virtiofsd/virtiofsd_1.7.0.bb
> @@ -6,8 +6,11 @@ LIC_FILES_CHKSUM = " \
>      file://LICENSE-APACHE;md5=3b83ef96387f14655fc854ddc3c6bd57 \
>      file://LICENSE-BSD-3-Clause;md5=b1ed361f9fc790c1054d81a7ef041a34 \
>  "
> -DEPENDS += "libseccomp"
> -DEPENDS += "libcap-ng"
> +
> +DEPENDS = "libseccomp libcap-ng"
> +
> +inherit features_check
> +REQUIRED_DISTRO_FEATURES = "seccomp"
>  
>  SRC_URI += "crate://crates.io/virtiofsd/1.7.0"
>  SRC_URI[virtiofsd-1.7.0.sha256sum] = "6f043afa23aedbb18f36084b9df831796a9e4c62e73a16fe557de0cf30d7708d"
> -- 
> 2.42.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8264): https://lists.yoctoproject.org/g/meta-virtualization/message/8264
> Mute This Topic: https://lists.yoctoproject.org/mt/101101651/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-04  3:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-01 19:01 [master-next][PATCH] virtiofsd: add seccomp to REQUIRED_DISTRO_FEATURES Martin Jansa
2023-09-04  3:06 ` [meta-virtualization] " Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.