Re: [PATCH 1/8] counter: chrdev: fix getting array extensions

From: William Breathitt Gray <william.gray@linaro.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: lee@kernel.org, alexandre.torgue@foss.st.com,
	linux-iio@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] counter: chrdev: fix getting array extensions
Date: Mon, 4 Sep 2023 16:36:35 -0400	[thread overview]
Message-ID: <ZPY/033Z0dDi5zJB@ishi> (raw)
In-Reply-To: <20230829134029.2402868-2-fabrice.gasnier@foss.st.com>

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Tue, Aug 29, 2023 at 03:40:22PM +0200, Fabrice Gasnier wrote:
> When trying to watch a component array extension, and the array isn't the
> first extended element, it fails as the type comparison is always done on
> the 1st element. Fix it by indexing the 'ext' array.
> 
> Example on a dummy struct counter_comp:
> static struct counter_comp dummy[] = {
> 	COUNTER_COMP_DIRECTION(..),
> 	...,
> 	COUNTER_COMP_ARRAY_CAPTURE(...),
> };
> static struct counter_count dummy_cnt = {
> 	...
> 	.ext = dummy,
> 	.num_ext = ARRAY_SIZE(dummy),
> }
> 
> Currently, counter_get_ext() returns -EINVAL when trying to add a watch
> event on one of the capture array element in such example.
> 
> Fixes: d2011be1e22f ("counter: Introduce the COUNTER_COMP_ARRAY component type")
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Applied to counter-fixes as commit 3170256d7bc1.

Thanks,

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]