From: Baoquan He <bhe@redhat.com>
To: "chenjiahao (C)" <chenjiahao16@huawei.com>
Cc: robh@kernel.org, aou@eecs.berkeley.edu, zephray@outlook.com,
alexghiti@rivosinc.com, thunder.leizhen@huawei.com,
bjorn@rivosinc.com, linux-kernel@vger.kernel.org,
conor.dooley@microchip.com, palmer@dabbelt.com,
jszhang@kernel.org, paul.walmsley@sifive.com,
akpm@linux-foundation.org, linux-riscv@lists.infradead.org,
ajones@ventanamicro.com
Subject: Re: [PATCH -next] riscv: kdump: fix crashkernel reserving problem on RISC-V
Date: Fri, 22 Sep 2023 18:28:27 +0800 [thread overview]
Message-ID: <ZQ1sSzUueObu7KZH@MiWiFi-R3L-srv> (raw)
In-Reply-To: <c590ac5d-91b9-ec3b-6899-a18c16c9f980@huawei.com>
On 09/22/23 at 05:33pm, chenjiahao (C) wrote:
>
> On 2023/9/22 15:16, Baoquan He wrote:
> > Hi Jiahao,
> >
> > On 09/22/23 at 11:07am, Chen Jiahao wrote:
> > > When testing on risc-v QEMU environment with "crashkernel="
> > > parameter enabled, a problem occurred with the following
> > > message:
> > >
> > > [ 0.000000] crashkernel low memory reserved: 0xf8000000 - 0x100000000 (128 MB)
> > > [ 0.000000] crashkernel reserved: 0x0000000177e00000 - 0x0000000277e00000 (4096 MB)
> > > [ 0.000000] ------------[ cut here ]------------
> > > [ 0.000000] WARNING: CPU: 0 PID: 0 at kernel/resource.c:779 __insert_resource+0x8e/0xd0
> > > [ 0.000000] Modules linked in:
> > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.0-rc2-next-20230920 #1
> > > [ 0.000000] Hardware name: riscv-virtio,qemu (DT)
> > > [ 0.000000] epc : __insert_resource+0x8e/0xd0
> > > [ 0.000000] ra : insert_resource+0x28/0x4e
> > > [ 0.000000] epc : ffffffff80017344 ra : ffffffff8001742e sp : ffffffff81203db0
> > > [ 0.000000] gp : ffffffff812ece98 tp : ffffffff8120dac0 t0 : ff600001f7ff2b00
> > > [ 0.000000] t1 : 0000000000000000 t2 : 3428203030303030 s0 : ffffffff81203dc0
> > > [ 0.000000] s1 : ffffffff81211e18 a0 : ffffffff81211e18 a1 : ffffffff81289380
> > > [ 0.000000] a2 : 0000000277dfffff a3 : 0000000177e00000 a4 : 0000000177e00000
> > > [ 0.000000] a5 : ffffffff81289380 a6 : 0000000277dfffff a7 : 0000000000000078
> > > [ 0.000000] s2 : ffffffff81289380 s3 : ffffffff80a0bac8 s4 : ff600001f7ff2880
> > > [ 0.000000] s5 : 0000000000000280 s6 : 8000000a00006800 s7 : 000000000000007f
> > > [ 0.000000] s8 : 0000000080017038 s9 : 0000000080038ea0 s10: 0000000000000000
> > > [ 0.000000] s11: 0000000000000000 t3 : ffffffff80a0bc00 t4 : ffffffff80a0bc00
> > > [ 0.000000] t5 : ffffffff80a0bbd0 t6 : ffffffff80a0bc00
> > > [ 0.000000] status: 0000000200000100 badaddr: 0000000000000000 cause: 0000000000000003
> > > [ 0.000000] [<ffffffff80017344>] __insert_resource+0x8e/0xd0
> > > [ 0.000000] ---[ end trace 0000000000000000 ]---
> > > [ 0.000000] Failed to add a Crash kernel resource at 177e00000
> > >
> > > The crashkernel memory has been allocated successfully, whereas
> > > it failed to insert into iomem_resource. This is due to the
> > This is a warning, not a failure, right? Inserting crashk_*res into
> > iomem_resource has been successful, just the repeated inserting cause
> > the warning. Maybe, we should tell this in log clearly? Other than minor
> > concern, this looks good to me, thanks for the testing and this fix:
>
> Thanks for reviewing. Actually this is not only a warning message.
> Since when failure occurs in riscv's init_resources(),
>
> error:
> release_child_resources(&iomem_resource);
>
> will get called, already added crashkernel memory will hence
> get removed. To verify this, I have checked but cannot find
> crashkernel memory in /proc/iomem when this problem occurs.
I see, I was mistaken then. Thanks for telling.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: "chenjiahao (C)" <chenjiahao16@huawei.com>
Cc: thunder.leizhen@huawei.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
conor.dooley@microchip.com, alexghiti@rivosinc.com,
ajones@ventanamicro.com, jszhang@kernel.org,
sunilvl@ventanamicro.com, robh@kernel.org, bjorn@rivosinc.com,
zephray@outlook.com, akpm@linux-foundation.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] riscv: kdump: fix crashkernel reserving problem on RISC-V
Date: Fri, 22 Sep 2023 18:28:27 +0800 [thread overview]
Message-ID: <ZQ1sSzUueObu7KZH@MiWiFi-R3L-srv> (raw)
In-Reply-To: <c590ac5d-91b9-ec3b-6899-a18c16c9f980@huawei.com>
On 09/22/23 at 05:33pm, chenjiahao (C) wrote:
>
> On 2023/9/22 15:16, Baoquan He wrote:
> > Hi Jiahao,
> >
> > On 09/22/23 at 11:07am, Chen Jiahao wrote:
> > > When testing on risc-v QEMU environment with "crashkernel="
> > > parameter enabled, a problem occurred with the following
> > > message:
> > >
> > > [ 0.000000] crashkernel low memory reserved: 0xf8000000 - 0x100000000 (128 MB)
> > > [ 0.000000] crashkernel reserved: 0x0000000177e00000 - 0x0000000277e00000 (4096 MB)
> > > [ 0.000000] ------------[ cut here ]------------
> > > [ 0.000000] WARNING: CPU: 0 PID: 0 at kernel/resource.c:779 __insert_resource+0x8e/0xd0
> > > [ 0.000000] Modules linked in:
> > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.0-rc2-next-20230920 #1
> > > [ 0.000000] Hardware name: riscv-virtio,qemu (DT)
> > > [ 0.000000] epc : __insert_resource+0x8e/0xd0
> > > [ 0.000000] ra : insert_resource+0x28/0x4e
> > > [ 0.000000] epc : ffffffff80017344 ra : ffffffff8001742e sp : ffffffff81203db0
> > > [ 0.000000] gp : ffffffff812ece98 tp : ffffffff8120dac0 t0 : ff600001f7ff2b00
> > > [ 0.000000] t1 : 0000000000000000 t2 : 3428203030303030 s0 : ffffffff81203dc0
> > > [ 0.000000] s1 : ffffffff81211e18 a0 : ffffffff81211e18 a1 : ffffffff81289380
> > > [ 0.000000] a2 : 0000000277dfffff a3 : 0000000177e00000 a4 : 0000000177e00000
> > > [ 0.000000] a5 : ffffffff81289380 a6 : 0000000277dfffff a7 : 0000000000000078
> > > [ 0.000000] s2 : ffffffff81289380 s3 : ffffffff80a0bac8 s4 : ff600001f7ff2880
> > > [ 0.000000] s5 : 0000000000000280 s6 : 8000000a00006800 s7 : 000000000000007f
> > > [ 0.000000] s8 : 0000000080017038 s9 : 0000000080038ea0 s10: 0000000000000000
> > > [ 0.000000] s11: 0000000000000000 t3 : ffffffff80a0bc00 t4 : ffffffff80a0bc00
> > > [ 0.000000] t5 : ffffffff80a0bbd0 t6 : ffffffff80a0bc00
> > > [ 0.000000] status: 0000000200000100 badaddr: 0000000000000000 cause: 0000000000000003
> > > [ 0.000000] [<ffffffff80017344>] __insert_resource+0x8e/0xd0
> > > [ 0.000000] ---[ end trace 0000000000000000 ]---
> > > [ 0.000000] Failed to add a Crash kernel resource at 177e00000
> > >
> > > The crashkernel memory has been allocated successfully, whereas
> > > it failed to insert into iomem_resource. This is due to the
> > This is a warning, not a failure, right? Inserting crashk_*res into
> > iomem_resource has been successful, just the repeated inserting cause
> > the warning. Maybe, we should tell this in log clearly? Other than minor
> > concern, this looks good to me, thanks for the testing and this fix:
>
> Thanks for reviewing. Actually this is not only a warning message.
> Since when failure occurs in riscv's init_resources(),
>
> error:
> release_child_resources(&iomem_resource);
>
> will get called, already added crashkernel memory will hence
> get removed. To verify this, I have checked but cannot find
> crashkernel memory in /proc/iomem when this problem occurs.
I see, I was mistaken then. Thanks for telling.
next prev parent reply other threads:[~2023-09-22 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 3:07 [PATCH -next] riscv: kdump: fix crashkernel reserving problem on RISC-V Chen Jiahao
2023-09-22 3:07 ` Chen Jiahao
2023-09-22 7:16 ` Baoquan He
2023-09-22 7:16 ` Baoquan He
2023-09-22 9:33 ` chenjiahao (C)
2023-09-22 9:33 ` chenjiahao (C)
2023-09-22 10:28 ` Baoquan He [this message]
2023-09-22 10:28 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ1sSzUueObu7KZH@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=ajones@ventanamicro.com \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn@rivosinc.com \
--cc=chenjiahao16@huawei.com \
--cc=conor.dooley@microchip.com \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=zephray@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.