* [PATCH v1 1/5] perf parse-events: Remove unused header files
@ 2023-09-11 17:05 Ian Rogers
2023-09-11 17:05 ` [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build Ian Rogers
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Ian Rogers @ 2023-09-11 17:05 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Gaosheng Cui,
Rob Herring, linux-perf-users, linux-kernel, bpf
The fnmatch header is now used in the PMU matching logic in pmu.c.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/parse-events.y | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 21bfe7e0d944..ef03728b7ea3 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -9,11 +9,8 @@
#define YYDEBUG 1
#include <errno.h>
-#include <fnmatch.h>
-#include <stdio.h>
#include <linux/compiler.h>
#include <linux/types.h>
-#include <linux/zalloc.h>
#include "pmu.h"
#include "pmus.h"
#include "evsel.h"
--
2.42.0.283.g2d96d420d3-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build
2023-09-11 17:05 [PATCH v1 1/5] perf parse-events: Remove unused header files Ian Rogers
@ 2023-09-11 17:05 ` Ian Rogers
2023-09-12 5:59 ` Namhyung Kim
2023-09-11 17:05 ` [PATCH v1 3/5] perf expr: " Ian Rogers
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Ian Rogers @ 2023-09-11 17:05 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Gaosheng Cui,
Rob Herring, linux-perf-users, linux-kernel, bpf
YYDEBUG enables line numbers and other error helpers in the generated
parse-events-bison.c. These shouldn't be generated when debugging
isn't enabled.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/parse-events.y | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index ef03728b7ea3..786393106ae6 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -6,7 +6,9 @@
%{
+#ifndef NDEBUG
#define YYDEBUG 1
+#endif
#include <errno.h>
#include <linux/compiler.h>
--
2.42.0.283.g2d96d420d3-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 3/5] perf expr: Make YYDEBUG dependent on doing a debug build
2023-09-11 17:05 [PATCH v1 1/5] perf parse-events: Remove unused header files Ian Rogers
2023-09-11 17:05 ` [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build Ian Rogers
@ 2023-09-11 17:05 ` Ian Rogers
2023-09-12 6:00 ` Namhyung Kim
2023-09-11 17:05 ` [PATCH v1 4/5] perf pmu: Add YYDEBUG Ian Rogers
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Ian Rogers @ 2023-09-11 17:05 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Gaosheng Cui,
Rob Herring, linux-perf-users, linux-kernel, bpf
YYDEBUG enables line numbers and other error helpers in the generated
expr-bison.c. These shouldn't be generated when debugging
isn't enabled.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/expr.y | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
index 6c93b358cc2d..e364790babb5 100644
--- a/tools/perf/util/expr.y
+++ b/tools/perf/util/expr.y
@@ -1,6 +1,8 @@
/* Simple expression parser */
%{
+#ifndef NDEBUG
#define YYDEBUG 1
+#endif
#include <assert.h>
#include <math.h>
#include <stdlib.h>
--
2.42.0.283.g2d96d420d3-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 4/5] perf pmu: Add YYDEBUG
2023-09-11 17:05 [PATCH v1 1/5] perf parse-events: Remove unused header files Ian Rogers
2023-09-11 17:05 ` [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build Ian Rogers
2023-09-11 17:05 ` [PATCH v1 3/5] perf expr: " Ian Rogers
@ 2023-09-11 17:05 ` Ian Rogers
2023-09-12 6:00 ` Namhyung Kim
2023-09-11 17:05 ` [PATCH v1 5/5] perf bpf-filter: " Ian Rogers
2023-09-12 5:58 ` [PATCH v1 1/5] perf parse-events: Remove unused header files Namhyung Kim
4 siblings, 1 reply; 11+ messages in thread
From: Ian Rogers @ 2023-09-11 17:05 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Gaosheng Cui,
Rob Herring, linux-perf-users, linux-kernel, bpf
YYDEBUG enables line numbers and other error helpers in the generated
pmu-bison.c. Conditionally enabled only for debug builds.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/pmu.y | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
index 600c8c158c8e..198907a8a48a 100644
--- a/tools/perf/util/pmu.y
+++ b/tools/perf/util/pmu.y
@@ -5,6 +5,10 @@
%{
+#ifndef NDEBUG
+#define YYDEBUG 1
+#endif
+
#include <linux/compiler.h>
#include <linux/list.h>
#include <linux/bitmap.h>
--
2.42.0.283.g2d96d420d3-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v1 5/5] perf bpf-filter: Add YYDEBUG
2023-09-11 17:05 [PATCH v1 1/5] perf parse-events: Remove unused header files Ian Rogers
` (2 preceding siblings ...)
2023-09-11 17:05 ` [PATCH v1 4/5] perf pmu: Add YYDEBUG Ian Rogers
@ 2023-09-11 17:05 ` Ian Rogers
2023-09-12 6:00 ` Namhyung Kim
2023-09-12 5:58 ` [PATCH v1 1/5] perf parse-events: Remove unused header files Namhyung Kim
4 siblings, 1 reply; 11+ messages in thread
From: Ian Rogers @ 2023-09-11 17:05 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Ian Rogers, Adrian Hunter, Kan Liang, James Clark, Gaosheng Cui,
Rob Herring, linux-perf-users, linux-kernel, bpf
YYDEBUG enables line numbers and other error helpers in the generated
bpf-filter-bison.c. Conditionally enabled only for debug builds.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/bpf-filter.y | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/bpf-filter.y b/tools/perf/util/bpf-filter.y
index 5dfa948fc986..0e4d6de3c2ad 100644
--- a/tools/perf/util/bpf-filter.y
+++ b/tools/perf/util/bpf-filter.y
@@ -3,6 +3,10 @@
%{
+#ifndef NDEBUG
+#define YYDEBUG 1
+#endif
+
#include <stdio.h>
#include <string.h>
#include <linux/compiler.h>
--
2.42.0.283.g2d96d420d3-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v1 1/5] perf parse-events: Remove unused header files
2023-09-11 17:05 [PATCH v1 1/5] perf parse-events: Remove unused header files Ian Rogers
` (3 preceding siblings ...)
2023-09-11 17:05 ` [PATCH v1 5/5] perf bpf-filter: " Ian Rogers
@ 2023-09-12 5:58 ` Namhyung Kim
2023-09-12 20:47 ` Arnaldo Carvalho de Melo
4 siblings, 1 reply; 11+ messages in thread
From: Namhyung Kim @ 2023-09-12 5:58 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, James Clark, Gaosheng Cui, Rob Herring,
linux-perf-users, linux-kernel, bpf
On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
>
> The fnmatch header is now used in the PMU matching logic in pmu.c.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/parse-events.y | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 21bfe7e0d944..ef03728b7ea3 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -9,11 +9,8 @@
> #define YYDEBUG 1
>
> #include <errno.h>
> -#include <fnmatch.h>
> -#include <stdio.h>
> #include <linux/compiler.h>
> #include <linux/types.h>
> -#include <linux/zalloc.h>
> #include "pmu.h"
> #include "pmus.h"
> #include "evsel.h"
> --
> 2.42.0.283.g2d96d420d3-goog
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build
2023-09-11 17:05 ` [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build Ian Rogers
@ 2023-09-12 5:59 ` Namhyung Kim
0 siblings, 0 replies; 11+ messages in thread
From: Namhyung Kim @ 2023-09-12 5:59 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, James Clark, Gaosheng Cui, Rob Herring,
linux-perf-users, linux-kernel, bpf
On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> parse-events-bison.c. These shouldn't be generated when debugging
> isn't enabled.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/parse-events.y | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index ef03728b7ea3..786393106ae6 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -6,7 +6,9 @@
>
> %{
>
> +#ifndef NDEBUG
> #define YYDEBUG 1
> +#endif
>
> #include <errno.h>
> #include <linux/compiler.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 3/5] perf expr: Make YYDEBUG dependent on doing a debug build
2023-09-11 17:05 ` [PATCH v1 3/5] perf expr: " Ian Rogers
@ 2023-09-12 6:00 ` Namhyung Kim
0 siblings, 0 replies; 11+ messages in thread
From: Namhyung Kim @ 2023-09-12 6:00 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, James Clark, Gaosheng Cui, Rob Herring,
linux-perf-users, linux-kernel, bpf
On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> expr-bison.c. These shouldn't be generated when debugging
> isn't enabled.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/expr.y | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index 6c93b358cc2d..e364790babb5 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -1,6 +1,8 @@
> /* Simple expression parser */
> %{
> +#ifndef NDEBUG
> #define YYDEBUG 1
> +#endif
> #include <assert.h>
> #include <math.h>
> #include <stdlib.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 4/5] perf pmu: Add YYDEBUG
2023-09-11 17:05 ` [PATCH v1 4/5] perf pmu: Add YYDEBUG Ian Rogers
@ 2023-09-12 6:00 ` Namhyung Kim
0 siblings, 0 replies; 11+ messages in thread
From: Namhyung Kim @ 2023-09-12 6:00 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, James Clark, Gaosheng Cui, Rob Herring,
linux-perf-users, linux-kernel, bpf
On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> pmu-bison.c. Conditionally enabled only for debug builds.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/pmu.y | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
> index 600c8c158c8e..198907a8a48a 100644
> --- a/tools/perf/util/pmu.y
> +++ b/tools/perf/util/pmu.y
> @@ -5,6 +5,10 @@
>
> %{
>
> +#ifndef NDEBUG
> +#define YYDEBUG 1
> +#endif
> +
> #include <linux/compiler.h>
> #include <linux/list.h>
> #include <linux/bitmap.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 5/5] perf bpf-filter: Add YYDEBUG
2023-09-11 17:05 ` [PATCH v1 5/5] perf bpf-filter: " Ian Rogers
@ 2023-09-12 6:00 ` Namhyung Kim
0 siblings, 0 replies; 11+ messages in thread
From: Namhyung Kim @ 2023-09-12 6:00 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, James Clark, Gaosheng Cui, Rob Herring,
linux-perf-users, linux-kernel, bpf
On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> bpf-filter-bison.c. Conditionally enabled only for debug builds.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/bpf-filter.y | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/util/bpf-filter.y b/tools/perf/util/bpf-filter.y
> index 5dfa948fc986..0e4d6de3c2ad 100644
> --- a/tools/perf/util/bpf-filter.y
> +++ b/tools/perf/util/bpf-filter.y
> @@ -3,6 +3,10 @@
>
> %{
>
> +#ifndef NDEBUG
> +#define YYDEBUG 1
> +#endif
> +
> #include <stdio.h>
> #include <string.h>
> #include <linux/compiler.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 1/5] perf parse-events: Remove unused header files
2023-09-12 5:58 ` [PATCH v1 1/5] perf parse-events: Remove unused header files Namhyung Kim
@ 2023-09-12 20:47 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 11+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-09-12 20:47 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, Kan Liang,
James Clark, Gaosheng Cui, Rob Herring, linux-perf-users,
linux-kernel, bpf
Em Mon, Sep 11, 2023 at 10:58:18PM -0700, Namhyung Kim escreveu:
> On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@google.com> wrote:
> >
> > The fnmatch header is now used in the PMU matching logic in pmu.c.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied the series.
- Arnaldo
> Thanks,
> Namhyung
>
> > ---
> > tools/perf/util/parse-events.y | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > index 21bfe7e0d944..ef03728b7ea3 100644
> > --- a/tools/perf/util/parse-events.y
> > +++ b/tools/perf/util/parse-events.y
> > @@ -9,11 +9,8 @@
> > #define YYDEBUG 1
> >
> > #include <errno.h>
> > -#include <fnmatch.h>
> > -#include <stdio.h>
> > #include <linux/compiler.h>
> > #include <linux/types.h>
> > -#include <linux/zalloc.h>
> > #include "pmu.h"
> > #include "pmus.h"
> > #include "evsel.h"
> > --
> > 2.42.0.283.g2d96d420d3-goog
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-09-12 20:47 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-11 17:05 [PATCH v1 1/5] perf parse-events: Remove unused header files Ian Rogers
2023-09-11 17:05 ` [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build Ian Rogers
2023-09-12 5:59 ` Namhyung Kim
2023-09-11 17:05 ` [PATCH v1 3/5] perf expr: " Ian Rogers
2023-09-12 6:00 ` Namhyung Kim
2023-09-11 17:05 ` [PATCH v1 4/5] perf pmu: Add YYDEBUG Ian Rogers
2023-09-12 6:00 ` Namhyung Kim
2023-09-11 17:05 ` [PATCH v1 5/5] perf bpf-filter: " Ian Rogers
2023-09-12 6:00 ` Namhyung Kim
2023-09-12 5:58 ` [PATCH v1 1/5] perf parse-events: Remove unused header files Namhyung Kim
2023-09-12 20:47 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.