From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Guenter Roeck <linux@roeck-us.net>, Janne Grunau <j@jannau.net>,
Simon Ser <contact@emersion.fr>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
freedreno@lists.freedesktop.org, Won Chung <wonchung@google.com>
Subject: Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"
Date: Wed, 13 Sep 2023 13:34:08 +0300 [thread overview]
Message-ID: <ZQGQIGNUq+UL9lpi@kuha.fi.intel.com> (raw)
In-Reply-To: <a36d7b75-b072-4202-8f09-9eab0dfd52ed@linaro.org>
Hi Neil,
On Wed, Sep 13, 2023 at 11:38:19AM +0200, Neil Armstrong wrote:
> On new platforms (starting from SM8450) UCSI is mandatory to have
> pmic_glink_altmode events triggering.
You can also populate the typec devices conditionally, only if UCSI is
not supported.
However, I took a peek at drivers/soc/qcom/pmic_glink_altmode.c, and
it seems to be mostly is dealing with the muxes and retimer, and
sending the HPD notifications to the DRM side. All that is already
done in typec drivers, so there is actually a potential race here when
UCSI is used.
On top of that, it is sending two commands to the PMIC (ALTMODE_PAN_EN
and ALTMODE_PAN_ACK). I'm pretty sure both could be handled in the UCSI
glue driver (drivers/usb/typec/ucsi/ucsi_glink.c) if they are even
needed when UCSI is supported.
So why do you need that pmic_glibk_altmode driver at all when UCSI is
supported?
I don't know the hardware, so I may be missing something.
thanks,
--
heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: dri-devel@lists.freedesktop.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Janne Grunau <j@jannau.net>, Robert Foss <rfoss@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Andy Gross <agross@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jonas Karlman <jonas@kwiboo.se>,
linux-arm-msm@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Won Chung <wonchung@google.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org
Subject: Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"
Date: Wed, 13 Sep 2023 13:34:08 +0300 [thread overview]
Message-ID: <ZQGQIGNUq+UL9lpi@kuha.fi.intel.com> (raw)
In-Reply-To: <a36d7b75-b072-4202-8f09-9eab0dfd52ed@linaro.org>
Hi Neil,
On Wed, Sep 13, 2023 at 11:38:19AM +0200, Neil Armstrong wrote:
> On new platforms (starting from SM8450) UCSI is mandatory to have
> pmic_glink_altmode events triggering.
You can also populate the typec devices conditionally, only if UCSI is
not supported.
However, I took a peek at drivers/soc/qcom/pmic_glink_altmode.c, and
it seems to be mostly is dealing with the muxes and retimer, and
sending the HPD notifications to the DRM side. All that is already
done in typec drivers, so there is actually a potential race here when
UCSI is used.
On top of that, it is sending two commands to the PMIC (ALTMODE_PAN_EN
and ALTMODE_PAN_ACK). I'm pretty sure both could be handled in the UCSI
glue driver (drivers/usb/typec/ucsi/ucsi_glink.c) if they are even
needed when UCSI is supported.
So why do you need that pmic_glibk_altmode driver at all when UCSI is
supported?
I don't know the hardware, so I may be missing something.
thanks,
--
heikki
next prev parent reply other threads:[~2023-09-13 10:34 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 21:41 [RFC PATCH v1 00/12] drm,usb/typec: uABI for USB-C DisplayPort connectors Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 00/12] drm, usb/typec: " Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors" Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-05 8:49 ` Heikki Krogerus
2023-09-05 8:49 ` Heikki Krogerus
2023-09-05 10:56 ` Dmitry Baryshkov
2023-09-05 10:56 ` Dmitry Baryshkov
2023-09-06 12:44 ` Heikki Krogerus
2023-09-06 12:44 ` Heikki Krogerus
2023-09-06 12:48 ` Dmitry Baryshkov
2023-09-06 12:48 ` Dmitry Baryshkov
2023-09-06 12:53 ` Laurent Pinchart
2023-09-06 12:53 ` Laurent Pinchart
2023-09-06 14:32 ` Maxime Ripard
2023-09-06 14:32 ` Maxime Ripard
2023-09-06 13:38 ` Heikki Krogerus
2023-09-06 13:38 ` Heikki Krogerus
2023-09-11 21:15 ` Dmitry Baryshkov
2023-09-11 21:15 ` Dmitry Baryshkov
2023-09-12 11:05 ` Heikki Krogerus
2023-09-12 11:05 ` Heikki Krogerus
2023-09-12 17:39 ` Dmitry Baryshkov
2023-09-12 17:39 ` Dmitry Baryshkov
2023-09-13 9:27 ` Heikki Krogerus
2023-09-13 9:27 ` Heikki Krogerus
2023-09-13 10:26 ` Dmitry Baryshkov
2023-09-13 10:26 ` Dmitry Baryshkov
2023-09-13 13:14 ` Heikki Krogerus
2023-09-13 13:14 ` Heikki Krogerus
2023-09-13 13:47 ` Dmitry Baryshkov
2023-09-13 13:47 ` Dmitry Baryshkov
2023-09-14 9:26 ` Heikki Krogerus
2023-09-14 9:26 ` Heikki Krogerus
2023-09-14 9:35 ` Neil Armstrong
2023-09-14 9:35 ` Neil Armstrong
2023-09-14 10:16 ` Dmitry Baryshkov
2023-09-14 10:16 ` Dmitry Baryshkov
2023-09-14 10:40 ` Dmitry Baryshkov
2023-09-14 10:40 ` Dmitry Baryshkov
2023-09-14 14:55 ` Heikki Krogerus
2023-09-14 14:55 ` Heikki Krogerus
2023-09-13 9:38 ` Neil Armstrong
2023-09-13 9:38 ` Neil Armstrong
2023-09-13 10:34 ` Heikki Krogerus [this message]
2023-09-13 10:34 ` Heikki Krogerus
2023-09-13 3:00 ` [Freedreno] " Rob Clark
2023-09-13 3:00 ` Rob Clark
2023-09-03 21:41 ` [RFC PATCH v1 02/12] drm/sysfs: link DRM connector device to the connector's fw nodes Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 03/12] drm/connector: extend PATH property to covert Type-C case Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-10-03 9:15 ` Simon Ser
2023-10-03 9:15 ` Simon Ser
2023-09-03 21:41 ` [RFC PATCH v1 04/12] drm/bridge-connector: set the PATH property for the connector Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 05/12] drm/bridge: remove conditionals around devicetree pointers Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 06/12] soc: qcom: pmic_glink_altmode: fix DRM connector type Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-04 15:42 ` Bjorn Andersson
2023-09-04 15:42 ` Bjorn Andersson
2023-09-03 21:41 ` [RFC PATCH v1 07/12] soc: qcom: pmic_glink_altmode: report that this is a Type-C connector Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-04 15:43 ` Bjorn Andersson
2023-09-04 15:43 ` Bjorn Andersson
2023-09-04 15:45 ` Dmitry Baryshkov
2023-09-04 15:45 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 08/12] usb: typec: support generating Type-C port names for userspace Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 09/12] usb: typec: tcpm: " Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 10/12] usb: typec: qcom: implement proper error path in probe() Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 11/12] usb: typec: qcom: extract DRM bridge functionality to separate file Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-03 21:41 ` [RFC PATCH v1 12/12] usb: typec: qcom: define the bridge's path Dmitry Baryshkov
2023-09-03 21:41 ` Dmitry Baryshkov
2023-09-15 12:14 ` Heikki Krogerus
2023-09-15 12:14 ` Heikki Krogerus
2023-10-23 18:24 ` Dmitry Baryshkov
2023-10-23 18:24 ` Dmitry Baryshkov
2023-10-30 8:19 ` Heikki Krogerus
2023-10-30 8:19 ` Heikki Krogerus
2023-10-30 9:47 ` Dmitry Baryshkov
2023-10-30 9:47 ` Dmitry Baryshkov
2023-10-30 10:13 ` Simon Ser
2023-10-30 10:13 ` Simon Ser
2023-10-30 10:22 ` Dmitry Baryshkov
2023-10-30 10:22 ` Dmitry Baryshkov
2023-10-30 10:26 ` Simon Ser
2023-10-30 10:26 ` Simon Ser
2023-10-30 12:12 ` Dmitry Baryshkov
2023-10-30 12:12 ` Dmitry Baryshkov
2023-09-04 15:46 ` [RFC PATCH v1 00/12] drm,usb/typec: uABI for USB-C DisplayPort connectors Bjorn Andersson
2023-09-04 15:46 ` Bjorn Andersson
2023-09-04 15:49 ` Dmitry Baryshkov
2023-09-04 15:49 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQGQIGNUq+UL9lpi@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=bryan.odonoghue@linaro.org \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=j@jannau.net \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wonchung@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.