From: John Watts <contact@jookia.org>
To: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: dri-devel@lists.freedesktop.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Chris Morgan <macromorgan@hotmail.com>,
linux-kernel@vger.kernel.org, Jagan Teki <jagan@edgeble.ai>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel
Date: Thu, 14 Sep 2023 14:09:20 +1000 [thread overview]
Message-ID: <ZQKHcDZ-mxNaSe0j@titan> (raw)
In-Reply-To: <d46ee183-a010-e585-c47c-fa3229eafb33@quicinc.com>
On Wed, Sep 13, 2023 at 02:34:38PM -0700, Jessica Zhang wrote:
> Hi John,
>
> Having a separate panel_regs_len field seems a bit unnecessary to me.
>
> Looks like it's only being called in the panel prepare() and I don't seen
> any reason why we shouldn't just call the ARRAY_SIZE() macro there.
Can you call ARRAY_SIZE on an an array pointer?
>
> Thanks,
>
> Jessica Zhang
John.
WARNING: multiple messages have this Message-ID (diff)
From: John Watts <contact@jookia.org>
To: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jagan Teki <jagan@edgeble.ai>, Rob Herring <robh+dt@kernel.org>,
Chris Morgan <macromorgan@hotmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel
Date: Thu, 14 Sep 2023 14:09:20 +1000 [thread overview]
Message-ID: <ZQKHcDZ-mxNaSe0j@titan> (raw)
In-Reply-To: <d46ee183-a010-e585-c47c-fa3229eafb33@quicinc.com>
On Wed, Sep 13, 2023 at 02:34:38PM -0700, Jessica Zhang wrote:
> Hi John,
>
> Having a separate panel_regs_len field seems a bit unnecessary to me.
>
> Looks like it's only being called in the panel prepare() and I don't seen
> any reason why we shouldn't just call the ARRAY_SIZE() macro there.
Can you call ARRAY_SIZE on an an array pointer?
>
> Thanks,
>
> Jessica Zhang
John.
next prev parent reply other threads:[~2023-09-14 4:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 9:01 [RFC PATCH 0/8] Add FS035VG158 panel John Watts
2023-09-11 9:01 ` John Watts
2023-09-11 9:01 ` [RFC PATCH 1/8] drm/panel: nv3052c: Document known register names John Watts
2023-09-11 9:01 ` John Watts
2023-09-13 21:43 ` Jessica Zhang
2023-09-13 21:43 ` Jessica Zhang
2023-09-14 4:12 ` John Watts
2023-09-14 4:12 ` John Watts
2023-09-14 20:27 ` Jessica Zhang
2023-09-14 20:27 ` Jessica Zhang
2023-09-11 9:02 ` [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs John Watts
2023-09-11 9:02 ` John Watts
2023-09-15 21:50 ` Jessica Zhang
2023-09-15 21:50 ` Jessica Zhang
2023-09-11 9:02 ` [RFC PATCH 3/8] drm/panel: nv3052c: Sleep for 150ms after reset John Watts
2023-09-11 9:02 ` John Watts
2023-09-11 9:02 ` [RFC PATCH 4/8] drm/panel: nv3052c: Wait before entering sleep mode John Watts
2023-09-11 9:02 ` John Watts
2023-09-11 9:02 ` [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel John Watts
2023-09-11 9:02 ` John Watts
2023-09-13 21:34 ` Jessica Zhang
2023-09-13 21:34 ` Jessica Zhang
2023-09-14 4:09 ` John Watts [this message]
2023-09-14 4:09 ` John Watts
2023-09-14 20:22 ` Jessica Zhang
2023-09-14 20:22 ` Jessica Zhang
2023-09-15 21:23 ` Jessica Zhang
2023-09-15 21:23 ` Jessica Zhang
2023-09-11 9:02 ` [RFC PATCH 6/8] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display John Watts
2023-09-11 9:02 ` John Watts
2023-09-11 9:02 ` [RFC PATCH 7/8] dt-bindings: vendor-prefixes: Add fascontek John Watts
2023-09-11 9:02 ` John Watts
2023-09-11 9:41 ` Krzysztof Kozlowski
2023-09-11 9:41 ` Krzysztof Kozlowski
2023-09-11 9:02 ` [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek FS035VG158 panel John Watts
2023-09-11 9:02 ` John Watts
2023-09-11 9:41 ` Krzysztof Kozlowski
2023-09-11 9:41 ` Krzysztof Kozlowski
2023-09-11 9:49 ` John Watts
2023-09-11 9:49 ` John Watts
2023-09-11 11:49 ` Krzysztof Kozlowski
2023-09-11 11:49 ` Krzysztof Kozlowski
2023-09-11 16:47 ` John Watts
2023-09-11 16:47 ` John Watts
2023-09-12 6:55 ` Krzysztof Kozlowski
2023-09-12 6:55 ` Krzysztof Kozlowski
2023-09-12 8:56 ` John Watts
2023-09-12 8:56 ` John Watts
2023-09-17 20:24 ` John Watts
2023-09-17 20:24 ` John Watts
2023-09-18 12:06 ` Krzysztof Kozlowski
2023-09-18 12:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQKHcDZ-mxNaSe0j@titan \
--to=contact@jookia.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.