All of lore.kernel.org
 help / color / mirror / Atom feed
* [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3
@ 2023-09-08  9:13 Federico Serafini
  2023-09-19  8:25 ` Federico Serafini
  2023-09-19  8:31 ` Roger Pau Monné
  0 siblings, 2 replies; 3+ messages in thread
From: Federico Serafini @ 2023-09-08  9:13 UTC (permalink / raw)
  To: xen-devel; +Cc: consulting, Federico Serafini, Roger Pau Monné

Make function declaration consistent with the corresponding definition.
No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/include/xen/vpci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 0b8a2a3c74..d743d96a10 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
                __used_section(".data.vpci." p) = x
 
 /* Add vPCI handlers to device. */
-int __must_check vpci_add_handlers(struct pci_dev *dev);
+int __must_check vpci_add_handlers(struct pci_dev *pdev);
 
 /* Remove all handlers and free vpci related structures. */
 void vpci_remove_device(struct pci_dev *pdev);
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3
  2023-09-08  9:13 [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3 Federico Serafini
@ 2023-09-19  8:25 ` Federico Serafini
  2023-09-19  8:31 ` Roger Pau Monné
  1 sibling, 0 replies; 3+ messages in thread
From: Federico Serafini @ 2023-09-19  8:25 UTC (permalink / raw)
  To: xen-devel; +Cc: consulting, Roger Pau Monné

On 08/09/23 11:13, Federico Serafini wrote:
> Make function declaration consistent with the corresponding definition.
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> ---
>   xen/include/xen/vpci.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 0b8a2a3c74..d743d96a10 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
>                  __used_section(".data.vpci." p) = x
>   
>   /* Add vPCI handlers to device. */
> -int __must_check vpci_add_handlers(struct pci_dev *dev);
> +int __must_check vpci_add_handlers(struct pci_dev *pdev);
>   
>   /* Remove all handlers and free vpci related structures. */
>   void vpci_remove_device(struct pci_dev *pdev);

Are there any chances of getting an ack?

-- 
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3
  2023-09-08  9:13 [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3 Federico Serafini
  2023-09-19  8:25 ` Federico Serafini
@ 2023-09-19  8:31 ` Roger Pau Monné
  1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2023-09-19  8:31 UTC (permalink / raw)
  To: Federico Serafini; +Cc: xen-devel, consulting

On Fri, Sep 08, 2023 at 11:13:31AM +0200, Federico Serafini wrote:
> Make function declaration consistent with the corresponding definition.
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-19  8:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-08  9:13 [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3 Federico Serafini
2023-09-19  8:25 ` Federico Serafini
2023-09-19  8:31 ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.