* [PATCH v2] drm/i915: refactor deprecated strncpy
@ 2023-09-19 4:45 ` Justin Stitt
0 siblings, 0 replies; 8+ messages in thread
From: Justin Stitt @ 2023-09-19 4:45 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter
Cc: intel-gfx, Justin Stitt, linux-kernel, dri-devel, linux-hardening
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding. `ctx` is zero allocated and as such strncpy's
NUL-padding behavior was strictly a performance hit which is now
resolved.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
---
Changes in v2:
- drop the `... - 1` (thanks Kees)
- Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v1-1-c3f92df942e0@google.com
---
drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index 8ac6726ec16b..e199d7dbb876 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -36,7 +36,7 @@ mock_context(struct drm_i915_private *i915,
if (name) {
struct i915_ppgtt *ppgtt;
- strncpy(ctx->name, name, sizeof(ctx->name) - 1);
+ strscpy(ctx->name, name, sizeof(ctx->name));
ppgtt = mock_ppgtt(i915, name);
if (!ppgtt)
---
base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec
change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142
Best regards,
--
Justin Stitt <justinstitt@google.com>
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] drm/i915: refactor deprecated strncpy
@ 2023-09-19 4:45 ` Justin Stitt
0 siblings, 0 replies; 8+ messages in thread
From: Justin Stitt @ 2023-09-19 4:45 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter
Cc: intel-gfx, dri-devel, linux-kernel, linux-hardening, Justin Stitt
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding. `ctx` is zero allocated and as such strncpy's
NUL-padding behavior was strictly a performance hit which is now
resolved.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
---
Changes in v2:
- drop the `... - 1` (thanks Kees)
- Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v1-1-c3f92df942e0@google.com
---
drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
index 8ac6726ec16b..e199d7dbb876 100644
--- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
@@ -36,7 +36,7 @@ mock_context(struct drm_i915_private *i915,
if (name) {
struct i915_ppgtt *ppgtt;
- strncpy(ctx->name, name, sizeof(ctx->name) - 1);
+ strscpy(ctx->name, name, sizeof(ctx->name));
ppgtt = mock_ppgtt(i915, name);
if (!ppgtt)
---
base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec
change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142
Best regards,
--
Justin Stitt <justinstitt@google.com>
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: refactor deprecated strncpy (rev2)
2023-09-19 4:45 ` Justin Stitt
(?)
(?)
@ 2023-09-19 6:09 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-09-19 6:09 UTC (permalink / raw)
To: Justin Stitt; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4114 bytes --]
== Series Details ==
Series: drm/i915: refactor deprecated strncpy (rev2)
URL : https://patchwork.freedesktop.org/series/123858/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13651 -> Patchwork_123858v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_123858v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@engines@fds:
- bat-mtlp-6: [PASS][1] -> [ABORT][2] ([i915#9262])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/bat-mtlp-6/igt@gem_exec_parallel@engines@fds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/bat-mtlp-6/igt@gem_exec_parallel@engines@fds.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-adlp-9: NOTRUN -> [SKIP][5] ([i915#3546]) +2 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/bat-adlp-9/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
- bat-dg2-11: NOTRUN -> [SKIP][6] ([i915#1845]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][7] -> [ABORT][8] ([i915#8668])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [ABORT][9] ([i915#7913]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [FAIL][11] ([IGT#3] / [i915#6121]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9262]: https://gitlab.freedesktop.org/drm/intel/issues/9262
Build changes
-------------
* Linux: CI_DRM_13651 -> Patchwork_123858v2
CI-20190529: 20190529
CI_DRM_13651: 61b71c3f061a44a6ab1dcf756918886aa03a5480 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7493: 2517e42d612e0c1ca096acf8b5f6177f7ef4bce7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_123858v2: 61b71c3f061a44a6ab1dcf756918886aa03a5480 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
42a2d801357d drm/i915: refactor deprecated strncpy
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/index.html
[-- Attachment #2: Type: text/html, Size: 4885 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: refactor deprecated strncpy (rev2)
2023-09-19 4:45 ` Justin Stitt
` (2 preceding siblings ...)
(?)
@ 2023-09-20 5:44 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2023-09-20 5:44 UTC (permalink / raw)
To: Justin Stitt; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 61940 bytes --]
== Series Details ==
Series: drm/i915: refactor deprecated strncpy (rev2)
URL : https://patchwork.freedesktop.org/series/123858/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13651_full -> Patchwork_123858v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_123858v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_123858v2_full, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 10)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_123858v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_crc@cursor-offscreen-256x85@pipe-d-edp-1:
- shard-mtlp: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-7/igt@kms_cursor_crc@cursor-offscreen-256x85@pipe-d-edp-1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-5/igt@kms_cursor_crc@cursor-offscreen-256x85@pipe-d-edp-1.html
* igt@kms_selftest@drm_format_helper:
- shard-dg2: NOTRUN -> [TIMEOUT][3] +2 other tests timeout
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@kms_selftest@drm_format_helper.html
* igt@kms_selftest@framebuffer:
- shard-mtlp: NOTRUN -> [TIMEOUT][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@kms_selftest@framebuffer.html
Known issues
------------
Here are the changes found in Patchwork_123858v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@blit-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][5] ([i915#8411])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@api_intel_bb@blit-reloc-purge-cache.html
* igt@device_reset@unbind-cold-reset-rebind:
- shard-dg2: NOTRUN -> [SKIP][6] ([i915#7701])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@device_reset@unbind-cold-reset-rebind.html
* igt@drm_fdinfo@busy-hang@bcs0:
- shard-dg2: NOTRUN -> [SKIP][7] ([i915#8414]) +20 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@drm_fdinfo@busy-hang@bcs0.html
* igt@drm_fdinfo@busy@vcs0:
- shard-mtlp: NOTRUN -> [SKIP][8] ([i915#8414]) +5 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@drm_fdinfo@busy@vcs0.html
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [PASS][9] -> [FAIL][10] ([i915#7742])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_basic@multigpu-create-close:
- shard-dg2: NOTRUN -> [SKIP][11] ([i915#7697])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@gem_basic@multigpu-create-close.html
* igt@gem_ccs@ctrl-surf-copy:
- shard-mtlp: NOTRUN -> [SKIP][12] ([i915#3555]) +1 other test skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_ccs@ctrl-surf-copy.html
* igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0:
- shard-dg2: [PASS][13] -> [INCOMPLETE][14] ([i915#7297])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg2-2/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-2/igt@gem_ccs@suspend-resume@linear-compressed-compfmt0-lmem0-lmem0.html
* igt@gem_ctx_isolation@preservation@ccs0:
- shard-mtlp: [PASS][15] -> [ABORT][16] ([i915#9262]) +1 other test abort
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-4/igt@gem_ctx_isolation@preservation@ccs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-1/igt@gem_ctx_isolation@preservation@ccs0.html
* igt@gem_ctx_persistence@engines-hang@vcs0:
- shard-mtlp: NOTRUN -> [FAIL][17] ([i915#2410])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_ctx_persistence@engines-hang@vcs0.html
* igt@gem_ctx_persistence@heartbeat-stop:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#8555]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@gem_ctx_persistence@heartbeat-stop.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#1099])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-snb4/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_eio@unwedge-stress:
- shard-snb: NOTRUN -> [FAIL][20] ([i915#8898])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-snb4/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@bonded-pair:
- shard-mtlp: NOTRUN -> [SKIP][21] ([i915#4771])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_exec_balancer@bonded-pair.html
* igt@gem_exec_balancer@hang:
- shard-mtlp: [PASS][22] -> [ABORT][23] ([i915#8104] / [i915#9262])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-5/igt@gem_exec_balancer@hang.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@gem_exec_balancer@hang.html
* igt@gem_exec_balancer@hog:
- shard-dg2: NOTRUN -> [SKIP][24] ([i915#4812])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@gem_exec_balancer@hog.html
* igt@gem_exec_fair@basic-none-share:
- shard-mtlp: NOTRUN -> [SKIP][25] ([i915#4473] / [i915#4771])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_exec_fair@basic-none-share.html
* igt@gem_exec_fair@basic-pace-solo:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#3539])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gem_exec_fair@basic-pace-solo.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#2842])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-glk3/igt@gem_exec_fair@basic-pace@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk3/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_flush@basic-wb-rw-before-default:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#3539] / [i915#4852]) +2 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gem_exec_flush@basic-wb-rw-before-default.html
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-dg2: NOTRUN -> [SKIP][30] ([i915#3281]) +4 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@gem_exec_reloc@basic-gtt-cpu-active.html
* igt@gem_exec_reloc@basic-write-cpu-active:
- shard-mtlp: NOTRUN -> [SKIP][31] ([i915#3281]) +5 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_exec_reloc@basic-write-cpu-active.html
* igt@gem_exec_schedule@preempt-queue-chain:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#4537] / [i915#4812])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@gem_exec_schedule@preempt-queue-chain.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- shard-dg2: [PASS][33] -> [ABORT][34] ([i915#7975] / [i915#8213])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg2-11/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-10/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
- shard-dg1: [PASS][35] -> [ABORT][36] ([i915#7975] / [i915#8213])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-18/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_fence_thrash@bo-copy:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#4860]) +1 other test skip
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@gem_fence_thrash@bo-copy.html
* igt@gem_fence_thrash@bo-write-verify-x:
- shard-mtlp: NOTRUN -> [SKIP][38] ([i915#4860]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@gem_fence_thrash@bo-write-verify-x.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-mtlp: NOTRUN -> [SKIP][39] ([i915#4613]) +2 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_mmap@bad-size:
- shard-mtlp: NOTRUN -> [SKIP][40] ([i915#4083]) +5 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@gem_mmap@bad-size.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-mtlp: NOTRUN -> [SKIP][41] ([i915#4077]) +3 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#4077]) +9 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
* igt@gem_mmap_wc@copy:
- shard-dg2: NOTRUN -> [SKIP][43] ([i915#4083])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gem_mmap_wc@copy.html
* igt@gem_partial_pwrite_pread@reads-uncached:
- shard-mtlp: NOTRUN -> [SKIP][44] ([i915#3282])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@gem_partial_pwrite_pread@reads-uncached.html
* igt@gem_partial_pwrite_pread@write-display:
- shard-dg2: NOTRUN -> [SKIP][45] ([i915#3282]) +2 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@gem_partial_pwrite_pread@write-display.html
* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-dg2: NOTRUN -> [SKIP][46] ([i915#4270]) +2 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@gem_pxp@verify-pxp-execution-after-suspend-resume.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-mtlp: NOTRUN -> [SKIP][47] ([i915#4270]) +2 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-mtlp: NOTRUN -> [SKIP][48] ([i915#8428])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#5190]) +7 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@gem_render_copy@y-tiled-to-vebox-linear.html
* igt@gem_tiled_pread_pwrite:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#4079]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gem_tiled_pread_pwrite.html
* igt@gem_unfence_active_buffers:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#4879])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gem_unfence_active_buffers.html
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#3297]) +4 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gem_userptr_blits@create-destroy-unsync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#3297] / [i915#4880]) +1 other test skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-tglu: NOTRUN -> [SKIP][54] ([i915#3297])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-7/igt@gem_userptr_blits@unsync-overlap.html
* igt@gen7_exec_parse@basic-offset:
- shard-dg2: NOTRUN -> [SKIP][55] ([fdo#109289]) +6 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@gen7_exec_parse@basic-offset.html
* igt@gen7_exec_parse@basic-rejected:
- shard-mtlp: NOTRUN -> [SKIP][56] ([fdo#109289])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@gen7_exec_parse@basic-rejected.html
* igt@gen9_exec_parse@allowed-single:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#2856]) +1 other test skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@shadow-peek:
- shard-mtlp: NOTRUN -> [SKIP][58] ([i915#2856])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: NOTRUN -> [WARN][59] ([i915#7356])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [PASS][60] -> [SKIP][61] ([i915#1397]) +1 other test skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-2/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-dg2: NOTRUN -> [SKIP][62] ([i915#1397])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@i915_pm_rps@basic-api:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#6621])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@i915_pm_rps@basic-api.html
* igt@i915_pm_rps@waitboost:
- shard-mtlp: NOTRUN -> [FAIL][64] ([i915#8346])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@i915_pm_rps@waitboost.html
* igt@i915_query@query-topology-unsupported:
- shard-dg2: NOTRUN -> [SKIP][65] ([fdo#109302])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@i915_query@query-topology-unsupported.html
* igt@i915_suspend@debugfs-reader:
- shard-snb: NOTRUN -> [DMESG-WARN][66] ([i915#8841])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-snb4/igt@i915_suspend@debugfs-reader.html
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- shard-mtlp: NOTRUN -> [SKIP][67] ([i915#4212])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-mtlp: NOTRUN -> [SKIP][68] ([i915#5190])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- shard-dg2: NOTRUN -> [SKIP][69] ([i915#4215] / [i915#5190])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-edp-1-4-rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][70] ([i915#8502]) +11 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-edp-1-4-rc_ccs.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][71] ([i915#8502] / [i915#8709]) +11 other tests skip
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-5/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][72] ([i915#8502]) +3 other tests skip
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-b-hdmi-a-1-y-rc_ccs.html
* igt@kms_async_flips@crc@pipe-c-hdmi-a-1:
- shard-dg1: NOTRUN -> [FAIL][73] ([i915#8247]) +3 other tests fail
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-19/igt@kms_async_flips@crc@pipe-c-hdmi-a-1.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [PASS][74] -> [FAIL][75] ([i915#5138])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@linear-64bpp-rotate-270:
- shard-mtlp: NOTRUN -> [SKIP][76] ([fdo#111614]) +1 other test skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_big_fb@linear-64bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-dg2: NOTRUN -> [SKIP][77] ([fdo#111614]) +2 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglu: [PASS][78] -> [FAIL][79] ([i915#3743])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-tglu-9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-mtlp: NOTRUN -> [SKIP][80] ([fdo#111615]) +4 other tests skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-dg2: NOTRUN -> [SKIP][81] ([i915#4538] / [i915#5190]) +4 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][82] ([i915#5354]) +33 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][83] ([i915#5354] / [i915#6095])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#3886])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk4/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#3689] / [i915#3886] / [i915#5354]) +9 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#3886])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-apl4/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-4_tiled_mtl_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][87] ([fdo#109271]) +19 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk4/igt@kms_ccs@pipe-b-missing-ccs-buffer-4_tiled_mtl_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][88] ([i915#6095]) +16 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][89] ([i915#3886] / [i915#6095]) +6 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#3689] / [i915#5354]) +11 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-dg2: NOTRUN -> [SKIP][91] ([i915#4087] / [i915#7213])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_cdclk@mode-transition-all-outputs.html
- shard-mtlp: NOTRUN -> [SKIP][92] ([i915#7213] / [i915#9010])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-5/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_cdclk@plane-scaling@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][93] ([i915#4087]) +3 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_cdclk@plane-scaling@pipe-c-edp-1.html
* igt@kms_chamelium_audio@dp-audio:
- shard-mtlp: NOTRUN -> [SKIP][94] ([i915#7828]) +4 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_chamelium_audio@dp-audio.html
* igt@kms_chamelium_color@gamma:
- shard-dg2: NOTRUN -> [SKIP][95] ([fdo#111827])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@kms_chamelium_color@gamma.html
* igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k:
- shard-dg2: NOTRUN -> [SKIP][96] ([i915#7828]) +4 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k.html
* igt@kms_content_protection@atomic-dpms:
- shard-mtlp: NOTRUN -> [SKIP][97] ([i915#6944])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-dg2: NOTRUN -> [SKIP][98] ([i915#3299])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-mtlp: NOTRUN -> [SKIP][99] ([i915#3299]) +1 other test skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@srm:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#7118]) +2 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-mtlp: NOTRUN -> [SKIP][101] ([i915#3359])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_cursor_crc@cursor-onscreen-512x512.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x32:
- shard-mtlp: NOTRUN -> [SKIP][102] ([i915#3555] / [i915#8814]) +1 other test skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_cursor_crc@cursor-rapid-movement-32x32.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-dg2: NOTRUN -> [SKIP][103] ([fdo#109274] / [fdo#111767] / [i915#5354])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-dg2: NOTRUN -> [SKIP][104] ([fdo#109274] / [i915#5354]) +3 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-snb: NOTRUN -> [SKIP][105] ([fdo#109271] / [fdo#111767])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-snb4/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][106] ([i915#3804])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#3555]) +4 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html
* igt@kms_draw_crc@draw-method-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][108] ([i915#8812])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_draw_crc@draw-method-mmap-wc.html
* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-dg2: NOTRUN -> [SKIP][109] ([i915#8381])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_flip@2x-flip-vs-fences-interruptible.html
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-dg2: NOTRUN -> [SKIP][110] ([fdo#109274]) +3 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][111] ([i915#3637]) +4 other tests skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [PASS][112] -> [FAIL][113] ([i915#79])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][114] ([i915#2587] / [i915#2672])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][115] ([i915#2672] / [i915#3555])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#2672]) +4 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][117] ([i915#2672]) +2 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-dg2: [PASS][118] -> [FAIL][119] ([i915#6880])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#8708]) +12 other tests skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][121] ([i915#8708]) +4 other tests skip
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
- shard-tglu: NOTRUN -> [SKIP][122] ([fdo#110189])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
- shard-dg2: NOTRUN -> [SKIP][123] ([i915#3458]) +8 other tests skip
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-onoff:
- shard-mtlp: NOTRUN -> [SKIP][124] ([i915#1825]) +10 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-tglu: NOTRUN -> [SKIP][125] ([fdo#109280])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_hdr@static-swap:
- shard-dg2: NOTRUN -> [SKIP][126] ([i915#3555] / [i915#8228]) +2 other tests skip
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-6/igt@kms_hdr@static-swap.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][127] ([i915#8292])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-6/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [FAIL][128] ([i915#8292])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-13/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-3.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-hdmi-a-1:
- shard-dg1: NOTRUN -> [SKIP][129] ([i915#5176]) +15 other tests skip
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-19/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-c-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][130] ([i915#5176]) +3 other tests skip
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-c-edp-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][131] ([i915#5176]) +1 other test skip
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-7/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][132] ([i915#5235]) +15 other tests skip
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d-dp-4.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][133] ([i915#5235]) +11 other tests skip
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-13/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-3.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][134] ([fdo#109271]) +86 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-snb4/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][135] ([i915#5235]) +5 other tests skip
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-7/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][136] ([i915#5235]) +7 other tests skip
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-edp-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75@pipe-c-dp-1:
- shard-apl: NOTRUN -> [SKIP][137] ([fdo#109271]) +43 other tests skip
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-apl4/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75@pipe-c-dp-1.html
* igt@kms_prime@basic-modeset-hybrid:
- shard-mtlp: NOTRUN -> [SKIP][138] ([i915#6524])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@kms_prime@basic-modeset-hybrid.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-glk: NOTRUN -> [SKIP][139] ([fdo#109271] / [i915#658])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk4/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg2: NOTRUN -> [SKIP][140] ([i915#658]) +1 other test skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_sprite_blt:
- shard-dg2: NOTRUN -> [SKIP][141] ([i915#1072]) +4 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-11/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_rotation_crc@primary-rotation-90:
- shard-mtlp: NOTRUN -> [SKIP][142] ([i915#4235]) +1 other test skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_rotation_crc@primary-rotation-90.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-mtlp: NOTRUN -> [SKIP][143] ([i915#5289]) +1 other test skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-8/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-d:
- shard-mtlp: NOTRUN -> [SKIP][144] ([i915#5030]) +3 other tests skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-d.html
* igt@kms_setmode@invalid-clone-single-crtc-stealing:
- shard-mtlp: NOTRUN -> [SKIP][145] ([i915#3555] / [i915#8809])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_setmode@invalid-clone-single-crtc-stealing.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-d:
- shard-tglu: [PASS][146] -> [FAIL][147] ([i915#9196])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-tglu-10/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-10/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-mtlp: NOTRUN -> [ABORT][148] ([i915#9262]) +1 other test abort
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@kms_vrr@flip-suspend:
- shard-mtlp: NOTRUN -> [SKIP][149] ([i915#3555] / [i915#8808])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_vrr@flip-suspend.html
* igt@perf@gen12-group-concurrent-oa-buffer-read:
- shard-mtlp: NOTRUN -> [FAIL][150] ([i915#9259])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@perf@gen12-group-concurrent-oa-buffer-read.html
* igt@perf_pmu@busy-double-start@vcs1:
- shard-dg1: [PASS][151] -> [FAIL][152] ([i915#4349]) +1 other test fail
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-15/igt@perf_pmu@busy-double-start@vcs1.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-15/igt@perf_pmu@busy-double-start@vcs1.html
* igt@perf_pmu@busy-hang@ccs0:
- shard-mtlp: NOTRUN -> [FAIL][153] ([i915#4349]) +8 other tests fail
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@perf_pmu@busy-hang@ccs0.html
* igt@perf_pmu@event-wait@rcs0:
- shard-dg2: NOTRUN -> [SKIP][154] ([fdo#112283])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@perf_pmu@event-wait@rcs0.html
* igt@perf_pmu@faulting-read@gtt:
- shard-mtlp: NOTRUN -> [SKIP][155] ([i915#8440])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@perf_pmu@faulting-read@gtt.html
* igt@perf_pmu@frequency@gt0:
- shard-dg2: NOTRUN -> [FAIL][156] ([i915#6806])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@perf_pmu@frequency@gt0.html
* igt@perf_pmu@rc6-all-gts:
- shard-mtlp: NOTRUN -> [ABORT][157] ([i915#9268] / [i915#9335])
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@perf_pmu@rc6-all-gts.html
* igt@prime_vgem@basic-gtt:
- shard-dg2: NOTRUN -> [SKIP][158] ([i915#3708] / [i915#4077])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-write:
- shard-dg2: NOTRUN -> [SKIP][159] ([i915#3291] / [i915#3708])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@prime_vgem@basic-write.html
* igt@prime_vgem@fence-read-hang:
- shard-dg2: NOTRUN -> [SKIP][160] ([i915#3708]) +1 other test skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@prime_vgem@fence-read-hang.html
* igt@v3d/v3d_job_submission@array-job-submission:
- shard-mtlp: NOTRUN -> [SKIP][161] ([i915#2575]) +6 other tests skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@v3d/v3d_job_submission@array-job-submission.html
* igt@v3d/v3d_wait_bo@used-bo-1ns:
- shard-dg2: NOTRUN -> [SKIP][162] ([i915#2575]) +7 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@v3d/v3d_wait_bo@used-bo-1ns.html
* igt@vc4/vc4_purgeable_bo@mark-purgeable-twice:
- shard-mtlp: NOTRUN -> [SKIP][163] ([i915#7711]) +1 other test skip
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-3/igt@vc4/vc4_purgeable_bo@mark-purgeable-twice.html
* igt@vc4/vc4_wait_bo@unused-bo-1ns:
- shard-dg2: NOTRUN -> [SKIP][164] ([i915#7711]) +6 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-7/igt@vc4/vc4_wait_bo@unused-bo-1ns.html
#### Possible fixes ####
* igt@gem_exec_endless@dispatch@vecs0:
- shard-dg1: [TIMEOUT][165] ([i915#3778]) -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-16/igt@gem_exec_endless@dispatch@vecs0.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-19/igt@gem_exec_endless@dispatch@vecs0.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglu: [FAIL][167] ([i915#2842]) -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-tglu-6/igt@gem_exec_fair@basic-flow@rcs0.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-5/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: [FAIL][169] ([i915#2842]) -> [PASS][170]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-rkl-4/igt@gem_exec_fair@basic-pace@rcs0.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [INCOMPLETE][171] ([i915#5566]) -> [PASS][172]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-apl4/igt@gen9_exec_parse@allowed-single.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-apl4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-mtlp: [ABORT][173] ([i915#8489] / [i915#8668]) -> [PASS][174]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-7/igt@i915_module_load@reload-with-fault-injection.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-5/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][175] ([i915#1397]) -> [PASS][176] +1 other test pass
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-6/igt@i915_pm_rpm@dpms-non-lpsp.html
- shard-dg1: [SKIP][177] ([i915#1397]) -> [PASS][178] +2 other tests pass
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-19/igt@i915_pm_rpm@dpms-non-lpsp.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-13/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-dg2: [SKIP][179] ([i915#1397]) -> [PASS][180] +2 other tests pass
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-5/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][181] ([i915#5334]) -> [PASS][182]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-glk2/igt@i915_selftest@live@gt_heartbeat.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk9/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@requests:
- shard-mtlp: [ABORT][183] ([i915#9262]) -> [PASS][184] +1 other test pass
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-2/igt@i915_selftest@live@requests.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-dg1: [DMESG-WARN][185] ([i915#4391] / [i915#4423]) -> [PASS][186]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-17/igt@i915_suspend@basic-s3-without-i915.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-18/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_rc_ccs:
- shard-dg1: [DMESG-WARN][187] ([i915#4423]) -> [PASS][188]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-17/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_rc_ccs.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-18/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_rc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][189] ([i915#2346]) -> [PASS][190]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-mtlp: [DMESG-WARN][191] ([i915#9262]) -> [PASS][192] +2 other tests pass
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-4/igt@kms_flip@flip-vs-suspend@b-edp1.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-6/igt@kms_flip@flip-vs-suspend@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
- shard-dg2: [FAIL][193] ([i915#6880]) -> [PASS][194]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1:
- shard-apl: [INCOMPLETE][195] ([i915#180]) -> [PASS][196]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html
* igt@kms_plane@pixel-format@pipe-a-planes:
- shard-glk: [DMESG-FAIL][197] ([i915#118]) -> [PASS][198]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-glk2/igt@kms_plane@pixel-format@pipe-a-planes.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-glk8/igt@kms_plane@pixel-format@pipe-a-planes.html
* {igt@kms_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a}:
- shard-dg1: [SKIP][199] ([i915#1937]) -> [PASS][200]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-16/igt@kms_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-19/igt@kms_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-dg2: [FAIL][201] ([fdo#103375]) -> [PASS][202] +2 other tests pass
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg2-5/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg2-6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@device_reset@unbind-reset-rebind:
- shard-dg1: [ABORT][203] ([i915#4983] / [i915#7461]) -> [INCOMPLETE][204] ([i915#4983])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-13/igt@device_reset@unbind-reset-rebind.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-15/igt@device_reset@unbind-reset-rebind.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglu: [FAIL][205] ([i915#2681] / [i915#3591]) -> [WARN][206] ([i915#2681]) +1 other test warn
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-tglu-3/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-tglu-3/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@kms_async_flips@crc@pipe-d-edp-1:
- shard-mtlp: [DMESG-FAIL][207] ([i915#8561]) -> [FAIL][208] ([i915#8247]) +1 other test fail
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-mtlp-4/igt@kms_async_flips@crc@pipe-d-edp-1.html
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-mtlp-1/igt@kms_async_flips@crc@pipe-d-edp-1.html
* igt@kms_content_protection@mei_interface:
- shard-dg1: [SKIP][209] ([fdo#109300]) -> [SKIP][210] ([i915#7116])
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-13/igt@kms_content_protection@mei_interface.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-15/igt@kms_content_protection@mei_interface.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][211] ([i915#3955]) -> [SKIP][212] ([fdo#110189] / [i915#3955]) +1 other test skip
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-1/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][213] ([i915#4070] / [i915#4816]) -> [SKIP][214] ([i915#4816])
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-rkl-2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_psr@cursor_plane_move:
- shard-dg1: [SKIP][215] ([i915#1072]) -> [SKIP][216] ([i915#1072] / [i915#4078]) +1 other test skip
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-dg1-15/igt@kms_psr@cursor_plane_move.html
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-dg1-13/igt@kms_psr@cursor_plane_move.html
* igt@perf@enable-disable:
- shard-snb: [SKIP][217] ([fdo#109271]) -> [INCOMPLETE][218] ([i915#2295])
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13651/shard-snb1/igt@perf@enable-disable.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/shard-snb1/igt@perf@enable-disable.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5978]: https://gitlab.freedesktop.org/drm/intel/issues/5978
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6806]: https://gitlab.freedesktop.org/drm/intel/issues/6806
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7297]: https://gitlab.freedesktop.org/drm/intel/issues/7297
[i915#7356]: https://gitlab.freedesktop.org/drm/intel/issues/7356
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8104]: https://gitlab.freedesktop.org/drm/intel/issues/8104
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8346]: https://gitlab.freedesktop.org/drm/intel/issues/8346
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8440]: https://gitlab.freedesktop.org/drm/intel/issues/8440
[i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
[i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8808]: https://gitlab.freedesktop.org/drm/intel/issues/8808
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
[i915#8812]: https://gitlab.freedesktop.org/drm/intel/issues/8812
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8898]: https://gitlab.freedesktop.org/drm/intel/issues/8898
[i915#9010]: https://gitlab.freedesktop.org/drm/intel/issues/9010
[i915#9196]: https://gitlab.freedesktop.org/drm/intel/issues/9196
[i915#9259]: https://gitlab.freedesktop.org/drm/intel/issues/9259
[i915#9262]: https://gitlab.freedesktop.org/drm/intel/issues/9262
[i915#9268]: https://gitlab.freedesktop.org/drm/intel/issues/9268
[i915#9335]: https://gitlab.freedesktop.org/drm/intel/issues/9335
Build changes
-------------
* Linux: CI_DRM_13651 -> Patchwork_123858v2
CI-20190529: 20190529
CI_DRM_13651: 61b71c3f061a44a6ab1dcf756918886aa03a5480 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7493: 2517e42d612e0c1ca096acf8b5f6177f7ef4bce7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_123858v2: 61b71c3f061a44a6ab1dcf756918886aa03a5480 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123858v2/index.html
[-- Attachment #2: Type: text/html, Size: 72793 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Intel-gfx] [PATCH v2] drm/i915: refactor deprecated strncpy
2023-09-19 4:45 ` Justin Stitt
(?)
@ 2023-09-20 20:54 ` Rodrigo Vivi
-1 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2023-09-20 20:54 UTC (permalink / raw)
To: Justin Stitt
Cc: intel-gfx, linux-kernel, dri-devel, Daniel Vetter, David Airlie,
linux-hardening
On Tue, Sep 19, 2023 at 04:45:31AM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> We should prefer more robust and less ambiguous string interfaces.
>
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer without
> unnecessarily NUL-padding. `ctx` is zero allocated and as such strncpy's
> NUL-padding behavior was strictly a performance hit which is now
> resolved.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
> Changes in v2:
> - drop the `... - 1` (thanks Kees)
> - Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v1-1-c3f92df942e0@google.com
> ---
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushing it right now to drm-intel-gt-next
> drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> index 8ac6726ec16b..e199d7dbb876 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> @@ -36,7 +36,7 @@ mock_context(struct drm_i915_private *i915,
> if (name) {
> struct i915_ppgtt *ppgtt;
>
> - strncpy(ctx->name, name, sizeof(ctx->name) - 1);
> + strscpy(ctx->name, name, sizeof(ctx->name));
>
> ppgtt = mock_ppgtt(i915, name);
> if (!ppgtt)
>
> ---
> base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec
> change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142
>
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/i915: refactor deprecated strncpy
@ 2023-09-20 20:54 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2023-09-20 20:54 UTC (permalink / raw)
To: Justin Stitt
Cc: Tvrtko Ursulin, intel-gfx, linux-kernel, dri-devel,
linux-hardening
On Tue, Sep 19, 2023 at 04:45:31AM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> We should prefer more robust and less ambiguous string interfaces.
>
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer without
> unnecessarily NUL-padding. `ctx` is zero allocated and as such strncpy's
> NUL-padding behavior was strictly a performance hit which is now
> resolved.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
> Changes in v2:
> - drop the `... - 1` (thanks Kees)
> - Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v1-1-c3f92df942e0@google.com
> ---
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushing it right now to drm-intel-gt-next
> drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> index 8ac6726ec16b..e199d7dbb876 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> @@ -36,7 +36,7 @@ mock_context(struct drm_i915_private *i915,
> if (name) {
> struct i915_ppgtt *ppgtt;
>
> - strncpy(ctx->name, name, sizeof(ctx->name) - 1);
> + strscpy(ctx->name, name, sizeof(ctx->name));
>
> ppgtt = mock_ppgtt(i915, name);
> if (!ppgtt)
>
> ---
> base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec
> change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142
>
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] drm/i915: refactor deprecated strncpy
@ 2023-09-20 20:54 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2023-09-20 20:54 UTC (permalink / raw)
To: Justin Stitt
Cc: Jani Nikula, Joonas Lahtinen, Tvrtko Ursulin, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel,
linux-hardening
On Tue, Sep 19, 2023 at 04:45:31AM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> We should prefer more robust and less ambiguous string interfaces.
>
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer without
> unnecessarily NUL-padding. `ctx` is zero allocated and as such strncpy's
> NUL-padding behavior was strictly a performance hit which is now
> resolved.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
> Changes in v2:
> - drop the `... - 1` (thanks Kees)
> - Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v1-1-c3f92df942e0@google.com
> ---
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushing it right now to drm-intel-gt-next
> drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> index 8ac6726ec16b..e199d7dbb876 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> @@ -36,7 +36,7 @@ mock_context(struct drm_i915_private *i915,
> if (name) {
> struct i915_ppgtt *ppgtt;
>
> - strncpy(ctx->name, name, sizeof(ctx->name) - 1);
> + strscpy(ctx->name, name, sizeof(ctx->name));
>
> ppgtt = mock_ppgtt(i915, name);
> if (!ppgtt)
>
> ---
> base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec
> change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142
>
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>
^ permalink raw reply [flat|nested] 8+ messages in thread