From: John Watts <contact@jookia.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Aleksandr Shubin <privatesub2@gmail.com>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v6 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs
Date: Fri, 22 Sep 2023 07:35:19 +1000 [thread overview]
Message-ID: <ZQy3F_VtOL3XWcl0@titan> (raw)
In-Reply-To: <20230921212736.nw6ctlimtrxfksbu@pengutronix.de>
On Thu, Sep 21, 2023 at 11:27:36PM +0200, Uwe Kleine-König wrote:
> Hi John,
>
> On Wed, Sep 06, 2023 at 12:46:19PM +1000, John Watts wrote:
> > On Thu, Aug 24, 2023 at 02:40:24PM +0300, Aleksandr Shubin wrote:
> > > This series adds support for PWM controller on new
> > > Allwinner's SoCs, such as D1, T113s and R329. The implemented driver
> > > provides basic functionality for control PWM channels.
> >
> > I have tested this patch and earlier versions successfully on a Mango Pi MQ
> > Dual and verified it outputs a PWM signal.
>
> If you want that documented, the usual thing to do is to include a
> Tested-by: tag in your reply.
That's a good idea! I'll take a closer look under a scope and against the data
sheet and give another tested-by then when I can. I'm not sure how close that
gets to a reviewed-by but I don't have the experience in driver development to
know if something is off in the design.
>
> Best regards
> Uwe
John.
WARNING: multiple messages have this Message-ID (diff)
From: John Watts <contact@jookia.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Aleksandr Shubin <privatesub2@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samuel Holland <samuel@sholland.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, linux-sunxi@lists.linux.dev,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v6 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs
Date: Fri, 22 Sep 2023 07:35:19 +1000 [thread overview]
Message-ID: <ZQy3F_VtOL3XWcl0@titan> (raw)
In-Reply-To: <20230921212736.nw6ctlimtrxfksbu@pengutronix.de>
On Thu, Sep 21, 2023 at 11:27:36PM +0200, Uwe Kleine-König wrote:
> Hi John,
>
> On Wed, Sep 06, 2023 at 12:46:19PM +1000, John Watts wrote:
> > On Thu, Aug 24, 2023 at 02:40:24PM +0300, Aleksandr Shubin wrote:
> > > This series adds support for PWM controller on new
> > > Allwinner's SoCs, such as D1, T113s and R329. The implemented driver
> > > provides basic functionality for control PWM channels.
> >
> > I have tested this patch and earlier versions successfully on a Mango Pi MQ
> > Dual and verified it outputs a PWM signal.
>
> If you want that documented, the usual thing to do is to include a
> Tested-by: tag in your reply.
That's a good idea! I'll take a closer look under a scope and against the data
sheet and give another tested-by then when I can. I'm not sure how close that
gets to a reviewed-by but I don't have the experience in driver development to
know if something is off in the design.
>
> Best regards
> Uwe
John.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: John Watts <contact@jookia.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Aleksandr Shubin <privatesub2@gmail.com>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v6 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs
Date: Fri, 22 Sep 2023 07:35:19 +1000 [thread overview]
Message-ID: <ZQy3F_VtOL3XWcl0@titan> (raw)
In-Reply-To: <20230921212736.nw6ctlimtrxfksbu@pengutronix.de>
On Thu, Sep 21, 2023 at 11:27:36PM +0200, Uwe Kleine-König wrote:
> Hi John,
>
> On Wed, Sep 06, 2023 at 12:46:19PM +1000, John Watts wrote:
> > On Thu, Aug 24, 2023 at 02:40:24PM +0300, Aleksandr Shubin wrote:
> > > This series adds support for PWM controller on new
> > > Allwinner's SoCs, such as D1, T113s and R329. The implemented driver
> > > provides basic functionality for control PWM channels.
> >
> > I have tested this patch and earlier versions successfully on a Mango Pi MQ
> > Dual and verified it outputs a PWM signal.
>
> If you want that documented, the usual thing to do is to include a
> Tested-by: tag in your reply.
That's a good idea! I'll take a closer look under a scope and against the data
sheet and give another tested-by then when I can. I'm not sure how close that
gets to a reviewed-by but I don't have the experience in driver development to
know if something is off in the design.
>
> Best regards
> Uwe
John.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-21 22:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 11:40 [PATCH v6 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-08-24 11:40 ` [PATCH v6 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-08-24 11:40 ` [PATCH v6 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-09-21 21:24 ` Uwe Kleine-König
2023-09-21 21:24 ` Uwe Kleine-König
2023-09-21 21:24 ` Uwe Kleine-König
2023-08-24 11:40 ` [PATCH v6 3/3] riscv: dts: allwinner: d1: Add pwm node Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-08-24 11:40 ` Aleksandr Shubin
2023-09-06 2:46 ` [PATCH v6 0/3] Add support for Allwinner PWM on D1/T113s/R329 SoCs John Watts
2023-09-06 2:46 ` John Watts
2023-09-06 2:46 ` John Watts
2023-09-21 21:27 ` Uwe Kleine-König
2023-09-21 21:27 ` Uwe Kleine-König
2023-09-21 21:27 ` Uwe Kleine-König
2023-09-21 21:35 ` John Watts [this message]
2023-09-21 21:35 ` John Watts
2023-09-21 21:35 ` John Watts
2023-09-22 6:47 ` Uwe Kleine-König
2023-09-22 6:47 ` Uwe Kleine-König
2023-09-22 6:47 ` Uwe Kleine-König
2023-09-25 0:59 ` John Watts
2023-09-25 0:59 ` John Watts
2023-09-25 0:59 ` John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQy3F_VtOL3XWcl0@titan \
--to=contact@jookia.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=privatesub2@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.