From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: netdev@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
intel-wired-lan@lists.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier cleanups
Date: Wed, 4 Oct 2023 15:45:56 +0200 [thread overview]
Message-ID: <ZR1slAb0AQ3ayARW@kernel.org> (raw)
In-Reply-To: <20231003183603.3887546-1-jesse.brandeburg@intel.com>
On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote:
> Clean up some warnings from the W=1 build which moves the intel
> directory back to "clean" state. This mostly involved converting to
> using ethtool_sprintf where appropriate and kasprintf in other places.
>
> The second patch goes the extra mile and cleans up -Wformat=2 warnings
> as suggested by Alex Lobakin, since those flags will likely be turned on
> as well.
>
> gcc-12 runs clean after these changes, and clang-15 still has some minor
> complaints as mentioned in patch-2.
>
> Jesse Brandeburg (2):
> intel: fix string truncation warnings
> intel: fix format warnings
>
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++-
> .../net/ethernet/intel/iavf/iavf_ethtool.c | 8 ++--
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 22 ++++-------
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++--
> drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +-
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 +-
> drivers/net/ethernet/intel/igb/igb_main.c | 37 +++++++++----------
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 ++-
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +-
> 9 files changed, 46 insertions(+), 51 deletions(-)
For series,
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v1 0/2] intel: format specifier cleanups
Date: Wed, 4 Oct 2023 15:45:56 +0200 [thread overview]
Message-ID: <ZR1slAb0AQ3ayARW@kernel.org> (raw)
In-Reply-To: <20231003183603.3887546-1-jesse.brandeburg@intel.com>
On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote:
> Clean up some warnings from the W=1 build which moves the intel
> directory back to "clean" state. This mostly involved converting to
> using ethtool_sprintf where appropriate and kasprintf in other places.
>
> The second patch goes the extra mile and cleans up -Wformat=2 warnings
> as suggested by Alex Lobakin, since those flags will likely be turned on
> as well.
>
> gcc-12 runs clean after these changes, and clang-15 still has some minor
> complaints as mentioned in patch-2.
>
> Jesse Brandeburg (2):
> intel: fix string truncation warnings
> intel: fix format warnings
>
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++-
> .../net/ethernet/intel/iavf/iavf_ethtool.c | 8 ++--
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 22 ++++-------
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++--
> drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +-
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 +-
> drivers/net/ethernet/intel/igb/igb_main.c | 37 +++++++++----------
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 ++-
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +-
> 9 files changed, 46 insertions(+), 51 deletions(-)
For series,
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
next prev parent reply other threads:[~2023-10-04 13:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 18:36 [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier cleanups Jesse Brandeburg
2023-10-03 18:36 ` Jesse Brandeburg
2023-10-03 18:36 ` [Intel-wired-lan] [PATCH iwl-next v1 1/2] intel: fix string truncation warnings Jesse Brandeburg
2023-10-03 18:36 ` Jesse Brandeburg
2023-10-12 10:12 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-12 10:12 ` Pucha, HimasekharX Reddy
2023-10-03 18:36 ` [Intel-wired-lan] [PATCH iwl-next v1 2/2] intel: fix format warnings Jesse Brandeburg
2023-10-03 18:36 ` Jesse Brandeburg
2023-10-12 10:12 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-10-12 10:12 ` Pucha, HimasekharX Reddy
2023-10-12 10:13 ` Pucha, HimasekharX Reddy
2023-10-12 10:13 ` Pucha, HimasekharX Reddy
2023-10-04 13:45 ` Simon Horman [this message]
2023-10-04 13:45 ` [PATCH iwl-next v1 0/2] intel: format specifier cleanups Simon Horman
2023-10-06 15:16 ` [Intel-wired-lan] " Romanowski, Rafal
2023-10-06 15:16 ` Romanowski, Rafal
2023-10-09 10:50 ` Romanowski, Rafal
2023-10-09 10:50 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR1slAb0AQ3ayARW@kernel.org \
--to=horms@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.