From: John Watts <contact@jookia.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: dri-devel@lists.freedesktop.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Chris Morgan <macromorgan@hotmail.com>,
Jagan Teki <jagan@edgeble.ai>,
Christophe Branchereau <cbranchereau@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display
Date: Mon, 25 Sep 2023 19:21:25 +1000 [thread overview]
Message-ID: <ZRFRFXCKTIb9x7GW@titan> (raw)
In-Reply-To: <ebd5808fe3029e46376aea3c25d3770a6b406fdc.camel@crapouillou.net>
On Mon, Sep 25, 2023 at 11:12:29AM +0200, Paul Cercueil wrote:
> Hi John,
>
> Just to be sure, your fascontek panel won't work with the
> initialization sequence of the leadtek panel?
Yes, it does work.
> Did you try with the existing display modes? If you can afford the 24
> MHz clock (and if it works with your panel) it will give you a perfect
> 60.0 Hz refresh rate, while this mode above will give you above 59.93
> Hz (which is not that bad though).
No I didn't test with this.
In general I don't feel comfortable submitting code that strays from what is
recommended by the manufacturer.
> Otherwise LGTM.
>
> Cheers,
> -Paul
John.
WARNING: multiple messages have this Message-ID (diff)
From: John Watts <contact@jookia.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Chris Morgan <macromorgan@hotmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jagan Teki <jagan@edgeble.ai>, Rob Herring <robh+dt@kernel.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Shawn Guo <shawnguo@kernel.org>,
Christophe Branchereau <cbranchereau@gmail.com>
Subject: Re: [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display
Date: Mon, 25 Sep 2023 19:21:25 +1000 [thread overview]
Message-ID: <ZRFRFXCKTIb9x7GW@titan> (raw)
In-Reply-To: <ebd5808fe3029e46376aea3c25d3770a6b406fdc.camel@crapouillou.net>
On Mon, Sep 25, 2023 at 11:12:29AM +0200, Paul Cercueil wrote:
> Hi John,
>
> Just to be sure, your fascontek panel won't work with the
> initialization sequence of the leadtek panel?
Yes, it does work.
> Did you try with the existing display modes? If you can afford the 24
> MHz clock (and if it works with your panel) it will give you a perfect
> 60.0 Hz refresh rate, while this mode above will give you above 59.93
> Hz (which is not that bad though).
No I didn't test with this.
In general I don't feel comfortable submitting code that strays from what is
recommended by the manufacturer.
> Otherwise LGTM.
>
> Cheers,
> -Paul
John.
next prev parent reply other threads:[~2023-09-25 9:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 2:10 [RFC PATCH v3 0/7] Add FS035VG158 panel John Watts
2023-09-25 2:10 ` John Watts
2023-09-25 2:10 ` [RFC PATCH v3 1/7] drm/panel: nv3052c: Document known register names John Watts
2023-09-25 2:10 ` John Watts
2023-09-25 2:10 ` [RFC PATCH v3 2/7] drm/panel: nv3052c: Add SPI device IDs John Watts
2023-09-25 2:10 ` John Watts
2023-09-25 2:10 ` [RFC PATCH v3 3/7] drm/panel: nv3052c: Allow specifying registers per panel John Watts
2023-09-25 2:10 ` John Watts
2023-09-25 9:04 ` Paul Cercueil
2023-09-25 9:04 ` Paul Cercueil
2023-09-25 2:10 ` [RFC PATCH v3 4/7] drm/panel: nv3052c: Add Fascontek FS035VG158 LCD display John Watts
2023-09-25 2:10 ` John Watts
2023-09-25 9:12 ` Paul Cercueil
2023-09-25 9:12 ` Paul Cercueil
2023-09-25 9:21 ` John Watts [this message]
2023-09-25 9:21 ` John Watts
2023-09-25 9:43 ` Paul Cercueil
2023-09-25 9:43 ` Paul Cercueil
2023-09-25 9:48 ` John Watts
2023-09-25 9:48 ` John Watts
2023-09-25 10:34 ` Paul Cercueil
2023-09-25 10:34 ` Paul Cercueil
2023-09-25 20:09 ` John Watts
2023-09-25 20:09 ` John Watts
2023-09-25 2:10 ` [RFC PATCH v3 5/7] dt-bindings: display: panel: Clean up leadtek,ltk035c5444t properties John Watts
2023-09-25 2:10 ` [RFC PATCH v3 5/7] dt-bindings: display: panel: Clean up leadtek, ltk035c5444t properties John Watts
2023-09-25 2:10 ` [RFC PATCH v3 6/7] dt-bindings: vendor-prefixes: Add fascontek John Watts
2023-09-25 2:10 ` John Watts
2023-09-25 2:10 ` [RFC PATCH v3 7/7] dt-bindings: display: panel: add Fascontek FS035VG158 panel John Watts
2023-09-25 2:10 ` John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRFRFXCKTIb9x7GW@titan \
--to=contact@jookia.org \
--cc=airlied@gmail.com \
--cc=cbranchereau@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=paul@crapouillou.net \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.