From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Jonathan Cavitt <jonathan.cavitt@intel.com>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware
Date: Mon, 25 Sep 2023 17:24:30 +0200 [thread overview]
Message-ID: <ZRGmLlVzGfScSMR+@ashyti-mobl2.lan> (raw)
In-Reply-To: <877coemg89.fsf@intel.com>
Hi Jani,
> >> struct i915_vma *vma, *next;
> >> unsigned long freed_pages = 0;
> >> intel_wakeref_t wakeref;
> >> + struct intel_gt *gt;
> >> + int i;
> >
> > the trend is to use 'unsigned int' here and I've seen it
> > reviewed. Personally, if I really have to express a preference, I
> > prefer 'int' because it's a bit safer, generally I don't really
> > mind :)
>
> Always use int over unsigned int if you don't have a specific reason not
> to. ("It can't be negative" is not a good reason.)
Finally someone! I totally agree!
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
Jonathan Cavitt <jonathan.cavitt@intel.com>,
dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware
Date: Mon, 25 Sep 2023 17:24:30 +0200 [thread overview]
Message-ID: <ZRGmLlVzGfScSMR+@ashyti-mobl2.lan> (raw)
In-Reply-To: <877coemg89.fsf@intel.com>
Hi Jani,
> >> struct i915_vma *vma, *next;
> >> unsigned long freed_pages = 0;
> >> intel_wakeref_t wakeref;
> >> + struct intel_gt *gt;
> >> + int i;
> >
> > the trend is to use 'unsigned int' here and I've seen it
> > reviewed. Personally, if I really have to express a preference, I
> > prefer 'int' because it's a bit safer, generally I don't really
> > mind :)
>
> Always use int over unsigned int if you don't have a specific reason not
> to. ("It can't be negative" is not a good reason.)
Finally someone! I totally agree!
Andi
next prev parent reply other threads:[~2023-09-25 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 13:49 [Intel-gfx] [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware Nirmoy Das
2023-09-25 13:49 ` Nirmoy Das
2023-09-25 14:46 ` [Intel-gfx] " Andi Shyti
2023-09-25 14:46 ` Andi Shyti
2023-09-25 15:20 ` [Intel-gfx] " Jani Nikula
2023-09-25 15:20 ` Jani Nikula
2023-09-25 15:24 ` Andi Shyti [this message]
2023-09-25 15:24 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-09-22 12:35 [Intel-gfx] " Nirmoy Das
2023-09-25 13:23 ` Andrzej Hajda
2023-09-25 13:32 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRGmLlVzGfScSMR+@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jonathan.cavitt@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.