All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
	"Yury Norov" <yury.norov@gmail.com>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Shubhrajyoti Datta" <shubhrajyoti.datta@amd.com>,
	"Srinivas Neeli" <srinivas.neeli@amd.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH v1 4/5] gpio: xilinx: Replace bitmap_bitremap() calls
Date: Tue, 26 Sep 2023 19:17:52 +0800	[thread overview]
Message-ID: <ZRK94EzQ6atqGvLG@sol> (raw)
In-Reply-To: <ZRK8Uq699oeSOOg6@smile.fi.intel.com>

On Tue, Sep 26, 2023 at 02:11:14PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 26, 2023 at 06:41:00PM +0800, Kent Gibson wrote:
> > On Tue, Sep 26, 2023 at 08:20:06AM +0300, Andy Shevchenko wrote:
> > > We have sparse and dence masks of the line mappings based on
> > 
> > dense
> > 
> > > the view point (Linux numbering or hardware numbering). Since
> > > the Linux side uses sequential bits for the mask, we can simply
> > > convert a Linux number to the hardware one and vise versa by
> > 
> > vice
> > 
> > > counting set bits in the respective mask. Hence replace
> > > bitmap_bitremap() calls by simpler equivalents.
> > > 
> > > With this done the dence mask is not needed and thus dropped.
> > 
> > And dense again.
> 
> Thank you, Kent, I really appreciate your help with my poor English,
> nevertheless it would be nice if you can look at the last patch and
> maybe even test it, so we have a bit of confidence that it works
> as expected.
> 

Well that is the plan, but I haven't been in the GPIO space for a while so
I need to pull my test setup out of mothballs first - so don't hold your
breath.

> (The spelling will be fixed in the next version.)
> 

Those I can spot without needing to compile anything ;-).

Cheers,
Kent.


WARNING: multiple messages have this Message-ID (diff)
From: Kent Gibson <warthog618@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
	"Yury Norov" <yury.norov@gmail.com>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Shubhrajyoti Datta" <shubhrajyoti.datta@amd.com>,
	"Srinivas Neeli" <srinivas.neeli@amd.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH v1 4/5] gpio: xilinx: Replace bitmap_bitremap() calls
Date: Tue, 26 Sep 2023 19:17:52 +0800	[thread overview]
Message-ID: <ZRK94EzQ6atqGvLG@sol> (raw)
In-Reply-To: <ZRK8Uq699oeSOOg6@smile.fi.intel.com>

On Tue, Sep 26, 2023 at 02:11:14PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 26, 2023 at 06:41:00PM +0800, Kent Gibson wrote:
> > On Tue, Sep 26, 2023 at 08:20:06AM +0300, Andy Shevchenko wrote:
> > > We have sparse and dence masks of the line mappings based on
> > 
> > dense
> > 
> > > the view point (Linux numbering or hardware numbering). Since
> > > the Linux side uses sequential bits for the mask, we can simply
> > > convert a Linux number to the hardware one and vise versa by
> > 
> > vice
> > 
> > > counting set bits in the respective mask. Hence replace
> > > bitmap_bitremap() calls by simpler equivalents.
> > > 
> > > With this done the dence mask is not needed and thus dropped.
> > 
> > And dense again.
> 
> Thank you, Kent, I really appreciate your help with my poor English,
> nevertheless it would be nice if you can look at the last patch and
> maybe even test it, so we have a bit of confidence that it works
> as expected.
> 

Well that is the plan, but I haven't been in the GPIO space for a while so
I need to pull my test setup out of mothballs first - so don't hold your
breath.

> (The spelling will be fixed in the next version.)
> 

Those I can spot without needing to compile anything ;-).

Cheers,
Kent.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-26 11:18 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  5:20 [PATCH v1 0/5] bitmap: get rid of bitmap_remap() and bitmap_biremap() uses Andy Shevchenko
2023-09-26  5:20 ` Andy Shevchenko
2023-09-26  5:20 ` [PATCH v1 1/5] lib/test_bitmap: Excape space symbols when printing input string Andy Shevchenko
2023-09-26  5:20   ` Andy Shevchenko
2023-09-26 10:35   ` Kent Gibson
2023-09-26 10:35     ` Kent Gibson
2023-09-26 10:39     ` Kent Gibson
2023-09-26 10:39       ` Kent Gibson
2023-09-26  5:20 ` [PATCH v1 2/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Andy Shevchenko
2023-09-26  5:20   ` Andy Shevchenko
2023-09-27  0:25   ` Yury Norov
2023-09-27  0:25     ` Yury Norov
2023-09-27  2:10     ` Yury Norov
2023-09-27  2:10       ` Yury Norov
2023-09-27 12:10       ` Andy Shevchenko
2023-09-27 12:10         ` Andy Shevchenko
2023-09-27 12:02     ` Andy Shevchenko
2023-09-27 12:02       ` Andy Shevchenko
2023-10-02  4:06       ` Yury Norov
2023-10-02  4:06         ` Yury Norov
2023-10-02  8:23         ` Andy Shevchenko
2023-10-02  8:23           ` Andy Shevchenko
2023-09-26  5:20 ` [PATCH v1 3/5] gpio: xilinx: Switch to use new bitmap_scatter() helper Andy Shevchenko
2023-09-26  5:20   ` Andy Shevchenko
2023-09-26  5:20 ` [PATCH v1 4/5] gpio: xilinx: Replace bitmap_bitremap() calls Andy Shevchenko
2023-09-26  5:20   ` Andy Shevchenko
2023-09-26 10:41   ` Kent Gibson
2023-09-26 10:41     ` Kent Gibson
2023-09-26 11:11     ` Andy Shevchenko
2023-09-26 11:11       ` Andy Shevchenko
2023-09-26 11:17       ` Kent Gibson [this message]
2023-09-26 11:17         ` Kent Gibson
2023-09-26  5:20 ` [PATCH v1 5/5] gpiolib: cdev: Utilize more bitmap APIs Andy Shevchenko
2023-09-26  5:20   ` Andy Shevchenko
2023-09-27  0:46   ` Yury Norov
2023-09-27  0:46     ` Yury Norov
2023-09-27  6:48     ` Kent Gibson
2023-09-27  6:48       ` Kent Gibson
2023-09-27  1:32   ` Kent Gibson
2023-09-27  1:32     ` Kent Gibson
2023-09-27 12:17     ` Andy Shevchenko
2023-09-27 12:17       ` Andy Shevchenko
2023-09-27 13:49       ` Kent Gibson
2023-09-27 13:49         ` Kent Gibson
2023-09-27 13:59         ` Andy Shevchenko
2023-09-27 13:59           ` Andy Shevchenko
2023-09-27 14:23           ` Kent Gibson
2023-09-27 14:23             ` Kent Gibson
2023-10-02  9:05             ` Andy Shevchenko
2023-10-02  9:05               ` Andy Shevchenko
2023-10-02  9:25               ` Kent Gibson
2023-10-02  9:25                 ` Kent Gibson
2023-10-02  9:32                 ` Andy Shevchenko
2023-10-02  9:32                   ` Andy Shevchenko
2023-10-02  9:42                   ` Kent Gibson
2023-10-02  9:42                     ` Kent Gibson
2023-09-26  8:52 ` [PATCH v1 0/5] bitmap: get rid of bitmap_remap() and bitmap_biremap() uses Linus Walleij
2023-09-26  8:52   ` Linus Walleij
2023-09-26 11:16   ` Andy Shevchenko
2023-09-26 11:16     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRK94EzQ6atqGvLG@sol \
    --to=warthog618@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=kabel@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=michal.simek@amd.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=srinivas.neeli@amd.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.