All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Eric DeVolder <eric.devolder@oracle.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	vschneid@redhat.com, sourabhjain@linux.ibm.com
Subject: Re: [PATCH v3] Crash: add lock to serialize crash hotplug handling
Date: Wed, 27 Sep 2023 08:14:41 +0800	[thread overview]
Message-ID: <ZRNz8T1XOX7PWOt6@MiWiFi-R3L-srv> (raw)
In-Reply-To: <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com>

On 09/26/23 at 04:53pm, Eric DeVolder wrote:
> 
> 
> On 9/26/23 15:50, Andrew Morton wrote:
> > On Tue, 26 Sep 2023 20:09:05 +0800 Baoquan He <bhe@redhat.com> wrote:
> > 
> > > Eric reported that handling corresponding crash hotplug event can be
> > > failed easily when many memory hotplug event are notified in a short
> > > period. They failed because failing to take __kexec_lock.
> > 
> > I'm assuming that this failure is sufficiently likely so as to  justify a -stable
> > backport of the fix.   Please let me know if this is incorrect.
> 
> Andrew,
> Correct, this is sufficiently likely to happen.

Agree. Maybe a Fixes tag need be added:
===
Fixes: 247262756121 ("crash: add generic infrastructure for crash hotplug support")


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Eric DeVolder <eric.devolder@oracle.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	vschneid@redhat.com, sourabhjain@linux.ibm.com
Subject: Re: [PATCH v3] Crash: add lock to serialize crash hotplug handling
Date: Wed, 27 Sep 2023 08:14:41 +0800	[thread overview]
Message-ID: <ZRNz8T1XOX7PWOt6@MiWiFi-R3L-srv> (raw)
In-Reply-To: <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com>

On 09/26/23 at 04:53pm, Eric DeVolder wrote:
> 
> 
> On 9/26/23 15:50, Andrew Morton wrote:
> > On Tue, 26 Sep 2023 20:09:05 +0800 Baoquan He <bhe@redhat.com> wrote:
> > 
> > > Eric reported that handling corresponding crash hotplug event can be
> > > failed easily when many memory hotplug event are notified in a short
> > > period. They failed because failing to take __kexec_lock.
> > 
> > I'm assuming that this failure is sufficiently likely so as to  justify a -stable
> > backport of the fix.   Please let me know if this is incorrect.
> 
> Andrew,
> Correct, this is sufficiently likely to happen.

Agree. Maybe a Fixes tag need be added:
===
Fixes: 247262756121 ("crash: add generic infrastructure for crash hotplug support")


  reply	other threads:[~2023-09-27  0:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 12:09 [PATCH v3] Crash: add lock to serialize crash hotplug handling Baoquan He
2023-09-26 12:09 ` Baoquan He
2023-09-26 14:55 ` Eric DeVolder
2023-09-26 14:55   ` Eric DeVolder
2023-09-26 20:50 ` Andrew Morton
2023-09-26 20:50   ` Andrew Morton
2023-09-26 21:53   ` Eric DeVolder
2023-09-26 21:53     ` Eric DeVolder
2023-09-27  0:14     ` Baoquan He [this message]
2023-09-27  0:14       ` Baoquan He
2023-09-28  8:51 ` Valentin Schneider
2023-09-28  8:51   ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRNz8T1XOX7PWOt6@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.devolder@oracle.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sourabhjain@linux.ibm.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.