All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Donnefort <vdonnefort@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: maz@kernel.org, kvmarm@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	will@kernel.org, willy@infradead.org
Subject: Re: [PATCH v1 0/2] KVM: arm64: Use folio for THP support
Date: Wed, 27 Sep 2023 13:39:39 +0100	[thread overview]
Message-ID: <ZRQii9II1zGJF4vw@google.com> (raw)
In-Reply-To: <ZRPMEFvQ-bt4rPDQ@linux.dev>

On Wed, Sep 27, 2023 at 06:30:40AM +0000, Oliver Upton wrote:
> Vincent,
> 
> On Tue, Sep 26, 2023 at 07:19:30PM +0100, Vincent Donnefort wrote:
> > With the introduction of folios for transparent huge pages [1], we
> > can rely on this support to identify if a page is backed by a huge one,
> > saving a page table walk.
> 
> Better yet, this gets rid of a particular walk that has had some rather
> hairy bugs in the past :)
> 
> > [1] https://lkml.kernel.org/r/20220504182857.4013401-3-willy@infradead.org
> 
> nit: for the sake of posterity, it might be good to stick a reference to
> commit cb196ee1ef39 ("mm/huge_memory: convert do_huge_pmd_anonymous_page()
> to use vma_alloc_folio()") in the changelogs.

I'll add that reference in the following version.

> 
> -- 
> Thanks,
> Oliver

WARNING: multiple messages have this Message-ID (diff)
From: Vincent Donnefort <vdonnefort@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: maz@kernel.org, kvmarm@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	will@kernel.org, willy@infradead.org
Subject: Re: [PATCH v1 0/2] KVM: arm64: Use folio for THP support
Date: Wed, 27 Sep 2023 13:39:39 +0100	[thread overview]
Message-ID: <ZRQii9II1zGJF4vw@google.com> (raw)
In-Reply-To: <ZRPMEFvQ-bt4rPDQ@linux.dev>

On Wed, Sep 27, 2023 at 06:30:40AM +0000, Oliver Upton wrote:
> Vincent,
> 
> On Tue, Sep 26, 2023 at 07:19:30PM +0100, Vincent Donnefort wrote:
> > With the introduction of folios for transparent huge pages [1], we
> > can rely on this support to identify if a page is backed by a huge one,
> > saving a page table walk.
> 
> Better yet, this gets rid of a particular walk that has had some rather
> hairy bugs in the past :)
> 
> > [1] https://lkml.kernel.org/r/20220504182857.4013401-3-willy@infradead.org
> 
> nit: for the sake of posterity, it might be good to stick a reference to
> commit cb196ee1ef39 ("mm/huge_memory: convert do_huge_pmd_anonymous_page()
> to use vma_alloc_folio()") in the changelogs.

I'll add that reference in the following version.

> 
> -- 
> Thanks,
> Oliver

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-27 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 18:19 [PATCH v1 0/2] KVM: arm64: Use folio for THP support Vincent Donnefort
2023-09-26 18:19 ` Vincent Donnefort
2023-09-26 18:19 ` [PATCH v1 1/2] KVM: arm64: Do not transfer page refcount for THP adjustment Vincent Donnefort
2023-09-26 18:19   ` Vincent Donnefort
2023-09-27  7:00   ` Matthew Wilcox
2023-09-27  7:00     ` Matthew Wilcox
2023-09-27 12:40     ` Vincent Donnefort
2023-09-27 12:40       ` Vincent Donnefort
2023-09-26 18:19 ` [PATCH v1 2/2] KVM: arm64: Use folio " Vincent Donnefort
2023-09-26 18:19   ` Vincent Donnefort
2023-09-27  6:30 ` [PATCH v1 0/2] KVM: arm64: Use folio for THP support Oliver Upton
2023-09-27  6:30   ` Oliver Upton
2023-09-27 12:39   ` Vincent Donnefort [this message]
2023-09-27 12:39     ` Vincent Donnefort

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRQii9II1zGJF4vw@google.com \
    --to=vdonnefort@google.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.