From: Jiri Pirko <jiri@resnulli.us>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: vadim.fedorenko@linux.dev, corbet@lwn.net,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
intel-wired-lan@lists.osuosl.org, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next 2/4] dpll: spec: add support for pin-dpll signal phase offset/adjust
Date: Mon, 2 Oct 2023 16:53:24 +0200 [thread overview]
Message-ID: <ZRrZZDDvuifWhDeL@nanopsycho> (raw)
In-Reply-To: <20230927092435.1565336-3-arkadiusz.kubalewski@intel.com>
Wed, Sep 27, 2023 at 11:24:33AM CEST, arkadiusz.kubalewski@intel.com wrote:
>Add new pin's attributes to dpll netlink spec:
>- phase-offset - measured difference between phase of signals on pin
> and dpll
>- phase-adjust - adjustable value of pin's signal phase
>- phase-adjust-min / phase-adjust-max - values for determining limits
> for phase-adjust
>
>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
>---
> Documentation/netlink/specs/dpll.yaml | 33 ++++++++++++++++++++++++++-
> drivers/dpll/dpll_nl.c | 8 ++++---
> drivers/dpll/dpll_nl.h | 2 +-
> include/uapi/linux/dpll.h | 8 ++++++-
> 4 files changed, 45 insertions(+), 6 deletions(-)
>
>diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
>index 8b86b28b47a6..dc057494101f 100644
>--- a/Documentation/netlink/specs/dpll.yaml
>+++ b/Documentation/netlink/specs/dpll.yaml
>@@ -1,7 +1,7 @@
> # SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
>
> name: dpll
>-
>+version: 2
How is this supposed to work. You bump the version with every uapi
extension? First time I see this.
[...]
>diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h
>index 20ef0718f8dc..050f51b48ef8 100644
>--- a/include/uapi/linux/dpll.h
>+++ b/include/uapi/linux/dpll.h
>@@ -7,7 +7,7 @@
> #define _UAPI_LINUX_DPLL_H
>
> #define DPLL_FAMILY_NAME "dpll"
>-#define DPLL_FAMILY_VERSION 1
>+#define DPLL_FAMILY_VERSION 2
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Pirko <jiri@resnulli.us>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev,
corbet@lwn.net, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, linux-doc@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next 2/4] dpll: spec: add support for pin-dpll signal phase offset/adjust
Date: Mon, 2 Oct 2023 16:53:24 +0200 [thread overview]
Message-ID: <ZRrZZDDvuifWhDeL@nanopsycho> (raw)
In-Reply-To: <20230927092435.1565336-3-arkadiusz.kubalewski@intel.com>
Wed, Sep 27, 2023 at 11:24:33AM CEST, arkadiusz.kubalewski@intel.com wrote:
>Add new pin's attributes to dpll netlink spec:
>- phase-offset - measured difference between phase of signals on pin
> and dpll
>- phase-adjust - adjustable value of pin's signal phase
>- phase-adjust-min / phase-adjust-max - values for determining limits
> for phase-adjust
>
>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
>---
> Documentation/netlink/specs/dpll.yaml | 33 ++++++++++++++++++++++++++-
> drivers/dpll/dpll_nl.c | 8 ++++---
> drivers/dpll/dpll_nl.h | 2 +-
> include/uapi/linux/dpll.h | 8 ++++++-
> 4 files changed, 45 insertions(+), 6 deletions(-)
>
>diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
>index 8b86b28b47a6..dc057494101f 100644
>--- a/Documentation/netlink/specs/dpll.yaml
>+++ b/Documentation/netlink/specs/dpll.yaml
>@@ -1,7 +1,7 @@
> # SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
>
> name: dpll
>-
>+version: 2
How is this supposed to work. You bump the version with every uapi
extension? First time I see this.
[...]
>diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h
>index 20ef0718f8dc..050f51b48ef8 100644
>--- a/include/uapi/linux/dpll.h
>+++ b/include/uapi/linux/dpll.h
>@@ -7,7 +7,7 @@
> #define _UAPI_LINUX_DPLL_H
>
> #define DPLL_FAMILY_NAME "dpll"
>-#define DPLL_FAMILY_VERSION 1
>+#define DPLL_FAMILY_VERSION 2
next prev parent reply other threads:[~2023-10-02 14:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 9:24 [Intel-wired-lan] [PATCH net-next 0/4] dpll: add phase-offset and phase-adjust Arkadiusz Kubalewski
2023-09-27 9:24 ` Arkadiusz Kubalewski
2023-09-27 9:24 ` [Intel-wired-lan] [PATCH net-next 1/4] dpll: docs: add support for pin signal phase offset/adjust Arkadiusz Kubalewski
2023-09-27 9:24 ` Arkadiusz Kubalewski
2023-10-02 15:00 ` [Intel-wired-lan] " Jiri Pirko
2023-10-02 15:00 ` Jiri Pirko
2023-10-09 22:53 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-10-09 22:53 ` Kubalewski, Arkadiusz
2023-09-27 9:24 ` [Intel-wired-lan] [PATCH net-next 2/4] dpll: spec: add support for pin-dpll " Arkadiusz Kubalewski
2023-09-27 9:24 ` Arkadiusz Kubalewski
2023-10-02 14:53 ` Jiri Pirko [this message]
2023-10-02 14:53 ` Jiri Pirko
2023-10-06 10:29 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-10-06 10:29 ` Kubalewski, Arkadiusz
2023-09-27 9:24 ` [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: " Arkadiusz Kubalewski
2023-09-27 9:24 ` Arkadiusz Kubalewski
2023-09-27 18:09 ` [Intel-wired-lan] " Vadim Fedorenko
2023-09-27 18:09 ` Vadim Fedorenko
2023-10-02 14:32 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-10-02 14:32 ` Kubalewski, Arkadiusz
2023-10-02 15:04 ` [Intel-wired-lan] " Jiri Pirko
2023-10-02 15:04 ` Jiri Pirko
2023-10-02 15:09 ` [Intel-wired-lan] " Vadim Fedorenko
2023-10-02 15:09 ` Vadim Fedorenko
2023-10-02 23:10 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-10-02 23:10 ` Kubalewski, Arkadiusz
2023-10-03 6:27 ` Jiri Pirko
2023-10-03 6:27 ` Jiri Pirko
2023-10-03 14:29 ` Kubalewski, Arkadiusz
2023-10-03 14:29 ` Kubalewski, Arkadiusz
2023-10-03 17:18 ` Jiri Pirko
2023-10-03 17:18 ` Jiri Pirko
2023-10-04 9:13 ` Kubalewski, Arkadiusz
2023-10-04 9:13 ` Kubalewski, Arkadiusz
2023-10-02 23:03 ` Kubalewski, Arkadiusz
2023-10-02 23:03 ` Kubalewski, Arkadiusz
2023-10-03 6:32 ` [Intel-wired-lan] " Jiri Pirko
2023-10-03 6:32 ` Jiri Pirko
2023-10-03 14:29 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-10-03 14:29 ` Kubalewski, Arkadiusz
2023-10-03 17:19 ` [Intel-wired-lan] " Jiri Pirko
2023-10-03 17:19 ` Jiri Pirko
2023-10-04 9:11 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-10-04 9:11 ` Kubalewski, Arkadiusz
2023-09-27 9:24 ` [Intel-wired-lan] [PATCH net-next 4/4] ice: dpll: implement phase related callbacks Arkadiusz Kubalewski
2023-09-27 9:24 ` Arkadiusz Kubalewski
2023-09-27 13:17 ` [Intel-wired-lan] " kernel test robot
2023-09-27 13:17 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-09-05 23:26 [Intel-wired-lan] [PATCH net-next 0/4] dpll: add phase offset and phase adjust Arkadiusz Kubalewski
2023-09-05 23:26 ` [Intel-wired-lan] [PATCH net-next 2/4] dpll: spec: add support for pin-dpll signal phase offset/adjust Arkadiusz Kubalewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRrZZDDvuifWhDeL@nanopsycho \
--to=jiri@resnulli.us \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.