All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	bcm-kernel-feedback-list@broadcom.com,
	jonathan.derrick@linux.dev, kw@linux.com,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org,
	lpieralisi@kernel.org, marek.vasut+renesas@gmail.com,
	minghuan.Lian@nxp.com, mingkai.hu@nxp.com,
	m.karthikeyan@mobiveil.co.in, nirmal.patel@linux.intel.com,
	rjui@broadcom.com, robh@kernel.org, roy.zang@nxp.com,
	sbranden@broadcom.com, yoshihiro.shimoda.uh@renesas.com,
	Zhiqiang.Hou@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: Use PCI_HEADER_TYPE_* instead of literals
Date: Tue, 3 Oct 2023 15:07:24 +0200	[thread overview]
Message-ID: <ZRwSDNOlZwUu+vqE@ninjato> (raw)
In-Reply-To: <20231003125300.5541-4-ilpo.jarvinen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

On Tue, Oct 03, 2023 at 03:53:00PM +0300, Ilpo Järvinen wrote:
> Replace literals under drivers/pci/ with PCI_HEADER_TYPE_MASK,
> PCI_HEADER_TYPE_NORMAL, and PCI_HEADER_TYPE_MFD.
> 
> While at it, replace !! boolean conversion with FIELD_GET().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> # for Renesas R-Car


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: kw@linux.com, sbranden@broadcom.com,
	m.karthikeyan@mobiveil.co.in, robh@kernel.org,
	linux-pci@vger.kernel.org, lpieralisi@kernel.org,
	Zhiqiang.Hou@nxp.com, nirmal.patel@linux.intel.com,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	minghuan.Lian@nxp.com, bcm-kernel-feedback-list@broadcom.com,
	mingkai.hu@nxp.com, jonathan.derrick@linux.dev,
	rjui@broadcom.com, Bjorn Helgaas <bhelgaas@google.com>,
	roy.zang@nxp.com, linuxppc-dev@lists.ozlabs.org,
	yoshihiro.shimoda.uh@renesas.com,
	linux-arm-kernel@lists.infradead.org,
	marek.vasut+renesas@gmail.com
Subject: Re: [PATCH 3/3] PCI: Use PCI_HEADER_TYPE_* instead of literals
Date: Tue, 3 Oct 2023 15:07:24 +0200	[thread overview]
Message-ID: <ZRwSDNOlZwUu+vqE@ninjato> (raw)
In-Reply-To: <20231003125300.5541-4-ilpo.jarvinen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

On Tue, Oct 03, 2023 at 03:53:00PM +0300, Ilpo Järvinen wrote:
> Replace literals under drivers/pci/ with PCI_HEADER_TYPE_MASK,
> PCI_HEADER_TYPE_NORMAL, and PCI_HEADER_TYPE_MFD.
> 
> While at it, replace !! boolean conversion with FIELD_GET().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> # for Renesas R-Car


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	bcm-kernel-feedback-list@broadcom.com,
	jonathan.derrick@linux.dev, kw@linux.com,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org,
	lpieralisi@kernel.org, marek.vasut+renesas@gmail.com,
	minghuan.Lian@nxp.com, mingkai.hu@nxp.com,
	m.karthikeyan@mobiveil.co.in, nirmal.patel@linux.intel.com,
	rjui@broadcom.com, robh@kernel.org, roy.zang@nxp.com,
	sbranden@broadcom.com, yoshihiro.shimoda.uh@renesas.com,
	Zhiqiang.Hou@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: Use PCI_HEADER_TYPE_* instead of literals
Date: Tue, 3 Oct 2023 15:07:24 +0200	[thread overview]
Message-ID: <ZRwSDNOlZwUu+vqE@ninjato> (raw)
In-Reply-To: <20231003125300.5541-4-ilpo.jarvinen@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]

On Tue, Oct 03, 2023 at 03:53:00PM +0300, Ilpo Järvinen wrote:
> Replace literals under drivers/pci/ with PCI_HEADER_TYPE_MASK,
> PCI_HEADER_TYPE_NORMAL, and PCI_HEADER_TYPE_MFD.
> 
> While at it, replace !! boolean conversion with FIELD_GET().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> # for Renesas R-Car


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-10-03 13:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 12:52 [PATCH 0/3] PCI: PCI_HEADER_TYPE bugfix & cleanups Ilpo Järvinen
2023-10-03 12:52 ` Ilpo Järvinen
2023-10-03 12:52 ` Ilpo Järvinen
2023-10-03 12:52 ` [PATCH 1/3] PCI: vmd: Correct PCI Header Type Register's MFD bit check Ilpo Järvinen
2023-10-03 12:52   ` Ilpo Järvinen
2023-10-03 12:52 ` [PATCH 2/3] PCI: Add PCI_HEADER_TYPE_MFD pci_regs.h Ilpo Järvinen
2023-10-03 12:52   ` Ilpo Järvinen
2023-10-03 12:53 ` [PATCH 3/3] PCI: Use PCI_HEADER_TYPE_* instead of literals Ilpo Järvinen
2023-10-03 12:53   ` Ilpo Järvinen
2023-10-03 13:07   ` Wolfram Sang [this message]
2023-10-03 13:07     ` Wolfram Sang
2023-10-03 13:07     ` Wolfram Sang
2023-10-03 16:58 ` [PATCH 0/3] PCI: PCI_HEADER_TYPE bugfix & cleanups Bjorn Helgaas
2023-10-03 16:58   ` Bjorn Helgaas
2023-10-03 16:58   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRwSDNOlZwUu+vqE@ninjato \
    --to=wsa@kernel.org \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jonathan.derrick@linux.dev \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.karthikeyan@mobiveil.co.in \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=minghuan.Lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=nirmal.patel@linux.intel.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=roy.zang@nxp.com \
    --cc=sbranden@broadcom.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.