All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Alexey Makhalov <amakhalov@vmware.com>,
	Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Ajay Kaher <akaher@vmware.com>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
Date: Wed, 18 Oct 2023 13:34:44 +0200	[thread overview]
Message-ID: <ZS/C1HS/EEXTtVji@gmail.com> (raw)
In-Reply-To: <4f5cc965-36da-43f0-aaaa-082a2235ec1e@suse.com>


* Juergen Gross <jgross@suse.com> wrote:

> On 16.10.23 16:29, Peter Zijlstra wrote:
> > On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote:
> > > Instead of stacking alternative and paravirt patching, use the new
> > > ALT_FLAG_CALL flag to switch those mixed calls to pure alternative
> > > handling.
> > > 
> > > This eliminates the need to be careful regarding the sequence of
> > > alternative and paravirt patching.
> > > 
> > > For call depth tracking callthunks_setup() needs to be adapted to patch
> > > calls at alternative patching sites instead of paravirt calls.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > 
> > I cannot help but feel this would've been better as two patches, one
> > introducing ALT_NOT_XEN and then a second with the rest.
> 
> In case I need to respin I'll split it up.

Yeah, would be nice to split this patch into two, as Peter requested.

Thanks,

	Ingo

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	virtualization@lists.linux-foundation.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ajay Kaher <akaher@vmware.com>,
	Alexey Makhalov <amakhalov@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>
Subject: Re: [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
Date: Wed, 18 Oct 2023 13:34:44 +0200	[thread overview]
Message-ID: <ZS/C1HS/EEXTtVji@gmail.com> (raw)
In-Reply-To: <4f5cc965-36da-43f0-aaaa-082a2235ec1e@suse.com>


* Juergen Gross <jgross@suse.com> wrote:

> On 16.10.23 16:29, Peter Zijlstra wrote:
> > On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote:
> > > Instead of stacking alternative and paravirt patching, use the new
> > > ALT_FLAG_CALL flag to switch those mixed calls to pure alternative
> > > handling.
> > > 
> > > This eliminates the need to be careful regarding the sequence of
> > > alternative and paravirt patching.
> > > 
> > > For call depth tracking callthunks_setup() needs to be adapted to patch
> > > calls at alternative patching sites instead of paravirt calls.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > 
> > I cannot help but feel this would've been better as two patches, one
> > introducing ALT_NOT_XEN and then a second with the rest.
> 
> In case I need to respin I'll split it up.

Yeah, would be nice to split this patch into two, as Peter requested.

Thanks,

	Ingo


  reply	other threads:[~2023-10-18 11:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 12:39 [PATCH v2 0/4] x86/paravirt: Get rid of paravirt patching Juergen Gross via Virtualization
2023-10-16 12:39 ` Juergen Gross
2023-10-16 12:39 ` [PATCH v2 1/4] x86/paravirt: move some functions and defines to alternative Juergen Gross via Virtualization
2023-10-16 12:39   ` Juergen Gross
2023-10-16 12:39 ` [PATCH v2 2/4] x86/alternative: add indirect call patching Juergen Gross
2023-10-16 12:39 ` [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2 Juergen Gross via Virtualization
2023-10-16 12:39   ` Juergen Gross
2023-10-16 14:29   ` Peter Zijlstra
2023-10-16 14:29     ` Peter Zijlstra
2023-10-16 14:40     ` Juergen Gross via Virtualization
2023-10-16 14:40       ` Juergen Gross
2023-10-18 11:34       ` Ingo Molnar [this message]
2023-10-18 11:34         ` Ingo Molnar
2023-10-18 15:02         ` Juergen Gross via Virtualization
2023-10-18 15:02           ` Juergen Gross
2023-10-16 12:39 ` [PATCH v2 4/4] x86/paravirt: remove no longer needed paravirt patching code Juergen Gross via Virtualization
2023-10-16 12:39   ` Juergen Gross
2023-10-16 14:30   ` Peter Zijlstra
2023-10-16 14:30     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS/C1HS/EEXTtVji@gmail.com \
    --to=mingo@kernel.org \
    --cc=akaher@vmware.com \
    --cc=amakhalov@vmware.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pv-drivers@vmware.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.