All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: patrice.chotard@foss.st.com, andersson@kernel.org,
	robh@kernel.org, ndesaulniers@google.com, trix@redhat.com,
	linux-arm-kernel@lists.infradead.org,
	linux-remoteproc@vger.kernel.org, llvm@lists.linux.dev,
	patches@lists.linux.dev
Subject: Re: [PATCH] remoteproc: st: Fix sometimes uninitialized ret in st_rproc_probe()
Date: Mon, 16 Oct 2023 11:29:00 -0600	[thread overview]
Message-ID: <ZS1ytespl//DoY3Q@p14s> (raw)
In-Reply-To: <20231012-st_remoteproc-fix-sometimes-uninit-v1-1-f64d0f2d5b37@kernel.org>

On Thu, Oct 12, 2023 at 10:04:01AM -0700, Nathan Chancellor wrote:
> Clang warns (or errors with CONFIG_WERROR=y):
> 
>   drivers/remoteproc/st_remoteproc.c:357:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>     357 |         if (!ddata->config)
>         |             ^~~~~~~~~~~~~~
>   drivers/remoteproc/st_remoteproc.c:442:9: note: uninitialized use occurs here
>     442 |         return ret;
>         |                ^~~
>   drivers/remoteproc/st_remoteproc.c:357:2: note: remove the 'if' if its condition is always false
>     357 |         if (!ddata->config)
>         |         ^~~~~~~~~~~~~~~~~~~
>     358 |                 goto free_rproc;
>         |                 ~~~~~~~~~~~~~~~
>   drivers/remoteproc/st_remoteproc.c:348:9: note: initialize the variable 'ret' to silence this warning
>     348 |         int ret, i;
>         |                ^
>         |                 = 0
>   1 error generated.
> 
> Set ret to -ENODEV, which seems to be a standard return code when
> device_get_match_data() returns NULL.
> 
> Closes: https://github.com/ClangBuiltLinux/linux/issues/1944
> Fixes: 5c77ebcd05ac ("remoteproc: st: Use device_get_match_data()")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/remoteproc/st_remoteproc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index b0638f984842..cb163766c56d 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -354,8 +354,10 @@ static int st_rproc_probe(struct platform_device *pdev)
>  	rproc->has_iommu = false;
>  	ddata = rproc->priv;
>  	ddata->config = (struct st_rproc_config *)device_get_match_data(dev);
> -	if (!ddata->config)
> +	if (!ddata->config) {
> +		ret = -ENODEV;

Applied and thanks for fixing this.

Mathieu

>  		goto free_rproc;
> +	}
>  
>  	platform_set_drvdata(pdev, rproc);
>  
> 
> ---
> base-commit: 5c77ebcd05acf3789949c8a387df72381d949ca2
> change-id: 20231012-st_remoteproc-fix-sometimes-uninit-7aff1bdb7349
> 
> Best regards,
> -- 
> Nathan Chancellor <nathan@kernel.org>
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: patrice.chotard@foss.st.com, andersson@kernel.org,
	robh@kernel.org, ndesaulniers@google.com, trix@redhat.com,
	linux-arm-kernel@lists.infradead.org,
	linux-remoteproc@vger.kernel.org, llvm@lists.linux.dev,
	patches@lists.linux.dev
Subject: Re: [PATCH] remoteproc: st: Fix sometimes uninitialized ret in st_rproc_probe()
Date: Mon, 16 Oct 2023 11:29:00 -0600	[thread overview]
Message-ID: <ZS1ytespl//DoY3Q@p14s> (raw)
In-Reply-To: <20231012-st_remoteproc-fix-sometimes-uninit-v1-1-f64d0f2d5b37@kernel.org>

On Thu, Oct 12, 2023 at 10:04:01AM -0700, Nathan Chancellor wrote:
> Clang warns (or errors with CONFIG_WERROR=y):
> 
>   drivers/remoteproc/st_remoteproc.c:357:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>     357 |         if (!ddata->config)
>         |             ^~~~~~~~~~~~~~
>   drivers/remoteproc/st_remoteproc.c:442:9: note: uninitialized use occurs here
>     442 |         return ret;
>         |                ^~~
>   drivers/remoteproc/st_remoteproc.c:357:2: note: remove the 'if' if its condition is always false
>     357 |         if (!ddata->config)
>         |         ^~~~~~~~~~~~~~~~~~~
>     358 |                 goto free_rproc;
>         |                 ~~~~~~~~~~~~~~~
>   drivers/remoteproc/st_remoteproc.c:348:9: note: initialize the variable 'ret' to silence this warning
>     348 |         int ret, i;
>         |                ^
>         |                 = 0
>   1 error generated.
> 
> Set ret to -ENODEV, which seems to be a standard return code when
> device_get_match_data() returns NULL.
> 
> Closes: https://github.com/ClangBuiltLinux/linux/issues/1944
> Fixes: 5c77ebcd05ac ("remoteproc: st: Use device_get_match_data()")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/remoteproc/st_remoteproc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index b0638f984842..cb163766c56d 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -354,8 +354,10 @@ static int st_rproc_probe(struct platform_device *pdev)
>  	rproc->has_iommu = false;
>  	ddata = rproc->priv;
>  	ddata->config = (struct st_rproc_config *)device_get_match_data(dev);
> -	if (!ddata->config)
> +	if (!ddata->config) {
> +		ret = -ENODEV;

Applied and thanks for fixing this.

Mathieu

>  		goto free_rproc;
> +	}
>  
>  	platform_set_drvdata(pdev, rproc);
>  
> 
> ---
> base-commit: 5c77ebcd05acf3789949c8a387df72381d949ca2
> change-id: 20231012-st_remoteproc-fix-sometimes-uninit-7aff1bdb7349
> 
> Best regards,
> -- 
> Nathan Chancellor <nathan@kernel.org>
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-10-16 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 17:04 [PATCH] remoteproc: st: Fix sometimes uninitialized ret in st_rproc_probe() Nathan Chancellor
2023-10-12 17:04 ` Nathan Chancellor
2023-10-13 20:36 ` Nick Desaulniers
2023-10-13 20:36   ` Nick Desaulniers
2023-10-16 17:29 ` Mathieu Poirier [this message]
2023-10-16 17:29   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS1ytespl//DoY3Q@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=andersson@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=patches@lists.linux.dev \
    --cc=patrice.chotard@foss.st.com \
    --cc=robh@kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.