Re: [Bridge] [PATCH net-next 07/13] bridge: add MDB get uAPI attributes

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Ido Schimmel <idosch@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	edumazet@google.com, mlxsw@nvidia.com, roopa@nvidia.com,
	kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 07/13] bridge: add MDB get uAPI attributes
Date: Tue, 17 Oct 2023 13:58:39 +0300	[thread overview]
Message-ID: <ZS5o337prUOKspUL@shredder> (raw)
In-Reply-To: <b3e0d656-cb25-3ac8-6391-8fb27217470b@blackwall.org>

On Tue, Oct 17, 2023 at 12:08:30PM +0300, Nikolay Aleksandrov wrote:
> On 10/16/23 16:12, Ido Schimmel wrote:
> > Add MDB get attributes that correspond to the MDB set attributes used in
> > RTM_NEWMDB messages. Specifically, add 'MDBA_GET_ENTRY' which will hold
> > a 'struct br_mdb_entry' and 'MDBA_GET_ENTRY_ATTRS' which will hold
> > 'MDBE_ATTR_*' attributes that are used as indexes (source IP and source
> > VNI).
> > 
> > An example request will look as follows:
> > 
> > [ struct nlmsghdr ]
> > [ struct br_port_msg ]
> > [ MDBA_GET_ENTRY ]
> > 	struct br_mdb_entry
> > [ MDBA_GET_ENTRY_ATTRS ]
> > 	[ MDBE_ATTR_SOURCE ]
> > 		struct in_addr / struct in6_addr
> > 	[ MDBE_ATTR_SRC_VNI ]
> > 		u32
> > 
> 
> Could you please add this info as a comment above the enum?
> Similar to the enum below it. It'd be nice to have an example
> of what's expected.

Yes, will add in v2

Thanks

WARNING: multiple messages have this Message-ID (diff)

From: Ido Schimmel <idosch@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
	pabeni@redhat.com, roopa@nvidia.com, mlxsw@nvidia.com
Subject: Re: [PATCH net-next 07/13] bridge: add MDB get uAPI attributes
Date: Tue, 17 Oct 2023 13:58:39 +0300	[thread overview]
Message-ID: <ZS5o337prUOKspUL@shredder> (raw)
In-Reply-To: <b3e0d656-cb25-3ac8-6391-8fb27217470b@blackwall.org>

On Tue, Oct 17, 2023 at 12:08:30PM +0300, Nikolay Aleksandrov wrote:
> On 10/16/23 16:12, Ido Schimmel wrote:
> > Add MDB get attributes that correspond to the MDB set attributes used in
> > RTM_NEWMDB messages. Specifically, add 'MDBA_GET_ENTRY' which will hold
> > a 'struct br_mdb_entry' and 'MDBA_GET_ENTRY_ATTRS' which will hold
> > 'MDBE_ATTR_*' attributes that are used as indexes (source IP and source
> > VNI).
> > 
> > An example request will look as follows:
> > 
> > [ struct nlmsghdr ]
> > [ struct br_port_msg ]
> > [ MDBA_GET_ENTRY ]
> > 	struct br_mdb_entry
> > [ MDBA_GET_ENTRY_ATTRS ]
> > 	[ MDBE_ATTR_SOURCE ]
> > 		struct in_addr / struct in6_addr
> > 	[ MDBE_ATTR_SRC_VNI ]
> > 		u32
> > 
> 
> Could you please add this info as a comment above the enum?
> Similar to the enum below it. It'd be nice to have an example
> of what's expected.

Yes, will add in v2

Thanks

next prev parent reply	other threads:[~2023-10-17 10:58 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 13:12 [Bridge] [PATCH net-next 00/13] Add MDB get support Ido Schimmel
2023-10-16 13:12 ` Ido Schimmel
2023-10-16 13:12 ` [Bridge] [PATCH net-next 01/13] bridge: mcast: Dump MDB entries even when snooping is disabled Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:04   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:04     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 02/13] bridge: mcast: Account for missing attributes Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:05   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:05     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 03/13] bridge: mcast: Factor out a helper for PG entry size calculation Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:05   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:05     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 04/13] bridge: mcast: Rename MDB entry get function Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:06   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:06     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 05/13] vxlan: mdb: Adjust function arguments Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:06   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:06     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 06/13] vxlan: mdb: Factor out a helper for remote entry size calculation Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:06   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:06     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 07/13] bridge: add MDB get uAPI attributes Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:08   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:08     ` Nikolay Aleksandrov
2023-10-17 10:58     ` Ido Schimmel [this message]
2023-10-17 10:58       ` Ido Schimmel
2023-10-16 13:12 ` [Bridge] [PATCH net-next 08/13] net: Add MDB get device operation Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:08   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:08     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 09/13] bridge: mcast: Add MDB get support Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:24   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:24     ` Nikolay Aleksandrov
2023-10-17 11:03     ` [Bridge] " Ido Schimmel
2023-10-17 11:03       ` Ido Schimmel
2023-10-17 12:53       ` [Bridge] " Nikolay Aleksandrov
2023-10-17 12:53         ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 10/13] vxlan: mdb: " Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:28   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:28     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 11/13] rtnetlink: " Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:29   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:29     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 12/13] selftests: bridge_mdb: Use MDB get instead of dump Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:29   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:29     ` Nikolay Aleksandrov
2023-10-16 13:12 ` [Bridge] [PATCH net-next 13/13] selftests: vxlan_mdb: " Ido Schimmel
2023-10-16 13:12   ` Ido Schimmel
2023-10-17  9:30   ` [Bridge] " Nikolay Aleksandrov
2023-10-17  9:30     ` Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS5o337prUOKspUL@shredder \
    --to=idosch@nvidia.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.