From: Wang Jinchao <wangjinchao@xfusion.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stone.xulei@xfusion.com>
Subject: Re: [RFC/REFACT] Refactoring and significantly reducing code complexity
Date: Sat, 7 Oct 2023 09:17:59 +0800 [thread overview]
Message-ID: <ZSCxxxMKoby6XWsg@fedora> (raw)
In-Reply-To: <ZRZk6tC6j1FtW3uY@gauss3.secunet.de>
On Fri, Sep 29, 2023 at 07:47:22AM +0200, Steffen Klassert wrote:
> On Thu, Sep 28, 2023 at 04:53:38PM +0800, Wang Jinchao wrote:
> > This is a refactored version with the following main changes:
> >
> > - The parallel workqueue no longer uses the WQ_UNBOUND attribute
> > - Removal of CPU-related logic, sysfs-related interfaces
> > - removal of structures like padata_cpumask, and deletion of parallel_data
> > - Using completion to maintain sequencing
> > - no longer using lists
> > - removing structures like padata_list and padata_serial_queue
> > - Removal of padata_do_serial()
>
> This removes all the logic that is needed to ensure that
> the parallelized objects return in the same order as
> they were before the parallelization. This change makes
> padata unusable for networking.
The RFC use the following three to ensure serial timing sequence:
1. Use alloc_ordered_workqueue() to create a serial worker queue where
serial() function runs. This ensures that serial() function executes
as serial work was enqueued using queue_work().
2. Queue the serial work before enqueueing parallel work in padata_do_parallel().
This ensures the serial work follows the same order as the padata_do_parallel().
3. The serial work wait for completion of parallel_done, which will be
complete()ed after the parallel() function within the parallel work.
This is just a design idea, because I am not familiar with IPsec, I haven't
tested it in a real network environment yet.
Could you give me some clues on how to use pcrypt in an IPsec scenario?
next prev parent reply other threads:[~2023-10-07 1:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 8:53 [RFC/REFACT] Refactoring and significantly reducing code complexity Wang Jinchao
2023-09-29 5:47 ` Steffen Klassert
2023-10-07 1:17 ` Wang Jinchao [this message]
2023-10-16 10:28 ` Steffen Klassert
2023-10-25 18:13 ` Daniel Jordan
2023-10-26 1:15 ` Wang Jinchao
2023-10-08 7:58 ` Wang Jinchao
2023-10-16 10:47 ` Steffen Klassert
2023-10-25 18:07 ` Daniel Jordan
2023-10-26 1:07 ` Wang Jinchao
2023-10-25 18:12 ` Daniel Jordan
2023-10-26 1:12 ` Wang Jinchao
2023-10-26 1:45 ` Wang Jinchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSCxxxMKoby6XWsg@fedora \
--to=wangjinchao@xfusion.com \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=stone.xulei@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.