All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state
@ 2023-10-09  9:59 Suraj Kandpal
  2023-10-09 10:36 ` Jani Nikula
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Suraj Kandpal @ 2023-10-09  9:59 UTC (permalink / raw)
  To: intel-gfx

Free hw_crtc_state in verify_crtc_state after we are done using
this or else it's just a resource leak.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_modeset_verify.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
index 303eb68fec11..5e1c2c780412 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
@@ -214,7 +214,7 @@ verify_crtc_state(struct intel_atomic_state *state,
 	}
 
 	if (!sw_crtc_state->hw.active)
-		return;
+		goto destroy_state;
 
 	intel_pipe_config_sanity_check(hw_crtc_state);
 
@@ -224,6 +224,9 @@ verify_crtc_state(struct intel_atomic_state *state,
 		intel_crtc_state_dump(hw_crtc_state, NULL, "hw state");
 		intel_crtc_state_dump(sw_crtc_state, NULL, "sw state");
 	}
+
+destroy_state:
+	intel_crtc_destroy_state(&crtc->base, &hw_crtc_state->uapi);
 }
 
 void intel_modeset_verify_crtc(struct intel_atomic_state *state,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-10-10 18:55 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09  9:59 [Intel-gfx] [PATCH] drm/i915/display: Free crtc_state in verify_crtc_state Suraj Kandpal
2023-10-09 10:36 ` Jani Nikula
2023-10-09 10:58   ` Kandpal, Suraj
2023-10-09 12:37     ` Ville Syrjälä
2023-10-10  2:31       ` Kandpal, Suraj
2023-10-09 12:48     ` Jani Nikula
2023-10-09 20:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-10-10  1:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-10  5:32 ` [Intel-gfx] [PATCH] " Suraj Kandpal
2023-10-10 18:55   ` Ville Syrjälä
2023-10-10 10:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Free crtc_state in verify_crtc_state (rev2) Patchwork
2023-10-10 17:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.