All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL
@ 2023-10-11 10:23 Melanie Lobo
  2023-10-11 10:21 ` Jani Nikula
                   ` (18 more replies)
  0 siblings, 19 replies; 29+ messages in thread
From: Melanie Lobo @ 2023-10-11 10:23 UTC (permalink / raw)
  To: intel-gfx; +Cc: juha-pekka.heikkila

MTL supports FP16 format which is a binary floating-point computer
number format that occupies 16 bits in computer memory.Platform shall
render compression in display engine to receive FP16 compressed formats.

This kernel change was tested with IGT patch,
https://patchwork.freedesktop.org/patch/562014/

Test-with: 20231011095520.10768-1-melanie.lobo@intel.com

Signed-off-by: Melanie Lobo <melanie.lobo@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fb.c            | 2 ++
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index e7678571b0d7..868cfc75e687 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -91,6 +91,8 @@ static const struct drm_format_info gen12_ccs_formats[] = {
 	{ .format = DRM_FORMAT_P016, .num_planes = 4,
 	  .char_per_block = { 2, 4, 1, 1 }, .block_w = { 1, 1, 2, 2 }, .block_h = { 1, 1, 1, 1 },
 	  .hsub = 2, .vsub = 2, .is_yuv = true },
+	{ .format = DRM_FORMAT_XRGB16161616F, .depth = 64, .num_planes = 2,
+	  .char_per_block = { 4, 1}, .block_w = { 1, 2}, .block_h = { 1, 1}, .hsub = 1, .vsub = 1 },
 };
 
 /*
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 245a64332cc7..64c1d6c2bd76 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -2122,8 +2122,7 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,
 	case DRM_FORMAT_Y216:
 	case DRM_FORMAT_XVYU12_16161616:
 	case DRM_FORMAT_XVYU16161616:
-		if (!intel_fb_is_ccs_modifier(modifier))
-			return true;
+		return true;
 		fallthrough;
 	default:
 		return false;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 29+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL
@ 2023-10-14 20:49 kernel test robot
  0 siblings, 0 replies; 29+ messages in thread
From: kernel test robot @ 2023-10-14 20:49 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231011102356.22014-1-melanie.lobo@intel.com>
References: <20231011102356.22014-1-melanie.lobo@intel.com>
TO: Melanie Lobo <melanie.lobo@intel.com>
TO: intel-gfx@lists.freedesktop.org
CC: juha-pekka.heikkila@intel.com

Hi Melanie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Melanie-Lobo/drm-i915-Support-FP16-compressed-formats-on-MTL/20231011-181214
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:    https://lore.kernel.org/r/20231011102356.22014-1-melanie.lobo%40intel.com
patch subject: [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-161-20231015 (https://download.01.org/0day-ci/archive/20231015/202310150454.S9QF86bl-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231015/202310150454.S9QF86bl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202310150454.S9QF86bl-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/i915/display/skl_universal_plane.c:2126 gen12_plane_format_mod_supported() warn: ignoring unreachable code.

vim +2126 drivers/gpu/drm/i915/display/skl_universal_plane.c

46d12f911821f7 Dave Airlie           2021-02-05  2080  
46d12f911821f7 Dave Airlie           2021-02-05  2081  static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,
46d12f911821f7 Dave Airlie           2021-02-05  2082  					     u32 format, u64 modifier)
46d12f911821f7 Dave Airlie           2021-02-05  2083  {
46d12f911821f7 Dave Airlie           2021-02-05  2084  	struct intel_plane *plane = to_intel_plane(_plane);
46d12f911821f7 Dave Airlie           2021-02-05  2085  
e2b8329432b880 Imre Deak             2021-10-20  2086  	if (!intel_fb_plane_supports_modifier(plane, modifier))
1a7910368cba1e José Roberto de Souza 2021-05-14  2087  		return false;
46d12f911821f7 Dave Airlie           2021-02-05  2088  
46d12f911821f7 Dave Airlie           2021-02-05  2089  	switch (format) {
46d12f911821f7 Dave Airlie           2021-02-05  2090  	case DRM_FORMAT_XRGB8888:
46d12f911821f7 Dave Airlie           2021-02-05  2091  	case DRM_FORMAT_XBGR8888:
46d12f911821f7 Dave Airlie           2021-02-05  2092  	case DRM_FORMAT_ARGB8888:
46d12f911821f7 Dave Airlie           2021-02-05  2093  	case DRM_FORMAT_ABGR8888:
e359c47bfa6155 Imre Deak             2021-10-20  2094  		if (intel_fb_is_ccs_modifier(modifier))
46d12f911821f7 Dave Airlie           2021-02-05  2095  			return true;
46d12f911821f7 Dave Airlie           2021-02-05  2096  		fallthrough;
46d12f911821f7 Dave Airlie           2021-02-05  2097  	case DRM_FORMAT_YUYV:
46d12f911821f7 Dave Airlie           2021-02-05  2098  	case DRM_FORMAT_YVYU:
46d12f911821f7 Dave Airlie           2021-02-05  2099  	case DRM_FORMAT_UYVY:
46d12f911821f7 Dave Airlie           2021-02-05  2100  	case DRM_FORMAT_VYUY:
46d12f911821f7 Dave Airlie           2021-02-05  2101  	case DRM_FORMAT_NV12:
46d12f911821f7 Dave Airlie           2021-02-05  2102  	case DRM_FORMAT_XYUV8888:
46d12f911821f7 Dave Airlie           2021-02-05  2103  	case DRM_FORMAT_P010:
46d12f911821f7 Dave Airlie           2021-02-05  2104  	case DRM_FORMAT_P012:
46d12f911821f7 Dave Airlie           2021-02-05  2105  	case DRM_FORMAT_P016:
0b2c31dd886865 Imre Deak             2021-10-20  2106  		if (intel_fb_is_mc_ccs_modifier(modifier))
46d12f911821f7 Dave Airlie           2021-02-05  2107  			return true;
46d12f911821f7 Dave Airlie           2021-02-05  2108  		fallthrough;
46d12f911821f7 Dave Airlie           2021-02-05  2109  	case DRM_FORMAT_RGB565:
46d12f911821f7 Dave Airlie           2021-02-05  2110  	case DRM_FORMAT_XRGB2101010:
46d12f911821f7 Dave Airlie           2021-02-05  2111  	case DRM_FORMAT_XBGR2101010:
46d12f911821f7 Dave Airlie           2021-02-05  2112  	case DRM_FORMAT_ARGB2101010:
46d12f911821f7 Dave Airlie           2021-02-05  2113  	case DRM_FORMAT_ABGR2101010:
46d12f911821f7 Dave Airlie           2021-02-05  2114  	case DRM_FORMAT_XVYU2101010:
46d12f911821f7 Dave Airlie           2021-02-05  2115  	case DRM_FORMAT_C8:
46d12f911821f7 Dave Airlie           2021-02-05  2116  	case DRM_FORMAT_XBGR16161616F:
46d12f911821f7 Dave Airlie           2021-02-05  2117  	case DRM_FORMAT_ABGR16161616F:
46d12f911821f7 Dave Airlie           2021-02-05  2118  	case DRM_FORMAT_XRGB16161616F:
46d12f911821f7 Dave Airlie           2021-02-05  2119  	case DRM_FORMAT_ARGB16161616F:
46d12f911821f7 Dave Airlie           2021-02-05  2120  	case DRM_FORMAT_Y210:
46d12f911821f7 Dave Airlie           2021-02-05  2121  	case DRM_FORMAT_Y212:
46d12f911821f7 Dave Airlie           2021-02-05  2122  	case DRM_FORMAT_Y216:
46d12f911821f7 Dave Airlie           2021-02-05  2123  	case DRM_FORMAT_XVYU12_16161616:
46d12f911821f7 Dave Airlie           2021-02-05  2124  	case DRM_FORMAT_XVYU16161616:
46d12f911821f7 Dave Airlie           2021-02-05  2125  		return true;
46d12f911821f7 Dave Airlie           2021-02-05 @2126  		fallthrough;
46d12f911821f7 Dave Airlie           2021-02-05  2127  	default:
46d12f911821f7 Dave Airlie           2021-02-05  2128  		return false;
46d12f911821f7 Dave Airlie           2021-02-05  2129  	}
46d12f911821f7 Dave Airlie           2021-02-05  2130  }
46d12f911821f7 Dave Airlie           2021-02-05  2131  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2024-07-05 14:35 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-11 10:23 [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL Melanie Lobo
2023-10-11 10:21 ` Jani Nikula
2023-10-11 10:35   ` Lobo, Melanie
2023-10-12  4:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-10-12  6:26 ` [Intel-gfx] [PATCH] " Melanie Lobo
2023-10-12 12:56   ` Ville Syrjälä
2023-10-23  9:15     ` Lobo, Melanie
2023-10-23  9:25   ` Melanie Lobo
2023-10-12 23:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support FP16 compressed formats on MTL (rev3) Patchwork
2023-10-13 21:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-16  5:35 ` [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL Dan Carpenter
2023-10-16  5:35   ` Dan Carpenter
2023-10-24 16:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support FP16 compressed formats on MTL (rev4) Patchwork
2023-10-24 16:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-25  6:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-12-01  9:11 ` [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL Melanie Lobo
2023-12-02  0:08   ` Matt Roper
2024-06-03  8:37     ` Lobo, Melanie
2023-12-01 19:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support FP16 compressed formats on MTL (rev5) Patchwork
2023-12-01 19:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-12-03  3:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2024-06-03  8:47 ` [PATCH] drm/i915: Support RGB16161616_64B compressed formats Melanie Lobo
2024-06-03 10:29 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support FP16 compressed formats on MTL (rev6) Patchwork
2024-06-03 10:44 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-03 23:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-05  5:58 ` [PATCH] drm/i915: Support RGB16161616_64B compressed formats Melanie Lobo
2024-06-05  6:04 ` Melanie Lobo
2024-07-05 14:35   ` Ville Syrjälä
  -- strict thread matches above, loose matches on Subject: below --
2023-10-14 20:49 [Intel-gfx] [PATCH] drm/i915: Support FP16 compressed formats on MTL kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.