From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line
Date: Thu, 12 Oct 2023 14:05:54 +0100 [thread overview]
Message-ID: <ZSfvMoAhTXtT7G7l@shell.armlinux.org.uk> (raw)
In-Reply-To: <202310122011.vD7J81PV-lkp@intel.com>
On Thu, Oct 12, 2023 at 08:59:37PM +0800, kernel test robot wrote:
> tree: git://git.armlinux.org.uk/~rmk/linux-arm.git ktext
> head: 7fa946ce05c273d5ff092c814efe64978e5faf45
> commit: e4881183f9059ed8aaa3f16857fd9e0c1db5c168 [3/20] arm64: place kernel in its own L0 page table entry
> reproduce: (https://download.01.org/0day-ci/archive/20231012/202310122011.vD7J81PV-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310122011.vD7J81PV-lkp@intel.com/
>
> # many are suggestions rather than must-fix
>
> WARNING:LEADING_SPACE: please, no spaces at the start of a line
> #72: FILE: arch/arm64/include/asm/memory.h:57:
> + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \$
>
> WARNING:LEADING_SPACE: please, no spaces at the start of a line
> #73: FILE: arch/arm64/include/asm/memory.h:58:
> + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2)$
Sorry, but I disagree with these warnings - and if they are being
applied blanketly as seems to be the case, they will be doing more harm
than good.
What this is complaining about is this:
+#if (CONFIG_ARM64_4K_PAGES && CONFIG_PGTABLE_LEVELS < 4) || \
+ (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \
+ (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2)
which is perfectly reasonably laid out, whereas what it is suggesting:
+#if (CONFIG_ARM64_4K_PAGES && CONFIG_PGTABLE_LEVELS < 4) || \
+ (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \
+ (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2)
Is just awful.
No, I'm not going to fix these, and this emails are just needless
noise. Sorry.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-10-12 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 12:59 [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line kernel test robot
2023-10-12 13:05 ` Russell King (Oracle) [this message]
2023-10-12 13:49 ` Philip Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSfvMoAhTXtT7G7l@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.