* [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line @ 2023-10-12 12:59 kernel test robot 2023-10-12 13:05 ` Russell King (Oracle) 0 siblings, 1 reply; 3+ messages in thread From: kernel test robot @ 2023-10-12 12:59 UTC (permalink / raw) To: Russell King (Oracle); +Cc: oe-kbuild-all tree: git://git.armlinux.org.uk/~rmk/linux-arm.git ktext head: 7fa946ce05c273d5ff092c814efe64978e5faf45 commit: e4881183f9059ed8aaa3f16857fd9e0c1db5c168 [3/20] arm64: place kernel in its own L0 page table entry reproduce: (https://download.01.org/0day-ci/archive/20231012/202310122011.vD7J81PV-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202310122011.vD7J81PV-lkp@intel.com/ # many are suggestions rather than must-fix WARNING:LEADING_SPACE: please, no spaces at the start of a line #72: FILE: arch/arm64/include/asm/memory.h:57: + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #73: FILE: arch/arm64/include/asm/memory.h:58: + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2)$ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line 2023-10-12 12:59 [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line kernel test robot @ 2023-10-12 13:05 ` Russell King (Oracle) 2023-10-12 13:49 ` Philip Li 0 siblings, 1 reply; 3+ messages in thread From: Russell King (Oracle) @ 2023-10-12 13:05 UTC (permalink / raw) To: kernel test robot; +Cc: oe-kbuild-all On Thu, Oct 12, 2023 at 08:59:37PM +0800, kernel test robot wrote: > tree: git://git.armlinux.org.uk/~rmk/linux-arm.git ktext > head: 7fa946ce05c273d5ff092c814efe64978e5faf45 > commit: e4881183f9059ed8aaa3f16857fd9e0c1db5c168 [3/20] arm64: place kernel in its own L0 page table entry > reproduce: (https://download.01.org/0day-ci/archive/20231012/202310122011.vD7J81PV-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202310122011.vD7J81PV-lkp@intel.com/ > > # many are suggestions rather than must-fix > > WARNING:LEADING_SPACE: please, no spaces at the start of a line > #72: FILE: arch/arm64/include/asm/memory.h:57: > + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \$ > > WARNING:LEADING_SPACE: please, no spaces at the start of a line > #73: FILE: arch/arm64/include/asm/memory.h:58: > + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2)$ Sorry, but I disagree with these warnings - and if they are being applied blanketly as seems to be the case, they will be doing more harm than good. What this is complaining about is this: +#if (CONFIG_ARM64_4K_PAGES && CONFIG_PGTABLE_LEVELS < 4) || \ + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \ + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2) which is perfectly reasonably laid out, whereas what it is suggesting: +#if (CONFIG_ARM64_4K_PAGES && CONFIG_PGTABLE_LEVELS < 4) || \ + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \ + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2) Is just awful. No, I'm not going to fix these, and this emails are just needless noise. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line 2023-10-12 13:05 ` Russell King (Oracle) @ 2023-10-12 13:49 ` Philip Li 0 siblings, 0 replies; 3+ messages in thread From: Philip Li @ 2023-10-12 13:49 UTC (permalink / raw) To: Russell King (Oracle); +Cc: kernel test robot, oe-kbuild-all On Thu, Oct 12, 2023 at 02:05:54PM +0100, Russell King (Oracle) wrote: > On Thu, Oct 12, 2023 at 08:59:37PM +0800, kernel test robot wrote: > > tree: git://git.armlinux.org.uk/~rmk/linux-arm.git ktext > > head: 7fa946ce05c273d5ff092c814efe64978e5faf45 > > commit: e4881183f9059ed8aaa3f16857fd9e0c1db5c168 [3/20] arm64: place kernel in its own L0 page table entry > > reproduce: (https://download.01.org/0day-ci/archive/20231012/202310122011.vD7J81PV-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@intel.com> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202310122011.vD7J81PV-lkp@intel.com/ > > > > # many are suggestions rather than must-fix > > > > WARNING:LEADING_SPACE: please, no spaces at the start of a line > > #72: FILE: arch/arm64/include/asm/memory.h:57: > > + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \$ > > > > WARNING:LEADING_SPACE: please, no spaces at the start of a line > > #73: FILE: arch/arm64/include/asm/memory.h:58: > > + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2)$ > > Sorry, but I disagree with these warnings - and if they are being > applied blanketly as seems to be the case, they will be doing more harm > than good. Thanks for the feedback, we look into some existing fixes for this warning on mainline, but seems no similar case to this one. We will turn this to manual check to avoid bringing noise in future. > > What this is complaining about is this: > > +#if (CONFIG_ARM64_4K_PAGES && CONFIG_PGTABLE_LEVELS < 4) || \ > + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \ > + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2) > > which is perfectly reasonably laid out, whereas what it is suggesting: > > +#if (CONFIG_ARM64_4K_PAGES && CONFIG_PGTABLE_LEVELS < 4) || \ > + (CONFIG_ARM64_16K_PAGES && CONFIG_PGTABLE_LEVELS < 3) || \ > + (CONFIG_ARM64_64K_PAGES && CONFIG_PGTABLE_LEVELS < 2) > > Is just awful. > > No, I'm not going to fix these, and this emails are just needless > noise. Sorry. Sorry for the noise, we will fix it asap. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12 13:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-12 12:59 [arm:ktext 3/20] checkpatch: WARNING: please, no spaces at the start of a line kernel test robot 2023-10-12 13:05 ` Russell King (Oracle) 2023-10-12 13:49 ` Philip Li
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.