[PATCH v1 net-next 0/2] Add missing MODULE_DESCRIPTIONS

[PATCH v1 net-next 0/2] Add missing MODULE_DESCRIPTIONS

[Andrew Lunn]

Fixup PHY and MDIO drivers which are missing MODULE_DESCRIPTION.

Andrew Lunn (2):
  net: phy: fill in missing MODULE_DESCRIPTION()s
  net: mdio: fill in missing MODULE_DESCRIPTION()s

 drivers/net/mdio/acpi_mdio.c    | 1 +
 drivers/net/mdio/fwnode_mdio.c  | 1 +
 drivers/net/mdio/mdio-aspeed.c  | 1 +
 drivers/net/mdio/mdio-bitbang.c | 1 +
 drivers/net/mdio/of_mdio.c      | 1 +
 drivers/net/phy/bcm-phy-ptp.c   | 1 +
 drivers/net/phy/bcm87xx.c       | 1 +
 drivers/net/phy/phylink.c       | 1 +
 drivers/net/phy/sfp.c           | 1 +
 9 files changed, 9 insertions(+)

-- 
2.42.0

[PATCH v1 net-next 1/2] net: phy: fill in missing MODULE_DESCRIPTION()s

[Andrew Lunn]

W=1 builds now warn if a module is built without a
MODULE_DESCRIPTION(). Fill them in based on the Kconfig text, or
similar.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/phy/bcm-phy-ptp.c | 1 +
 drivers/net/phy/bcm87xx.c     | 1 +
 drivers/net/phy/phylink.c     | 1 +
 drivers/net/phy/sfp.c         | 1 +
 4 files changed, 4 insertions(+)

diff --git a/drivers/net/phy/bcm-phy-ptp.c b/drivers/net/phy/bcm-phy-ptp.c
index ef00d6163061..cb4b91af5e17 100644
--- a/drivers/net/phy/bcm-phy-ptp.c
+++ b/drivers/net/phy/bcm-phy-ptp.c
@@ -942,3 +942,4 @@ struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev)
 EXPORT_SYMBOL_GPL(bcm_ptp_probe);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Broadcom PHY PTP driver");
diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
index cc2858107668..e81404bf8994 100644
--- a/drivers/net/phy/bcm87xx.c
+++ b/drivers/net/phy/bcm87xx.c
@@ -223,3 +223,4 @@ static struct phy_driver bcm87xx_driver[] = {
 module_phy_driver(bcm87xx_driver);
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Broadcom BCM87xx PHY driver");
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 6712883498bb..6fdc6ba294d5 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -3726,3 +3726,4 @@ static int __init phylink_init(void)
 module_init(phylink_init);
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("phylink models the MAC to optional PHY connection");
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index b8c0961daf53..5468bd209fab 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -3153,3 +3153,4 @@ module_exit(sfp_exit);
 MODULE_ALIAS("platform:sfp");
 MODULE_AUTHOR("Russell King");
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("SFP cage support");
-- 
2.42.0

Re: [PATCH v1 net-next 1/2] net: phy: fill in missing MODULE_DESCRIPTION()s

[Florian Fainelli]

On 10/28/2023 11:44 AM, Andrew Lunn wrote:
> W=1 builds now warn if a module is built without a
> MODULE_DESCRIPTION(). Fill them in based on the Kconfig text, or
> similar.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Re: [PATCH v1 net-next 1/2] net: phy: fill in missing MODULE_DESCRIPTION()s

[Russell King (Oracle)]

On Sat, Oct 28, 2023 at 08:44:57PM +0200, Andrew Lunn wrote:
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index b8c0961daf53..5468bd209fab 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -3153,3 +3153,4 @@ module_exit(sfp_exit);
>  MODULE_ALIAS("platform:sfp");
>  MODULE_AUTHOR("Russell King");
>  MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("SFP cage support");

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

[PATCH v1 net-next 2/2] net: mdio: fill in missing MODULE_DESCRIPTION()s

[Andrew Lunn]

W=1 builds now warn if a module is built without a
MODULE_DESCRIPTION(). Fill them in based on the Kconfig text, or
similar.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/mdio/acpi_mdio.c    | 1 +
 drivers/net/mdio/fwnode_mdio.c  | 1 +
 drivers/net/mdio/mdio-aspeed.c  | 1 +
 drivers/net/mdio/mdio-bitbang.c | 1 +
 drivers/net/mdio/of_mdio.c      | 1 +
 5 files changed, 5 insertions(+)

diff --git a/drivers/net/mdio/acpi_mdio.c b/drivers/net/mdio/acpi_mdio.c
index 4630dde01974..5d0f11f280cf 100644
--- a/drivers/net/mdio/acpi_mdio.c
+++ b/drivers/net/mdio/acpi_mdio.c
@@ -16,6 +16,7 @@
 
 MODULE_AUTHOR("Calvin Johnson <calvin.johnson@oss.nxp.com>");
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("ACPI MDIO bus (Ethernet PHY) accessors");
 
 /**
  * __acpi_mdiobus_register - Register mii_bus and create PHYs from the ACPI ASL.
diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
index 1183ef5e203e..fd02f5cbc853 100644
--- a/drivers/net/mdio/fwnode_mdio.c
+++ b/drivers/net/mdio/fwnode_mdio.c
@@ -14,6 +14,7 @@
 
 MODULE_AUTHOR("Calvin Johnson <calvin.johnson@oss.nxp.com>");
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("FWNODE MDIO bus (Ethernet PHY) accessors");
 
 static struct pse_control *
 fwnode_find_pse_control(struct fwnode_handle *fwnode)
diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index 70edeeb7771e..c2170650415c 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -205,3 +205,4 @@ module_platform_driver(aspeed_mdio_driver);
 
 MODULE_AUTHOR("Andrew Jeffery <andrew@aj.id.au>");
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("ASPEED MDIO bus controller");
diff --git a/drivers/net/mdio/mdio-bitbang.c b/drivers/net/mdio/mdio-bitbang.c
index 81b7748c10ce..f88639297ff2 100644
--- a/drivers/net/mdio/mdio-bitbang.c
+++ b/drivers/net/mdio/mdio-bitbang.c
@@ -263,3 +263,4 @@ void free_mdio_bitbang(struct mii_bus *bus)
 EXPORT_SYMBOL(free_mdio_bitbang);
 
 MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Bitbanged MDIO buses");
diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index 7eb32ebb846d..64ebcb6d235c 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -25,6 +25,7 @@
 
 MODULE_AUTHOR("Grant Likely <grant.likely@secretlab.ca>");
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("OpenFirmware MDIO bus (Ethernet PHY) accessors");
 
 /* Extract the clause 22 phy ID from the compatible string of the form
  * ethernet-phy-idAAAA.BBBB */
-- 
2.42.0

Re: [PATCH v1 net-next 2/2] net: mdio: fill in missing MODULE_DESCRIPTION()s

[Florian Fainelli]

On 10/28/2023 11:44 AM, Andrew Lunn wrote:
> W=1 builds now warn if a module is built without a
> MODULE_DESCRIPTION(). Fill them in based on the Kconfig text, or
> similar.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Re: [PATCH v1 net-next 2/2] net: mdio: fill in missing MODULE_DESCRIPTION()s

[Andrew Jeffery]

On Sat, 2023-10-28 at 20:44 +0200, Andrew Lunn wrote:
> W=1 builds now warn if a module is built without a
> MODULE_DESCRIPTION(). Fill them in based on the Kconfig text, or
> similar.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  drivers/net/mdio/acpi_mdio.c    | 1 +
>  drivers/net/mdio/fwnode_mdio.c  | 1 +
>  drivers/net/mdio/mdio-aspeed.c  | 1 +

For the Aspeed change:

Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Re: [PATCH v1 net-next 0/2] Add missing MODULE_DESCRIPTIONS

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 28 Oct 2023 20:44:56 +0200 you wrote:
> Fixup PHY and MDIO drivers which are missing MODULE_DESCRIPTION.
> 
> Andrew Lunn (2):
>   net: phy: fill in missing MODULE_DESCRIPTION()s
>   net: mdio: fill in missing MODULE_DESCRIPTION()s
> 
>  drivers/net/mdio/acpi_mdio.c    | 1 +
>  drivers/net/mdio/fwnode_mdio.c  | 1 +
>  drivers/net/mdio/mdio-aspeed.c  | 1 +
>  drivers/net/mdio/mdio-bitbang.c | 1 +
>  drivers/net/mdio/of_mdio.c      | 1 +
>  drivers/net/phy/bcm-phy-ptp.c   | 1 +
>  drivers/net/phy/bcm87xx.c       | 1 +
>  drivers/net/phy/phylink.c       | 1 +
>  drivers/net/phy/sfp.c           | 1 +
>  9 files changed, 9 insertions(+)

Here is the summary with links:
  - [v1,net-next,1/2] net: phy: fill in missing MODULE_DESCRIPTION()s
    https://git.kernel.org/netdev/net/c/dd9d75fcf0f4
  - [v1,net-next,2/2] net: mdio: fill in missing MODULE_DESCRIPTION()s
    https://git.kernel.org/netdev/net/c/031fba65fc20

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html