All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
	outreachy@lists.linux.dev, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: Remove unnecessary parentheses
Date: Mon, 30 Oct 2023 19:06:23 +0700	[thread overview]
Message-ID: <ZT-cPxSGysyfLCfk@debian.me> (raw)
In-Reply-To: <20231029185405.11073-1-dorine.a.tipo@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Sun, Oct 29, 2023 at 06:54:05PM +0000, Dorine Tipo wrote:
> diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
> index 0c4fac31540a..15d2c84925ba 100644
> --- a/drivers/staging/octeon/ethernet-rgmii.c
> +++ b/drivers/staging/octeon/ethernet-rgmii.c
> @@ -148,7 +148,7 @@ int cvm_oct_rgmii_open(struct net_device *dev)
>  		 */
>  		if ((priv->imode == CVMX_HELPER_INTERFACE_MODE_GMII &&
>  		     priv->port  == 0) ||
> -		    (priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII)) {
> +		    priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII) {
>  			priv->poll = cvm_oct_check_preamble_errors;
>  			cvm_oct_check_preamble_errors(dev);
>  		}
> 

I'd prefer explicit parens on the right-hand side of || instead (to match
the left-hand one).

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-10-30 12:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29 18:54 [PATCH] staging: Remove unnecessary parentheses Dorine Tipo
2023-10-30 12:06 ` Bagas Sanjaya [this message]
2023-10-30 12:40   ` Greg KH
2023-10-30 13:30     ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZT-cPxSGysyfLCfk@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=dorine.a.tipo@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.