Re: [PATCH] staging: Remove unnecessary parentheses

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Oct 30, 2023 at 07:06:23PM +0700, Bagas Sanjaya wrote:
> On Sun, Oct 29, 2023 at 06:54:05PM +0000, Dorine Tipo wrote:
> > diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
> > index 0c4fac31540a..15d2c84925ba 100644
> > --- a/drivers/staging/octeon/ethernet-rgmii.c
> > +++ b/drivers/staging/octeon/ethernet-rgmii.c
> > @@ -148,7 +148,7 @@ int cvm_oct_rgmii_open(struct net_device *dev)
> >  		 */
> >  		if ((priv->imode == CVMX_HELPER_INTERFACE_MODE_GMII &&
> >  		     priv->port  == 0) ||
> > -		    (priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII)) {
> > +		    priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII) {
> >  			priv->poll = cvm_oct_check_preamble_errors;
> >  			cvm_oct_check_preamble_errors(dev);
> >  		}
> > 
> 
> I'd prefer explicit parens on the right-hand side of || instead (to match
> the left-hand one).

Sorry, but as always for this type of change, I will reject it so
there's no need to ask for it to be cleaned up any other way.

Dorine, this type of change is constantly rejected on the mailing list
that you should be copying all of these patches to.  Please search the
archives for reasons why.

thanks,

greg k-h