[PATCH] staging: Remove unnecessary parentheses

[PATCH] staging: Remove unnecessary parentheses

[Dorine Tipo]

- Remove the unnecessary parentheses around
'priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII'

The '==' operator has higher precedence than the '&&' and '||' operators.
Removing the unnecessary parentheses simplifies the code while maintaining
the correct order of operations, making it more readable.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/octeon/ethernet-rgmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
index 0c4fac31540a..15d2c84925ba 100644
--- a/drivers/staging/octeon/ethernet-rgmii.c
+++ b/drivers/staging/octeon/ethernet-rgmii.c
@@ -148,7 +148,7 @@ int cvm_oct_rgmii_open(struct net_device *dev)
 		 */
 		if ((priv->imode == CVMX_HELPER_INTERFACE_MODE_GMII &&
 		     priv->port  == 0) ||
-		    (priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII)) {
+		    priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII) {
 			priv->poll = cvm_oct_check_preamble_errors;
 			cvm_oct_check_preamble_errors(dev);
 		}
-- 
2.25.1

Re: [PATCH] staging: Remove unnecessary parentheses

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Sun, Oct 29, 2023 at 06:54:05PM +0000, Dorine Tipo wrote:
> diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
> index 0c4fac31540a..15d2c84925ba 100644
> --- a/drivers/staging/octeon/ethernet-rgmii.c
> +++ b/drivers/staging/octeon/ethernet-rgmii.c
> @@ -148,7 +148,7 @@ int cvm_oct_rgmii_open(struct net_device *dev)
>  		 */
>  		if ((priv->imode == CVMX_HELPER_INTERFACE_MODE_GMII &&
>  		     priv->port  == 0) ||
> -		    (priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII)) {
> +		    priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII) {
>  			priv->poll = cvm_oct_check_preamble_errors;
>  			cvm_oct_check_preamble_errors(dev);
>  		}
> 

I'd prefer explicit parens on the right-hand side of || instead (to match
the left-hand one).

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] staging: Remove unnecessary parentheses

[Greg KH]

On Mon, Oct 30, 2023 at 07:06:23PM +0700, Bagas Sanjaya wrote:
> On Sun, Oct 29, 2023 at 06:54:05PM +0000, Dorine Tipo wrote:
> > diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
> > index 0c4fac31540a..15d2c84925ba 100644
> > --- a/drivers/staging/octeon/ethernet-rgmii.c
> > +++ b/drivers/staging/octeon/ethernet-rgmii.c
> > @@ -148,7 +148,7 @@ int cvm_oct_rgmii_open(struct net_device *dev)
> >  		 */
> >  		if ((priv->imode == CVMX_HELPER_INTERFACE_MODE_GMII &&
> >  		     priv->port  == 0) ||
> > -		    (priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII)) {
> > +		    priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII) {
> >  			priv->poll = cvm_oct_check_preamble_errors;
> >  			cvm_oct_check_preamble_errors(dev);
> >  		}
> > 
> 
> I'd prefer explicit parens on the right-hand side of || instead (to match
> the left-hand one).

Sorry, but as always for this type of change, I will reject it so
there's no need to ask for it to be cleaned up any other way.

Dorine, this type of change is constantly rejected on the mailing list
that you should be copying all of these patches to.  Please search the
archives for reasons why.

thanks,

greg k-h

Re: [PATCH] staging: Remove unnecessary parentheses

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

On Mon, Oct 30, 2023 at 01:40:14PM +0100, Greg KH wrote:
> On Mon, Oct 30, 2023 at 07:06:23PM +0700, Bagas Sanjaya wrote:
> > On Sun, Oct 29, 2023 at 06:54:05PM +0000, Dorine Tipo wrote:
> > > diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c
> > > index 0c4fac31540a..15d2c84925ba 100644
> > > --- a/drivers/staging/octeon/ethernet-rgmii.c
> > > +++ b/drivers/staging/octeon/ethernet-rgmii.c
> > > @@ -148,7 +148,7 @@ int cvm_oct_rgmii_open(struct net_device *dev)
> > >  		 */
> > >  		if ((priv->imode == CVMX_HELPER_INTERFACE_MODE_GMII &&
> > >  		     priv->port  == 0) ||
> > > -		    (priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII)) {
> > > +		    priv->imode == CVMX_HELPER_INTERFACE_MODE_RGMII) {
> > >  			priv->poll = cvm_oct_check_preamble_errors;
> > >  			cvm_oct_check_preamble_errors(dev);
> > >  		}
> > > 
> > 
> > I'd prefer explicit parens on the right-hand side of || instead (to match
> > the left-hand one).
> 
> Sorry, but as always for this type of change, I will reject it so
> there's no need to ask for it to be cleaned up any other way.

Oh dear! That's what I mean (keeping the status quo/code unchanged).

> 
> Dorine, this type of change is constantly rejected on the mailing list
> that you should be copying all of these patches to.  Please search the
> archives for reasons why.

Greg has review discussions on why it is the case ([1] and [2]).

[1]: https://lore.kernel.org/all/Y%2FiaYtKk4VSokAFz@kroah.com/
[2]: https://lore.kernel.org/all/20190401060216.GA5286@kroah.com/

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]