All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>,
	Dorine Tipo <dorine.a.tipo@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Helen Koike <helen.koike@collabora.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Nick Terrell <terrelln@fb.com>,
	Daniel Stone <daniels@collabora.com>,
	Rob Clark <robdclark@gmail.com>
Cc: Linux Outreachy <outreachy@lists.linux.dev>,
	Linux DRI Development <dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH Resend] Fix line Length
Date: Mon, 30 Oct 2023 06:50:55 +0700	[thread overview]
Message-ID: <ZT7v39jG4WTxPYjm@debian.me> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2310291610030.3136@hadrien>

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 29 Oct 2023, Dorine Tipo wrote:
> 
> > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> >
> > Fix the line lengths of lines 8 and 49
> 
> The Signed off by line should be here, below the log message.  Please see
> the patches sent by others.
> 
> >  export IGT_FORCE_DRIVER=${DRIVER_NAME}
> >  export PATH=$PATH:/igt/bin/
> > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
> 
> There was a suggestion that it was better to keep this as one line.
> 

Hi Julia,

The submitter touched one of CI scripts for the DRM subsystem. To test
this patch, there must be a way to run these scripts locally (which
may requires non-trivial setup).

Cc'ed DRM maintainers.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>,
	Dorine Tipo <dorine.a.tipo@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Helen Koike <helen.koike@collabora.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Nick Terrell <terrelln@fb.com>,
	Daniel Stone <daniels@collabora.com>,
	Rob Clark <robdclark@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux DRI Development <dri-devel@lists.freedesktop.org>,
	Linux Outreachy <outreachy@lists.linux.dev>
Subject: Re: [PATCH Resend] Fix line Length
Date: Mon, 30 Oct 2023 06:50:55 +0700	[thread overview]
Message-ID: <ZT7v39jG4WTxPYjm@debian.me> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2310291610030.3136@hadrien>

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

On Sun, Oct 29, 2023 at 04:11:01PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 29 Oct 2023, Dorine Tipo wrote:
> 
> > Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> >
> > Fix the line lengths of lines 8 and 49
> 
> The Signed off by line should be here, below the log message.  Please see
> the patches sent by others.
> 
> >  export IGT_FORCE_DRIVER=${DRIVER_NAME}
> >  export PATH=$PATH:/igt/bin/
> > -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> > +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
> 
> There was a suggestion that it was better to keep this as one line.
> 

Hi Julia,

The submitter touched one of CI scripts for the DRM subsystem. To test
this patch, there must be a way to run these scripts locally (which
may requires non-trivial setup).

Cc'ed DRM maintainers.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-10-29 23:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29 14:43 [PATCH Resend] Fix line Length Dorine Tipo
2023-10-29 15:11 ` Julia Lawall
2023-10-29 23:50   ` Bagas Sanjaya [this message]
2023-10-29 23:50     ` Bagas Sanjaya
2023-10-30  6:12     ` Julia Lawall
2023-10-30  6:12       ` Julia Lawall
2023-10-30 11:36       ` Bagas Sanjaya
2023-10-30 11:36         ` Bagas Sanjaya
2023-10-31 18:36         ` Helen Koike
2023-10-31 18:36           ` Helen Koike
2023-11-01  2:10           ` Bagas Sanjaya
2023-11-01  2:10             ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZT7v39jG4WTxPYjm@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=daniels@collabora.com \
    --cc=dorine.a.tipo@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=helen.koike@collabora.com \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy@lists.linux.dev \
    --cc=robdclark@gmail.com \
    --cc=terrelln@fb.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.