From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: mark.rutland@arm.com, len.brown@intel.com, will@kernel.org,
linux-gpio@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, robert.moore@intel.com,
bala.senthil@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
acpica-devel@lists.linuxfoundation.org,
linux-hwmon@vger.kernel.org, mika.westerberg@linux.intel.com,
linux@roeck-us.net
Subject: Re: [Acpica-devel] [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching _UID
Date: Fri, 20 Oct 2023 13:37:54 +0300 [thread overview]
Message-ID: <ZTJYgnugWHwBhtxv@smile.fi.intel.com> (raw)
In-Reply-To: <20231020084732.17130-6-raag.jadav@intel.com>
On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote:
> Convert manual _UID references to use standard ACPI helpers.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> - if (!adev->pnp.unique_id ||
> - strcmp(adev->pnp.unique_id, override_status_ids[i].uid))
> + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid))
The check for NULL argument inside that API does not affect the behaviour as
otherwise it will be a crash with the current implementation.
> continue;
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com, mark.rutland@arm.com,
will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching _UID
Date: Fri, 20 Oct 2023 13:37:54 +0300 [thread overview]
Message-ID: <ZTJYgnugWHwBhtxv@smile.fi.intel.com> (raw)
In-Reply-To: <20231020084732.17130-6-raag.jadav@intel.com>
On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote:
> Convert manual _UID references to use standard ACPI helpers.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> - if (!adev->pnp.unique_id ||
> - strcmp(adev->pnp.unique_id, override_status_ids[i].uid))
> + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid))
The check for NULL argument inside that API does not affect the behaviour as
otherwise it will be a crash with the current implementation.
> continue;
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com, mark.rutland@arm.com,
will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching _UID
Date: Fri, 20 Oct 2023 13:37:54 +0300 [thread overview]
Message-ID: <ZTJYgnugWHwBhtxv@smile.fi.intel.com> (raw)
In-Reply-To: <20231020084732.17130-6-raag.jadav@intel.com>
On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote:
> Convert manual _UID references to use standard ACPI helpers.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> - if (!adev->pnp.unique_id ||
> - strcmp(adev->pnp.unique_id, override_status_ids[i].uid))
> + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid))
The check for NULL argument inside that API does not affect the behaviour as
otherwise it will be a crash with the current implementation.
> continue;
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-20 10:37 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 8:47 [Acpica-devel] [PATCH v1 0/8] Refine _UID references across kernel Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 1/8] ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 10:35 ` [Acpica-devel] " Andy Shevchenko
2023-10-20 10:35 ` Andy Shevchenko
2023-10-20 10:35 ` Andy Shevchenko
2023-10-20 15:49 ` [Acpica-devel] " Jonathan Cameron
2023-10-20 15:49 ` Jonathan Cameron
2023-10-20 15:49 ` Jonathan Cameron
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 2/8] pinctrl: intel: use " Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 3/8] ACPI: sysfs: use acpi_device_uid() for fetching _UID Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 17:18 ` [Acpica-devel] " Rafael J. Wysocki
2023-10-20 17:18 ` Rafael J. Wysocki
2023-10-20 17:18 ` Rafael J. Wysocki
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 10:36 ` [Acpica-devel] " Andy Shevchenko
2023-10-20 10:36 ` Andy Shevchenko
2023-10-20 10:36 ` Andy Shevchenko
2023-10-20 11:38 ` [Acpica-devel] " Raag Jadav
2023-10-20 11:38 ` Raag Jadav
2023-10-20 11:38 ` Raag Jadav
2023-10-20 13:42 ` [Acpica-devel] " Andy Shevchenko
2023-10-20 13:42 ` Andy Shevchenko
2023-10-20 13:42 ` Andy Shevchenko
2023-10-20 14:00 ` [Acpica-devel] " Raag Jadav
2023-10-20 14:00 ` Raag Jadav
2023-10-20 14:00 ` Raag Jadav
2023-10-20 17:11 ` [Acpica-devel] " Rafael J. Wysocki
2023-10-20 17:11 ` Rafael J. Wysocki
2023-10-20 17:11 ` Rafael J. Wysocki
2023-10-20 18:11 ` [Acpica-devel] " Raag Jadav
2023-10-20 18:11 ` Raag Jadav
2023-10-20 18:11 ` Raag Jadav
2023-10-21 6:51 ` [Acpica-devel] " Raag Jadav
2023-10-21 6:51 ` Raag Jadav
2023-10-21 6:51 ` Raag Jadav
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 5/8] ACPI: x86: " Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 10:37 ` Andy Shevchenko [this message]
2023-10-20 10:37 ` Andy Shevchenko
2023-10-20 10:37 ` Andy Shevchenko
2023-10-20 17:05 ` [Acpica-devel] " Rafael J. Wysocki
2023-10-20 17:05 ` Rafael J. Wysocki
2023-10-20 17:05 ` Rafael J. Wysocki
2023-10-20 18:42 ` [Acpica-devel] " Andy Shevchenko
2023-10-20 18:42 ` Andy Shevchenko
2023-10-20 18:42 ` Andy Shevchenko
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 6/8] perf: qcom: use acpi_device_uid() for fetching _UID Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 17:22 ` [Acpica-devel] " Rafael J. Wysocki
2023-10-20 17:22 ` Rafael J. Wysocki
2023-10-20 17:22 ` Rafael J. Wysocki
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 7/8] hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and _UID Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` [Acpica-devel] [PATCH v1 8/8] perf: arm_cspmu: " Raag Jadav
2023-10-20 8:47 ` Raag Jadav
2023-10-20 8:47 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTJYgnugWHwBhtxv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=bala.senthil@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
--cc=robert.moore@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.