From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: mark.rutland@arm.com, len.brown@intel.com, will@kernel.org,
linux-gpio@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, robert.moore@intel.com,
bala.senthil@intel.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jonathan.Cameron@huawei.com,
acpica-devel@lists.linuxfoundation.org,
linux-hwmon@vger.kernel.org, mika.westerberg@linux.intel.com,
linux@roeck-us.net
Subject: Re: [Acpica-devel] [PATCH v2 2/6] pinctrl: intel: use acpi_dev_uid_match() for matching _UID
Date: Mon, 23 Oct 2023 17:42:48 +0300 [thread overview]
Message-ID: <ZTaGaDweYpBlxBez@black.fi.intel.com> (raw)
In-Reply-To: <ZTZacR86hSmV04M9@smile.fi.intel.com>
On Mon, Oct 23, 2023 at 02:35:13PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 23, 2023 at 11:05:26AM +0530, Raag Jadav wrote:
> > Convert manual _UID references to use the standard ACPI helper.
>
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> It has a hidden logic that is not aligned with acpi_dev_hid_uid_match().
> Or revert to your v1 I assume.
I don't see how this has to be aligned with acpi_dev_hid_uid_match() or
if acpi_dev_hid_uid_match() implementation concerns this specific change,
since that's not what we intend to do here.
Also, I think acpi_dev_uid_match() implementation in v2 is actually more
aligned with the previous logic that we're replacing here, since it gives
us a guaranteed match result as originally intended with strcmp in this
case. And the "hidden logic" in v1 implementation (match with @uid2 == NULL)
is what ends up breaking it in my opinion.
Regardless, for any version (v1 or v2) the usage still remains the same
in this case.
> As I asked you, please drop this one.
But okay, as you wish :(
Rafael, should I send a v3 with dropped tags?
Raag
WARNING: multiple messages have this Message-ID (diff)
From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com, mark.rutland@arm.com,
will@kernel.org, linux@roeck-us.net, Jonathan.Cameron@huawei.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v2 2/6] pinctrl: intel: use acpi_dev_uid_match() for matching _UID
Date: Mon, 23 Oct 2023 17:42:48 +0300 [thread overview]
Message-ID: <ZTaGaDweYpBlxBez@black.fi.intel.com> (raw)
In-Reply-To: <ZTZacR86hSmV04M9@smile.fi.intel.com>
On Mon, Oct 23, 2023 at 02:35:13PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 23, 2023 at 11:05:26AM +0530, Raag Jadav wrote:
> > Convert manual _UID references to use the standard ACPI helper.
>
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> It has a hidden logic that is not aligned with acpi_dev_hid_uid_match().
> Or revert to your v1 I assume.
I don't see how this has to be aligned with acpi_dev_hid_uid_match() or
if acpi_dev_hid_uid_match() implementation concerns this specific change,
since that's not what we intend to do here.
Also, I think acpi_dev_uid_match() implementation in v2 is actually more
aligned with the previous logic that we're replacing here, since it gives
us a guaranteed match result as originally intended with strcmp in this
case. And the "hidden logic" in v1 implementation (match with @uid2 == NULL)
is what ends up breaking it in my opinion.
Regardless, for any version (v1 or v2) the usage still remains the same
in this case.
> As I asked you, please drop this one.
But okay, as you wish :(
Rafael, should I send a v3 with dropped tags?
Raag
WARNING: multiple messages have this Message-ID (diff)
From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com, mark.rutland@arm.com,
will@kernel.org, linux@roeck-us.net, Jonathan.Cameron@huawei.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v2 2/6] pinctrl: intel: use acpi_dev_uid_match() for matching _UID
Date: Mon, 23 Oct 2023 17:42:48 +0300 [thread overview]
Message-ID: <ZTaGaDweYpBlxBez@black.fi.intel.com> (raw)
In-Reply-To: <ZTZacR86hSmV04M9@smile.fi.intel.com>
On Mon, Oct 23, 2023 at 02:35:13PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 23, 2023 at 11:05:26AM +0530, Raag Jadav wrote:
> > Convert manual _UID references to use the standard ACPI helper.
>
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> It has a hidden logic that is not aligned with acpi_dev_hid_uid_match().
> Or revert to your v1 I assume.
I don't see how this has to be aligned with acpi_dev_hid_uid_match() or
if acpi_dev_hid_uid_match() implementation concerns this specific change,
since that's not what we intend to do here.
Also, I think acpi_dev_uid_match() implementation in v2 is actually more
aligned with the previous logic that we're replacing here, since it gives
us a guaranteed match result as originally intended with strcmp in this
case. And the "hidden logic" in v1 implementation (match with @uid2 == NULL)
is what ends up breaking it in my opinion.
Regardless, for any version (v1 or v2) the usage still remains the same
in this case.
> As I asked you, please drop this one.
But okay, as you wish :(
Rafael, should I send a v3 with dropped tags?
Raag
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-23 14:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 5:35 [Acpica-devel] [PATCH v2 0/6] Refine _UID references across kernel Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` [Acpica-devel] [PATCH v2 1/6] ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 11:34 ` [Acpica-devel] " Andy Shevchenko
2023-10-23 11:34 ` Andy Shevchenko
2023-10-23 11:34 ` Andy Shevchenko
2023-10-23 5:35 ` [Acpica-devel] [PATCH v2 2/6] pinctrl: intel: use " Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 11:35 ` [Acpica-devel] " Andy Shevchenko
2023-10-23 11:35 ` Andy Shevchenko
2023-10-23 11:35 ` Andy Shevchenko
2023-10-23 14:42 ` Raag Jadav [this message]
2023-10-23 14:42 ` Raag Jadav
2023-10-23 14:42 ` Raag Jadav
2023-10-23 18:45 ` [Acpica-devel] " Rafael J. Wysocki
2023-10-23 18:45 ` Rafael J. Wysocki
2023-10-23 18:45 ` Rafael J. Wysocki
2023-10-23 5:35 ` [Acpica-devel] [PATCH v2 3/6] ACPI: utils: " Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` [Acpica-devel] [PATCH v2 4/6] ACPI: x86: " Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 11:36 ` [Acpica-devel] " Andy Shevchenko
2023-10-23 11:36 ` Andy Shevchenko
2023-10-23 11:36 ` Andy Shevchenko
2023-10-23 5:35 ` [Acpica-devel] [PATCH v2 5/6] hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and _UID Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` [Acpica-devel] [PATCH v2 6/6] perf: arm_cspmu: " Raag Jadav
2023-10-23 5:35 ` Raag Jadav
2023-10-23 5:35 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTaGaDweYpBlxBez@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robert.moore@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.