All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
	qemu-ppc@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	"Eric Blake" <eblake@redhat.com>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v6 09/23] ui/console: allow to override the default VC
Date: Fri, 27 Oct 2023 17:38:14 +0100	[thread overview]
Message-ID: <ZTvndl9Bocy2YLOa@redhat.com> (raw)
In-Reply-To: <CABJz62N7-Bo8j=Dopt960=q8Q+CnDQRDWjMLFLqsLMOq_aZxHg@mail.gmail.com>

On Fri, Oct 27, 2023 at 05:53:19AM -0700, Andrea Bolognani wrote:
> On Wed, Oct 25, 2023 at 11:08:03PM +0400, marcandre.lureau@redhat.com wrote:
> > If a display is backed by a specialized VC, allow to override the
> > default "vc:80Cx24C". For that, set the dpy.type just before creating
> > the default serial/parallel/monitor.
> >
> > As suggested by Paolo, if the display doesn't implement a VC (get_vc()
> > returns NULL), use a fallback that will use a muxed console on stdio.
> >
> > This changes the behaviour of "qemu -display none", to create a muxed
> > serial/monitor by default.
> 
> Have you verified that this doesn't break libvirt? We use '-display
> none' for every single VM we run.

IIUC we're ok as this logic appears to be skipped when -nodefaults
is set.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


  reply	other threads:[~2023-10-27 16:38 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 19:07 [PATCH v6 00/23] Make Pixman an optional dependency marcandre.lureau
2023-10-25 19:07 ` [PATCH v6 01/23] build-sys: add a "pixman" feature marcandre.lureau
2023-10-25 19:07 ` [PATCH v6 02/23] build-sys: drop needless warning pragmas for old pixman marcandre.lureau
2023-10-26  5:21   ` Thomas Huth
2023-10-25 19:07 ` [PATCH v6 03/23] ui: compile out some qemu-pixman functions when !PIXMAN marcandre.lureau
2023-10-25 19:07 ` [PATCH v6 04/23] ui: add pixman-minimal.h marcandre.lureau
2023-10-25 19:07 ` [PATCH v6 05/23] vl: drop needless -spice checks marcandre.lureau
2023-10-26  5:23   ` Thomas Huth
2023-10-25 19:08 ` [PATCH v6 06/23] qemu-options: define -vnc only #ifdef CONFIG_VNC marcandre.lureau
2023-10-26  5:24   ` Thomas Huth
2023-10-25 19:08 ` [PATCH v6 07/23] vl: simplify display_remote logic marcandre.lureau
2023-10-26  5:29   ` Thomas Huth
2023-10-25 19:08 ` [PATCH v6 08/23] vl: move display early init before default devices marcandre.lureau
2023-10-26  5:31   ` Thomas Huth
2023-10-25 19:08 ` [PATCH v6 09/23] ui/console: allow to override the default VC marcandre.lureau
2023-10-26  5:35   ` Thomas Huth
2023-10-27 12:53   ` Andrea Bolognani
2023-10-27 16:38     ` Daniel P. Berrangé [this message]
2023-10-25 19:08 ` [PATCH v6 10/23] ui/vc: console-vc requires PIXMAN marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 11/23] qmp/hmp: disable screendump if PIXMAN is missing marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 12/23] virtio-gpu: replace PIXMAN for region/rect test marcandre.lureau
2023-10-25 20:54   ` BALATON Zoltan
2023-10-26  7:24     ` Marc-André Lureau
2023-10-25 19:08 ` [PATCH v6 13/23] ui/console: when PIXMAN is unavailable, don't draw placeholder msg marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 14/23] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN marcandre.lureau
2023-10-25 20:58   ` BALATON Zoltan
2023-10-26  8:03     ` Marc-André Lureau
2023-10-25 19:08 ` [PATCH v6 15/23] ui/gl: opengl doesn't require PIXMAN marcandre.lureau
2023-10-26  5:39   ` Thomas Huth
2023-10-26  8:09     ` Marc-André Lureau
2023-10-26  8:45       ` Thomas Huth
2023-10-30 10:24         ` Marc-André Lureau
2023-10-25 19:08 ` [PATCH v6 16/23] ui/vnc: VNC requires PIXMAN marcandre.lureau
2023-10-26  5:40   ` Thomas Huth
2023-10-25 19:08 ` [PATCH v6 17/23] ui/spice: SPICE/QXL " marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 18/23] ui/gtk: -display gtk " marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 19/23] ui/dbus: do not require PIXMAN marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 20/23] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN marcandre.lureau
2023-10-25 19:08 ` [PATCH v6 21/23] hw/sm501: allow compiling without PIXMAN marcandre.lureau
2023-10-25 21:02   ` BALATON Zoltan
2023-10-25 19:08 ` [PATCH v6 22/23] hw/display: make ATI_VGA depend on PIXMAN marcandre.lureau
2023-10-25 21:05   ` BALATON Zoltan
2023-10-26 14:41     ` Marc-André Lureau
2023-10-25 19:08 ` [PATCH v6 23/23] build-sys: make pixman actually optional marcandre.lureau
2023-10-26  5:42   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTvndl9Bocy2YLOa@redhat.com \
    --to=berrange@redhat.com \
    --cc=abologna@redhat.com \
    --cc=armbru@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=dave@treblig.org \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.